29830 2009-09-28 15:24:38 -0700 Do not add platform-specific methods to cross-platform header FileSystem.h per Darin's feedback for 29109. 2009-09-28 16:58:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli darin oldest_to_newest 150684 0 jianli 2009-09-28 15:24:38 -0700 This is post fix to my patch for bug 29109 (https://bugs.webkit.org/show_bug.cgi?id=29109), per Darin's feedback. We should not add platform-specific methods to cross-platform header FileSystem.h. 150689 1 40265 jianli 2009-09-28 15:37:01 -0700 Created attachment 40265 Proposed Patch 150726 2 jianli 2009-09-28 16:58:06 -0700 Committed as http://trac.webkit.org/changeset/48846. 40265 2009-09-28 15:37:01 -0700 2009-09-28 15:47:16 -0700 Proposed Patch 29830 text/plain 3037 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDIxNjUxYi4uMWQ2ZTE1YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0yOCAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRG8gbm90IGFkZCBwbGF0Zm9ybS1zcGVjaWZpYyBtZXRob2RzIHRvIGNyb3Nz LXBsYXRmb3JtIGhlYWRlcgorICAgICAgICBGaWxlU3lzdGVtLmggcGVyIERhcmluJ3MgZmVlZGJh Y2sgZm9yIDI5MTA5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mjk4MzAKKworICAgICAgICAqIHBsYXRmb3JtL0ZpbGVTeXN0ZW0uaDoKKyAgICAgICAg KiBwbGF0Zm9ybS9jaHJvbWl1bS9EcmFnRGF0YUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkRyYWdEYXRhOjphc1VSTCk6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vRmlsZVN5 c3RlbUNocm9taXVtLmNwcDoKKwogMjAwOS0wOS0yOCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmggYi9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVT eXN0ZW0uaAppbmRleCAxMTAyMDRiLi45NThlYjczIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL0ZpbGVTeXN0ZW0uaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVTeXN0ZW0uaApAQCAt NDksNyArNDksNiBAQAogI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgogI2luY2x1ZGUgPHd0Zi9W ZWN0b3IuaD4KIAotI2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5o IgogCiB0eXBlZGVmIGNvbnN0IHN0cnVjdCBfX0NGRGF0YSogQ0ZEYXRhUmVmOwpAQCAtMTczLDkg KzE3Miw2IEBAIFN0cmluZyBmaWxlbmFtZUZvckRpc3BsYXkoY29uc3QgU3RyaW5nJik7CiAKICNp ZiBQTEFURk9STShDSFJPTUlVTSkKIFN0cmluZyBwYXRoR2V0RGlzcGxheUZpbGVOYW1lKGNvbnN0 IFN0cmluZyYpOwotU3RyaW5nIGdldEFic29sdXRlUGF0aChjb25zdCBTdHJpbmcmKTsKLWJvb2wg aXNEaXJlY3RvcnkoY29uc3QgU3RyaW5nJik7Ci1LVVJMIGZpbGVQYXRoVG9VUkwoY29uc3QgU3Ry aW5nJik7CiAjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnRGF0YUNocm9taXVtLmNwcCBiL1dlYkNvcmUvcGxh dGZvcm0vY2hyb21pdW0vRHJhZ0RhdGFDaHJvbWl1bS5jcHAKaW5kZXggNDA4M2I4MC4uMTMzYmEy NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnRGF0YUNocm9taXVt LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdEYXRhQ2hyb21pdW0uY3Bw CkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRHJhZ0Rh dGEuaCIKIAorI2luY2x1ZGUgIkNocm9taXVtQnJpZGdlLmgiCiAjaW5jbHVkZSAiQ2hyb21pdW1E YXRhT2JqZWN0LmgiCiAjaW5jbHVkZSAiQ2xpcGJvYXJkLmgiCiAjaW5jbHVkZSAiQ2xpcGJvYXJk Q2hyb21pdW0uaCIKQEAgLTY3LDkgKzY4LDkgQEAgU3RyaW5nIERyYWdEYXRhOjphc1VSTChTdHJp bmcqIHRpdGxlKSBjb25zdAogICAgICAgICB1cmwgPSBtX3BsYXRmb3JtRHJhZ0RhdGEtPnVybC5z dHJpbmcoKTsKICAgICBlbHNlIGlmIChtX3BsYXRmb3JtRHJhZ0RhdGEtPmZpbGVuYW1lcy5zaXpl KCkgPT0gMSkgewogICAgICAgICBTdHJpbmcgZmlsZU5hbWUgPSBtX3BsYXRmb3JtRHJhZ0RhdGEt PmZpbGVuYW1lc1swXTsKLSAgICAgICAgZmlsZU5hbWUgPSBnZXRBYnNvbHV0ZVBhdGgoZmlsZU5h bWUpOwotICAgICAgICBpZiAoZmlsZUV4aXN0cyhmaWxlTmFtZSkgJiYgIWlzRGlyZWN0b3J5KGZp bGVOYW1lKSkKLSAgICAgICAgICAgIHVybCA9IGZpbGVQYXRoVG9VUkwoZmlsZU5hbWUpLnN0cmlu ZygpOworICAgICAgICBmaWxlTmFtZSA9IENocm9taXVtQnJpZGdlOjpnZXRBYnNvbHV0ZVBhdGgo ZmlsZU5hbWUpOworICAgICAgICBpZiAoZmlsZUV4aXN0cyhmaWxlTmFtZSkgJiYgIUNocm9taXVt QnJpZGdlOjppc0RpcmVjdG9yeShmaWxlTmFtZSkpCisgICAgICAgICAgICB1cmwgPSBDaHJvbWl1 bUJyaWRnZTo6ZmlsZVBhdGhUb1VSTChmaWxlTmFtZSkuc3RyaW5nKCk7CiAgICAgfQogIAogICAg IC8vIHx0aXRsZXwgY2FuIGJlIE5VTEwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vRmlsZVN5c3RlbUNocm9taXVtLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v RmlsZVN5c3RlbUNocm9taXVtLmNwcAppbmRleCA5ZTc0MjRkLi4zMDY3NGQ5IDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0ZpbGVTeXN0ZW1DaHJvbWl1bS5jcHAKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9GaWxlU3lzdGVtQ2hyb21pdW0uY3BwCkBAIC03Nywx OSArNzcsNCBAQCBib29sIGZpbGVFeGlzdHMoY29uc3QgU3RyaW5nJiBwYXRoKQogICAgIHJldHVy biBDaHJvbWl1bUJyaWRnZTo6ZmlsZUV4aXN0cyhwYXRoKTsKIH0KIAotU3RyaW5nIGdldEFic29s dXRlUGF0aChjb25zdCBTdHJpbmcmIHBhdGgpCi17Ci0gICAgcmV0dXJuIENocm9taXVtQnJpZGdl OjpnZXRBYnNvbHV0ZVBhdGgocGF0aCk7Ci19Ci0KLWJvb2wgaXNEaXJlY3RvcnkoY29uc3QgU3Ry aW5nJiBwYXRoKQotewotICAgIHJldHVybiBDaHJvbWl1bUJyaWRnZTo6aXNEaXJlY3RvcnkocGF0 aCk7Ci19Ci0KLUtVUkwgZmlsZVBhdGhUb1VSTChjb25zdCBTdHJpbmcmIHBhdGgpCi17Ci0gICAg cmV0dXJuIENocm9taXVtQnJpZGdlOjpmaWxlUGF0aFRvVVJMKHBhdGgpOwotfQotCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCg==