29827 2009-09-28 15:03:03 -0700 transforms/3d tests are not run in Release builds 2009-09-30 13:20:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric simon.fraser simon.fraser oldest_to_newest 150673 0 eric 2009-09-28 15:03:03 -0700 transforms/3d tests are not run in Release builds WebCoreHas3DRendering is not an exported symbol, so the check in webkitdirs fails to find it: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitdirs.pm#L633 in Release builds of WebCore. We'll need to find a new way to check if we should run the transforms/3d tests or not. I only ran the tests in Release mode before checking in: http://trac.webkit.org/changeset/48833 So the transforms/3d tests started failing in Debug mode on the bots: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/5406 150680 1 simon.fraser 2009-09-28 15:19:14 -0700 Nice find. 151341 2 40395 simon.fraser 2009-09-30 13:15:49 -0700 Created attachment 40395 Patch 151342 3 40395 mrowe 2009-09-30 13:17:51 -0700 Comment on attachment 40395 Patch r=me 151343 4 simon.fraser 2009-09-30 13:20:01 -0700 http://trac.webkit.org/changeset/48945 40395 2009-09-30 13:15:49 -0700 2009-09-30 13:17:51 -0700 Patch 29827_patch.txt text/plain 3777 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWEwMjhiOS4uNDYwYmIxMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wOS0zMCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICB0cmFuc2Zvcm1zLzNkIHRlc3RzIGFyZSBub3QgcnVuIGluIFJl bGVhc2UgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yOTgyNworCisgICAgICAgIE1ha2Ugc3VyZSB3ZSBleHBvcnQgdGhlIFdlYkNvcmVIYXMz RFJlbmRlcmluZyBzeW1ib2wgaW4gUmVsZWFzZSBidWlsZHMsCisgICAgICAgIGJlY2F1c2UgdGhp cyBzeW1ib2xzIGlzIHVzZWQgYnkgcnVuLXdlYmtpdC10ZXN0cyAodmlhICdubScpIHRvIGRldGVj dCB3aGV0aGVyCisgICAgICAgIFdlYkNvcmUgd2FzIGJ1aWx0IHdpdGggRU5BQkxFXzNEX1JFTkRF UklORyB0dXJuZWQgb24uCisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5tYWtlOgorICAgICAg ICAqIFdlYkNvcmUuM0RSZW5kZXJpbmcuZXhwOiBBZGRlZC4KKyAgICAgICAgKiBXZWJDb3JlLnhj b2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisKIDIwMDktMDktMjkgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVp bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZSBiL1dlYkNvcmUvRGVy aXZlZFNvdXJjZXMubWFrZQppbmRleCBlNzc1MDFmLi4wZjc5YTA2IDEwMDY0NAotLS0gYS9XZWJD b3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKKysrIGIvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtl CkBAIC04MDYsNiArODA2LDEwIEBAIGlmZXEgKCQoc2hlbGwgZ2NjIC1FIC1QIC1kTSAkKEZSQU1F V09SS19GTEFHUykgV2ViQ29yZS9Gb3J3YXJkaW5nSGVhZGVycy93dGYvUGxhCiAgICAgV0VCQ09S RV9FWFBPUlRfREVQRU5ERU5DSUVTIDo9ICQoV0VCQ09SRV9FWFBPUlRfREVQRU5ERU5DSUVTKSBX ZWJDb3JlLlBsdWdpbkhvc3RQcm9jZXNzLmV4cAogZW5kaWYKIAoraWZlcSAoJChmaW5kc3RyaW5n IEVOQUJMRV8zRF9SRU5ERVJJTkcsJChGRUFUVVJFX0RFRklORVMpKSwgRU5BQkxFXzNEX1JFTkRF UklORykKKyAgICBXRUJDT1JFX0VYUE9SVF9ERVBFTkRFTkNJRVMgOj0gJChXRUJDT1JFX0VYUE9S VF9ERVBFTkRFTkNJRVMpIFdlYkNvcmUuM0RSZW5kZXJpbmcuZXhwCitlbmRpZgorCiBpZmVxICgk KHNoZWxsIGdjYyAtRSAtUCAtZE0gJChGUkFNRVdPUktfRkxBR1MpIFdlYkNvcmUvRm9yd2FyZGlu Z0hlYWRlcnMvd3RmL1BsYXRmb3JtLmggfCBncmVwIEVOQUJMRV9DT05URVhUX01FTlVTIHwgY3V0 IC1kJyAnIC1mMyksIDEpCiAgICAgV0VCQ09SRV9FWFBPUlRfREVQRU5ERU5DSUVTIDo9ICQoV0VC Q09SRV9FWFBPUlRfREVQRU5ERU5DSUVTKSBXZWJDb3JlLkNvbnRleHRNZW51cy5leHAKIGVuZGlm CmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUuM0RSZW5kZXJpbmcuZXhwIGIvV2ViQ29yZS9X ZWJDb3JlLjNEUmVuZGVyaW5nLmV4cApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li40YTg0YzYzCi0tLSAvZGV2L251bGwKKysrIGIvV2ViQ29yZS9XZWJDb3JlLjNEUmVuZGVyaW5n LmV4cApAQCAtMCwwICsxIEBACitfV2ViQ29yZUhhczNEUmVuZGVyaW5nCmRpZmYgLS1naXQgYS9X ZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1dlYkNvcmUvV2ViQ29y ZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDQ2ZmRhNmUuLjFiNWFiY2MgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1dl YkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC01MjgzLDYgKzUyODMs NyBAQAogCQkwRjU4MENGQzBGMTJERTlCMDA1MUQ2ODkgLyogUmVuZGVyTGF5ZXJCYWNraW5nLmNw cCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25v d25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLmNwcDsgcGF0aCA9IFJlbmRlckxheWVyQmFja2lu Zy5jcHA7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCTBGNkVDRDQzMEYyNTJGMzcwMEJE RTI3MSAvKiBDU1NQcm9wZXJ0eUxvbmdoYW5kLmggKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5j ZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmMuaDsg cGF0aCA9IENTU1Byb3BlcnR5TG9uZ2hhbmQuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsK IAkJMEY2RUNENDQwRjI1MkYzNzAwQkRFMjcxIC8qIENTU1Byb3BlcnR5TG9uZ2hhbmQuY3BwICov ID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZp bGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gQ1NTUHJvcGVydHlMb25naGFuZC5j cHA7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCTBGOUM2RjRCMTA3M0VGMDQwMERFRDlC RiAvKiBXZWJDb3JlLjNEUmVuZGVyaW5nLmV4cCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNl OyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuZXhwb3J0 czsgcGF0aCA9IFdlYkNvcmUuM0RSZW5kZXJpbmcuZXhwOyBzb3VyY2VUcmVlID0gIjxncm91cD4i OyB9OwogCQkwRkM3MDUyMDBFQjE4MTU2MDBCOTBBRDggLyogQXRvbWljU3RyaW5nSGFzaC5oICov ID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZp bGVUeXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBBdG9taWNTdHJpbmdIYXNoLmg7IHNvdXJj ZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCTBGQ0YzMzIzMEYyQjk3MTUwMDRCNjc5NSAvKiBDb2xv ckNHLmNwcCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBs YXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLmNwcDsgcGF0aCA9IENvbG9yQ0cuY3Bw OyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQkwRkNGMzMyODBGMkI5QTI1MDA0QjY3OTUg LyogV2ViVGlsZWRMYXllci5tbSAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5j b2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLm9iamNwcDsgcGF0 aCA9IFdlYlRpbGVkTGF5ZXIubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CkBAIC0xMDQ3 Miw2ICsxMDQ3Myw3IEBACiAJCQlpc2EgPSBQQlhHcm91cDsKIAkJCWNoaWxkcmVuID0gKAogCQkJ CUY1OEVGNThFMDJERkRGQjcwMTg2MzVDQSAvKiBXZWJDb3JlLmJhc2UuZXhwICovLAorCQkJCTBG OUM2RjRCMTA3M0VGMDQwMERFRDlCRiAvKiBXZWJDb3JlLjNEUmVuZGVyaW5nLmV4cCAqLywKIAkJ CQlGRUZEMTAyQzEwNUM0MTQ3MDAwMjg1NUUgLyogV2ViQ29yZS5Db250ZXh0TWVudXMuZXhwICov LAogCQkJCTQ0OTE5NTlEMEZCRTE3RDcwMEQ5RjgyNCAvKiBXZWJDb3JlLkRhc2hib2FyZFN1cHBv cnQuZXhwICovLAogCQkJCUZFQTQxMzNGMTA1RDY3QUUwMDA3MjM2RiAvKiBXZWJDb3JlLkRyYWdT dXBwb3J0LmV4cCAqLywK