29815 2009-09-28 10:50:17 -0700 REGRESSION (r48698): Cannot enter text in Facebook message content field 2009-10-28 03:04:09 -0700 1 1 1 Unclassified WebKit Evangelism 528+ (Nightly build) Mac OS X 10.6 RESOLVED WONTFIX http://www.facebook.com/ InRadar, Regression P1 Critical --- 1 mitz webkit-unassigned adele dhamlin genzuk marcel mathewsb medicatingx742 mrowe mtrillo mvernal pete poweruser.webkit sebastianbf tkent vicki oldest_to_newest 150558 0 mitz 2009-09-28 10:50:17 -0700 The Message text field in the Facebook Compose Message box does not accept text entry. Steps to reproduce: 1. Log in to Facebook 2. Choose Inbox > Compose New Message 3. Click in the Message text field 4. Type some text Result: No text appears in the Message text field Regression: This is a regression from <http://trac.webkit.org/changeset/48698> 150559 1 mitz 2009-09-28 10:50:46 -0700 <rdar://problem/7258171> 150755 2 tkent 2009-09-28 17:30:37 -0700 I have confirmed I couldn't type anything into a textarea. However, this <textarea> element actually had maxlength="0" according to the inspector. So, this is an expected behavior and a Facebook's bug. What should we do in such case? 150765 3 tkent 2009-09-28 17:43:44 -0700 > However, this <textarea> element actually had maxlength="0" according to the > inspector. So, this is an expected behavior and a Facebook's bug. It doesn't have maxlength="0" in an HTML text. The code seems to call "textarea.maxLength = 0" and it makes a maxlength="0" attribute. 150778 4 tkent 2009-09-28 18:33:33 -0700 I took a look at a Facebook JS code. I guess TextInputControl class in it does something like the following: textarea.maxLength = textarea.maxLength; If maxlength= HTML attribute is missing, .maxLength is 0 according to older HTML5 draft, so the new .maxLength becomes 0, of course. Maybe this bug will be fixed if Bug#29796 is fixed. I'll check it soon. 150784 5 tkent 2009-09-28 19:30:29 -0700 (In reply to comment #4) > I took a look at a Facebook JS code. > I guess TextInputControl class in it does something like the following: > textarea.maxLength = textarea.maxLength; My guess was wrong. Returning -1 for .maxLength didn't help. 150789 6 tkent 2009-09-28 20:40:05 -0700 I understand the Facebook code. In the definition of TextInpuTcontrol.prototype: setMaxLength:function(maxlength){ this.maxLength=maxlength; this.getRoot().maxLength=this.maxLength||null; return this; }, This code is called by UIComposer.prototype.initializeTextarea() like: initializeTextarea:function(maxLength,initialHeight){ new TextAreaControl(this.input) .setMaxLength(maxLength) .setOriginalHeight(initialHeight) .setAutogrow(true) .onfocus(); this.input.onfocus=''; }, where the maxLength parameter is 0. > this.getRoot().maxLength=this.maxLength||null; this.getRoot() is a <textarea> element. In the case of maxLength==0, null is set. null is converted to 0. So textarea.maxLength becomes 0. 150791 7 tkent 2009-09-28 20:54:15 -0700 I reported this issue to Facebook. 151397 8 mrowe 2009-09-30 17:07:15 -0700 I just CCd all of the facebook.com folks with Bugzilla accounts on this bug to hopefully get this some attention. If this requires a fix on the Facebook side it would be nice to get an ETA for the fix. 151400 9 mrowe 2009-09-30 17:11:09 -0700 *** Bug 29922 has been marked as a duplicate of this bug. *** 151403 10 40410 mrowe 2009-09-30 17:34:04 -0700 Created attachment 40410 Reduction I've attached a reduction that demonstrates that Facebook is relying on behavior that works in Firefox but is incorrect per the HTML 5 specification. 151632 11 genzuk 2009-10-01 11:25:42 -0700 I want to confirm this bug. Unable to insert text in response box on facebook's "inbox" 151769 12 mathewsb 2009-10-01 22:12:10 -0700 I've fixed this in our trunk; the fix will go out on Tuesday afternoon. 151770 13 mrowe 2009-10-01 22:19:16 -0700 Thanks for the info, Ben! 152085 14 mitz 2009-10-03 10:33:02 -0700 *** Bug 30046 has been marked as a duplicate of this bug. *** 152152 15 mrowe 2009-10-04 03:52:31 -0700 *** Bug 30056 has been marked as a duplicate of this bug. *** 152186 16 mrowe 2009-10-04 13:23:33 -0700 *** Bug 30058 has been marked as a duplicate of this bug. *** 158503 17 tkent 2009-10-28 03:04:09 -0700 I confirmed Facebook's code has no problem now. 40410 2009-09-30 17:34:04 -0700 2009-09-30 17:34:04 -0700 Reduction test.html text/html 1843 mrowe PHA+RHVyaW5nIHBhZ2UgbG9hZCBzb21lIEphdmFTY3JpcHQgc2V0cyB0aGUgbWF4TGVuZ3RoIHBy b3BlcnR5IG9mIHRoZSB0ZXh0IGFyZWEgYmVsb3cgdG8gbnVsbC4gIFBlciA8YSBocmVmPSdodHRw Oi8vZGV2LnczLm9yZy9odG1sNS9zcGVjL092ZXJ2aWV3Lmh0bWwjYXR0ci10ZXh0YXJlYS1tYXhs ZW5ndGgnPkhUTUwgNTwvYT4gInRoZSBtYXhMZW5ndGggSURMIGF0dHJpYnV0ZSBtdXN0IHJlZmxl Y3QgdGhlIG1heGxlbmd0aCBjb250ZW50IGF0dHJpYnV0ZSwgbGltaXRlZCB0byBvbmx5IHBvc2l0 aXZlIG51bWJlcnMiLiAgVGhlIHNwZWNpZmljYXRpb24gaGFzIHRoZSBmb2xsb3dpbmcgdG8gc2F5 IGFib3V0IDxhIGhyZWY9J2h0dHA6Ly9kZXYudzMub3JnL2h0bWw1L3NwZWMvT3ZlcnZpZXcuaHRt bCNyZWZsZWN0Jz5yZWZsZWN0aW5nIGNvbnRlbnQgYXR0cmlidXRlcyBpbiBJREwgYXR0cmlidXRl czwvYT4gKGVtcGhhc2lzIGFkZGVkIHRvIHRoZSByZWxldmFudCBzZW50ZW5jZSk6PC9wPgo8Ymxv Y2txdW90ZT4KICAgIElmIGEgcmVmbGVjdGluZyBJREwgYXR0cmlidXRlIGlzIGEgc2lnbmVkIGlu dGVnZXIgdHlwZSAobG9uZykgdGhhdCBpcyBsaW1pdGVkIHRvIG9ubHkgcG9zaXRpdmUgbnVtYmVy cyB0aGVuLCBvbiBnZXR0aW5nLCB0aGUgY29udGVudCBhdHRyaWJ1dGUgbXVzdCBiZSBwYXJzZWQg YWNjb3JkaW5nIHRvIHRoZSBydWxlcyBmb3IgcGFyc2luZyBub24tbmVnYXRpdmUgaW50ZWdlcnMs IGFuZCBpZiB0aGF0IGlzIHN1Y2Nlc3NmdWwsIGFuZCB0aGUgdmFsdWUgaXMgaW4gdGhlIHJhbmdl IG9mIHRoZSBJREwgYXR0cmlidXRlJ3MgdHlwZSwgdGhlIHJlc3VsdGluZyB2YWx1ZSBtdXN0IGJl IHJldHVybmVkLiBJZiwgb24gdGhlIG90aGVyIGhhbmQsIGl0IGZhaWxzIG9yIHJldHVybnMgYW4g b3V0IG9mIHJhbmdlIHZhbHVlLCBvciBpZiB0aGUgYXR0cmlidXRlIGlzIGFic2VudCwgdGhlIGRl ZmF1bHQgdmFsdWUgbXVzdCBiZSByZXR1cm5lZCBpbnN0ZWFkLCBvciDiiJIxIGlmIHRoZXJlIGlz IG5vIGRlZmF1bHQgdmFsdWUuIE9uIHNldHRpbmcsIGlmIHRoZSB2YWx1ZSBpcyBuZWdhdGl2ZSwg dGhlIHVzZXIgYWdlbnQgbXVzdCBmaXJlIGFuIElOREVYX1NJWkVfRVJSIGV4Y2VwdGlvbi4gPGVt Pk90aGVyd2lzZSwgdGhlIGdpdmVuIHZhbHVlIG11c3QgYmUgY29udmVydGVkIHRvIHRoZSBzaG9y dGVzdCBwb3NzaWJsZSBzdHJpbmcgcmVwcmVzZW50aW5nIHRoZSBudW1iZXIgYXMgYSB2YWxpZCBu b24tbmVnYXRpdmUgaW50ZWdlciBhbmQgdGhlbiB0aGF0IHN0cmluZyBtdXN0IGJlIHVzZWQgYXMg dGhlIG5ldyBjb250ZW50IGF0dHJpYnV0ZSB2YWx1ZS48L2VtPgo8L2Jsb2NrcXVvdGU+CjxwPlRo aXMgbWVhbnMgdGhhdCBzZXR0aW5nIG1heExlbmd0aCB0byBudWxsIGlzIGVxdWl2YWxlbnQgdG8g c2V0dGluZyBpdCB0byAwLCB3aGljaCBwcmV2ZW50cyB0ZXh0IGZyb20gYmVpbmcgZW50ZXJlZCBp biB0aGUgdGV4dCBhcmVhLiAgRmlyZWZveCBkb2VzIG5vdCB5ZXQgZm9sbG93IHRoaXMgYXNwZWN0 IG9mIHRoZSBIVE1MIDUgc3BlY2lmaWNhdGlvbiwgYW5kIGFwcGVhcnMgdG8gdHJlYXQgc2V0dGlu ZyB0aGUgYXR0cmlidXRlIHRvIG51bGwgYXMgcmVtb3ZpbmcgdGhlIG1heGltdW0gbGVuZ3RoIG9m IHRoZSB0ZXh0IGFyZWEuPC9wPgo8dGV4dGFyZWEgaWQ9InRlc3QiIGNvbHM9IjEwMCIgcm93cz0i MjAiPjwvdGV4dGFyZWE+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgIHZhciB0 ZXN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKICAgIHRlc3QubWF4TGVuZ3Ro ID0gbnVsbDsKPC9zY3JpcHQ+Cg==