29810 2009-09-28 09:11:29 -0700 [V8] Unsigned int return values are incorrectly treated as signed. 2025-08-29 11:11:27 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 dglazkov ahmad.saleem792 eric levin tkent webkit-bug-importer oldest_to_newest 150518 0 dglazkov 2009-09-28 09:11:29 -0700 In CodeGeneratorV8.pm, "unsigned long" return value in IDL incorrectly generates "int" in C++. It should be "unsigned" instead. 150519 1 40238 dglazkov 2009-09-28 09:12:47 -0700 Created attachment 40238 Fixed type-conversion error in CodeGeneratorV8.pm, v1. WebCore/ChangeLog | 13 +++++++++++++ WebCore/bindings/scripts/CodeGeneratorV8.pm | 3 ++- 2 files changed, 15 insertions(+), 1 deletions(-) 150522 2 40238 abarth 2009-09-28 09:15:32 -0700 Comment on attachment 40238 Fixed type-conversion error in CodeGeneratorV8.pm, v1. Nice! I presume the test mentioned already exists. 150524 3 dglazkov 2009-09-28 09:21:56 -0700 Yep. tkent wrote it :) 150535 4 dglazkov 2009-09-28 09:29:40 -0700 Landed as http://trac.webkit.org/changeset/48817. 150555 5 dglazkov 2009-09-28 10:48:10 -0700 Oops. I maked bugs. Fix coming up. 150561 6 40245 dglazkov 2009-09-28 10:53:24 -0700 Created attachment 40245 Add index arguments special case, v1. WebCore/ChangeLog | 13 +++++++++++++ WebCore/bindings/scripts/CodeGeneratorV8.pm | 5 +++++ 2 files changed, 18 insertions(+), 0 deletions(-) 150562 7 dglazkov 2009-09-28 10:53:52 -0700 Fix uploaded. Sorry for the troubles. 150563 8 40238 commit-queue 2009-09-28 10:54:18 -0700 Comment on attachment 40238 Fixed type-conversion error in CodeGeneratorV8.pm, v1. Rejecting patch 40238 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=40238 from bug 29810 failed to download and apply. 150564 9 dglazkov 2009-09-28 10:57:52 -0700 Fix landed as http://trac.webkit.org/changeset/48820. 150623 10 eric 2009-09-28 13:24:00 -0700 patching file WebCore/bindings/scripts/CodeGeneratorV8.pm Hunk #1 FAILED at 1711. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/bindings/scripts/CodeGeneratorV8.pm.rej Was the cause of the rejection. 2139701 11 ahmad.saleem792 2025-08-29 09:29:05 -0700 <rdar://problem/159452245> 2139702 12 ahmad.saleem792 2025-08-29 09:29:55 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/50068 2139723 13 ews-feeder 2025-08-29 11:11:23 -0700 Committed 299335@main (ca82e44da1e9): <https://commits.webkit.org/299335@main> Reviewed commits have been landed. Closing PR #50068 and removing active labels. 40238 2009-09-28 09:12:47 -0700 2009-09-28 10:54:17 -0700 Fixed type-conversion error in CodeGeneratorV8.pm, v1. Fixed-type-conversion-error-in-CodeGeneratorV8.pm-v1..patch text/plain 1452 dglazkov YzBlZDJkNzI2MTY1MjY0MGMzNGYwZDY1MmQwMjkxYzQwNDZmNTQ2NQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3NmE3MjRmLi45MTY5NTA2 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDA5LTA5LTI4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1Y4XSBGaXggYW4gZXJyb3IgaW4gdHlwZSBsb2dpYyBpbiBDb2RlR2VuZXJhdG9yVjgu cG0sIHdoZXJlCisgICAgICAgIHVuc2lnbmVkIGludHMgYXJlIGFjY2lkZW50YWxseSB1c2VkIGFz IHNpZ25lZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI5ODEwCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS1t YXhsZW5ndGguaHRtbAorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG06IE1hZGUgc3VyZSAidW5zaWduZWQgbG9uZyIgaW4gSURMIGlzCisgICAgICAgICAgcHJv cGVybHkgZ2VuZXJhdGVzIG9uICJ1bnNpZ25lZCIgcmV0dXJuIHZhbHVlLgorCiAyMDA5LTA5LTI4 ICBKYWt1YiBXaWVjem9yZWsgIDxmYXcyMTdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yVjgucG0KaW5kZXggMWNiZThkMi4uODUxZWJlNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0xNzExLDcgKzE3MTEsOCBAQCBzdWIgR2V0TmF0 aXZlVHlwZQogCiAgICAgcmV0dXJuICJpbnQiIGlmICR0eXBlIGVxICJpbnQiOwogICAgIHJldHVy biAiaW50IiBpZiAkdHlwZSBlcSAic2hvcnQiIG9yICR0eXBlIGVxICJ1bnNpZ25lZCBzaG9ydCI7 Ci0gICAgcmV0dXJuICJpbnQiIGlmICR0eXBlIGVxICJsb25nIiBvciAkdHlwZSBlcSAidW5zaWdu ZWQgbG9uZyI7CisgICAgcmV0dXJuICJ1bnNpZ25lZCIgaWYgJHR5cGUgZXEgInVuc2lnbmVkIGxv bmciOworICAgIHJldHVybiAiaW50IiBpZiAkdHlwZSBlcSAibG9uZyI7CiAgICAgcmV0dXJuICJ1 bnNpZ25lZCBsb25nIGxvbmciIGlmICR0eXBlIGVxICJ1bnNpZ25lZCBsb25nIGxvbmciOwogICAg IHJldHVybiAiYm9vbCIgaWYgJHR5cGUgZXEgImJvb2xlYW4iOwogICAgIHJldHVybiAiU3RyaW5n IiBpZiAkdHlwZSBlcSAiRE9NU3RyaW5nIjsK 40245 2009-09-28 10:53:24 -0700 2009-09-28 10:55:35 -0700 Add index arguments special case, v1. Add-index-arguments-special-case-v1..patch text/plain 1455 dglazkov Y2QwZWU0NWExYzg2OTc4NjNmMDU3ZjM3MmZlNWYxZGUyN2Q5NDk0ZApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYjA3MzI3Li5jYzlhMGFh IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDE4IEBACiAyMDA5LTA5LTI4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1Y4XSBBZGQgYSBzcGVjaWFsIGNhc2UgdG8gaGFuZGxlIGluZGV4IGFyZ3VtZW50cywg YmVjYXVzZSB3ZSBuZWVkIHRvIGJlCisgICAgICAgIGFibGUgdG8gc2VlIGlmIHRoZXkncmUgPCAw LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk4MTAK KworICAgICAgICBUZXN0OiBMYXlvdXRUZXN0cy9kb20vaHRtbC9sZXZlbDEvY29yZS9oY19jaGFy YWN0ZXJkYXRhaW5kZXhzaXplZXJyZGVsZXRlZGF0YWNvdW50bmVnYXRpdmUuaHRtbAorCisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IEFkZGVkIHNwZWNpYWwg Y2FzZSAobWF0Y2hpbmcgQ29kZUdlbmVyYXRvckpTLnBtKQorICAgICAgICAgIGZvciBpbmRleCBh cmd1bWVudHMuCisKKzIwMDktMDktMjggIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9t aXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIFtW OF0gRml4IGFuIGVycm9yIGluIHR5cGUgbG9naWMgaW4gQ29kZUdlbmVyYXRvclY4LnBtLCB3aGVy ZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggODUx ZWJlNS4uN2YxNTA4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JWOC5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtCkBAIC0xNTg5LDYgKzE1ODksMTEgQEAgc3ViIEdldE5hdGl2ZVR5cGVGcm9tU2lnbmF0 dXJlCiAKICAgICBteSAkdHlwZSA9IEdldFR5cGVGcm9tU2lnbmF0dXJlKCRzaWduYXR1cmUpOwog CisgICAgaWYgKCR0eXBlIGVxICJ1bnNpZ25lZCBsb25nIiBhbmQgJHNpZ25hdHVyZS0+ZXh0ZW5k ZWRBdHRyaWJ1dGVzLT57IklzSW5kZXgifSkgeworICAgICAgICAjIFNwZWNpYWwtY2FzZSBpbmRl eCBhcmd1bWVudHMgYmVjYXVzZSB3ZSBuZWVkIHRvIGNoZWNrIHRoYXQgdGhleSBhcmVuJ3QgPCAw LgorICAgICAgICByZXR1cm4gImludCI7CisgICAgfQorCiAgICAgcmV0dXJuIEdldE5hdGl2ZVR5 cGUoJHR5cGUsICRpc1BhcmFtZXRlcik7CiB9CiAK