<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>29801</bug_id>
          
          <creation_ts>2009-09-28 02:33:53 -0700</creation_ts>
          <short_desc>addEventListener of MessagePort should also call start(), like onmessage</short_desc>
          <delta_ts>2009-09-29 10:41:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Zoltan Herczeg">zherczeg</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>150477</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2009-09-28 02:33:53 -0700</bug_when>
    <thetext>My qestion is: should we do it all the time, or only when eventType is &quot;message&quot;.
In case of the latter, where should I create a global string &quot;message&quot;?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>150481</commentid>
    <comment_count>1</comment_count>
      <attachid>40223</attachid>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2009-09-28 03:37:22 -0700</bug_when>
    <thetext>Created attachment 40223
fix for calling the call start()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>150544</commentid>
    <comment_count>2</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2009-09-28 09:57:16 -0700</bug_when>
    <thetext>This needs a regression test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>150546</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-09-28 10:18:32 -0700</bug_when>
    <thetext>Also, please explain why this should be so. I don&apos;t think the spec says that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>150554</commentid>
    <comment_count>4</comment_count>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2009-09-28 10:44:37 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Also, please explain why this should be so. I don&apos;t think the spec says that.

See the SharedWorker example here: http://www.whatwg.org/specs/web-workers/current-work/

See the code example after &quot;The viewer is more involved:&quot;

worker.port.addEventListener(&apos;message&apos;, configure, false);

is used instead of

worker.port.onmessage = configure

Moreover, more addEventListener (4, exactly) is applied for one worker object (actually I didn&apos;t tested that, yet)

You think the example is wrong?

How can I make regression test for Shared Workers?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>150565</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2009-09-28 11:05:16 -0700</bug_when>
    <thetext>&gt; See the SharedWorker example here:
&gt; http://www.whatwg.org/specs/web-workers/current-work/

The examples section is non-normative. We need to have this specified in normative text - I&apos;d suggest e-mailing WhatWG mailing list about this issue.

&gt; How can I make regression test for Shared Workers?

We have a number of tests for workers in LayoutTests/fast/workers, so you could use one of those as an example.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>150951</commentid>
    <comment_count>6</comment_count>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2009-09-29 10:41:42 -0700</bug_when>
    <thetext>According to the discussion on whatwg (http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-September/023246.html), this bug turned out to be a feature. And they will probably change the example to call worker.start() after the listeners added.

I close this bug now. Days of debugging goes waste again. I am not a lucky person nowadays.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>40223</attachid>
            <date>2009-09-28 03:37:22 -0700</date>
            <delta_ts>2009-09-28 09:57:02 -0700</delta_ts>
            <desc>fix for calling the call start()</desc>
            <filename>0001-Call-start-for-addEventListener.patch</filename>
            <type>text/plain</type>
            <size>1590</size>
            <attacher name="Zoltan Herczeg">zherczeg</attacher>
            
              <data encoding="base64">RnJvbSA2YTAyYjI4NTk2MjliYzhiNDE3ZDVlOTI2MWU5NDBmNjY3MjY3NzMzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk
Lmh1PgpEYXRlOiBNb24sIDI4IFNlcCAyMDA5IDExOjM4OjEyICswMjAwClN1YmplY3Q6IFtQQVRD
SF0gQ2FsbCBzdGFydCBmb3IgYWRkRXZlbnRMaXN0ZW5lcgoKU2lnbmVkLW9mZi1ieTogWm9sdGFu
IEhlcmN6ZWcgPHpoZXJjemVnQGluZi51LXN6ZWdlZC5odT4KLS0tCiBXZWJDb3JlL0NoYW5nZUxv
ZyAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYkNvcmUvZG9tL01lc3NhZ2VQb3J0
LmNwcCB8ICAgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAwIGRlbGV0
aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VM
b2cKaW5kZXggYzJmZjJhMi4uYzMxYjFlNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0yOCAgWm9s
dGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYWRkRXZlbnRMaXN0ZW5lciBvZiBNZXNz
YWdlUG9ydCBzaG91bGQgYWxzbyBjYWxsIHN0YXJ0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5ODAxCisKKyAgICAgICAgYWRkRXZlbnRMaXN0ZW5l
ciwganVzdCBsaWtlIG9ubWVzc2FnZSwgc2hvdWxkIGFsc28gY2FsbAorICAgICAgICBzdGFydCgp
IHRvIGVuYWJsZSByZWNlaXZpbmcgbWVzc2FnZXMKKworICAgICAgICAqIGRvbS9NZXNzYWdlUG9y
dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZXNzYWdlUG9ydDo6YWRkRXZlbnRMaXN0ZW5lcik6
CisKIDIwMDktMDktMTYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBj
b2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0t
Z2l0IGEvV2ViQ29yZS9kb20vTWVzc2FnZVBvcnQuY3BwIGIvV2ViQ29yZS9kb20vTWVzc2FnZVBv
cnQuY3BwCmluZGV4IGJmZDc5MzIuLjQ3Nzc4MTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL01l
c3NhZ2VQb3J0LmNwcAorKysgYi9XZWJDb3JlL2RvbS9NZXNzYWdlUG9ydC5jcHAKQEAgLTIwMCw2
ICsyMDAsNyBAQCB2b2lkIE1lc3NhZ2VQb3J0OjphZGRFdmVudExpc3RlbmVyKGNvbnN0IEF0b21p
Y1N0cmluZyYgZXZlbnRUeXBlLCBQYXNzUmVmUHRyPEV2ZQogICAgICAgICBsaXN0ZW5lcnMuYXBw
ZW5kKGV2ZW50TGlzdGVuZXIpOwogICAgICAgICBtX2V2ZW50TGlzdGVuZXJzLmFkZChldmVudFR5
cGUsIGxpc3RlbmVycyk7CiAgICAgfSAgICAKKyAgICBzdGFydCgpOwogfQogCiB2b2lkIE1lc3Nh
Z2VQb3J0OjpyZW1vdmVFdmVudExpc3RlbmVyKGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBl
LCBFdmVudExpc3RlbmVyKiBldmVudExpc3RlbmVyLCBib29sKQotLSAKMS42LjAuNAoK
</data>
<flag name="review"
          id="21409"
          type_id="1"
          status="-"
          setter="sam"
    />
          </attachment>
      

    </bug>

</bugzilla>