29772 2009-09-26 15:55:04 -0700 [GTK] Crash when right-clicking misspelled word 2009-10-31 04:53:39 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Major --- 1 christian webkit-unassigned darin David.Ronis gustavo jmalonzo pochu27 oldest_to_newest 150340 0 christian 2009-09-26 15:55:04 -0700 I discovered that WebKit doesn't ensure that the dictionaries it is trying to use exist at all. In the worst case, this results in a crash when right-clicking a misspelled word. 150342 1 40182 christian 2009-09-26 15:59:31 -0700 Created attachment 40182 Make sure dicts exist With this change enchant is asked for every dictionary whether it actually exists, otherwise it is not added to the list. 151024 2 David.Ronis 2009-09-29 13:34:22 -0700 I've been experiencing a crash in liferea (https://sourceforge.net/tracker/?func=detail&atid=581684&aid=2865307&group_id=87005) which the developers think is related to this issue. I applied the patch and it still crashes. Either the patch is bad, or the issue is different. I'd appreciate your comments. 152150 3 40182 gustavo 2009-10-04 03:50:06 -0700 Comment on attachment 40182 Make sure dicts exist r=me, I'm setting cq-, because I assume you are going to commit yourself =). 152153 4 gustavo 2009-10-04 03:59:18 -0700 (In reply to comment #2) > I've been experiencing a crash in liferea > (https://sourceforge.net/tracker/?func=detail&atid=581684&aid=2865307&group_id=87005) > which the developers think is related to this issue. I applied the patch and > it still crashes. Either the patch is bad, or the issue is different. I'd > appreciate your comments. OK, so this has absolutely no relation to this problem. The dictionary the trace refers to is related to javascript properties mapping/caching, rather than to spelling. If that is webkit 1.1.15, I highly recommend upgrading to 1.1.15.1. If you can still reproduce that crash with 1.1.15.1, please file a bug report specifically for it. 154055 5 jmalonzo 2009-10-12 07:20:09 -0700 (In reply to comment #3) > (From update of attachment 40182 [details]) > r=me, I'm setting cq-, because I assume you are going to commit yourself =). Landed as http://trac.webkit.org/changeset/49437. This patch also fixed a few critical warnings wrt enchant in some layout tests, which is why I landed it. I hope that's ok. 40182 2009-09-26 15:59:31 -0700 2009-10-04 03:50:06 -0700 Make sure dicts exist spell-exists.diff text/plain 3662 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNw cCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcAppbmRleCA3 MWE3YzFhLi40MWM4ZTg2IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JD bGllbnRHdGsuY3BwCkBAIC02MDUsNiArNjA1LDEwIEBAIHZvaWQgRWRpdG9yQ2xpZW50OjpsZWFy bldvcmQoY29uc3QgU3RyaW5nJiB0ZXh0KQogCiB2b2lkIEVkaXRvckNsaWVudDo6Y2hlY2tTcGVs bGluZ09mU3RyaW5nKGNvbnN0IFVDaGFyKiB0ZXh0LCBpbnQgbGVuZ3RoLCBpbnQqIG1pc3NwZWxs aW5nTG9jYXRpb24sIGludCogbWlzc3BlbGxpbmdMZW5ndGgpCiB7CisgICAgR1NMaXN0KiBsYW5n cyA9IHdlYmtpdF93ZWJfc2V0dGluZ3NfZ2V0X3NwZWxsX2xhbmd1YWdlcyhtX3dlYlZpZXcpOwor ICAgIGlmICghbGFuZ3MpCisgICAgICAgIHJldHVybjsKKwogICAgIGdjaGFyKiBjdGV4dCA9IGdf dXRmMTZfdG9fdXRmOChjb25zdF9jYXN0PGd1bmljaGFyMio+KHRleHQpLCBsZW5ndGgsIDAsIDAs IDApOwogICAgIGludCB1dGZsZW4gPSBnX3V0Zjhfc3RybGVuKGN0ZXh0LCAtMSk7CiAKQEAgLTYy Miw3ICs2MjYsNiBAQCB2b2lkIEVkaXRvckNsaWVudDo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKGNv bnN0IFVDaGFyKiB0ZXh0LCBpbnQgbGVuZ3RoLCBpbnQqIG1pcwogICAgICAgICAgICAgaW50IHN0 YXJ0ID0gaTsKICAgICAgICAgICAgIGludCBlbmQgPSBpOwogICAgICAgICAgICAgaW50IHdvcmRM ZW5ndGg7Ci0gICAgICAgICAgICBHU0xpc3QqIGxhbmdzID0gd2Via2l0X3dlYl9zZXR0aW5nc19n ZXRfc3BlbGxfbGFuZ3VhZ2VzKG1fd2ViVmlldyk7CiAKICAgICAgICAgICAgIHdoaWxlIChhdHRy c1tlbmRdLmlzX3dvcmRfZW5kIDwgMSkKICAgICAgICAgICAgICAgICBlbmQrKzsKZGlmZiAtLWdp dCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAppbmRleCA1ODhkNWJkLi45YWFkZjE4IDEwMDY0 NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCkBAIC02OTQsNiArNjk0LDcgQEAg c3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19zZXRfcHJvcGVydHkoR09iamVjdCogb2Jq ZWN0LCBndWludCBwcm9wX2lkLCBjb24KIHsKICAgICBXZWJLaXRXZWJTZXR0aW5ncyogd2ViX3Nl dHRpbmdzID0gV0VCS0lUX1dFQl9TRVRUSU5HUyhvYmplY3QpOwogICAgIFdlYktpdFdlYlNldHRp bmdzUHJpdmF0ZSogcHJpdiA9IHdlYl9zZXR0aW5ncy0+cHJpdjsKKyAgICBFbmNoYW50QnJva2Vy KiBicm9rZXI7CiAgICAgU3BlbGxMYW5ndWFnZSogbGFuZzsKICAgICBHU0xpc3QqIHNwZWxsTGFu Z3VhZ2VzID0gTlVMTDsKIApAQCAtNzg3LDI2ICs3ODgsMzIgQEAgc3RhdGljIHZvaWQgd2Via2l0 X3dlYl9zZXR0aW5nc19zZXRfcHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wX2lk LCBjb24KICAgICBjYXNlIFBST1BfU1BFTExfQ0hFQ0tJTkdfTEFOR1VBR0VTOgogICAgICAgICBw cml2LT5zcGVsbF9jaGVja2luZ19sYW5ndWFnZXMgPSBnX3N0cmR1cChnX3ZhbHVlX2dldF9zdHJp bmcodmFsdWUpKTsKIAorICAgICAgICBicm9rZXIgPSBlbmNoYW50X2Jyb2tlcl9pbml0KCk7CiAg ICAgICAgIGlmIChwcml2LT5zcGVsbF9jaGVja2luZ19sYW5ndWFnZXMpIHsKICAgICAgICAgICAg IGNoYXIqKiBsYW5ncyA9IGdfc3Ryc3BsaXQocHJpdi0+c3BlbGxfY2hlY2tpbmdfbGFuZ3VhZ2Vz LCAiLCIsIC0xKTsKICAgICAgICAgICAgIGZvciAoaW50IGkgPSAwOyBsYW5nc1tpXTsgaSsrKSB7 Ci0gICAgICAgICAgICAgICAgbGFuZyA9IGdfc2xpY2VfbmV3MChTcGVsbExhbmd1YWdlKTsKLSAg ICAgICAgICAgICAgICBsYW5nLT5jb25maWcgPSBlbmNoYW50X2Jyb2tlcl9pbml0KCk7Ci0gICAg ICAgICAgICAgICAgbGFuZy0+c3BlbGxlciA9IGVuY2hhbnRfYnJva2VyX3JlcXVlc3RfZGljdChs YW5nLT5jb25maWcsIGxhbmdzW2ldKTsKKyAgICAgICAgICAgICAgICBpZiAoZW5jaGFudF9icm9r ZXJfZGljdF9leGlzdHMoYnJva2VyLCBsYW5nc1tpXSkpIHsKKyAgICAgICAgICAgICAgICAgICAg bGFuZyA9IGdfc2xpY2VfbmV3MChTcGVsbExhbmd1YWdlKTsKKyAgICAgICAgICAgICAgICAgICAg bGFuZy0+Y29uZmlnID0gZW5jaGFudF9icm9rZXJfaW5pdCgpOworICAgICAgICAgICAgICAgICAg ICBsYW5nLT5zcGVsbGVyID0gZW5jaGFudF9icm9rZXJfcmVxdWVzdF9kaWN0KGxhbmctPmNvbmZp ZywgbGFuZ3NbaV0pOwogCi0gICAgICAgICAgICAgICAgc3BlbGxMYW5ndWFnZXMgPSBnX3NsaXN0 X2FwcGVuZChzcGVsbExhbmd1YWdlcywgbGFuZyk7CisgICAgICAgICAgICAgICAgICAgIHNwZWxs TGFuZ3VhZ2VzID0gZ19zbGlzdF9hcHBlbmQoc3BlbGxMYW5ndWFnZXMsIGxhbmcpOworICAgICAg ICAgICAgICAgIH0KICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgZ19zdHJmcmVldihsYW5n cyk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBjb25zdCBjaGFyKiBsYW5ndWFnZSA9 IHBhbmdvX2xhbmd1YWdlX3RvX3N0cmluZyhndGtfZ2V0X2RlZmF1bHRfbGFuZ3VhZ2UoKSk7CiAK LSAgICAgICAgICAgIGxhbmcgPSBnX3NsaWNlX25ldzAoU3BlbGxMYW5ndWFnZSk7Ci0gICAgICAg ICAgICBsYW5nLT5jb25maWcgPSBlbmNoYW50X2Jyb2tlcl9pbml0KCk7Ci0gICAgICAgICAgICBs YW5nLT5zcGVsbGVyID0gZW5jaGFudF9icm9rZXJfcmVxdWVzdF9kaWN0KGxhbmctPmNvbmZpZywg bGFuZ3VhZ2UpOworICAgICAgICAgICAgaWYgKGVuY2hhbnRfYnJva2VyX2RpY3RfZXhpc3RzKGJy b2tlciwgbGFuZ3VhZ2UpKSB7CisgICAgICAgICAgICAgICAgbGFuZyA9IGdfc2xpY2VfbmV3MChT cGVsbExhbmd1YWdlKTsKKyAgICAgICAgICAgICAgICBsYW5nLT5jb25maWcgPSBlbmNoYW50X2Jy b2tlcl9pbml0KCk7CisgICAgICAgICAgICAgICAgbGFuZy0+c3BlbGxlciA9IGVuY2hhbnRfYnJv a2VyX3JlcXVlc3RfZGljdChsYW5nLT5jb25maWcsIGxhbmd1YWdlKTsKIAotICAgICAgICAgICAg c3BlbGxMYW5ndWFnZXMgPSBnX3NsaXN0X2FwcGVuZChzcGVsbExhbmd1YWdlcywgbGFuZyk7Cisg ICAgICAgICAgICAgICAgc3BlbGxMYW5ndWFnZXMgPSBnX3NsaXN0X2FwcGVuZChzcGVsbExhbmd1 YWdlcywgbGFuZyk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KKyAgICAgICAgZW5jaGFudF9i cm9rZXJfZnJlZShicm9rZXIpOwogICAgICAgICBnX3NsaXN0X2ZvcmVhY2gocHJpdi0+c3BlbGxf Y2hlY2tpbmdfbGFuZ3VhZ2VzX2xpc3QsIGZyZWVfc3BlbGxfY2hlY2tpbmdfbGFuZ3VhZ2UsIE5V TEwpOwogICAgICAgICBnX3NsaXN0X2ZyZWUocHJpdi0+c3BlbGxfY2hlY2tpbmdfbGFuZ3VhZ2Vz X2xpc3QpOwogICAgICAgICBwcml2LT5zcGVsbF9jaGVja2luZ19sYW5ndWFnZXNfbGlzdCA9IHNw ZWxsTGFuZ3VhZ2VzOwo=