29771 2009-09-26 13:14:45 -0700 "Use of uninitialized value $result" warnings when ignoring metrics in run-webkit-tests. 2009-09-27 12:45:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jwieczorek webkit-unassigned commit-queue oldest_to_newest 150335 0 jwieczorek 2009-09-26 13:14:45 -0700 When a test is new, i.e. it doesn't have the expected result, running the test without metrics (--ignore-metrics) results in a bunch of following warnings: Use of uninitialized value $result in substitution (s///) at (...)/WebKitTools/Scripts/run-webkit-tests line 1951, <IN> line 512. There is no point in stripping metrics when there is no result for a test. 150336 1 40179 jwieczorek 2009-09-26 13:20:23 -0700 Created attachment 40179 Do not strip the metrics when there is no expected result for a test. 150407 2 40179 commit-queue 2009-09-27 12:45:32 -0700 Comment on attachment 40179 Do not strip the metrics when there is no expected result for a test. Clearing flags on attachment: 40179 Committed r48803: <http://trac.webkit.org/changeset/48803> 150408 3 commit-queue 2009-09-27 12:45:35 -0700 All reviewed patches have been landed. Closing bug. 40179 2009-09-26 13:20:23 -0700 2009-09-27 12:45:32 -0700 Do not strip the metrics when there is no expected result for a test. 0001-run-webkit-tests-Do-not-strip-the-metrics-when-there.patch text/plain 1508 jwieczorek RnJvbSA2NTdmOTcyMWQzNDkzODM4ZGUzOWE1YjViZjJmMGQyMzY3ZGRiMGRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFN1biwgMjcgU2VwIDIwMDkgMDA6MTU6MTkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBydW4t d2Via2l0LXRlc3RzOiBEbyBub3Qgc3RyaXAgdGhlIG1ldHJpY3Mgd2hlbiB0aGVyZSBpcyBubyBl eHBlY3RlZCByZXN1bHQgZm9yIGEgdGVzdC4KIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yOTc3MQoKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgfCAgICA5ICsrKysrKysrKwogV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3Rz IHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0No YW5nZUxvZwppbmRleCBhMmVlODQ5Li5kNmE2MDg0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIw MDktMDktMjYgIEpha3ViIFdpZWN6b3JlayAgPGZhdzIxN0BnbWFpbC5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcnVuLXdlYmtpdC10ZXN0czog RG8gbm90IHN0cmlwIHRoZSBtZXRyaWNzIHdoZW4gdGhlcmUgaXMgbm8gZXhwZWN0ZWQgcmVzdWx0 IGZvciBhIHRlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yOTc3MQorCisgICAgICAgICogU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzOgorCiAyMDA5 LTA5LTI1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgPGh0 dHA6Ly93ZWJraXQub3JnL2IvMjk3MTg+IG1hcmstYnVnLWZpeGVkOiBhZGQgLXV8LS11cGRhdGUt b25seSBzd2l0Y2gKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10 ZXN0cyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwppbmRleCA2NzlmZWQ1 Li5mNjlmNzcxIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCkBAIC02NDQsNyAr NjQ0LDcgQEAgZm9yIG15ICR0ZXN0IChAdGVzdHMpIHsKICAgICAgICAgY2xvc2UgRVhQRUNURUQ7 CiAgICAgfQogCi0gICAgaWYgKCRpZ25vcmVNZXRyaWNzICYmICEkaXNUZXh0KSB7CisgICAgaWYg KCRpZ25vcmVNZXRyaWNzICYmICEkaXNUZXh0ICYmIGRlZmluZWQgJGV4cGVjdGVkKSB7CiAgICAg ICAgICgkYWN0dWFsLCAkZXhwZWN0ZWQpID0gc3RyaXBNZXRyaWNzKCRhY3R1YWwsICRleHBlY3Rl ZCk7CiAgICAgfQogCi0tIAoxLjYuNC40Cgo=