29770 2009-09-26 11:35:29 -0700 Web Inspector: DOM store is being unbound twice, leading to assertion failure 2009-09-27 02:19:30 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman timothy yurys oldest_to_newest 150321 0 pfeldman 2009-09-26 11:35:29 -0700 1. Open Web Inspector 2. Type something in console (completions are being calculated for window, touching localStore, lazily creating it) 3. Close Web Inspector (unbind is called once) 4. Refresh the page (unbind is called again) -> ASSERTION fails We keep stores bound only while inspector window is show, so this assersion is not correct. 150323 1 40176 pfeldman 2009-09-26 11:39:22 -0700 Created attachment 40176 patch 150370 2 pfeldman 2009-09-27 02:19:30 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorDOMStorageResource.cpp Committed r48799 40176 2009-09-26 11:39:22 -0700 2009-09-26 13:39:41 -0700 patch unbind text/plain 2344 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDQ4NGJmNi4uMzdmMThkZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBET00gc3RvcmUgaXMgYmVp bmcgdW5ib3VuZCB0d2ljZSwgbGVhZGluZyB0byBhc3NlcnRpb24gZmFpbHVyZS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk3NzAKKworICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvckNvbnRyb2xsZXI6OmRpZE9wZW5EYXRhYmFzZSk6CisgICAgICAgIChXZWJDb3Jl OjpJbnNwZWN0b3JDb250cm9sbGVyOjpkaWRVc2VET01TdG9yYWdlKToKKyAgICAgICAgKiBpbnNw ZWN0b3IvSW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZTo6dW5iaW5kKToKKworMjAwOS0wOS0yNiAgUGF2 ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBUaW1vdGh5IEhhdGNoZXIuCisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90IHRyYWNr IERPTSBjaGFuZ2VzIHdoaWxlIGluc3BlY3RvciB3aW5kb3cgaXMgY2xvc2VkLgogCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTc2OQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCBjNjZjN2YyLi5lNjVmMjFjIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysg Yi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcApAQCAtMTA5NCw3ICsx MDk0LDggQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpkaWRPcGVuRGF0YWJhc2UoRGF0YWJh c2UqIGRhdGFiYXNlLCBjb25zdCBTdHJpbmcmIGRvbWEKIAogICAgIG1fZGF0YWJhc2VSZXNvdXJj ZXMuYWRkKHJlc291cmNlKTsKIAotICAgIGlmIChtX2Zyb250ZW5kKQorICAgIC8vIFJlc291cmNl cyBhcmUgb25seSBib3VuZCB3aGlsZSB2aXNpYmxlLgorICAgIGlmIChtX2Zyb250ZW5kICYmIHdp bmRvd1Zpc2libGUoKSkKICAgICAgICAgcmVzb3VyY2UtPmJpbmQobV9mcm9udGVuZC5nZXQoKSk7 CiB9CiAjZW5kaWYKQEAgLTExMTUsNyArMTExNiw4IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxl cjo6ZGlkVXNlRE9NU3RvcmFnZShTdG9yYWdlQXJlYSogc3RvcmFnZUFyZWEsIGJvb2wgaXNMb2Nh CiAKICAgICBtX2RvbVN0b3JhZ2VSZXNvdXJjZXMuYWRkKHJlc291cmNlKTsKIAotICAgIGlmICht X2Zyb250ZW5kKQorICAgIC8vIFJlc291cmNlcyBhcmUgb25seSBib3VuZCB3aGlsZSB2aXNpYmxl LgorICAgIGlmIChtX2Zyb250ZW5kICYmIHdpbmRvd1Zpc2libGUoKSkKICAgICAgICAgcmVzb3Vy Y2UtPmJpbmQobV9mcm9udGVuZC5nZXQoKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZS5jcHAgYi9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2UuY3BwCmluZGV4IDk5YTJkYmEuLjdlZDBkN2Yg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJj ZS5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNl LmNwcApAQCAtNzksNyArNzksOSBAQCB2b2lkIEluc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZTo6 YmluZChJbnNwZWN0b3JGcm9udGVuZCogZnJvbnRlbmQpCiAKIHZvaWQgSW5zcGVjdG9yRE9NU3Rv cmFnZVJlc291cmNlOjp1bmJpbmQoKQogewotICAgIEFTU0VSVChtX2Zyb250ZW5kKTsKKyAgICBp ZiAoIW1fZnJvbnRlbmQpCisgICAgICAgIHJldHVybjsgIC8vIEFscmVhZHkgdW5ib3VuZC4KKwog ICAgIGlmIChtX3JlcG9ydGluZ0NoYW5nZXNUb0Zyb250ZW5kKSB7CiAgICAgICAgIG1fZnJhbWUt PmRvbVdpbmRvdygpLT5yZW1vdmVFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5zdG9yYWdlRXZl bnQsIHRoaXMsIHRydWUpOwogICAgICAgICBtX3JlcG9ydGluZ0NoYW5nZXNUb0Zyb250ZW5kID0g ZmFsc2U7Cg==