29769 2009-09-26 11:25:57 -0700 Web Inspector: Do not track DOM changes while inspector window is closed. 2009-09-27 00:02:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED DUPLICATE 28903 P2 Normal --- 1 pfeldman pfeldman timothy oldest_to_newest 150317 0 pfeldman 2009-09-26 11:25:57 -0700 - There is no need to track DOM changes while inspector window is hidden. This is different from the way it was working before the dom agent refactoring. - There is a following bug: 1. Open web inspector for some page 2. Close web inspector 3. Reload the page 4. Open web inspector Expected: Elements panel showing the DOM tree Actual: Empty panel The reason for a bug is that page reload pushes document's representation into the frontend and calls ElementsPanel's refresh. ElementsPanel is trying to be smart and is not processing refreshes while inspector window is hidden. Keeping dom agent operational only while inspector is visible solves both problems. 150320 1 40175 pfeldman 2009-09-26 11:32:00 -0700 Created attachment 40175 patch Note that I needed to restore WebCore::InspectorController::inspectedWindowScriptObjectCleared callback in order to clear injected script properly. 150333 2 timothy 2009-09-26 12:49:35 -0700 Sounds like bug 28903. 150359 3 pfeldman 2009-09-27 00:02:44 -0700 *** This bug has been marked as a duplicate of bug 28903 *** 40175 2009-09-26 11:32:00 -0700 2009-09-26 13:38:47 -0700 patch dom_reset text/plain 6949 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTA4MmFkMS4uZDQ4NGJmNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAwOS0wOS0yNiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90IHRyYWNrIERPTSBjaGFu Z2VzIHdoaWxlIGluc3BlY3RvciB3aW5kb3cgaXMgY2xvc2VkLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTc2OQorCisgICAgICAgICogaW5zcGVj dG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9y Q29udHJvbGxlcjo6aW5zcGVjdGVkV2luZG93U2NyaXB0T2JqZWN0Q2xlYXJlZCk6CisgICAgICAg IChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpwb3B1bGF0ZVNjcmlwdE9iamVjdHMpOgor ICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6cmVzZXRTY3JpcHRPYmplY3Rz KToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmRpZENvbW1pdExvYWQp OgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmg6CisgICAgICAgICog aW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3Bl Y3RvckRPTUFnZW50OjpzZXREb2N1bWVudCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rv ckRPTUFnZW50Lmg6CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpkaXNwYXRjaFdpbmRvd09iamVjdEF2YWlsYWJsZSk6Cisg ICAgICAgICogcGFnZS9hbmRyb2lkL0luc3BlY3RvckNvbnRyb2xsZXJBbmRyb2lkLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6Omluc3BlY3RlZFdpbmRvd1Njcmlw dE9iamVjdENsZWFyZWQpOgorCiAyMDA5LTA5LTI1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxv dkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwIGIvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXggNjlhN2U2MC4uYzY2 YzdmMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5j cHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAgLTUw Myw2ICs1MDMsMTMgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpoYW5kbGVNb3VzZVByZXNz T25Ob2RlKE5vZGUqIG5vZGUpCiAgICAgaW5zcGVjdChub2RlKTsKIH0KIAordm9pZCBJbnNwZWN0 b3JDb250cm9sbGVyOjppbnNwZWN0ZWRXaW5kb3dTY3JpcHRPYmplY3RDbGVhcmVkKEZyYW1lKiBm cmFtZSkKK3sKKyAgICBpZiAoIWVuYWJsZWQoKSB8fCAhbV9mcm9udGVuZCB8fCBmcmFtZSAhPSBt X2luc3BlY3RlZFBhZ2UtPm1haW5GcmFtZSgpKQorICAgICAgICByZXR1cm47CisgICAgcmVzZXRJ bmplY3RlZFNjcmlwdCgpOworfQorCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OndpbmRvd1Nj cmlwdE9iamVjdEF2YWlsYWJsZSgpCiB7CiAgICAgaWYgKCFtX3BhZ2UgfHwgIWVuYWJsZWQoKSkK QEAgLTY0NCw5ICs2NTEsNyBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnBvcHVsYXRlU2Ny aXB0T2JqZWN0cygpCiAgICAgaWYgKCFtX2Zyb250ZW5kKQogICAgICAgICByZXR1cm47CiAKLSAg ICAvLyBJbml0aWFsaXplIGRvbSBhZ2VudCBhbmQgcmVzZXQgaW5qZWN0ZWQgc2NyaXB0IHN0YXRl IGZpcnN0LgotICAgIGlmIChtX2RvbUFnZW50LT5zZXREb2N1bWVudChtX2luc3BlY3RlZFBhZ2Ut Pm1haW5GcmFtZSgpLT5kb2N1bWVudCgpKSkKLSAgICAgICAgcmVzZXRJbmplY3RlZFNjcmlwdCgp OworICAgIG1fZG9tQWdlbnQtPnNldERvY3VtZW50KG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1l KCktPmRvY3VtZW50KCkpOwogCiAgICAgUmVzb3VyY2VzTWFwOjppdGVyYXRvciByZXNvdXJjZXNF bmQgPSBtX3Jlc291cmNlcy5lbmQoKTsKICAgICBmb3IgKFJlc291cmNlc01hcDo6aXRlcmF0b3Ig aXQgPSBtX3Jlc291cmNlcy5iZWdpbigpOyBpdCAhPSByZXNvdXJjZXNFbmQ7ICsraXQpCkBAIC02 OTQsNiArNjk5LDcgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpyZXNldFNjcmlwdE9iamVj dHMoKQogICAgICAgICBtX3RpbWVsaW5lQWdlbnQtPnJlc2V0KCk7CiAKICAgICBtX2Zyb250ZW5k LT5yZXNldCgpOworICAgIG1fZG9tQWdlbnQtPnNldERvY3VtZW50KDApOwogfQogCiB2b2lkIElu c3BlY3RvckNvbnRyb2xsZXI6OnBydW5lUmVzb3VyY2VzKFJlc291cmNlc01hcCogcmVzb3VyY2VN YXAsIERvY3VtZW50TG9hZGVyKiBsb2FkZXJUb0tlZXApCkBAIC03NTgsMTAgKzc2NCw5IEBAIHZv aWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlkQ29tbWl0TG9hZChEb2N1bWVudExvYWRlciogbG9h ZGVyKQogICAgICAgICAgICAgICAgIC8vIGlkZW50aWZpZXJGb3JJbml0aWFsUmVxdWVzdC4KICAg ICAgICAgICAgICAgICBtX21haW5SZXNvdXJjZSA9IDA7CiAgICAgICAgICAgICB9CisgICAgICAg ICAgICBpZiAod2luZG93VmlzaWJsZSgpKQorICAgICAgICAgICAgICAgIG1fZG9tQWdlbnQtPnNl dERvY3VtZW50KG1faW5zcGVjdGVkUGFnZS0+bWFpbkZyYW1lKCktPmRvY3VtZW50KCkpOwogICAg ICAgICB9Ci0KLSAgICAgICAgaWYgKG1fZG9tQWdlbnQgJiYgbV9kb21BZ2VudC0+c2V0RG9jdW1l bnQobV9pbnNwZWN0ZWRQYWdlLT5tYWluRnJhbWUoKS0+ZG9jdW1lbnQoKSkpCi0gICAgICAgICAg ICByZXNldEluamVjdGVkU2NyaXB0KCk7CiAgICAgfQogCiAgICAgZm9yIChGcmFtZSogZnJhbWUg PSBsb2FkZXItPmZyYW1lKCk7IGZyYW1lOyBmcmFtZSA9IGZyYW1lLT50cmVlKCktPnRyYXZlcnNl TmV4dChsb2FkZXItPmZyYW1lKCkpKQpAQCAtMTEwOSw2ICsxMTE0LDcgQEAgdm9pZCBJbnNwZWN0 b3JDb250cm9sbGVyOjpkaWRVc2VET01TdG9yYWdlKFN0b3JhZ2VBcmVhKiBzdG9yYWdlQXJlYSwg Ym9vbCBpc0xvY2EKICAgICBSZWZQdHI8SW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlPiByZXNv dXJjZSA9IEluc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZTo6Y3JlYXRlKGRvbVN0b3JhZ2UuZ2V0 KCksIGlzTG9jYWxTdG9yYWdlLCBmcmFtZSk7CiAKICAgICBtX2RvbVN0b3JhZ2VSZXNvdXJjZXMu YWRkKHJlc291cmNlKTsKKwogICAgIGlmIChtX2Zyb250ZW5kKQogICAgICAgICByZXNvdXJjZS0+ YmluZChtX2Zyb250ZW5kLmdldCgpKTsKIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckNvbnRyb2xsZXIuaCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRy b2xsZXIuaAppbmRleCAyMDI5NWFhLi5mZjdhNTE2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5oCkBAIC0xOTYsNiArMTk2LDcgQEAgcHVibGljOgogICAgIHZvaWQgbW91 c2VEaWRNb3ZlT3ZlckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3VsdCYsIHVuc2lnbmVkIG1vZGlm aWVyRmxhZ3MpOwogICAgIHZvaWQgaGFuZGxlTW91c2VQcmVzc09uTm9kZShOb2RlKik7CiAKKyAg ICB2b2lkIGluc3BlY3RlZFdpbmRvd1NjcmlwdE9iamVjdENsZWFyZWQoRnJhbWUqKTsKICAgICB2 b2lkIHdpbmRvd1NjcmlwdE9iamVjdEF2YWlsYWJsZSgpOwogCiAgICAgdm9pZCBzZXRGcm9udGVu ZFByb3h5T2JqZWN0KFNjcmlwdFN0YXRlKiBzdGF0ZSwgU2NyaXB0T2JqZWN0IHdlYkluc3BlY3Rv ck9iaiwgU2NyaXB0T2JqZWN0IGluamVjdGVkU2NyaXB0T2JqID0gU2NyaXB0T2JqZWN0KCkpOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwIGIvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDRhNDkwMmQuLmQ4OTM3 OTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAor KysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKQEAgLTcwLDEwICs3 MCwxMCBAQCBJbnNwZWN0b3JET01BZ2VudDo6fkluc3BlY3RvckRPTUFnZW50KCkKICAgICBzZXRE b2N1bWVudCgwKTsKIH0KIAotYm9vbCBJbnNwZWN0b3JET01BZ2VudDo6c2V0RG9jdW1lbnQoRG9j dW1lbnQqIGRvYykKK3ZvaWQgSW5zcGVjdG9yRE9NQWdlbnQ6OnNldERvY3VtZW50KERvY3VtZW50 KiBkb2MpCiB7CiAgICAgaWYgKGRvYyA9PSBtYWluRnJhbWVEb2N1bWVudCgpKQotICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgICAgIHJldHVybjsKICAgICBkaXNjYXJkQmluZGluZ3MoKTsKIAog ICAgIExpc3RIYXNoU2V0PFJlZlB0cjxEb2N1bWVudD4gPiBjb3B5ID0gbV9kb2N1bWVudHM7CkBA IC04OCw3ICs4OCw2IEBAIGJvb2wgSW5zcGVjdG9yRE9NQWdlbnQ6OnNldERvY3VtZW50KERvY3Vt ZW50KiBkb2MpCiAgICAgICAgICAgICBwdXNoRG9jdW1lbnRUb0Zyb250ZW5kKCk7CiAgICAgICAg IH0KICAgICB9Ci0gICAgcmV0dXJuIHRydWU7CiB9CiAKIHZvaWQgSW5zcGVjdG9yRE9NQWdlbnQ6 OnJlbGVhc2VEYW5nbGluZ05vZGVzKCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckRPTUFnZW50LmggYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5o CmluZGV4IGJkNTM5YTUuLmM0MzBjNTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckRPTUFnZW50LmgKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuaApAQCAtNzUsNyArNzUsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQg Z2V0Q29va2llcyhsb25nIGNhbGxJZCk7CiAKICAgICAgICAgLy8gTWV0aG9kcyBjYWxsZWQgZnJv bSB0aGUgSW5zcGVjdG9yQ29udHJvbGxlci4KLSAgICAgICAgYm9vbCBzZXREb2N1bWVudChEb2N1 bWVudCogZG9jdW1lbnQpOworICAgICAgICB2b2lkIHNldERvY3VtZW50KERvY3VtZW50KiBkb2N1 bWVudCk7CiAgICAgICAgIHZvaWQgcmVsZWFzZURhbmdsaW5nTm9kZXMoKTsKIAogICAgICAgICBO b2RlKiBub2RlRm9ySWQobG9uZyBub2RlSWQpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IDgw N2VkZWYuLjU0ZGZjMDAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAorKysgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKQEAgLTUxOTMsNiArNTE5Myw4 IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmRpc3BhdGNoV2luZG93T2JqZWN0QXZhaWxhYmxlKCkKIAog I2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBtX2ZyYW1lLT5wYWdl KCkpIHsKKyAgICAgICAgaWYgKEluc3BlY3RvckNvbnRyb2xsZXIqIGluc3BlY3RvciA9IHBhZ2Ut Pmluc3BlY3RvckNvbnRyb2xsZXIoKSkKKyAgICAgICAgICAgIGluc3BlY3Rvci0+aW5zcGVjdGVk V2luZG93U2NyaXB0T2JqZWN0Q2xlYXJlZChtX2ZyYW1lKTsKICAgICAgICAgaWYgKEluc3BlY3Rv ckNvbnRyb2xsZXIqIGluc3BlY3RvciA9IHBhZ2UtPnBhcmVudEluc3BlY3RvckNvbnRyb2xsZXIo KSkKICAgICAgICAgICAgIGluc3BlY3Rvci0+d2luZG93U2NyaXB0T2JqZWN0QXZhaWxhYmxlKCk7 CiAgICAgfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2FuZHJvaWQvSW5zcGVjdG9yQ29udHJv bGxlckFuZHJvaWQuY3BwIGIvV2ViQ29yZS9wYWdlL2FuZHJvaWQvSW5zcGVjdG9yQ29udHJvbGxl ckFuZHJvaWQuY3BwCmluZGV4IDNiYTY0ZTkuLjk3OGJjMjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGFnZS9hbmRyb2lkL0luc3BlY3RvckNvbnRyb2xsZXJBbmRyb2lkLmNwcAorKysgYi9XZWJDb3Jl L3BhZ2UvYW5kcm9pZC9JbnNwZWN0b3JDb250cm9sbGVyQW5kcm9pZC5jcHAKQEAgLTkwLDYgKzkw LDcgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjphZGRQcm9maWxlKFBhc3NSZWZQdHI8SlND OjpQcm9maWxlPiwgdW5zaWduZWQgaW50LCBjb24KIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6 aW5zcGVjdGVkUGFnZURlc3Ryb3llZCgpIHt9CiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnJl c291cmNlUmV0cmlldmVkQnlYTUxIdHRwUmVxdWVzdCh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIs IEpTQzo6VVN0cmluZyYgc291cmNlU3RyaW5nKSB7fQogCit2b2lkIEluc3BlY3RvckNvbnRyb2xs ZXI6Omluc3BlY3RlZFdpbmRvd1NjcmlwdE9iamVjdENsZWFyZWQoRnJhbWUqIGZyYW1lKSB7fQog dm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpzdGFydEdyb3VwKE1lc3NhZ2VTb3VyY2Ugc291cmNl LCBKU0M6OkV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSlNDOjpBcmdMaXN0JiBhcmd1bWVudHMsIHVu c2lnbmVkIGxpbmVOdW1iZXIsIGNvbnN0IFN0cmluZyYgc291cmNlVVJMKSB7fQogdm9pZCBJbnNw ZWN0b3JDb250cm9sbGVyOjplbmRHcm91cChNZXNzYWdlU291cmNlIHNvdXJjZSwgdW5zaWduZWQg bGluZU51bWJlciwgY29uc3QgU3RyaW5nJiBzb3VyY2VVUkwpIHt9CiB2b2lkIEluc3BlY3RvckNv bnRyb2xsZXI6OnN0YXJ0VGltaW5nKGNvbnN0IEpTQzo6VVN0cmluZyYgdGl0bGUpIHt9Cg==