29764 2009-09-26 05:35:48 -0700 mark-bug-fixed: add -o|--open switch 2009-09-26 16:17:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer aroben eric oldest_to_newest 150281 0 40169 ddkilzer 2009-09-26 05:35:48 -0700 Created attachment 40169 Patch v1 Reviewed by NOBODY (OOPS!). The -o|--open switch uses the open(1) command on Mac OS X to open the bug URL in the default web browser. If there are similar mechanisms on other platforms, they may be added later. * Scripts/mark-bug-fixed: (MarkBugFixed.__init__): Added -o|--open switch to list of parse options. (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging code into main() and extracted prompting code into _prompt_user_for_correctness(). (MarkBugFixed._open_bug_in_web_browser): Added. (MarkBugFixed._prompt_user_for_correctness): Added. (MarkBugFixed.main): Added logging code from _determine_bug_id_and_svn_revision(). Added code to call _open_bug_in_web_browser() if the switch is set. Added code to call _prompt_user_for_correctness() when needed. * Scripts/modules/bugzilla.py: (Bugzilla.short_bug_url_for_bug_id): Added. --- 3 files changed, 51 insertions(+), 6 deletions(-) 150316 1 40169 eric 2009-09-26 11:14:59 -0700 Comment on attachment 40169 Patch v1 I like the feature! But it's sad that it seems more of this should be in the modules and thus shared between commands. _prompt_user_for_correctness seems useful in logging.py. _open_bug_in_web_browser I'm not sure. Maybe bugzilla? or some new desktop.py or interaction.py? I do wonder if other modules (like post-diff for instance) would want to have this option. This is one of the sad things about splitting commands into separate scripts like this is that we have to be careful not to end up with too much code duplication. I'm glad to see this script becoming more useful for Apple though. :) 150343 2 ddkilzer 2009-09-26 16:14:58 -0700 Committed r48794: <http://trac.webkit.org/changeset/48794> 150345 3 ddkilzer 2009-09-26 16:17:08 -0700 (In reply to comment #1) > (From update of attachment 40169 [details]) > I like the feature! But it's sad that it seems more of this should be in the > modules and thus shared between commands. It's easy enough to move the methods as soon as they're used a second time. It seems a little premature to move a methods into modules when they're only used in one place. 40169 2009-09-26 05:35:48 -0700 2009-09-26 11:14:58 -0700 Patch v1 20090926053547.patch text/plain 5304 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMmVlODQ5Li5lZTVhYTIxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMDktMDkt MjYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBtYXJrLWJ1 Zy1maXhlZDogYWRkIC1vfC0tb3BlbiBzd2l0Y2gKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgLW98LS1vcGVuIHN3aXRjaCB1c2VzIHRoZSBvcGVu KDEpIGNvbW1hbmQgb24gTWFjIE9TIFggdG8KKyAgICAgICAgb3BlbiB0aGUgYnVnIFVSTCBpbiB0 aGUgZGVmYXVsdCB3ZWIgYnJvd3Nlci4gIElmIHRoZXJlIGFyZQorICAgICAgICBzaW1pbGFyIG1l Y2hhbmlzbXMgb24gb3RoZXIgcGxhdGZvcm1zLCB0aGV5IG1heSBiZSBhZGRlZCBsYXRlci4KKwor ICAgICAgICAqIFNjcmlwdHMvbWFyay1idWctZml4ZWQ6CisgICAgICAgIChNYXJrQnVnRml4ZWQu X19pbml0X18pOiBBZGRlZCAtb3wtLW9wZW4gc3dpdGNoIHRvIGxpc3Qgb2YgcGFyc2UKKyAgICAg ICAgb3B0aW9ucy4KKyAgICAgICAgKE1hcmtCdWdGaXhlZC5fZGV0ZXJtaW5lX2J1Z19pZF9hbmRf c3ZuX3JldmlzaW9uKTogTW92ZWQgbG9nZ2luZworICAgICAgICBjb2RlIGludG8gbWFpbigpIGFu ZCBleHRyYWN0ZWQgcHJvbXB0aW5nIGNvZGUgaW50bworICAgICAgICBfcHJvbXB0X3VzZXJfZm9y X2NvcnJlY3RuZXNzKCkuCisgICAgICAgIChNYXJrQnVnRml4ZWQuX29wZW5fYnVnX2luX3dlYl9i cm93c2VyKTogQWRkZWQuCisgICAgICAgIChNYXJrQnVnRml4ZWQuX3Byb21wdF91c2VyX2Zvcl9j b3JyZWN0bmVzcyk6IEFkZGVkLgorICAgICAgICAoTWFya0J1Z0ZpeGVkLm1haW4pOiBBZGRlZCBs b2dnaW5nIGNvZGUgZnJvbQorICAgICAgICBfZGV0ZXJtaW5lX2J1Z19pZF9hbmRfc3ZuX3Jldmlz aW9uKCkuICBBZGRlZCBjb2RlIHRvIGNhbGwKKyAgICAgICAgX29wZW5fYnVnX2luX3dlYl9icm93 c2VyKCkgaWYgdGhlIHN3aXRjaCBpcyBzZXQuICBBZGRlZCBjb2RlIHRvCisgICAgICAgIGNhbGwg X3Byb21wdF91c2VyX2Zvcl9jb3JyZWN0bmVzcygpIHdoZW4gbmVlZGVkLgorICAgICAgICAqIFNj cmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weToKKyAgICAgICAgKEJ1Z3ppbGxhLnNob3J0X2J1Z191 cmxfZm9yX2J1Z19pZCk6IEFkZGVkLgorCiAyMDA5LTA5LTI1ICBEYXZpZCBLaWx6ZXIgIDxkZGtp bHplckBhcHBsZS5jb20+CiAKICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMjk3MTg+IG1h cmstYnVnLWZpeGVkOiBhZGQgLXV8LS11cGRhdGUtb25seSBzd2l0Y2gKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbWFyay1idWctZml4ZWQgYi9XZWJLaXRUb29scy9TY3JpcHRzL21h cmstYnVnLWZpeGVkCmluZGV4IGE5ZWU5NDQuLmM3MDg2YzIgMTAwNzU1Ci0tLSBhL1dlYktpdFRv b2xzL1NjcmlwdHMvbWFyay1idWctZml4ZWQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tYXJr LWJ1Zy1maXhlZApAQCAtMzQsNyArMzQsNyBAQCBmcm9tIG9wdHBhcnNlIGltcG9ydCBPcHRpb25Q YXJzZXIKIGZyb20gbW9kdWxlcy5idWd6aWxsYSBpbXBvcnQgQnVnemlsbGEsIHBhcnNlX2J1Z19p ZAogZnJvbSBtb2R1bGVzLmNvbW1lbnRzIGltcG9ydCBidWdfY29tbWVudF9mcm9tX3N2bl9yZXZp c2lvbgogZnJvbSBtb2R1bGVzLmxvZ2dpbmcgaW1wb3J0IGVycm9yLCBsb2cKLWZyb20gbW9kdWxl cy5zY20gaW1wb3J0IGRldGVjdF9zY21fc3lzdGVtCitmcm9tIG1vZHVsZXMuc2NtIGltcG9ydCBT Q00sIGRldGVjdF9zY21fc3lzdGVtCiAKIAogY2xhc3MgTWFya0J1Z0ZpeGVkVG9vbDoKQEAgLTQ0 LDYgKzQ0LDcgQEAgY2xhc3MgTWFya0J1Z0ZpeGVkVG9vbDoKICAgICAgICAgc2VsZi5vcHRpb25f cGFyc2VyID0gT3B0aW9uUGFyc2VyKHVzYWdlPSJ1c2FnZTogJXByb2cgW29wdGlvbnNdIFtyTk5O Tk5dIikKICAgICAgICAgc2VsZi5vcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oIi1iIiwgIi0tYnVn LWlkIiwgYWN0aW9uPSJzdG9yZSIsIHR5cGU9InN0cmluZyIsIGRlc3Q9ImJ1Z19pZCIsIGhlbHA9 IlNwZWNpZnkgYnVnIGlkIGlmIG5vIFVSTCBpcyBwcm92aWRlZCBpbiB0aGUgY29tbWl0IGxvZy4i KQogICAgICAgICBzZWxmLm9wdGlvbl9wYXJzZXIuYWRkX29wdGlvbigiLW0iLCAiLS1jb21tZW50 IiwgYWN0aW9uPSJzdG9yZSIsIHR5cGU9InN0cmluZyIsIGRlc3Q9ImNvbW1lbnQiLCBoZWxwPSJU ZXh0IHRvIGluY2x1ZGUgaW4gYnVnIGNvbW1lbnQuIikKKyAgICAgICAgc2VsZi5vcHRpb25fcGFy c2VyLmFkZF9vcHRpb24oIi1vIiwgIi0tb3BlbiIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlZmF1 bHQ9RmFsc2UsIGRlc3Q9Im9wZW5fYnVnIiwgaGVscD0iT3BlbiBidWcgaW4gZGVmYXVsdCB3ZWIg YnJvd3NlciAoTWFjIG9ubHkpLiIpCiAgICAgICAgIHNlbGYub3B0aW9uX3BhcnNlci5hZGRfb3B0 aW9uKCItdSIsICItLXVwZGF0ZS1vbmx5IiwgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVmYXVsdD1G YWxzZSwgZGVzdD0idXBkYXRlX29ubHkiLCBoZWxwPSJBZGQgY29tbWVudCB0byB0aGUgYnVnLCBi dXQgZG8gbm90IGNsb3NlIGl0LiIpCiAKICAgICBkZWYgc2NtKHNlbGYpOgpAQCAtNzgsMTQgKzc5 LDE5IEBAIGNsYXNzIE1hcmtCdWdGaXhlZFRvb2w6CiAgICAgICAgICAgICBlcnJvcigiQ291bGQg bm90IGZpbmQgJXMgb24gY29tbWFuZC1saW5lIG9yIGluICVzLiIKICAgICAgICAgICAgICAgICAg ICUgKCIgb3IgIi5qb2luKG5vdF9mb3VuZCksICJyJXMiICUgc3ZuX3JldmlzaW9uIGlmIHN2bl9y ZXZpc2lvbiBlbHNlICJsYXN0IGNvbW1pdCIpKQogCi0gICAgICAgIGxvZygiQnVnOiA8aHR0cDov L3dlYmtpdC5vcmcvYi8lcz4gJXMiICUgKGJ1Z19pZCwgc2VsZi5idWdzLmZldGNoX3RpdGxlX2Zy b21fYnVnKGJ1Z19pZCkpKQotICAgICAgICBsb2coIlJldmlzaW9uOiAlcyIgJSBzdm5fcmV2aXNp b24pCisgICAgICAgIHJldHVybiAoYnVnX2lkLCBzdm5fcmV2aXNpb24pCisKKyAgICBkZWYgX29w ZW5fYnVnX2luX3dlYl9icm93c2VyKHNlbGYsIGJ1Z19pZCk6CisgICAgICAgIGlmIHN5cy5wbGF0 Zm9ybSA9PSAiZGFyd2luIjoKKyAgICAgICAgICAgIFNDTS5ydW5fY29tbWFuZChbIm9wZW4iLCBz ZWxmLmJ1Z3Muc2hvcnRfYnVnX3VybF9mb3JfYnVnX2lkKGJ1Z19pZCldKQorICAgICAgICAgICAg cmV0dXJuCisgICAgICAgIGxvZygiV0FSTklORzogLW98LS1vcGVuIGlzIG9ubHkgc3VwcG9ydGVk IG9uIE1hYyBPUyBYLiIpCisKKyAgICBkZWYgX3Byb21wdF91c2VyX2Zvcl9jb3JyZWN0bmVzcyhz ZWxmLCBidWdfaWQsIHN2bl9yZXZpc2lvbik6CiAgICAgICAgIGFuc3dlciA9IHJhd19pbnB1dCgi SXMgdGhpcyBjb3JyZWN0ICh5L04pPyAiKQogICAgICAgICBpZiBub3QgcmUubWF0Y2goIl5ccyp5 KGVzKT8iLCBhbnN3ZXIsIHJlLklHTk9SRUNBU0UpOgogICAgICAgICAgICAgZXhpdCgxKQogCi0g ICAgICAgIHJldHVybiAoYnVnX2lkLCBzdm5fcmV2aXNpb24pCi0KICAgICBkZWYgbWFpbihzZWxm KToKICAgICAgICAgKG9wdGlvbnMsIGFyZ3MpID0gc2VsZi5vcHRpb25fcGFyc2VyLnBhcnNlX2Fy Z3Moc3lzLmFyZ3ZbMTpdKQogCkBAIC0xMDEsOSArMTA3LDIwIEBAIGNsYXNzIE1hcmtCdWdGaXhl ZFRvb2w6CiAgICAgICAgICAgICBpZiBub3QgcmUubWF0Y2goIl5bMC05XSskIiwgc3ZuX3Jldmlz aW9uKToKICAgICAgICAgICAgICAgICBlcnJvcigiSW52YWxpZCBzdm4gcmV2aXNpb246ICclcyci ICUgc3ZuX3JldmlzaW9uKQogCisgICAgICAgIG5lZWRzX3Byb21wdCA9IEZhbHNlCiAgICAgICAg IGlmIG5vdCBidWdfaWQgb3Igbm90IHN2bl9yZXZpc2lvbjoKKyAgICAgICAgICAgIG5lZWRzX3By b21wdCA9IFRydWUKICAgICAgICAgICAgIChidWdfaWQsIHN2bl9yZXZpc2lvbikgPSBzZWxmLl9k ZXRlcm1pbmVfYnVnX2lkX2FuZF9zdm5fcmV2aXNpb24oYnVnX2lkLCBzdm5fcmV2aXNpb24pCiAK KyAgICAgICAgbG9nKCJCdWc6IDwlcz4gJXMiICUgKHNlbGYuYnVncy5zaG9ydF9idWdfdXJsX2Zv cl9idWdfaWQoYnVnX2lkKSwgc2VsZi5idWdzLmZldGNoX3RpdGxlX2Zyb21fYnVnKGJ1Z19pZCkp KQorICAgICAgICBsb2coIlJldmlzaW9uOiAlcyIgJSBzdm5fcmV2aXNpb24pCisKKyAgICAgICAg aWYgb3B0aW9ucy5vcGVuX2J1ZzoKKyAgICAgICAgICAgIHNlbGYuX29wZW5fYnVnX2luX3dlYl9i cm93c2VyKGJ1Z19pZCkKKworICAgICAgICBpZiBuZWVkc19wcm9tcHQ6CisgICAgICAgICAgICBz ZWxmLl9wcm9tcHRfdXNlcl9mb3JfY29ycmVjdG5lc3MoYnVnX2lkLCBzdm5fcmV2aXNpb24pCisK ICAgICAgICAgYnVnX2NvbW1lbnQgPSBidWdfY29tbWVudF9mcm9tX3N2bl9yZXZpc2lvbihzdm5f cmV2aXNpb24pCiAgICAgICAgIGlmIG9wdGlvbnMuY29tbWVudDoKICAgICAgICAgICAgIGJ1Z19j b21tZW50ID0gIiVzXG5cbiVzIiAlIChvcHRpb25zLmNvbW1lbnQsIGJ1Z19jb21tZW50KQpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5CmluZGV4IDNhNGQwMGEuLmRhZjNmMTkg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9idWd6aWxsYS5weQorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHkKQEAgLTE1MSw3ICsxNTEs MTAgQEAgY2xhc3MgQnVnemlsbGE6CiAgICAgZGVmIGJ1Z191cmxfZm9yX2J1Z19pZChzZWxmLCBi dWdfaWQsIHhtbD1GYWxzZSk6CiAgICAgICAgIGNvbnRlbnRfdHlwZSA9ICImY3R5cGU9eG1sIiBp ZiB4bWwgZWxzZSAiIgogICAgICAgICByZXR1cm4gIiVzc2hvd19idWcuY2dpP2lkPSVzJXMiICUg KHNlbGYuYnVnX3NlcnZlcl91cmwsIGJ1Z19pZCwgY29udGVudF90eXBlKQotICAgIAorCisgICAg ZGVmIHNob3J0X2J1Z191cmxfZm9yX2J1Z19pZChzZWxmLCBidWdfaWQpOgorICAgICAgICByZXR1 cm4gImh0dHA6Ly93ZWJraXQub3JnL2IvJXMiICUgYnVnX2lkCisKICAgICBkZWYgYXR0YWNobWVu dF91cmxfZm9yX2lkKHNlbGYsIGF0dGFjaG1lbnRfaWQsIGFjdGlvbj0idmlldyIpOgogICAgICAg ICBhY3Rpb25fcGFyYW0gPSAiIgogICAgICAgICBpZiBhY3Rpb24gYW5kIGFjdGlvbiAhPSAidmll dyI6