29758 2009-09-25 18:02:27 -0700 Code generator does not support custom constructor getters in V8 2009-10-02 12:30:29 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 1 atwilson atwilson oldest_to_newest 150214 0 atwilson 2009-09-25 18:02:27 -0700 Need to update the code generator to support custom getters for constructors in V8, so we can properly support turning on/off APIs at runtime via command line flags. 150421 1 40206 atwilson 2009-09-27 14:06:18 -0700 Created attachment 40206 proposed patch This patch just enables custom constructors for V8, but none of the existing code requires a custom constructor. My upcoming patch to turn on the ENABLE_SHARED_WORKERS flag for Chromium will include custom constructors - this patch is a prelude to that. 150422 2 atwilson 2009-09-27 14:07:14 -0700 Successful trybot run: http://build.chromium.org/buildbot/try-server/builders/layout_mac/builds/39 151731 3 atwilson 2009-10-01 16:10:58 -0700 Closing - made obsolete by http://trac.webkit.org/changeset/48955 151935 4 40206 eric 2009-10-02 12:30:29 -0700 Comment on attachment 40206 proposed patch Clearing review flag on closed bug. 40206 2009-09-27 14:06:18 -0700 2009-10-02 12:30:29 -0700 proposed patch y text/plain 5724 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTdkMzkyZi4uNjg1OGQxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOS0wOS0yNyAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEN1c3RvbUdldHRlci0+SlNDQ3VzdG9tR2V0dGVyCisKKyAgICAgICAg TWVyZ2UgYnJhbmNoICdzaGFyZWQtZmxhZycgaW50byB2OGdjCisKKyAgICAgICAgaW5pdGlhbCBj aGVja2luCisKKyAgICAgICAgQ29kZSBnZW5lcmF0b3IgZG9lcyBub3Qgc3VwcG9ydCBjdXN0b20g Y29uc3RydWN0b3IgZ2V0dGVycyBpbiBWOC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI5NzU4CisKKyAgICAgICAgVGVzdHM9bm9uZSAocmVzdWx0aW5n IGdlbmVyYXRlZCBjb2RlIGlzIHVuY2hhbmdlZCwgc28gZXhpc3RpbmcgdGVzdHMgc3VmZmljZSku CisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAg ICAgTm93IGNoZWNrcyBmb3IgYSBDdXN0b20vQ3VzdG9tR2V0dGVyIGF0dHJpYnV0ZSBmb3IgY29u c3RydWN0b3JzIGFuZCBnZW5lcmF0ZXMgYSBjdXN0b20gZ2V0dGVyLgorICAgICAgICAqIHBhZ2Uv RE9NV2luZG93LmlkbDoKKyAgICAgICAgVXBkYXRlZCBET01XaW5kb3cuaWRsIHRvIGNoYW5nZSB0 aGUgZXhpc3RpbmcgY3VzdG9tIGNvbnN0cnVjdG9yIGdldHRlcnMgdG8gYmUgSlNDQ3VzdG9tR2V0 dGVycyAoc2luY2UgVjggd2FzIG5vdCBnZW5lcmF0aW5nIGN1c3RvbSBnZXR0ZXJzIGFuZCBkb2Vz IG5vdCBuZWVkIHRoZW0pLgorCiAyMDA5LTA5LTI1ICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGdv b2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBhMThkZTQ5Li40ODVm NmU2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAg LTk1OSw3ICs5NTksMTEgQEAgc3ViIEdlbmVyYXRlQmF0Y2hlZEF0dHJpYnV0ZURhdGEKICAgICAg ICAgICAgICRjb25zdHJ1Y3RvclR5cGUgPX4gcy9Db25zdHJ1Y3RvciQvLzsKICAgICAgICAgICAg IG15ICRjb25zdHJ1Y3RvckluZGV4ID0gdWMoJGNvbnN0cnVjdG9yVHlwZSk7CiAgICAgICAgICAg ICAkZGF0YSA9ICJWOENsYXNzSW5kZXg6OiR7Y29uc3RydWN0b3JJbmRleH0iOwotICAgICAgICAg ICAgJGdldHRlciA9ICIke2ludGVyZmFjZU5hbWV9SW50ZXJuYWw6OiR7aW50ZXJmYWNlTmFtZX1D b25zdHJ1Y3RvckdldHRlciI7CisgICAgICAgICAgICBpZiAoJGF0dHJFeHQtPnsiQ3VzdG9tR2V0 dGVyIn0gfHwgJGF0dHJFeHQtPnsiQ3VzdG9tIn0gfHwgJGF0dHJFeHQtPnsiVjhDdXN0b20ifSkg eworICAgICAgICAgICAgICAgICRnZXR0ZXIgPSAiVjhDdXN0b206OnY4JHtjdXN0b21BY2Nlc3Nv cn1Db25zdHJ1Y3RvckdldHRlciI7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAg ICAgICRnZXR0ZXIgPSAiJHtpbnRlcmZhY2VOYW1lfUludGVybmFsOjoke2ludGVyZmFjZU5hbWV9 Q29uc3RydWN0b3JHZXR0ZXIiOworICAgICAgICAgICAgfQogICAgICAgICAgICAgJHNldHRlciA9 ICIwIjsKICAgICAgICAgICAgICRwcm9wQXR0ciA9ICJ2ODo6UmVhZE9ubHkiOwogCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbCBiL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cu aWRsCmluZGV4IGYzNjE3NWUuLjQyZmNmNjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9ET01X aW5kb3cuaWRsCisrKyBiL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCkBAIC00MjcsMjEgKzQy NywyMSBAQCBtb2R1bGUgd2luZG93IHsKIAogICAgICAgICBhdHRyaWJ1dGUgSFRNTENvbGxlY3Rp b25Db25zdHJ1Y3RvciBIVE1MQ29sbGVjdGlvbjsKIAotICAgICAgICBhdHRyaWJ1dGUgW0N1c3Rv bUdldHRlcl0gSFRNTEltYWdlRWxlbWVudENvbnN0cnVjdG9yIEltYWdlOyAvLyBVc2FibGUgd2l0 aCBuZXcgb3BlcmF0b3IKLSAgICAgICAgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXJdIEhUTUxPcHRp b25FbGVtZW50Q29uc3RydWN0b3IgT3B0aW9uOyAvLyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IK KyAgICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXJdIEhUTUxJbWFnZUVsZW1lbnRDb25z dHJ1Y3RvciBJbWFnZTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCisgICAgICAgIGF0dHJp YnV0ZSBbSlNDQ3VzdG9tR2V0dGVyXSBIVE1MT3B0aW9uRWxlbWVudENvbnN0cnVjdG9yIE9wdGlv bjsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCiAKICAgICAgICAgYXR0cmlidXRlIENhbnZh c1JlbmRlcmluZ0NvbnRleHQyRENvbnN0cnVjdG9yIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDsK ICAgICAgICAgYXR0cmlidXRlIFtDb25kaXRpb25hbD0zRF9DQU5WQVNdIENhbnZhc1JlbmRlcmlu Z0NvbnRleHQzRENvbnN0cnVjdG9yIENhbnZhc1JlbmRlcmluZ0NvbnRleHQzRDsKICAgICAgICAg YXR0cmlidXRlIFRleHRNZXRyaWNzQ29uc3RydWN0b3IgVGV4dE1ldHJpY3M7CiAKLSAgICAgICAg YXR0cmlidXRlIFtDdXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFTXSBDYW52YXNBcnJh eUJ1ZmZlckNvbnN0cnVjdG9yIENhbnZhc0FycmF5QnVmZmVyOyAvLyBVc2FibGUgd2l0aCBuZXcg b3BlcmF0b3IKLSAgICAgICAgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9M0Rf Q0FOVkFTXSBDYW52YXNCeXRlQXJyYXlDb25zdHJ1Y3RvciBDYW52YXNCeXRlQXJyYXk7IC8vIFVz YWJsZSB3aXRoIG5ldyBvcGVyYXRvcgotICAgICAgICBhdHRyaWJ1dGUgW0N1c3RvbUdldHRlcixD b25kaXRpb25hbD0zRF9DQU5WQVNdIENhbnZhc1Vuc2lnbmVkQnl0ZUFycmF5Q29uc3RydWN0b3Ig Q2FudmFzVW5zaWduZWRCeXRlQXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgotICAg ICAgICBhdHRyaWJ1dGUgW0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNdIENhbnZh c1Nob3J0QXJyYXlDb25zdHJ1Y3RvciBDYW52YXNTaG9ydEFycmF5OyAvLyBVc2FibGUgd2l0aCBu ZXcgb3BlcmF0b3IKLSAgICAgICAgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9 M0RfQ0FOVkFTXSBDYW52YXNVbnNpZ25lZFNob3J0QXJyYXlDb25zdHJ1Y3RvciBDYW52YXNVbnNp Z25lZFNob3J0QXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgotICAgICAgICBhdHRy aWJ1dGUgW0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNdIENhbnZhc0ludEFycmF5 Q29uc3RydWN0b3IgQ2FudmFzSW50QXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgot ICAgICAgICBhdHRyaWJ1dGUgW0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNdIENh bnZhc1Vuc2lnbmVkSW50QXJyYXlDb25zdHJ1Y3RvciBDYW52YXNVbnNpZ25lZEludEFycmF5OyAv LyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKLSAgICAgICAgYXR0cmlidXRlIFtDdXN0b21HZXR0 ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFTXSBDYW52YXNGbG9hdEFycmF5Q29uc3RydWN0b3IgQ2Fu dmFzRmxvYXRBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCisgICAgICAgIGF0dHJp YnV0ZSBbSlNDQ3VzdG9tR2V0dGVyLENvbmRpdGlvbmFsPTNEX0NBTlZBU10gQ2FudmFzQXJyYXlC dWZmZXJDb25zdHJ1Y3RvciBDYW52YXNBcnJheUJ1ZmZlcjsgLy8gVXNhYmxlIHdpdGggbmV3IG9w ZXJhdG9yCisgICAgICAgIGF0dHJpYnV0ZSBbSlNDQ3VzdG9tR2V0dGVyLENvbmRpdGlvbmFsPTNE X0NBTlZBU10gQ2FudmFzQnl0ZUFycmF5Q29uc3RydWN0b3IgQ2FudmFzQnl0ZUFycmF5OyAvLyBV c2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKKyAgICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0 ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFTXSBDYW52YXNVbnNpZ25lZEJ5dGVBcnJheUNvbnN0cnVj dG9yIENhbnZhc1Vuc2lnbmVkQnl0ZUFycmF5OyAvLyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IK KyAgICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFT XSBDYW52YXNTaG9ydEFycmF5Q29uc3RydWN0b3IgQ2FudmFzU2hvcnRBcnJheTsgLy8gVXNhYmxl IHdpdGggbmV3IG9wZXJhdG9yCisgICAgICAgIGF0dHJpYnV0ZSBbSlNDQ3VzdG9tR2V0dGVyLENv bmRpdGlvbmFsPTNEX0NBTlZBU10gQ2FudmFzVW5zaWduZWRTaG9ydEFycmF5Q29uc3RydWN0b3Ig Q2FudmFzVW5zaWduZWRTaG9ydEFycmF5OyAvLyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKKyAg ICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFTXSBD YW52YXNJbnRBcnJheUNvbnN0cnVjdG9yIENhbnZhc0ludEFycmF5OyAvLyBVc2FibGUgd2l0aCBu ZXcgb3BlcmF0b3IKKyAgICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXIsQ29uZGl0aW9u YWw9M0RfQ0FOVkFTXSBDYW52YXNVbnNpZ25lZEludEFycmF5Q29uc3RydWN0b3IgQ2FudmFzVW5z aWduZWRJbnRBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCisgICAgICAgIGF0dHJp YnV0ZSBbSlNDQ3VzdG9tR2V0dGVyLENvbmRpdGlvbmFsPTNEX0NBTlZBU10gQ2FudmFzRmxvYXRB cnJheUNvbnN0cnVjdG9yIENhbnZhc0Zsb2F0QXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVy YXRvcgogCiAgICAgICAgIGF0dHJpYnV0ZSBFdmVudENvbnN0cnVjdG9yIEV2ZW50OwogICAgICAg ICBhdHRyaWJ1dGUgS2V5Ym9hcmRFdmVudENvbnN0cnVjdG9yIEtleWJvYXJkRXZlbnQ7CkBAIC01 MjQsNyArNTI0LDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIGF0dHJpYnV0ZSBTdG9yYWdl RXZlbnRDb25zdHJ1Y3RvciBTdG9yYWdlRXZlbnQ7CiAjZW5kaWYKIAotICAgICAgICBhdHRyaWJ1 dGUgW0N1c3RvbUdldHRlcixDb25kaXRpb25hbD1WSURFT10gSFRNTEF1ZGlvRWxlbWVudENvbnN0 cnVjdG9yIEF1ZGlvOyAvLyBVc2FibGUgd2l0aCB0aGUgbmV3IG9wZXJhdG9yCisgICAgICAgIGF0 dHJpYnV0ZSBbSlNDQ3VzdG9tR2V0dGVyLENvbmRpdGlvbmFsPVZJREVPXSBIVE1MQXVkaW9FbGVt ZW50Q29uc3RydWN0b3IgQXVkaW87IC8vIFVzYWJsZSB3aXRoIHRoZSBuZXcgb3BlcmF0b3IKICAg ICAgICAgYXR0cmlidXRlIFtDb25kaXRpb25hbD1WSURFT10gSFRNTEF1ZGlvRWxlbWVudENvbnN0 cnVjdG9yIEhUTUxBdWRpb0VsZW1lbnQ7CiAgICAgICAgIGF0dHJpYnV0ZSBbQ29uZGl0aW9uYWw9 VklERU9dIEhUTUxNZWRpYUVsZW1lbnRDb25zdHJ1Y3RvciBIVE1MTWVkaWFFbGVtZW50OwogICAg ICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPVZJREVPXSBIVE1MVmlkZW9FbGVtZW50Q29uc3Ry dWN0b3IgSFRNTFZpZGVvRWxlbWVudDsK