29757 2009-09-25 17:38:32 -0700 Chromium wants to turn off SharedWorkers at runtime 2009-10-11 17:13:18 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue sam oldest_to_newest 150210 0 atwilson 2009-09-25 17:38:32 -0700 We need to add SharedWorkerRepository::isAvailable(), and have window.SharedWorker === undefined when isAvailable returns false. 150215 1 40156 atwilson 2009-09-25 18:03:11 -0700 Created attachment 40156 proposed patch V8 does not support custom getters for constructors yet, so this just turns on this functionality for JSC. V8 functionality will be added once https://bugs.webkit.org/show_bug.cgi?id=29758 is addressed 150742 2 40156 eric 2009-09-28 17:19:10 -0700 Comment on attachment 40156 proposed patch Where is the code to make it return false? // Returns true if the platform supports SharedWorkers, otherwise false. 52 static bool isAvailable(); 150745 3 atwilson 2009-09-28 17:22:55 -0700 That will be in the platform specific implementation. Chromium will provide its own implementation of SharedWorkerRepository (it will not compile the default WebKit implementation in DefaultSharedWorkerRepository). 151934 4 40156 eric 2009-10-02 12:30:06 -0700 Comment on attachment 40156 proposed patch Why wouldn't this be held off of Settings? 151942 5 atwilson 2009-10-02 12:42:24 -0700 (In reply to comment #4) > (From update of attachment 40156 [details]) > Why wouldn't this be held off of Settings? Because it's not intended to be a user setting, and it doesn't make sense to pollute all platforms with extra settings when there's already a clear platform-specific interface to hang this off of. I'm basically doing the same thing that MediaPlayer::isAvailable() does, so there's ample precedent for putting it here. 152304 6 40156 levin 2009-10-05 08:38:22 -0700 Comment on attachment 40156 proposed patch Looks good. Sorry it took me so long to look at this. 152516 7 40156 commit-queue 2009-10-05 16:34:38 -0700 Comment on attachment 40156 proposed patch Clearing flags on attachment: 40156 Committed r49130: <http://trac.webkit.org/changeset/49130> 152517 8 commit-queue 2009-10-05 16:34:41 -0700 All reviewed patches have been landed. Closing bug. 152520 9 sam 2009-10-05 16:46:23 -0700 This is wrong. "SharedWorker" in window will still return true, and that is the way we encourage web developers to due feature detection. 153953 10 atwilson 2009-10-11 17:11:42 -0700 (In reply to comment #9) > This is wrong. "SharedWorker" in window will still return true, and that is > the way we encourage web developers to due feature detection. I've logged two new bugs to track the issues Sam is concerned about, so I'm closing this bug. https://bugs.webkit.org/show_bug.cgi?id=30240 https://bugs.webkit.org/show_bug.cgi?id=30289 40156 2009-09-25 18:03:11 -0700 2009-10-05 16:34:38 -0700 proposed patch x text/plain 3397 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTAxYTFmNS4uYTdkMzkyZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wOS0yNSAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENocm9taXVtIHdhbnRzIHRvIHR1cm4gb2ZmIFNoYXJlZFdvcmtlcnMg YXQgcnVudGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjk3NTcKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93OjpzaGFyZWRXb3JrZXIpOgorICAgICAgICBO b3cgcmV0dXJucyBqc1VuZGVmaW5lZCBpZiBpc0F2YWlsYWJsZSgpIHJldHVybnMgZmFsc2UsIHRv IGFsbG93IFNoYXJlZFdvcmtlcnMgdG8gYmUgZGlzYWJsZWQgYXQgcnVudGltZS4KKyAgICAgICAg KiB3b3JrZXJzL0RlZmF1bHRTaGFyZWRXb3JrZXJSZXBvc2l0b3J5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNoYXJlZFdvcmtlclJlcG9zaXRvcnk6OmlzQXZhaWxhYmxlKToKKyAgICAgICAgTWFk ZSBTaGFyZWRXb3JrZXJzIGF2YWlsYWJsZSBieSBkZWZhdWx0LgorICAgICAgICAqIHdvcmtlcnMv U2hhcmVkV29ya2VyUmVwb3NpdG9yeS5oOgorICAgICAgICBBZGRlZCBkZWZpbml0aW9uIGZvciBT aGFyZWRXb3JrZXJSZXBvc2l0b3J5Ojppc0F2YWlsYWJsZSgpLgorCiAyMDA5LTA5LTI0ICBHZW9m ZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3Rl cGhhbmllIExld2lzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRv d0N1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcApp bmRleCAwOGM3MTQ0Li5jNTRjNDQwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT RE9NV2luZG93Q3VzdG9tLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93 Q3VzdG9tLmNwcApAQCAtODAsNiArODAsNyBAQAogI2luY2x1ZGUgIlNjaGVkdWxlZEFjdGlvbi5o IgogI2luY2x1ZGUgIlNjcmlwdENvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgor I2luY2x1ZGUgIlNoYXJlZFdvcmtlclJlcG9zaXRvcnkuaCIKICNpbmNsdWRlICJXaW5kb3dGZWF0 dXJlcy5oIgogI2luY2x1ZGUgPHJ1bnRpbWUvRXJyb3IuaD4KICNpbmNsdWRlIDxydW50aW1lL0pT RnVuY3Rpb24uaD4KQEAgLTcxMyw3ICs3MTQsOSBAQCBKU1ZhbHVlIEpTRE9NV2luZG93Ojp3b3Jr ZXIoRXhlY1N0YXRlKiBleGVjKSBjb25zdAogI2lmIEVOQUJMRShTSEFSRURfV09SS0VSUykKIEpT VmFsdWUgSlNET01XaW5kb3c6OnNoYXJlZFdvcmtlcihFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0CiB7 Ci0gICAgcmV0dXJuIGdldERPTUNvbnN0cnVjdG9yPEpTU2hhcmVkV29ya2VyQ29uc3RydWN0b3I+ KGV4ZWMsIHRoaXMpOworICAgIGlmIChTaGFyZWRXb3JrZXJSZXBvc2l0b3J5Ojppc0F2YWlsYWJs ZSgpKQorICAgICAgICByZXR1cm4gZ2V0RE9NQ29uc3RydWN0b3I8SlNTaGFyZWRXb3JrZXJDb25z dHJ1Y3Rvcj4oZXhlYywgdGhpcyk7CisgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiB9CiAjZW5k aWYKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS93b3JrZXJzL0RlZmF1bHRTaGFyZWRXb3JrZXJSZXBv c2l0b3J5LmNwcCBiL1dlYkNvcmUvd29ya2Vycy9EZWZhdWx0U2hhcmVkV29ya2VyUmVwb3NpdG9y eS5jcHAKaW5kZXggMTExMDZlZS4uMjEyNmRmNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS93b3JrZXJz L0RlZmF1bHRTaGFyZWRXb3JrZXJSZXBvc2l0b3J5LmNwcAorKysgYi9XZWJDb3JlL3dvcmtlcnMv RGVmYXVsdFNoYXJlZFdvcmtlclJlcG9zaXRvcnkuY3BwCkBAIC0zMTEsNiArMzExLDEyIEBAIHZv aWQgRGVmYXVsdFNoYXJlZFdvcmtlclJlcG9zaXRvcnk6OndvcmtlclNjcmlwdExvYWRlZChTaGFy ZWRXb3JrZXJQcm94eSYgcHJveHksCiAgICAgcHJveHkudGhyZWFkKCktPnJ1bkxvb3AoKS5wb3N0 VGFzayhTaGFyZWRXb3JrZXJDb25uZWN0VGFzazo6Y3JlYXRlKHBvcnQpKTsKIH0KIAorYm9vbCBT aGFyZWRXb3JrZXJSZXBvc2l0b3J5Ojppc0F2YWlsYWJsZSgpCit7CisgICAgLy8gU2hhcmVkV29y a2VycyBhcmUgZW5hYmxlZCBvbiB0aGUgZGVmYXVsdCBXZWJLaXQgcGxhdGZvcm0uCisgICAgcmV0 dXJuIHRydWU7Cit9CisKIHZvaWQgU2hhcmVkV29ya2VyUmVwb3NpdG9yeTo6Y29ubmVjdChQYXNz UmVmUHRyPFNoYXJlZFdvcmtlcj4gd29ya2VyLCBQYXNzT3duUHRyPE1lc3NhZ2VQb3J0Q2hhbm5l bD4gcG9ydCwgY29uc3QgS1VSTCYgdXJsLCBjb25zdCBTdHJpbmcmIG5hbWUsIEV4Y2VwdGlvbkNv ZGUmIGVjKQogewogICAgIERlZmF1bHRTaGFyZWRXb3JrZXJSZXBvc2l0b3J5OjppbnN0YW5jZSgp LmNvbm5lY3RUb1dvcmtlcih3b3JrZXIsIHBvcnQsIHVybCwgbmFtZSwgZWMpOwpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS93b3JrZXJzL1NoYXJlZFdvcmtlclJlcG9zaXRvcnkuaCBiL1dlYkNvcmUvd29y a2Vycy9TaGFyZWRXb3JrZXJSZXBvc2l0b3J5LmgKaW5kZXggOTZkMmZiMS4uNDlmMzk0MSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS93b3JrZXJzL1NoYXJlZFdvcmtlclJlcG9zaXRvcnkuaAorKysgYi9X ZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5oCkBAIC00OCw2ICs0OCw5IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAvLyBJbnRlcmZhY2UgdG8gYSByZXBvc2l0b3J5IHdo aWNoIG1hbmFnZXMgcmVmZXJlbmNlcyB0byB0aGUgc2V0IG9mIGFjdGl2ZSBzaGFyZWQgd29ya2Vy cy4KICAgICBjbGFzcyBTaGFyZWRXb3JrZXJSZXBvc2l0b3J5IHsKICAgICBwdWJsaWM6CisgICAg ICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgcGxhdGZvcm0gc3VwcG9ydHMgU2hhcmVkV29ya2Vy cywgb3RoZXJ3aXNlIGZhbHNlLgorICAgICAgICBzdGF0aWMgYm9vbCBpc0F2YWlsYWJsZSgpOwor CiAgICAgICAgIC8vIENvbm5lY3RzIHRoZSBwYXNzZWQgU2hhcmVkV29ya2VyIG9iamVjdCB3aXRo IHRoZSBzcGVjaWZpZWQgd29ya2VyIHRocmVhZCwgY3JlYXRpbmcgYSBuZXcgdGhyZWFkIGlmIG5l Y2Vzc2FyeS4KICAgICAgICAgc3RhdGljIHZvaWQgY29ubmVjdChQYXNzUmVmUHRyPFNoYXJlZFdv cmtlcj4sIFBhc3NPd25QdHI8TWVzc2FnZVBvcnRDaGFubmVsPiwgY29uc3QgS1VSTCYsIGNvbnN0 IFN0cmluZyYgbmFtZSwgRXhjZXB0aW9uQ29kZSYpOwogCg==