29747 2009-09-25 13:05:37 -0700 Load blocks during unload should not affect targeted loads 2014-06-03 14:53:31 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue eric fishd oldest_to_newest 150119 0 abarth 2009-09-25 13:05:37 -0700 Comment #8 From Darin Fisher (:fishd, Google) 2009-09-21 00:54:16 PDT (-) [reply] Also, why is it correct to block loads made on a target that is not unloading? If the target string indicates a different top-level window (e.g., target=_blank), then why should we care if it happens during "unload" of the opener? 150125 1 abarth 2009-09-25 13:26:24 -0700 I have a patch that I'm building / testing now. 150142 2 40142 abarth 2009-09-25 14:03:54 -0700 Created attachment 40142 Patch v1 150233 3 40142 commit-queue 2009-09-25 19:35:22 -0700 Comment on attachment 40142 Patch v1 Clearing flags on attachment: 40142 Committed r48783: <http://trac.webkit.org/changeset/48783> 150234 4 commit-queue 2009-09-25 19:35:25 -0700 All reviewed patches have been landed. Closing bug. 1013152 5 eric 2014-06-03 14:53:31 -0700 FYI this test turned out to be very flaky, finally fixed today: https://codereview.chromium.org/318523002 40142 2009-09-25 14:03:54 -0700 2009-09-25 19:35:22 -0700 Patch v1 bug-29747-20090925140350.patch text/plain 3984 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMTM4Y2E3Li5kZDUyYzMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDkt MjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMb2FkIGJsb2NrcyBkdXJpbmcgdW5sb2FkIHNo b3VsZCBub3QgYWZmZWN0IHRhcmdldGVkIGxvYWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTc0NworCisgICAgICAgIFRlc3QgdGhhdCB3ZSBjYW4g Zm9sbG93IHRhcmdldGVkIGh5cGVybGlua3MgaW4gYW4gdW5sb2FkIGhhbmRsZXIuCisKKyAgICAg ICAgKiBmYXN0L2xvYWRlci9yZXNvdXJjZXMvdW5sb2FkLWh5cGVybGluay10YXJnZXRlZC1zdWJm cmFtZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2xvYWRlci91bmxvYWQtaHlwZXJsaW5r LXRhcmdldGVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9sb2FkZXIvdW5s b2FkLWh5cGVybGluay10YXJnZXRlZC5odG1sOiBBZGRlZC4KKwogMjAwOS0wOS0yMyAgS2FyZW4g R3LDvG5iZXJnICA8a2FyZW4rd2Via2l0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3Jl c291cmNlcy91bmxvYWQtaHlwZXJsaW5rLXRhcmdldGVkLXN1YmZyYW1lLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2xvYWRlci9yZXNvdXJjZXMvdW5sb2FkLWh5cGVybGluay10YXJnZXRlZC1zdWJm cmFtZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjg3OWQxNzkKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZXNvdXJjZXMvdW5sb2Fk LWh5cGVybGluay10YXJnZXRlZC1zdWJmcmFtZS5odG1sCkBAIC0wLDAgKzEsMTUgQEAKKzxzY3Jp cHQ+CithZGRFdmVudExpc3RlbmVyKCJ1bmxvYWQiLCBmdW5jdGlvbigpIHsKKyAgdmFyIGFuYyA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJsayIpOworICB2YXIgZXZ0ID0gZG9jdW1lbnQuY3Jl YXRlRXZlbnQoIk1vdXNlRXZlbnRzIik7CisgIGV2dC5pbml0TW91c2VFdmVudCgKKyAgICAgICJj bGljayIsIHRydWUsIHRydWUsIHdpbmRvdywgMSwgMCwgMCwgMCwgMCwKKyAgICAgIGZhbHNlLCBm YWxzZSwgZmFsc2UsIGZhbHNlLCAwLCBhbmMpOworICBhbmMuZGlzcGF0Y2hFdmVudChldnQpOwor fSwgZmFsc2UpOworPC9zY3JpcHQ+Cis8YSBpZD0ibGsiIHRhcmdldD0iX3RvcCIKKyAgIGhyZWY9 InBhc3MtYW5kLW5vdGlmeS1kb25lLmh0bWwiPkxpbmsgdG8gaWZyYW1lLjwvYT4KKzxzY3JpcHQ+ Cit3aW5kb3cubG9jYXRpb24gPSAiYWJvdXQ6YmxhbmsiOworPC9zY3JpcHQ+CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci91bmxvYWQtaHlwZXJsaW5rLXRhcmdldGVkLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3VubG9hZC1oeXBlcmxpbmstdGFyZ2V0 ZWQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjAwMTVl ZDEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci91bmxvYWQtaHlw ZXJsaW5rLXRhcmdldGVkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK2ZyYW1lICI8IS0t ZnJhbWVQYXRoIC8vPCEtLWZyYW1lMC0tPi0tPiIgLSBoYXMgMSBvbnVubG9hZCBoYW5kbGVyKHMp CitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci91bmxvYWQtaHlwZXJs aW5rLXRhcmdldGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci91bmxvYWQtaHlwZXJs aW5rLXRhcmdldGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYjJm MGMzYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3VubG9hZC1o eXBlcmxpbmstdGFyZ2V0ZWQuaHRtbApAQCAtMCwwICsxLDggQEAKKzxzY3JpcHQ+CitpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKyAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorPC9z Y3JpcHQ+Cis8aWZyYW1lIHNyYz0icmVzb3VyY2VzL3VubG9hZC1oeXBlcmxpbmstdGFyZ2V0ZWQt c3ViZnJhbWUuaHRtbCI+Cis8L2lmcmFtZT4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjhiM2Q0Yy4uNjU1NmMxYiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAwOS0wOS0yNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExvYWQgYmxvY2tzIGR1cmlu ZyB1bmxvYWQgc2hvdWxkIG5vdCBhZmZlY3QgdGFyZ2V0ZWQgbG9hZHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NzQ3CisKKyAgICAgICAgTW92ZSB0 aGUgY2hlY2sgb2YgdGhlIHVubG9hZCBzdGF0ZSBhZnRlciBjaGVja2luZyBmb3IgdGFyZ2V0ZWQg bGlua3MuCisKKyAgICAgICAgVGVzdDogZmFzdC9sb2FkZXIvdW5sb2FkLWh5cGVybGluay10YXJn ZXRlZC5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWVMb2FkZXI6OmxvYWRVUkwpOgorCiAyMDA5LTA5LTIzICBLZW50IFRhbXVy YSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1dlYkNvcmUv bG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCBmNWZmMDI1Li4xMDlkNjViIDEwMDY0NAotLS0g YS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRnJh bWVMb2FkZXIuY3BwCkBAIC0yMzExLDkgKzIzMTEsNiBAQCB2b2lkIEZyYW1lTG9hZGVyOjpsb2Fk RnJhbWVSZXF1ZXN0KGNvbnN0IEZyYW1lTG9hZFJlcXVlc3QmIHJlcXVlc3QsIGJvb2wgbG9ja0hp cwogdm9pZCBGcmFtZUxvYWRlcjo6bG9hZFVSTChjb25zdCBLVVJMJiBuZXdVUkwsIGNvbnN0IFN0 cmluZyYgcmVmZXJyZXIsIGNvbnN0IFN0cmluZyYgZnJhbWVOYW1lLCBib29sIGxvY2tIaXN0b3J5 LCBGcmFtZUxvYWRUeXBlIG5ld0xvYWRUeXBlLAogICAgIFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50 LCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4gcHJwRm9ybVN0YXRlKQogewotICAgIGlmIChtX3VubG9h ZEV2ZW50QmVpbmdEaXNwYXRjaGVkKQotICAgICAgICByZXR1cm47Ci0KICAgICBSZWZQdHI8Rm9y bVN0YXRlPiBmb3JtU3RhdGUgPSBwcnBGb3JtU3RhdGU7CiAgICAgYm9vbCBpc0Zvcm1TdWJtaXNz aW9uID0gZm9ybVN0YXRlOwogICAgIApAQCAtMjMzNiw2ICsyMzMzLDkgQEAgdm9pZCBGcmFtZUxv YWRlcjo6bG9hZFVSTChjb25zdCBLVVJMJiBuZXdVUkwsIGNvbnN0IFN0cmluZyYgcmVmZXJyZXIs IGNvbnN0IFN0cmkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChtX3VubG9hZEV2 ZW50QmVpbmdEaXNwYXRjaGVkKQorICAgICAgICByZXR1cm47CisKICAgICBOYXZpZ2F0aW9uQWN0 aW9uIGFjdGlvbihuZXdVUkwsIG5ld0xvYWRUeXBlLCBpc0Zvcm1TdWJtaXNzaW9uLCBldmVudCk7 CiAKICAgICBpZiAoIXRhcmdldEZyYW1lICYmICFmcmFtZU5hbWUuaXNFbXB0eSgpKSB7