29742 2009-09-25 10:50:18 -0700 [Chromium] Change window.toString() callback to match JSC 2009-09-28 15:30:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth ager dglazkov eric oldest_to_newest 150066 0 japhet 2009-09-25 10:50:18 -0700 The V8 bindings currently access the global object wrapper instead of the DOMWindow wrapper in the toString() callback. We should be accessing the DOMWindow wrapper, since we currently output [object global] instead of the expected [object DOMWindow]. 150067 1 40124 japhet 2009-09-25 10:51:26 -0700 Created attachment 40124 patch 150148 2 eric 2009-09-25 14:18:55 -0700 You should list what test this affects. Assuming that it affects a test? If it doesn't then we need to add a test. Adam and Dimitri are probably your two best WebKit reviewers here. 150150 3 40124 abarth 2009-09-25 14:25:38 -0700 Comment on attachment 40124 patch This looks great, but please list which LayoutTests this fixes. 150151 4 japhet 2009-09-25 14:27:35 -0700 I initially started looking at it for LayoutTests/fast/events/event-trace.html, and from a run of all layout tests, it appears it will fix 2 and allow us to use default expectations on about a dozen others. There are some others that we're also failing for other reasons that will still fail, but will be closer to expectations. I'll see if I can assemble a full list. I can try and compile a full list if that would be helpful.(In reply to comment #3) > (From update of attachment 40124 [details]) > This looks great, but please list which LayoutTests this fixes. 150158 5 japhet 2009-09-25 14:36:44 -0700 The complete list, to the best of my knowledge, is: LayoutTests/fast/dom/Window/atob-btoa.html LayoutTests/fast/dom/Window/window-lookup-precedence.html LayoutTests/fast/dom/Window/window-postmessage-args.html LayoutTests/fast/dom/Window/window-properties.html LayoutTests/fast/events/event-trace.html LayoutTests/fast/events/event-view-toString.html LayoutTests/fast/js/eval-cross-window.html LayoutTests/fast/js/eval-keyword-vs-function.html LayoutTests/fast/js/toString-and-valueOf-override.html LayoutTests/http/tests/security/cross-frame-access-custom.html LayoutTests/http/tests/security/cross-frame-access-put.html 150166 6 40124 abarth 2009-09-25 14:52:23 -0700 Comment on attachment 40124 patch Awesome! 150171 7 40124 japhet 2009-09-25 15:05:37 -0700 Comment on attachment 40124 patch cq- The Chromium WebKit canary is compile-broken at the moment, and I would like to verify precisely how the downstream expectations need to be changed before this gets integrated, so I want to wait on committing. 150685 8 japhet 2009-09-28 15:30:30 -0700 Committed as r48841. 40124 2009-09-25 10:51:26 -0700 2009-09-25 15:05:37 -0700 patch patch.txt text/plain 1613 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ4NzU5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxOCBAQAorMjAwOS0wOS0yNSAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENoYW5nZSB0aGUgVjggYmluZGluZ3MnIGhhbmRsaW5nIG9mIHdpbmRvdy50b1N0cmluZygpLAor ICAgICAgICBzbyB3ZSByZXR1cm4gW29iamVjdCBET01XaW5kb3ddIChsaWtlIEpTQyksIG5vdCBb b2JqZWN0IGdsb2JhbF0uCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI5NzQyCisKKyAgICAgICAgVGhpcyB3aWxsIGZpeCBhIGNvdXBsZSBvZiBDaHJv bWl1bSBwb3J0IHRlc3QgZmFpbHVyZXMgYW5kIGVuYWJsZSB1cyB0bworICAgICAgICB1c2UgdGhl IGRlZmF1bHQgZXhwZWN0YXRpb25zIGZvciBhIGJ1bmNoIG1vcmUuCisKKyAgICAgICAgKiBiaW5k aW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwOiBVc2UgdGhlIERPTVdpbmRvdyB3 cmFwcGVyIGluc3RlYWQKKyAgICAgICAgb2YgdGhlIGdsb2JhbCBvYmplY3Qgd3JhcHBlciB3aGVu IGl0J3MgYXZhaWxhYmxlIGluIHRoZSBET01XaW5kb3cgdG9TdHJpbmcgY2FsbGJhY2suCisKIDIw MDktMDktMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOERPTVdpbmRvd0N1c3RvbS5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL2JpbmRpbmdz L3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAJKHJldmlzaW9uIDQ4NzU5KQorKysgV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNjgsNyArMzY4LDEwIEBAIENBTExCQUNLX0ZVTkNfREVDTChET01XaW5kb3dCdG9h KQogQ0FMTEJBQ0tfRlVOQ19ERUNMKERPTVdpbmRvd1RvU3RyaW5nKQogewogICAgIElOQ19TVEFU UygiRE9NLkRPTVdpbmRvdy50b1N0cmluZygpIik7Ci0gICAgcmV0dXJuIGFyZ3MuVGhpcygpLT5P YmplY3RQcm90b1RvU3RyaW5nKCk7CisgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBkb21XcmFw cGVyID0gVjhET01XcmFwcGVyOjpsb29rdXBET01XcmFwcGVyKFY4Q2xhc3NJbmRleDo6RE9NV0lO RE9XLCBhcmdzLlRoaXMoKSk7CisgICAgaWYgKGRvbVdyYXBwZXIuSXNFbXB0eSgpKQorICAgICAg ICByZXR1cm4gYXJncy5UaGlzKCktPk9iamVjdFByb3RvVG9TdHJpbmcoKTsKKyAgICByZXR1cm4g ZG9tV3JhcHBlci0+T2JqZWN0UHJvdG9Ub1N0cmluZygpOwogfQogCiBDQUxMQkFDS19GVU5DX0RF Q0woRE9NV2luZG93Tk9QKQo=