29736 2009-09-25 07:47:43 -0700 fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails since r48752 2009-09-30 08:35:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 0 abecsi webkit-unassigned ariya.hidayat commit-queue eric hausmann yongjun.zhang oldest_to_newest 150010 0 abecsi 2009-09-25 07:47:43 -0700 If input text has length==0 the returned QString does not get initialized so a nullstring is returned. 150011 1 40111 abecsi 2009-09-25 07:50:43 -0700 Created attachment 40111 proposed patch Fix decode method to return an empty string and not a null string if the length of the input is 0. 150013 2 40111 vestbo 2009-09-25 07:57:59 -0700 Comment on attachment 40111 proposed patch Hmm, where is the code that gets affected by this? Ie, is there something that checks isNull() no a QString? It should be doing isEmpty or check length I'm guessing... 150018 3 abecsi 2009-09-25 08:30:33 -0700 (In reply to comment #2) > (From update of attachment 40111 [details]) > Hmm, where is the code that gets affected by this? Ie, is there something that > checks isNull() no a QString? It should be doing isEmpty or check length I'm > guessing... http://trac.webkit.org/changeset/48752 Previously m_codec->toUnicode(bytes, length, &m_state) always returned a nonnull QString which was then returned. If length was 0 the string returned was empty but not null. r48752 changed that. It creates a null string and if length is 0 the while loop does not run, so the returned string remains null, and here: http://build.webkit.org/results/Qt%20Linux%20Release/r48752%20%281911%29/results.html you can see the failure in the layout test which is caused by this. Now I see it probably would have been better to ping ariya whith this since he r+-sed this, but anyway. 150489 4 40228 abecsi 2009-09-28 05:37:21 -0700 Created attachment 40228 proposed patch v2 Update Changelog text not to be misleading. 150923 5 40302 abecsi 2009-09-29 08:10:29 -0700 Created attachment 40302 gdb dump of the backtrace on TextCodecQt::decode 150924 6 abecsi 2009-09-29 08:13:11 -0700 (In reply to comment #5) > Created an attachment (id=40302) [details] > gdb dump of the backtrace on TextCodecQt::decode Run on 150925 7 abecsi 2009-09-29 08:14:06 -0700 (In reply to comment #2) > (From update of attachment 40111 [details]) > Hmm, where is the code that gets affected by this? Ie, is there something that > checks isNull() no a QString? It should be doing isEmpty or check length I'm > guessing... Here is the gdb backtrace: #0 WebCore::TextCodecQt::decode (this=0x8286970, bytes=0x0, length=0, flush=false, sawError=@0x823e998) at ../../../WebCore/platform/text/qt/TextCodecQt.cpp:95 #1 0xb6e118e1 in WebCore::TextResourceDecoder::flush (this=0x823e968) at ../../../WebCore/loader/TextResourceDecoder.cpp:847 #2 0xb706d415 in WebCore::XMLHttpRequest::didFinishLoading (this=0x8288728, identifier=2) at ../../../WebCore/xml/XMLHttpRequest.cpp:815 #3 0xb6dc14f4 in WebCore::DocumentThreadableLoader::didFinishLoading (this=0x8289928, identifier=2) at ../../../WebCore/loader/DocumentThreadableLoader.cpp:240 #4 0xb6dc18df in WebCore::DocumentThreadableLoader::loadRequest (this=0x8289928, request=@0xbf8049b8, skipCanLoadCheck=false) at ../../../WebCore/loader/DocumentThreadableLoader.cpp:340 #5 0xb6dc324f in DocumentThreadableLoader (this=0x8289928, document=0x8252308, client=0x8288734, blockingBehavior=WebCore::DocumentThreadableLoader::LoadSynchronously, request=@0xbf8049b8, options=@0xbf804a58) at ../../../WebCore/loader/DocumentThreadableLoader.cpp:74 #6 0xb6dc36fa in WebCore::DocumentThreadableLoader::loadResourceSynchronously (document=0x8252308, request=@0xbf8049b8, client=@0x8288734, options=@0xbf804a58) at ../../../WebCore/loader/DocumentThreadableLoader.cpp:50 #7 0xb6e13706 in WebCore::ThreadableLoader::loadResourceSynchronously (context=0x8252338, request=@0xbf8049b8, client=@0x8288734, options=@0xbf804a58) at ../../../WebCore/loader/ThreadableLoader.cpp:69 #8 0xb706e7d3 in WebCore::XMLHttpRequest::createRequest (this=0x8288728, ec=@0xbf804b8c) at ../../../WebCore/xml/XMLHttpRequest.cpp:493 #9 0xb706ecc8 in WebCore::XMLHttpRequest::send (this=0x8288728, body=@0xbf804b28, ec=@0xbf804b8c) at ../../../WebCore/xml/XMLHttpRequest.cpp:407 #10 0xb706ed08 in WebCore::XMLHttpRequest::send (this=0x8288728, ec=@0xbf804b8c) at ../../../WebCore/xml/XMLHttpRequest.cpp:350 #11 0xb69ef36d in WebCore::JSXMLHttpRequest::send (this=0xb2042e40, exec=0xb20cf0f8, args=@0xbf804c00) at ../../../WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:112 #12 0xb75ff687 in WebCore::jsXMLHttpRequestPrototypeFunctionSend (exec=0xb20cf0f8, thisValue= {u = {asEncodedJSValue = -5603316160, asDouble = -nan(0xffffeb2042e40), asBits = {payload = -1308348864, tag = -2}}}, args=@0xbf804c00) at generated/debug/JSXMLHttpRequest.cpp:385 (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=40302) [details] [details] > > gdb dump of the backtrace on TextCodecQt::decode Run on fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html 150984 8 abecsi 2009-09-29 11:53:35 -0700 Sorry for the multiple posts. 151240 9 40368 abecsi 2009-09-30 07:06:27 -0700 Created attachment 40368 proposed patch v3 151244 10 40368 commit-queue 2009-09-30 07:42:15 -0700 Comment on attachment 40368 proposed patch v3 Rejecting patch 40368 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11355 test cases. http/tests/workers/text-encoding.html -> crashed Exiting early after 1 failures. 8950 tests run. 430.82s total testing time 8949 test cases (99%) succeeded 1 test case (<1%) crashed 5 test cases (<1%) had stderr output 151252 11 40368 eric 2009-09-30 08:23:42 -0700 Comment on attachment 40368 proposed patch v3 The commit queue already rejected this patch because it caused a layout test to crash? Why is this set commit-queue=? again? 151254 12 40368 eric 2009-09-30 08:25:03 -0700 Comment on attachment 40368 proposed patch v3 Actually, given that this does not affect any non-qt code, the crash makes no sense. Maybe the text-encoding test is flakey. cq+ 151260 13 eric 2009-09-30 08:29:37 -0700 I filed bug 29926 about the crash. Sorry for the confusion. 151262 14 abecsi 2009-09-30 08:33:30 -0700 (In reply to comment #13) > I filed bug 29926 about the crash. Sorry for the confusion. Thanks. 151263 15 40368 commit-queue 2009-09-30 08:35:17 -0700 Comment on attachment 40368 proposed patch v3 Clearing flags on attachment: 40368 Committed r48929: <http://trac.webkit.org/changeset/48929> 151264 16 commit-queue 2009-09-30 08:35:22 -0700 All reviewed patches have been landed. Closing bug. 40111 2009-09-25 07:50:43 -0700 2009-09-28 05:37:21 -0700 proposed patch gistfile1 text/plain 1127 abecsi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODc1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMjUgIEFuZHJhcyBCZWNzaSAgPGJlY3NpLmFuZHJhc0Bz dHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gRml4IGRlY29kZSBtZXRob2QgdG8gcmV0dXJuIGFuIGVtcHR5IHN0cmlu ZyBhbmQgbm90IGEgbnVsbCBzdHJpbmcgaWYgdGhlIGxlbmd0aCBvZiB0aGUgaW5wdXQgaXMgMC4K KyAgICAgICAgVGhpcyBmaXhlcyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjk3MzYuCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L3F0L1RleHRDb2RlY1F0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlRleHRDb2RlY1F0OjpkZWNvZGUpOgorCiAyMDA5LTA5LTI1ICBZ b25nanVuIFpoYW5nICA8eW9uZ2p1bi56aGFuZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQXJpeWEgSGlkYXlhdC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9xdC9UZXh0 Q29kZWNRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L3F0L1RleHRD b2RlY1F0LmNwcAkocmV2aXNpb24gNDg3NTMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQv VGV4dENvZGVjUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsNyArMTA0LDcgQEAgU3RyaW5n IFRleHRDb2RlY1F0OjpkZWNvZGUoY29uc3QgY2hhciogYgogI2VuZGlmCiAgICAgY29uc3QgY2hh ciogYnVmID0gYnl0ZXM7CiAgICAgY29uc3QgY2hhciogZW5kID0gYnVmICsgbGVuZ3RoOwotICAg IFN0cmluZyB1bmljb2RlOworICAgIFFTdHJpbmcgdW5pY29kZSgiIik7CiAKICAgICB3aGlsZSAo YnVmIDwgZW5kKSB7CiAgICAgICAgIGludCBzaXplID0gZW5kIC0gYnVmOwo= 40228 2009-09-28 05:37:21 -0700 2009-09-30 07:06:27 -0700 proposed patch v2 xml.patch text/plain 1108 abecsi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDM2ZmI1ZS4uODFiY2I5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOS0yOCAgQW5kcmFzIEJlY3Np ICA8YmVjc2kuYW5kcmFzQHN0dWQudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggVGV4dENvZGVjUXQ6OmRlY29kZSBt ZXRob2QgYWZ0ZXIgcjQ4NzUyIHRvIHJldHVybiBhbiBlbXB0eSBzdHJpbmcgYWdhaW4gaWYgdGhl IGxlbmd0aCBvZiB0aGUgaW5wdXQgaXMgMC4KKyAgICAgICAgVGhpcyBmaXhlcyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk3MzYuCisKKyAgICAgICAgKiBwbGF0Zm9y bS90ZXh0L3F0L1RleHRDb2RlY1F0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRDb2RlY1F0 OjpkZWNvZGUpOgorCiAyMDA5LTA5LTI3ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vdGV4dC9xdC9UZXh0Q29kZWNRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQv cXQvVGV4dENvZGVjUXQuY3BwCmluZGV4IGUzNTE1MjIuLmZlN2U4NjkgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vdGV4dC9xdC9UZXh0Q29kZWNRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0 Zm9ybS90ZXh0L3F0L1RleHRDb2RlY1F0LmNwcApAQCAtMTA0LDcgKzEwNCw3IEBAIFN0cmluZyBU ZXh0Q29kZWNRdDo6ZGVjb2RlKGNvbnN0IGNoYXIqIGJ5dGVzLCBzaXplX3QgbGVuZ3RoLCBib29s IGZsdXNoLCBib29sIC8qCiAjZW5kaWYKICAgICBjb25zdCBjaGFyKiBidWYgPSBieXRlczsKICAg ICBjb25zdCBjaGFyKiBlbmQgPSBidWYgKyBsZW5ndGg7Ci0gICAgU3RyaW5nIHVuaWNvZGU7Cisg ICAgUVN0cmluZyB1bmljb2RlKCIiKTsKIAogICAgIHdoaWxlIChidWYgPCBlbmQpIHsKICAgICAg ICAgaW50IHNpemUgPSBlbmQgLSBidWY7Cg== 40302 2009-09-29 08:10:29 -0700 2009-09-29 08:10:29 -0700 gdb dump of the backtrace on TextCodecQt::decode bt.txt text/plain 3089 abecsi QnJlYWtwb2ludCAxLCBXZWJDb3JlOjpUZXh0Q29kZWNRdDo6ZGVjb2RlICh0aGlzPTB4ODI4Njk3 MCwgYnl0ZXM9MHgwLCBsZW5ndGg9MCwgZmx1c2g9ZmFsc2UsIHNhd0Vycm9yPUAweDgyM2U5OTgp IGF0IC4uLy4uLy4uL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9xdC9UZXh0Q29kZWNRdC5jcHA6OTUK OTUgICAgICBTdHJpbmcgVGV4dENvZGVjUXQ6OmRlY29kZShjb25zdCBjaGFyKiBieXRlcywgc2l6 ZV90IGxlbmd0aCwgYm9vbCBmbHVzaCwgYm9vbCAvKnN0b3BPbkVycm9yKi8sIGJvb2wmIHNhd0Vy cm9yKQooZ2RiKSBidAojMCAgV2ViQ29yZTo6VGV4dENvZGVjUXQ6OmRlY29kZSAodGhpcz0weDgy ODY5NzAsIGJ5dGVzPTB4MCwgbGVuZ3RoPTAsIGZsdXNoPWZhbHNlLCBzYXdFcnJvcj1AMHg4MjNl OTk4KSBhdCAuLi8uLi8uLi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dENvZGVjUXQuY3Bw Ojk1CiMxICAweGI2ZTExOGUxIGluIFdlYkNvcmU6OlRleHRSZXNvdXJjZURlY29kZXI6OmZsdXNo ICh0aGlzPTB4ODIzZTk2OCkgYXQgLi4vLi4vLi4vV2ViQ29yZS9sb2FkZXIvVGV4dFJlc291cmNl RGVjb2Rlci5jcHA6ODQ3CiMyICAweGI3MDZkNDE1IGluIFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0 OjpkaWRGaW5pc2hMb2FkaW5nICh0aGlzPTB4ODI4ODcyOCwgaWRlbnRpZmllcj0yKSBhdCAuLi8u Li8uLi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHA6ODE1CiMzICAweGI2ZGMxNGY0IGlu IFdlYkNvcmU6OkRvY3VtZW50VGhyZWFkYWJsZUxvYWRlcjo6ZGlkRmluaXNoTG9hZGluZyAodGhp cz0weDgyODk5MjgsIGlkZW50aWZpZXI9MikgYXQgLi4vLi4vLi4vV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRUaHJlYWRhYmxlTG9hZGVyLmNwcDoyNDAKIzQgIDB4YjZkYzE4ZGYgaW4gV2ViQ29yZTo6 RG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyOjpsb2FkUmVxdWVzdCAodGhpcz0weDgyODk5MjgsIHJl cXVlc3Q9QDB4YmY4MDQ5YjgsIHNraXBDYW5Mb2FkQ2hlY2s9ZmFsc2UpIGF0IC4uLy4uLy4uL1dl YkNvcmUvbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHA6MzQwCiM1ICAweGI2ZGMz MjRmIGluIERvY3VtZW50VGhyZWFkYWJsZUxvYWRlciAodGhpcz0weDgyODk5MjgsIGRvY3VtZW50 PTB4ODI1MjMwOCwgY2xpZW50PTB4ODI4ODczNCwgYmxvY2tpbmdCZWhhdmlvcj1XZWJDb3JlOjpE b2N1bWVudFRocmVhZGFibGVMb2FkZXI6OkxvYWRTeW5jaHJvbm91c2x5LCByZXF1ZXN0PUAweGJm ODA0OWI4LAogICAgb3B0aW9ucz1AMHhiZjgwNGE1OCkgYXQgLi4vLi4vLi4vV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmNwcDo3NAojNiAgMHhiNmRjMzZmYSBpbiBXZWJD b3JlOjpEb2N1bWVudFRocmVhZGFibGVMb2FkZXI6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkg KGRvY3VtZW50PTB4ODI1MjMwOCwgcmVxdWVzdD1AMHhiZjgwNDliOCwgY2xpZW50PUAweDgyODg3 MzQsIG9wdGlvbnM9QDB4YmY4MDRhNTgpCiAgICBhdCAuLi8uLi8uLi9XZWJDb3JlL2xvYWRlci9E b2N1bWVudFRocmVhZGFibGVMb2FkZXIuY3BwOjUwCiM3ICAweGI2ZTEzNzA2IGluIFdlYkNvcmU6 OlRocmVhZGFibGVMb2FkZXI6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkgKGNvbnRleHQ9MHg4 MjUyMzM4LCByZXF1ZXN0PUAweGJmODA0OWI4LCBjbGllbnQ9QDB4ODI4ODczNCwgb3B0aW9ucz1A MHhiZjgwNGE1OCkgYXQgLi4vLi4vLi4vV2ViQ29yZS9sb2FkZXIvVGhyZWFkYWJsZUxvYWRlci5j cHA6NjkKIzggIDB4YjcwNmU3ZDMgaW4gV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmNyZWF0ZVJl cXVlc3QgKHRoaXM9MHg4Mjg4NzI4LCBlYz1AMHhiZjgwNGI4YykgYXQgLi4vLi4vLi4vV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwOjQ5MwojOSAgMHhiNzA2ZWNjOCBpbiBXZWJDb3JlOjpY TUxIdHRwUmVxdWVzdDo6c2VuZCAodGhpcz0weDgyODg3MjgsIGJvZHk9QDB4YmY4MDRiMjgsIGVj PUAweGJmODA0YjhjKSBhdCAuLi8uLi8uLi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHA6 NDA3CiMxMCAweGI3MDZlZDA4IGluIFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpzZW5kICh0aGlz PTB4ODI4ODcyOCwgZWM9QDB4YmY4MDRiOGMpIGF0IC4uLy4uLy4uL1dlYkNvcmUveG1sL1hNTEh0 dHBSZXF1ZXN0LmNwcDozNTAKIzExIDB4YjY5ZWYzNmQgaW4gV2ViQ29yZTo6SlNYTUxIdHRwUmVx dWVzdDo6c2VuZCAodGhpcz0weGIyMDQyZTQwLCBleGVjPTB4YjIwY2YwZjgsIGFyZ3M9QDB4YmY4 MDRjMDApIGF0IC4uLy4uLy4uL1dlYkNvcmUvYmluZGluZ3MvanMvSlNYTUxIdHRwUmVxdWVzdEN1 c3RvbS5jcHA6MTEyCiMxMiAweGI3NWZmNjg3IGluIFdlYkNvcmU6OmpzWE1MSHR0cFJlcXVlc3RQ cm90b3R5cGVGdW5jdGlvblNlbmQgKGV4ZWM9MHhiMjBjZjBmOCwgdGhpc1ZhbHVlPQogICAgICAg ICAge3UgPSB7YXNFbmNvZGVkSlNWYWx1ZSA9IC01NjAzMzE2MTYwLCBhc0RvdWJsZSA9IC1uYW4o MHhmZmZmZWIyMDQyZTQwKSwgYXNCaXRzID0ge3BheWxvYWQgPSAtMTMwODM0ODg2NCwgdGFnID0g LTJ9fX0sIGFyZ3M9QDB4YmY4MDRjMDApIGF0IGdlbmVyYXRlZC9kZWJ1Zy9KU1hNTEh0dHBSZXF1 ZXN0LmNwcDozODUKIzEzIDB4YjI0Y2YxNmUgaW4gPz8gKCkKIzE0IDB4YjIwNDJmMDAgaW4gPz8g KCkKIzE1IDB4YjIwNDJlNDAgaW4gPz8gKCkKIzE2IDB4ZmZmZmZmZmUgaW4gPz8gKCkKIzE3IDB4 YmY4MDRjMDAgaW4gPz8gKCkKIzE4IDB4YjIwY2YwYjAgaW4gPz8gKCkKIzE5IDB4MDAwMDAwMDEg aW4gPz8gKCkKIzIwIDB4YjI0Y2ZmOTMgaW4gPz8gKCkKIzIxIDB4MDAwMDAwMDEgaW4gPz8gKCkK IzIyIDB4ZmZmZmZmZmUgaW4gPz8gKCkKIzIzIDB4YjI0Y2ZmOTMgaW4gPz8gKCkKIzI0IDB4MDAw MGVmMzcgaW4gPz8gKCkKIzI1IDB4MDAwMDAwMDIgaW4gPz8gKCkKIzI2IDB4YjIwNDJlMDAgaW4g Pz8gKCkKIzI3IDB4ZmZmZmZmZmUgaW4gPz8gKCkKIzI4IDB4MDAwMDAwMDMgaW4gPz8gKCkKQmFj a3RyYWNlIHN0b3BwZWQ6IHByZXZpb3VzIGZyYW1lIGlubmVyIHRvIHRoaXMgZnJhbWUgKGNvcnJ1 cHQgc3RhY2s/KQo= 40368 2009-09-30 07:06:27 -0700 2009-09-30 08:35:17 -0700 proposed patch v3 gistfile1 text/plain 1148 abecsi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGNkZjFhOS4uMTcxOGM2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOS0zMCAgQW5kcmFzIEJlY3Np ICA8YmVjc2kuYW5kcmFzQHN0dWQudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggVGV4dENvZGVjUXQ6OmRlY29kZSBt ZXRob2QgYWZ0ZXIgcjQ4NzUyIHRvIHJldHVybiBhIG5vbi1udWxsIHN0cmluZyBpZiB0aGUgbGVu Z3RoIG9mIHRoZSBpbnB1dCBpcyAwLgorICAgICAgICBUaGlzIGZpeGVzIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTczNi4KKworICAgICAgICAqIHBsYXRmb3JtL3Rl eHQvcXQvVGV4dENvZGVjUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dENvZGVjUXQ6OmRl Y29kZSk6CisKIDIwMDktMDktMjkgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L3F0L1RleHRDb2RlY1F0LmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9xdC9UZXh0Q29kZWNRdC5jcHAKaW5kZXggZTM1MTUyMi4uYjNmNzVjYyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L3F0L1RleHRDb2RlY1F0LmNwcAorKysgYi9XZWJD b3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dENvZGVjUXQuY3BwCkBAIC0xMDQsNyArMTA0LDcgQEAg U3RyaW5nIFRleHRDb2RlY1F0OjpkZWNvZGUoY29uc3QgY2hhciogYnl0ZXMsIHNpemVfdCBsZW5n dGgsIGJvb2wgZmx1c2gsIGJvb2wgLyoKICNlbmRpZgogICAgIGNvbnN0IGNoYXIqIGJ1ZiA9IGJ5 dGVzOwogICAgIGNvbnN0IGNoYXIqIGVuZCA9IGJ1ZiArIGxlbmd0aDsKLSAgICBTdHJpbmcgdW5p Y29kZTsKKyAgICBTdHJpbmcgdW5pY29kZSgiIik7IC8vIGEgbm9uLW51bGwgc3RyaW5nIGlzIGV4 cGVjdGVkCiAKICAgICB3aGlsZSAoYnVmIDwgZW5kKSB7CiAgICAgICAgIGludCBzaXplID0gZW5k IC0gYnVmOwo=