29726 2009-09-24 16:17:43 -0700 Popup menus in Mac Chromium do not register the users selection 2009-09-25 09:23:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 paul webkit-unassigned commit-queue oldest_to_newest 149884 0 paul 2009-09-24 16:17:43 -0700 This is a regression caused by: http://trac.webkit.org/changeset/48642 149887 1 40090 paul 2009-09-24 16:24:52 -0700 Created attachment 40090 Patch to fix Mac Chromium popup menu regression. 149897 2 40090 eric 2009-09-24 16:39:23 -0700 Comment on attachment 40090 Patch to fix Mac Chromium popup menu regression. OK. Code change looks fine, but how do we test this? manual tests are OK. They go in WebCore/manual-tests/ 149899 3 paul 2009-09-24 16:43:41 -0700 There's already a manual popup menu test that I created: WebCore/manual-tests/select-narrow-width.html Note: this is a P0 release blocker for Mac Chromium. 150030 4 40090 commit-queue 2009-09-25 09:23:13 -0700 Comment on attachment 40090 Patch to fix Mac Chromium popup menu regression. Clearing flags on attachment: 40090 Committed r48757: <http://trac.webkit.org/changeset/48757> 150031 5 commit-queue 2009-09-25 09:23:16 -0700 All reviewed patches have been landed. Closing bug. 40090 2009-09-24 16:24:52 -0700 2009-09-25 09:23:13 -0700 Patch to fix Mac Chromium popup menu regression. mac_p text/plain 1573 paul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODczOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMjQgIFBhdWwgR29kYXZhcmkgIDxwYXVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggYSByZWdyZXNzaW9uIGluIE1hYyBDaHJvbWl1bSBwb3B1cCBtZW51cywgd2hlcmUgdGhlIHVz ZXIncworICAgICAgICBzZWxlY3Rpb24gd2FzIGlnbm9yZWQgYW5kIHRoZSBwb3B1cCBiZWNhbWUg dW5yZXNwb25zaXZlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mjk3MjYKKworICAgICAgICBUaGUgZml4IGlzIHRvIG5vdGlmeSB0aGUgcG9wdXAncyBj bGllbnQgdGhhdCB0aGUgcG9wdXAgd2FzIGhpZGRlbiwKKyAgICAgICAgZXZlbiBpZiB0aGUgcG9w dXAgaGFzIG5vIHBhcmVudC4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVu dUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6aGlkZVBvcHVw KToKKwogMjAwOS0wOS0yNCAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNDg3Mzgp CisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTA1NywxMiArMTA1NywxMSBAQCB2b2lkIFBvcHVwTGlzdEJveDo6YWRq dXN0U2VsZWN0ZWRJbmRleChpCiAKIHZvaWQgUG9wdXBMaXN0Qm94OjpoaWRlUG9wdXAoKQogewot ICAgIGlmICghcGFyZW50KCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIFBvcHVwQ29udGFpbmVy KiBjb250YWluZXIgPSBzdGF0aWNfY2FzdDxQb3B1cENvbnRhaW5lcio+KHBhcmVudCgpKTsKLSAg ICBpZiAoY29udGFpbmVyLT5jbGllbnQoKSkKLSAgICAgICAgY29udGFpbmVyLT5jbGllbnQoKS0+ cG9wdXBDbG9zZWQoY29udGFpbmVyKTsKKyAgICBpZiAocGFyZW50KCkpIHsKKyAgICAgICAgUG9w dXBDb250YWluZXIqIGNvbnRhaW5lciA9IHN0YXRpY19jYXN0PFBvcHVwQ29udGFpbmVyKj4ocGFy ZW50KCkpOworICAgICAgICBpZiAoY29udGFpbmVyLT5jbGllbnQoKSkKKyAgICAgICAgICAgIGNv bnRhaW5lci0+Y2xpZW50KCktPnBvcHVwQ2xvc2VkKGNvbnRhaW5lcik7CisgICAgfQogCiAgICAg bV9wb3B1cENsaWVudC0+cG9wdXBEaWRIaWRlKCk7CiB9Cg==