29725 2009-09-24 15:28:20 -0700 Add ARM version detection rules for Symbian 2009-09-24 15:44:49 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Other RESOLVED DUPLICATE 29715 Qt P2 Normal --- 0 laszlo.gombos webkit-unassigned laszlo.gombos loki oldest_to_newest 149872 0 laszlo.gombos 2009-09-24 15:28:20 -0700 Platform.h has a set of rules to detect ARM HW version. The detection rules seems to be specific (to GCC) and does not work for Symbian. A patch will follow to add the appropriate Symbian defines to detect ARM HW version using the Symbian toolchain. Without this change the Symbian build would fail since the compiler would hit #error "Not supported ARM architecture", which was recently added (see http://trac.webkit.org/changeset/48525) 149874 1 40086 laszlo.gombos 2009-09-24 15:36:46 -0700 Created attachment 40086 proposed patch 149876 2 40086 laszlo.gombos 2009-09-24 15:40:08 -0700 Comment on attachment 40086 proposed patch cancel the review as this is a dup of bug 29715; will upload this patch there for review. 149880 3 laszlo.gombos 2009-09-24 15:44:49 -0700 *** This bug has been marked as a duplicate of bug 29715 *** 40086 2009-09-24 15:36:46 -0700 2009-09-24 15:40:08 -0700 proposed patch patch_29725.txt text/plain 1598 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ4NzM3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDktMjQgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBBUk0gdmVyc2lvbiBkZXRlY3Rpb24gcnVs ZXMgZm9yIFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI5NzI1CisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAwOS0wOS0yNCAg WW9uZyBMaSAgPHlvbmcubGlAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gQmFydGguCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNDg3MzMpCisr KyBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMjM3LDE5 ICsyMzcsMTkgQEAKICNkZWZpbmUgV1RGX1BMQVRGT1JNX01JRERMRV9FTkRJQU4gMQogI2VuZGlm CiAjZGVmaW5lIEFSTV9BUkNIX1ZFUlNJT04gMwotI2lmIGRlZmluZWQoX19BUk1fQVJDSF80X18p IHx8IGRlZmluZWQoX19BUk1fQVJDSF80VF9fKQorI2lmIGRlZmluZWQoX19BUk1fQVJDSF80X18p IHx8IGRlZmluZWQoX19BUk1fQVJDSF80VF9fKSB8fCBkZWZpbmVkKF9fTUFSTV9BUk1WNF9fKQog I3VuZGVmIEFSTV9BUkNIX1ZFUlNJT04KICNkZWZpbmUgQVJNX0FSQ0hfVkVSU0lPTiA0CiAjZW5k aWYKICNpZiBkZWZpbmVkKF9fQVJNX0FSQ0hfNV9fKSB8fCBkZWZpbmVkKF9fQVJNX0FSQ0hfNVRf XykgXAogICAgICAgICB8fCBkZWZpbmVkKF9fQVJNX0FSQ0hfNUVfXykgfHwgZGVmaW5lZChfX0FS TV9BUkNIXzVURV9fKSBcCi0gICAgICAgIHx8IGRlZmluZWQoX19BUk1fQVJDSF81VEVKX18pCisg ICAgICAgIHx8IGRlZmluZWQoX19BUk1fQVJDSF81VEVKX18pIHx8IGRlZmluZWQoX19NQVJNX0FS TVY1X18pCiAjdW5kZWYgQVJNX0FSQ0hfVkVSU0lPTgogI2RlZmluZSBBUk1fQVJDSF9WRVJTSU9O IDUKICNlbmRpZgogI2lmIGRlZmluZWQoX19BUk1fQVJDSF82X18pIHx8IGRlZmluZWQoX19BUk1f QVJDSF82Sl9fKSBcCiAgICAgIHx8IGRlZmluZWQoX19BUk1fQVJDSF82S19fKSB8fCBkZWZpbmVk KF9fQVJNX0FSQ0hfNlpfXykgXAotICAgICB8fCBkZWZpbmVkKF9fQVJNX0FSQ0hfNlpLX18pCisg ICAgIHx8IGRlZmluZWQoX19BUk1fQVJDSF82WktfXykgfHwgZGVmaW5lZChfX0FSTVY2X18pCiAj dW5kZWYgQVJNX0FSQ0hfVkVSU0lPTgogI2RlZmluZSBBUk1fQVJDSF9WRVJTSU9OIDYKICNlbmRp Zgo=