29721 2009-09-24 12:09:09 -0700 add a gyp variable to allow compiling webcore without debug symbols 2009-09-25 16:20:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 tony agl agl mark yaar oldest_to_newest 149796 0 tony 2009-09-24 12:09:09 -0700 Compiling a debug chromium with a webcore that doesn't have debug symbols cuts the output binary from ~750mb to ~350mb. This speeds up the compile and reduces the gdb startup time considerably. It would be nice to have a gyp variable for this. 149798 1 40078 tony 2009-09-24 12:29:17 -0700 Created attachment 40078 v1 149827 2 tony 2009-09-24 14:02:20 -0700 Mark: Can you take a look at this change? 149828 3 40078 mark 2009-09-24 14:04:20 -0700 Comment on attachment 40078 v1 This change looks good to me, but you should be aware that it won't be effective on the Mac, because we don't turn on debugging symbols by setting cflags. 149830 4 mark 2009-09-24 14:05:36 -0700 I'm somewhat surprised that Bugzilla allowed me to formally r+ this, since I'm not a WebKit reviewer. I'm not sure what WebKit reviewer would be appropriate here though. I just mention this so that you can cover your bases. 149834 5 40078 levin 2009-09-24 14:06:50 -0700 Comment on attachment 40078 v1 Changing back to r? so I can r+ it. 149836 6 40078 levin 2009-09-24 14:08:29 -0700 Comment on attachment 40078 v1 r=me (since Mark said it looked good.) I'll leave the cq?. Tony since you are a committer you can change it to cq+ if you want to try to use the auto-commit thing. 149841 7 40078 tony 2009-09-24 14:12:05 -0700 Comment on attachment 40078 v1 Let's try the auto committer. 149844 8 40078 commit-queue 2009-09-24 14:19:17 -0700 Comment on attachment 40078 v1 Rejecting patch 40078 from commit-queue. tony@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 149851 9 40078 eric 2009-09-24 14:38:19 -0700 Comment on attachment 40078 v1 Looks like tony hasn't added himself to the committers.py file yet. 149859 10 40078 eric 2009-09-24 15:05:31 -0700 Comment on attachment 40078 v1 Was this diff edited by hand? It failed to apply correctly... See attachment on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log. 149871 11 tony 2009-09-24 15:19:06 -0700 (In reply to comment #10) > (From update of attachment 40078 [details]) > Was this diff edited by hand? It failed to apply correctly... See attachment > on https://bugs.webkit.org/show_bug.cgi?id=29622 for the log. I made the diff using "git diff --no-prefix --relative". I guess I should just use git-bugzilla-tool. 150190 12 agl 2009-09-25 16:08:41 -0700 Will land manually. 150192 13 agl 2009-09-25 16:19:33 -0700 Landed. 150194 14 agl 2009-09-25 16:20:15 -0700 Changed by: agl@chromium.org Changed at: Fri 25 Sep 2009 16:19:03 Branch: trunk Revision: 48777 Changed files: WebCore/ChangeLog WebCore/WebCore.gyp/WebCore.gyp Comments: 2009-09-24 Tony Chang <tony@chromium.org> Reviewed by David Levin. Add a gyp variable to allow building a debug webcore without debug symbols. This allows for faster compile, link, and gdb times. https://bugs.webkit.org/show_bug.cgi?id=29721 No new tests, build config change. * WebCore.gyp/WebCore.gyp: Properties: 40078 2009-09-24 12:29:17 -0700 2009-09-24 15:05:31 -0700 v1 no_symbols.diff text/plain 1527 tony ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IGNmYjI5YTIuLmMwZTZlYzMgMTAw NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSw0ICsxLDE2IEBACisyMDA5LTA5 LTI0ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgZ3lwIHZhcmlhYmxlIHRvIGFsbG93 IGJ1aWxkaW5nIGEgZGVidWcgd2ViY29yZSB3aXRob3V0IGRlYnVnCisgICAgICAgIHN5bWJvbHMu ICBUaGlzIGFsbG93cyBmb3IgZmFzdGVyIGNvbXBpbGUsIGxpbmssIGFuZCBnZGIgdGltZXMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTcyMQorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgY29uZmlnIGNoYW5nZS4KKworICAgICAgICAqIFdl YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwOgorCiAyMDA5LTA5LTI0ICBCcmFkeSBFaWRzb24gIDxiZWlk c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgogCmRpZmYg LS1naXQgV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5k ZXggZjMyYzU5ZC4uZWJlNDY4ZSAxMDA2NDQKLS0tIFdlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisr KyBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMzgsOCArMzgsMTIgQEAKICAgJ3ZhcmlhYmxl cyc6IHsKICAgICAjIEZJWEVNRTogU2Vuc2Ugd2hldGhlciB1cHN0cmVhbSBvciBkb3duc3RyZWFt IGJ1aWxkLCBhbmQKICAgICAjIHBvaW50IHRvIHRoZSByaWdodCBzcmMgZGlyCiAgICAgJ2Nocm9t aXVtX3NyY19kaXInOiAnLi4vLi4vLi4vLi4nLAorCisgICAgIyBJZiBzZXQgdG8gMSwgZG9lc24n dCBjb21waWxlIGRlYnVnIHN5bWJvbHMgaW50byB3ZWJjb3JlIHJlZHVjaW5nIHRoZQorICAgICMg c2l6ZSBvZiB0aGUgYmluYXJ5IGFuZCBpbmNyZWFzaW5nIHRoZSBzcGVlZCBvZiBnZGIuICBnY2Mg b25seS4KKyAgICAncmVtb3ZlX3dlYmNvcmVfZGVidWdfc3ltYm9scyUnOiAwLAogICAKICAgICAn d2ViY29yZV9pbmNsdWRlX2RpcnMnOiBbCiAgICAgICAnLi4vJywKICAgICAgICcuLi9hY2Nlc3Np YmlsaXR5JywKQEAgLTc4OCw4ICs3OTIsMTUgQEAKICAgICAgICAgICAgIFsnZXhjbHVkZScsICdX aW5cXC5jcHAkJ10sCiAgICAgICAgICAgICBbJ2V4Y2x1ZGUnLCAnLyhXaW5kb3dzfFVuaXNjcmli ZSlbXi9dKlxcLmNwcCQnXQogICAgICAgICAgIF0sCiAgICAgICAgIH1dLAorICAgICAgICBbJ09T IT0id2luIiBhbmQgcmVtb3ZlX3dlYmNvcmVfZGVidWdfc3ltYm9scz09MScsIHsKKyAgICAgICAg ICAnY29uZmlndXJhdGlvbnMnOiB7CisgICAgICAgICAgICAnRGVidWcnOiB7CisgICAgICAgICAg ICAgICdjZmxhZ3MhJzogWyctZyddLAorICAgICAgICAgICAgfQorICAgICAgICAgIH0sCisgICAg ICAgIH1dLAogICAgICAgXSwKICAgICB9LAogICBdLCAjIHRhcmdldHMKIH0K