29718 2009-09-24 10:31:35 -0700 mark-bug-fixed: add -u|--update-only switch 2009-09-25 15:03:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned aroben eric oldest_to_newest 149774 0 40072 ddkilzer 2009-09-24 10:31:35 -0700 Created attachment 40072 Patch v1 Reviewed by NOBODY (OOPS!). * Scripts/mark-bug-fixed: (MarkBugFixed.__init__): Added -u|--update-only switch to list of parse options. (MarkBugFixed.main): When -u|--update-only is specified, add a comment to the bug without marking it Resolved/Fixed. --- 2 files changed, 19 insertions(+), 2 deletions(-) 149780 1 eric 2009-09-24 11:05:06 -0700 I think this is kinda a strange command-line API (calling mark-as-fixed but not having it mark anything as fixed), but I like the functionality. An Apple person would have to comment as to if this makes sense for y'alls workflow. 150115 2 ddkilzer 2009-09-25 12:52:57 -0700 (In reply to comment #1) > I think this is kinda a strange command-line API (calling mark-as-fixed but not > having it mark anything as fixed), but I like the functionality. An Apple > person would have to comment as to if this makes sense for y'alls workflow. This is useful if you have more than one patch that is required to fix a bug, but don't want to close the bug after the first commit. Some folks like to commit fixes to individual directories separately (one for WebCore, one for LayoutTests), which makes this flag useful as well. 150117 3 ddkilzer 2009-09-25 13:02:08 -0700 (In reply to comment #2) > This is useful if you have more than one patch that is required to fix a bug, > but don't want to close the bug after the first commit. I don't see why creating a second script would be helpful in this case. (The most common workflow is to mark the bug as fixed, but you use the same script to update it as well.) Do you have another suggestion for the script's name? I did not want to use "update-bug" since there are too many update-* scripts already. :) > Some folks like to commit fixes to individual directories separately (one for > WebCore, one for LayoutTests), which makes this flag useful as well. BTW, I don't condone this workflow. 150133 4 40072 eric 2009-09-25 13:42:13 -0700 Comment on attachment 40072 Patch v1 OK. You might want to make clear in the -u help that it will add the fixed revision to the bug as well, not just the comment you pass in -m. I think that was my initial confusion is that I thought you had effectively created a "add-comment" command, but now I see that this is still really a "mark-bug-with-revision" behavior even if it doesn't always close the bug. 150169 5 ddkilzer 2009-09-25 15:03:31 -0700 Committed r48772: <http://trac.webkit.org/changeset/48772> 40072 2009-09-24 10:31:35 -0700 2009-09-25 13:42:12 -0700 Patch v1 20090924103134.patch text/plain 2260 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3NWZlYzgwLi5hMDJlZTRiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDktMDkt MjQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAorICAgICAgICBtYXJrLWJ1 Zy1maXhlZDogYWRkIC11fC0tdXBkYXRlLW9ubHkgc3dpdGNoCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL21hcmstYnVnLWZpeGVkOgor ICAgICAgICAoTWFya0J1Z0ZpeGVkLl9faW5pdF9fKTogQWRkZWQgLXV8LS11cGRhdGUtb25seSBz d2l0Y2ggdG8gbGlzdAorICAgICAgICBvZiBwYXJzZSBvcHRpb25zLgorICAgICAgICAoTWFya0J1 Z0ZpeGVkLm1haW4pOiBXaGVuIC11fC0tdXBkYXRlLW9ubHkgaXMgc3BlY2lmaWVkLCBhZGQgYQor ICAgICAgICBjb21tZW50IHRvIHRoZSBidWcgd2l0aG91dCBtYXJraW5nIGl0IFJlc29sdmVkL0Zp eGVkLgorCisyMDA5LTA5LTI0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisK ICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMjk3MTI+IG1hcmstYnVnLWZpeGVkOiBhZGQg LW18LS1jb21tZW50IHN3aXRjaAogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21hcmstYnVnLWZpeGVkIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9tYXJrLWJ1Zy1maXhlZAppbmRleCBkM2MzZDkyLi5hOWVlOTQ0IDEwMDc1NQot LS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21hcmstYnVnLWZpeGVkCisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvbWFyay1idWctZml4ZWQKQEAgLTQ0LDYgKzQ0LDcgQEAgY2xhc3MgTWFya0J1Z0Zp eGVkVG9vbDoKICAgICAgICAgc2VsZi5vcHRpb25fcGFyc2VyID0gT3B0aW9uUGFyc2VyKHVzYWdl PSJ1c2FnZTogJXByb2cgW29wdGlvbnNdIFtyTk5OTk5dIikKICAgICAgICAgc2VsZi5vcHRpb25f cGFyc2VyLmFkZF9vcHRpb24oIi1iIiwgIi0tYnVnLWlkIiwgYWN0aW9uPSJzdG9yZSIsIHR5cGU9 InN0cmluZyIsIGRlc3Q9ImJ1Z19pZCIsIGhlbHA9IlNwZWNpZnkgYnVnIGlkIGlmIG5vIFVSTCBp cyBwcm92aWRlZCBpbiB0aGUgY29tbWl0IGxvZy4iKQogICAgICAgICBzZWxmLm9wdGlvbl9wYXJz ZXIuYWRkX29wdGlvbigiLW0iLCAiLS1jb21tZW50IiwgYWN0aW9uPSJzdG9yZSIsIHR5cGU9InN0 cmluZyIsIGRlc3Q9ImNvbW1lbnQiLCBoZWxwPSJUZXh0IHRvIGluY2x1ZGUgaW4gYnVnIGNvbW1l bnQuIikKKyAgICAgICAgc2VsZi5vcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oIi11IiwgIi0tdXBk YXRlLW9ubHkiLCBhY3Rpb249InN0b3JlX3RydWUiLCBkZWZhdWx0PUZhbHNlLCBkZXN0PSJ1cGRh dGVfb25seSIsIGhlbHA9IkFkZCBjb21tZW50IHRvIHRoZSBidWcsIGJ1dCBkbyBub3QgY2xvc2Ug aXQuIikKIAogICAgIGRlZiBzY20oc2VsZik6CiAgICAgICAgICMgTGF6aWx5IGluaXRpYWxpemUg U0NNIHRvIG5vdCBlcnJvci1vdXQgYmVmb3JlIGNvbW1hbmQgbGluZSBwYXJzaW5nIChvciB3aGVu IHJ1bm5pbmcgbm9uLXNjbSBjb21tYW5kcykuCkBAIC0xMDcsOCArMTA4LDEyIEBAIGNsYXNzIE1h cmtCdWdGaXhlZFRvb2w6CiAgICAgICAgIGlmIG9wdGlvbnMuY29tbWVudDoKICAgICAgICAgICAg IGJ1Z19jb21tZW50ID0gIiVzXG5cbiVzIiAlIChvcHRpb25zLmNvbW1lbnQsIGJ1Z19jb21tZW50 KQogCi0gICAgICAgIGxvZygiVXBkYXRpbmcgQnVnICVzLiIgJSBidWdfaWQpCi0gICAgICAgIHNl bGYuYnVncy5jbG9zZV9idWdfYXNfZml4ZWQoYnVnX2lkLCBidWdfY29tbWVudCkKKyAgICAgICAg aWYgb3B0aW9ucy51cGRhdGVfb25seToKKyAgICAgICAgICAgIGxvZygiQWRkaW5nIGNvbW1lbnQg dG8gQnVnICVzLiIgJSBidWdfaWQpCisgICAgICAgICAgICBzZWxmLmJ1Z3MucG9zdF9jb21tZW50 X3RvX2J1ZyhidWdfaWQsIGJ1Z19jb21tZW50KQorICAgICAgICBlbHNlOgorICAgICAgICAgICAg bG9nKCJBZGRpbmcgY29tbWVudCB0byBCdWcgJXMgYW5kIG1hcmtpbmcgYXMgUmVzb2x2ZWQvRml4 ZWQuIiAlIGJ1Z19pZCkKKyAgICAgICAgICAgIHNlbGYuYnVncy5jbG9zZV9idWdfYXNfZml4ZWQo YnVnX2lkLCBidWdfY29tbWVudCkKIAogCiBkZWYgbWFpbigpOg==