29716 2009-09-24 09:10:47 -0700 [GTK] re-enable some media tests 2009-09-24 22:30:58 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 pnormand webkit-unassigned xan.lopez oldest_to_newest 149765 0 pnormand 2009-09-24 09:10:47 -0700 It looks harmless to me to re-enable some of the media tests. The one related to canPlayType() needs a little adjustment in the gstreamers backend though. Attaching patch. 149766 1 40069 pnormand 2009-09-24 09:19:49 -0700 Created attachment 40069 proposed patch 149768 2 40071 pnormand 2009-09-24 09:24:53 -0700 Created attachment 40071 proposed patch (without white spaces in ChangeLog) 149771 3 40071 gustavo 2009-09-24 10:08:52 -0700 Comment on attachment 40071 proposed patch (without white spaces in ChangeLog) OK, a couple nits: > + [GTK] re-enable some media tests > + https://bugs.webkit.org/show_bug.cgi?id=29716 > + > + make canPlayType() return "probably" if mime-type is known > + and codecs string is not empty. If codecs is empty return > + "maybe". > + * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: > + (WebCore::MediaPlayerPrivate::duration): > + This is refering to duration, but you only touch supportsType. Maybe it was incorrectly generated by prepare-ChangeLogs, but may be worth fixing. Also, I think you want a blank line between the message and the list of files. I'll ask that you upload a new patch just because I am lazy and want to use the commit bot =). 149773 4 40071 gustavo 2009-09-24 10:29:47 -0700 Comment on attachment 40071 proposed patch (without white spaces in ChangeLog) I will actually fix the nits myself, and land. 149937 5 xan.lopez 2009-09-24 22:30:58 -0700 This was landed in r48724, closing. 40069 2009-09-24 09:19:49 -0700 2009-09-24 09:24:53 -0700 proposed patch 0001-re-enable-some-media-tests.patch text/plain 3312 pnormand RnJvbSAxNzhiMTFiOWRkMzVkMTRmMTU3NDNmMDg0MGUwZjhmY2NmOGI2MGFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI0IFNlcCAyMDA5IDE4OjE3OjM2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cmUtZW5hYmxlIHNvbWUgbWVkaWEgdGVzdHMKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQgICAgICAgICAgICAgICAgICAgfCAgICA4IC0tLS0tLS0tCiBX ZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMg KysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwICAgfCAgICAzICsrLQogNCBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkOTA3NGZlLi5kY2JjZTI2IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTIgQEAKKzIwMDktMDktMjQgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IHJlLWVuYWJsZSBzb21lIG1lZGlhIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yOTcxNgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBw ZWQ6CisKIDIwMDktMDktMjQgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkocm9sbG91dCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQK aW5kZXggOTE2MWU2Yi4uYWIyZGQwYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTM4 MTIsMTcgKzM4MTIsOSBAQCBodHRwL3Rlc3RzL3dlYmFyY2hpdmUvdGVzdC1wcmVsb2FkLXJlc291 cmNlcy5odG1sCiAKICMgVGVzdHMgaW4gbWVkaWEvIGRpcmVjdG9yeQogIyAgIFRlc3RzIGZhaWxp bmcKLW1lZGlhL3ZpZGVvLWFwcGVuZC1zb3VyY2UuaHRtbAotbWVkaWEvdmlkZW8tYXV0b3BsYXku aHRtbAotbWVkaWEvdmlkZW8tYnVmZmVyZWQuaHRtbAotbWVkaWEvdmlkZW8tY2FuLXBsYXktdHlw ZS5odG1sCi1tZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLmh0bWwKIG1lZGlh L3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWwKIG1lZGlhL3ZpZGVvLWNvbnRyb2xzLXpv b21lZC5odG1sCi1tZWRpYS92aWRlby1kb2N1bWVudC10eXBlcy5odG1sCi1tZWRpYS92aWRlby1w bGF5ZWQtcmVzZXQuaHRtbAogbWVkaWEvdmlkZW8tc2l6ZS1pbnRyaW5zaWMtc2NhbGUuaHRtbAot bWVkaWEvdmlkZW8tc291cmNlLWVycm9yLmh0bWwKICMgICBUZXN0cyB0aW1pbmcgb3V0CiBtZWRp YS9hdWRpby1kYXRhLXVybC5odG1sCiBtZWRpYS9jb250cm9scy1kcmFnLXRpbWViYXIuaHRtbApk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5 MTBkY2VjLi44MTg4ZDNlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTA5LTI0ICBQaGlsaXBwZSBOb3Jt YW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR1RLXSByZS1lbmFibGUgc29tZSBtZWRpYSB0ZXN0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk3MTYKKworCW1h a2UgY2FuUGxheVR5cGUoKSByZXR1cm4gInByb2JhYmx5IiBpZiBtaW1lLXR5cGUgaXMga25vd24K KyAgICAgICAgYW5kIGNvZGVjcyBzdHJpbmcgaXMgbm90IGVtcHR5LiBJZiBjb2RlY3MgaXMgZW1w dHkgcmV0dXJuCisJIm1heWJlIgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlOjpkdXJhdGlvbik6CisKIDIwMDktMDktMjQgIFZpdGFseSBSZXBlc2hrbyAgPHZp dGFseXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtv di4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDM3MzcwNTMuLjAwZDgyNDIgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtNzUwLDggKzc1MCw5IEBAIE1lZGlhUGxheWVyOjpT dXBwb3J0c1R5cGUgTWVkaWFQbGF5ZXJQcml2YXRlOjpzdXBwb3J0c1R5cGUoY29uc3QgU3RyaW5n JiB0eXBlLCBjCiAgICAgaWYgKHR5cGUuaXNOdWxsKCkgfHwgdHlwZS5pc0VtcHR5KCkpCiAgICAg ICAgIHJldHVybiBNZWRpYVBsYXllcjo6SXNOb3RTdXBwb3J0ZWQ7CiAKKyAgICAvLyBzcGVjIHNh eXMgd2Ugc2hvdWxkIG5vdCByZXR1cm4gInByb2JhYmx5IiBpZiB0aGUgY29kZWNzIHN0cmluZyBp cyBlbXB0eQogICAgIGlmIChtaW1lVHlwZUNhY2hlKCkuY29udGFpbnModHlwZSkpCi0gICAgICAg IHJldHVybiAhY29kZWNzLmlzRW1wdHkoKSA/IE1lZGlhUGxheWVyOjpNYXlCZVN1cHBvcnRlZCA6 IE1lZGlhUGxheWVyOjpJc1N1cHBvcnRlZDsKKyAgICAgICAgcmV0dXJuIGNvZGVjcy5pc0VtcHR5 KCkgPyBNZWRpYVBsYXllcjo6TWF5QmVTdXBwb3J0ZWQgOiBNZWRpYVBsYXllcjo6SXNTdXBwb3J0 ZWQ7CiAgICAgcmV0dXJuIE1lZGlhUGxheWVyOjpJc05vdFN1cHBvcnRlZDsKIH0KIAotLSAKMS42 LjAuNAoK 40071 2009-09-24 09:24:53 -0700 2009-09-24 10:29:46 -0700 proposed patch (without white spaces in ChangeLog) 0001--GTK-re-enable-some-media-tests.patch text/plain 3333 pnormand RnJvbSBjZTA4NzM0NzRlZGU3Yjg4M2VmYmFlYzU3NjVjODBmMGQwMDMyOGIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI0IFNlcCAyMDA5IDE4OjE3OjM2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g W0dUS10gcmUtZW5hYmxlIHNvbWUgbWVkaWEgdGVzdHMKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgICAgICAgICAgICAgICAgICAgfCAgICA4IC0tLS0t LS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTMgKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwICAgfCAgICAzICsrLQogNCBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25z KCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkOTA3NGZlLi5kY2JjZTI2IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMDktMDktMjQgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtHVEtdIHJlLWVuYWJsZSBzb21lIG1lZGlhIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTcxNgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1NraXBwZWQ6CisKIDIwMDktMDktMjQgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkocm9sbG91dCkKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Nr aXBwZWQKaW5kZXggOTE2MWU2Yi4uYWIyZGQwYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQK QEAgLTM4MTIsMTcgKzM4MTIsOSBAQCBodHRwL3Rlc3RzL3dlYmFyY2hpdmUvdGVzdC1wcmVsb2Fk LXJlc291cmNlcy5odG1sCiAKICMgVGVzdHMgaW4gbWVkaWEvIGRpcmVjdG9yeQogIyAgIFRlc3Rz IGZhaWxpbmcKLW1lZGlhL3ZpZGVvLWFwcGVuZC1zb3VyY2UuaHRtbAotbWVkaWEvdmlkZW8tYXV0 b3BsYXkuaHRtbAotbWVkaWEvdmlkZW8tYnVmZmVyZWQuaHRtbAotbWVkaWEvdmlkZW8tY2FuLXBs YXktdHlwZS5odG1sCi1tZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLmh0bWwK IG1lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWwKIG1lZGlhL3ZpZGVvLWNvbnRy b2xzLXpvb21lZC5odG1sCi1tZWRpYS92aWRlby1kb2N1bWVudC10eXBlcy5odG1sCi1tZWRpYS92 aWRlby1wbGF5ZWQtcmVzZXQuaHRtbAogbWVkaWEvdmlkZW8tc2l6ZS1pbnRyaW5zaWMtc2NhbGUu aHRtbAotbWVkaWEvdmlkZW8tc291cmNlLWVycm9yLmh0bWwKICMgICBUZXN0cyB0aW1pbmcgb3V0 CiBtZWRpYS9hdWRpby1kYXRhLXVybC5odG1sCiBtZWRpYS9jb250cm9scy1kcmFnLXRpbWViYXIu aHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCA5MTBkY2VjLi5jNmU1YzEyIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTA5LTI0ICBQaGlsaXBw ZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSByZS1lbmFibGUgc29tZSBtZWRpYSB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk3MTYK KworICAgICAgICBtYWtlIGNhblBsYXlUeXBlKCkgcmV0dXJuICJwcm9iYWJseSIgaWYgbWltZS10 eXBlIGlzIGtub3duCisgICAgICAgIGFuZCBjb2RlY3Mgc3RyaW5nIGlzIG5vdCBlbXB0eS4gSWYg Y29kZWNzIGlzIGVtcHR5IHJldHVybgorICAgICAgICAibWF5YmUiLgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpkdXJhdGlvbik6CisKIDIwMDktMDktMjQg IFZpdGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDM3 MzcwNTMuLjAwZDgyNDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtNzUwLDggKzc1 MCw5IEBAIE1lZGlhUGxheWVyOjpTdXBwb3J0c1R5cGUgTWVkaWFQbGF5ZXJQcml2YXRlOjpzdXBw b3J0c1R5cGUoY29uc3QgU3RyaW5nJiB0eXBlLCBjCiAgICAgaWYgKHR5cGUuaXNOdWxsKCkgfHwg dHlwZS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBNZWRpYVBsYXllcjo6SXNOb3RTdXBwb3J0 ZWQ7CiAKKyAgICAvLyBzcGVjIHNheXMgd2Ugc2hvdWxkIG5vdCByZXR1cm4gInByb2JhYmx5IiBp ZiB0aGUgY29kZWNzIHN0cmluZyBpcyBlbXB0eQogICAgIGlmIChtaW1lVHlwZUNhY2hlKCkuY29u dGFpbnModHlwZSkpCi0gICAgICAgIHJldHVybiAhY29kZWNzLmlzRW1wdHkoKSA/IE1lZGlhUGxh eWVyOjpNYXlCZVN1cHBvcnRlZCA6IE1lZGlhUGxheWVyOjpJc1N1cHBvcnRlZDsKKyAgICAgICAg cmV0dXJuIGNvZGVjcy5pc0VtcHR5KCkgPyBNZWRpYVBsYXllcjo6TWF5QmVTdXBwb3J0ZWQgOiBN ZWRpYVBsYXllcjo6SXNTdXBwb3J0ZWQ7CiAgICAgcmV0dXJuIE1lZGlhUGxheWVyOjpJc05vdFN1 cHBvcnRlZDsKIH0KIAotLSAKMS42LjAuNAoK