297124 2025-08-08 11:15:38 -0700 [Bindings] Optimize union IDL attribute setters by avoiding conversion to variant 2025-10-05 18:59:13 -0700 1 1 1 Unclassified WebKit Bindings Safari 18 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam cdumez webkit-bug-importer oldest_to_newest 2135207 0 sam 2025-08-08 11:15:38 -0700 Setters for IDL attributes with a union type can be optimized by taking advantage of the fact that we type check the JS value, at which point we know the concrete final type, but then construct a variant with that value, at which which point we lose that information. This means, the first thing the implementation often does is switch on the variant it was passed to recover that information. Instead, the implementation can expose overloads for each member of the union, thus preserving the information. For example, for CanvasFillStrokeStyles's strokeStyle attribute: ``` interface mixin CanvasFillStrokeStyles { // colors and styles (see also the CanvasPathDrawingStyles and CanvasTextDrawingStyles interfaces) attribute (DOMString or CanvasGradient or CanvasPattern) strokeStyle; // (default black) ... } ``` The implementation currently exposes a getter and setter: ``` using StyleVariant = Variant<String, RefPtr<CanvasGradient>, RefPtr<CanvasPattern>>; StyleVariant strokeStyle() const; void setStrokeStyle(StyleVariant&&); ``` and what setStrokeStyle has to do is check what type it got and then do something with the style: ``` void CanvasRenderingContext2DBase::setStrokeStyle(CanvasRenderingContext2DBase::StyleVariant&& style) { if (std::holds_alternative<String>(style)) { ... } else if (std::holds_alternative<RefPtr<CanvasGradient>>(style)) { ... } else { ... } ``` Instead, it will now expose 3 setters: ``` using StyleVariant = Variant<String, RefPtr<CanvasGradient>, RefPtr<CanvasPattern>>; StyleVariant strokeStyle() const; void setStrokeStyle(String&&); void setStrokeStyle(RefPtr<CanvasGradient>&&); void setStrokeStyle(RefPtr<CanvasPattern>&&); ``` with no additional checking needed. (This idea originates from Kimmo Kinnunen, all credit to them) 2135217 1 sam 2025-08-08 11:30:33 -0700 Pull request: https://github.com/WebKit/WebKit/pull/49126 2136826 2 webkit-bug-importer 2025-08-15 11:16:13 -0700 <rdar://problem/158423078> 2148600 3 ews-feeder 2025-10-05 18:59:10 -0700 Committed 301035@main (16afa35bbfd9): <https://commits.webkit.org/301035@main> Reviewed commits have been landed. Closing PR #49126 and removing active labels.