29707 2009-09-24 02:12:16 -0700 Web Inspector: Color-code watch expression errors with red. 2009-09-29 14:24:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman pmuellr timothy oldest_to_newest 149702 0 pfeldman 2009-09-24 02:12:16 -0700 Reference and parse errors are currently rendered as black plain strings. 149703 1 40054 pfeldman 2009-09-24 02:17:14 -0700 Created attachment 40054 patch 149742 2 pmuellr 2009-09-24 06:29:47 -0700 It would probably be useful to have this in ObjectProperties* bits instead of just the WatchExpressiosn. So that if I'm in a catch block, I'll see my exception in the locals as red. Or if I happen to have some other local variable or object property which is holding onto an exception for some reason, it would also go red. See also: bug 27235 149752 3 timothy 2009-09-24 07:25:11 -0700 Red might mean "changed" since last step, like in Xcode too. So I'm not sure this should be universal thing for ObjectPropertiesSection. 149755 4 pmuellr 2009-09-24 07:47:23 -0700 That's fine for now. As we implement bug 27235, maybe we'll find a better holistic approach. w/r/t "changed since last step", I suppose we should open a bug up on that. So I just did, as bug 29714 151047 5 40054 eric 2009-09-29 14:12:43 -0700 Comment on attachment 40054 patch I think svn-apply would get confused by this ChangeLog, so marking cq-. Besides Pavel is a committer. :) 151051 6 pfeldman 2009-09-29 14:24:17 -0700 Landed as r48718. 40054 2009-09-24 02:17:14 -0700 2009-09-29 14:12:43 -0700 patch watch_error text/plain 2441 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTBjNWRhNi4uMDNjZTI4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxOSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb2xvci1jb2RlIHdhdGNo IGV4cHJlc3Npb24gZXJyb3JzIHdpdGggcmVkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTcwNworCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuV2F0Y2hFeHByZXNzaW9uc1NlY3Rpb24ucHJvdG90eXBlLnVwZGF0ZSk6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuV2F0Y2hFeHByZXNzaW9uVHJlZUVsZW1lbnQucHJvdG90eXBlLnVwZGF0ZSk6 CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzOgorCisyMDA5LTA5 LTI0ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaXgg Zm9ybWF0dGluZyBmb3IgbWVzc2FnZXMgZGVyaXZlZCBmcm9tIHJlc291cmNlIHdhcm5pbmdzLAog ICAgICAgICBjb3VwbGUgb2YgZHJpdmUtYnkgZm9ybWF0dGluZyBmaXhlcy4KIApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dhdGNoRXhwcmVzc2lvbnNTaWRlYmFyUGFu ZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJh clBhbmUuanMKaW5kZXggZjE2MjA5Yi4uYTYxYWYzMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1dhdGNoRXhwcmVzc2lvbnNTaWRlYmFyUGFuZS5qcworKysgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvV2F0Y2hFeHByZXNzaW9uc1NpZGViYXJQYW5lLmpzCkBA IC05MCw2ICs5MCw3IEBAIFdlYkluc3BlY3Rvci5XYXRjaEV4cHJlc3Npb25zU2VjdGlvbi5wcm90 b3R5cGUgPSB7CiAKICAgICAgICAgICAgIHZhciBwcm9wZXJ0eSA9IG5ldyBXZWJJbnNwZWN0b3Iu T2JqZWN0UHJvcGVydHlQcm94eShleHByZXNzaW9uLCByZXN1bHQpOwogICAgICAgICAgICAgcHJv cGVydHkud2F0Y2hJbmRleCA9IHdhdGNoSW5kZXg7CisgICAgICAgICAgICBwcm9wZXJ0eS5pc0V4 Y2VwdGlvbiA9IGV4Y2VwdGlvbjsKIAogICAgICAgICAgICAgLy8gRm9yIG5ld2x5IGFkZGVkLCBl bXB0eSBleHByZXNzaW9ucywgc2V0IGRlc2NyaXB0aW9uIHRvICIiLAogICAgICAgICAgICAgLy8g c2luY2Ugb3RoZXJ3aXNlIHlvdSBnZXQgRE9NV2luZG93CkBAIC0yMTgsNiArMjE5LDkgQEAgV2Vi SW5zcGVjdG9yLldhdGNoRXhwcmVzc2lvblRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICB7 CiAgICAgICAgIFdlYkluc3BlY3Rvci5PYmplY3RQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlw ZS51cGRhdGUuY2FsbCh0aGlzKTsKIAorICAgICAgICBpZiAodGhpcy5wcm9wZXJ0eS5pc0V4Y2Vw dGlvbikKKyAgICAgICAgICAgIHRoaXMudmFsdWVFbGVtZW50LmFkZFN0eWxlQ2xhc3MoIndhdGNo LWV4cHJlc3Npb25zLWVycm9yLWxldmVsIik7CisKICAgICAgICAgdmFyIGRlbGV0ZUJ1dHRvbiA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7CiAgICAgICAgIGRlbGV0ZUJ1dHRvbi50 eXBlID0gImJ1dHRvbiI7CiAgICAgICAgIGRlbGV0ZUJ1dHRvbi50aXRsZSA9IFdlYkluc3BlY3Rv ci5VSVN0cmluZygiRGVsZXRlIHdhdGNoIGV4cHJlc3Npb24uIik7CmRpZmYgLS1naXQgYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzCmluZGV4IDJhZTRhYWMuLjQ1MTM4ODYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzCisrKyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzCkBAIC0xNDA5LDYgKzE0MDksMTAg QEAgbGkuZWRpdGluZyAuc3dhdGNoLCBsaS5lZGl0aW5nIC5lbmFibGVkLWJ1dHRvbiwgIGxpLmVk aXRpbmctc3ViLXBhcnQgLmRlbGV0ZS1idXQKICAgICBkaXNwbGF5OiBub25lOwogfQogCisud2F0 Y2gtZXhwcmVzc2lvbnMtZXJyb3ItbGV2ZWwgeworICAgIGNvbG9yOiByZWQ7Cit9CisKIC5zZWN0 aW9uIC5wcm9wZXJ0aWVzIGxpLmVkaXRpbmctc3ViLXBhcnQgewogICAgIHBhZGRpbmc6IDNweCA2 cHggOHB4IDE4cHg7CiAgICAgbWFyZ2luOiAtM3B4IC02cHggLThweCAtNnB4Owo=