29696 2009-09-23 15:12:18 -0700 [CHROMIUM] Paths fail to render in SVG with large viewbox 2009-09-29 14:11:59 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco eric rolandsteiner oldest_to_newest 149518 0 senorblanco 2009-09-23 15:12:18 -0700 SVG paths with large coordinate values (and correspondingly large viewbox) are not rendered in Chrome. See http://crbug.com/21174. 149519 1 40021 senorblanco 2009-09-23 15:13:39 -0700 Created attachment 40021 Fix for SVG/skia coordinate issue 149593 2 40021 eric 2009-09-23 17:51:51 -0700 Comment on attachment 40021 Fix for SVG/skia coordinate issue I'm just gonna trust you that this is safe. The Skia seat-belt is so lame. :( If you want this committed by the commit-queue you'll need to set commit-queue=?. I can't remember if you're a committer or not. 149744 3 senorblanco 2009-09-24 06:50:37 -0700 (In reply to comment #2) > (From update of attachment 40021 [details]) > I'm just gonna trust you that this is safe. I ran it by the layout trybots on all three platforms, if that makes you feel better. > The Skia seat-belt is so lame. :( The best solution for that (IMHO) is to write floating point (or even better, SSE2) versions of the pixel loops, so there are no fixed-point limitations to worry about. 149822 4 40021 eric 2009-09-24 13:49:42 -0700 Comment on attachment 40021 Fix for SVG/skia coordinate issue According to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py Stephen is not a committer, but it looks like he was invited August 4th. So I'll assume he just hasn't added himself to that list yet and leave this for him to commit. 149843 5 senorblanco 2009-09-24 14:18:53 -0700 (In reply to comment #4) > (From update of attachment 40021 [details]) > According to > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py > Stephen is not a committer, but it looks like he was invited August 4th. So > I'll assume he just hasn't added himself to that list yet and leave this for > him to commit. Actually, I did commit it, in the end.. is there something I should do so that appears here? 150268 6 eric 2009-09-26 01:28:56 -0700 If you committed this bug, than you should update the bug with the revision number that you committed and close it. Searching the commit logs, I don't see that this has been committed though. 150447 7 rolandsteiner 2009-09-27 19:24:27 -0700 (In reply to comment #3) > The best solution for that (IMHO) is to write floating point (or even better, > SSE2) versions of the pixel loops, so there are no fixed-point limitations to > worry about. I agree that this is probably the best interim fix for this bug. However, it means that the paths that are not rendered due to my original patch are (potentially) rendered wrong instead. Until the fixed-point implementation in Skia is changed, there doesn't seem to be much that one could do about it, though. Very minor nit: in currentPathInLocalCoordinates(): one can wait with copying the patch until the matrix inversion has run, in case that fails. Since that's an exceptional case however, there shouldn't be much real impact one way or the other. 151046 8 eric 2009-09-29 14:11:59 -0700 This was landed as r48726 and can be closed. 40021 2009-09-23 15:13:39 -0700 2009-09-24 13:49:42 -0700 Fix for SVG/skia coordinate issue dom_path_units_webkit.patch text/plain 2334 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODY4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDktMjMgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmV2ZXJ0IHRoZSByZWxldmFudCBwYXJ0cyBvZiByNDc5MjUsIGFuZCBpbXBsZW1lbnQg YW4gYWx0ZXJuYXRlCisgICAgICAgIGZpeCAobG9jYWxpemUgdGhlIGNvb3JkaW5hdGUgY2hlY2sg dG8gR3JhcGhpY3NDb250ZXh0OjpjbGlwUGF0aCgpKS4KKyAgICAgICAgVGhpcyBmaXhlcyBodHRw Oi8vY3JidWcuY29tLzIxMTc0LgorCisgICAgICAgIENvdmVyZWQgYnkgTGF5b3V0VGVzdHMvc3Zn L2R5bmFtaWMtdXBkYXRlcy9TVkdDbGlwUGF0aEVsZW1lbnQtZG9tLWNsaXBQYXRoVW5pdHMtYXR0 ci5odG1sLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRl eHRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y2xpcFBhdGgp OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5j cHA6CisgICAgICAgIChQbGF0Zm9ybUNvbnRleHRTa2lhOjpjdXJyZW50UGF0aEluTG9jYWxDb29y ZGluYXRlcyk6CisKIDIwMDktMDktMjMgIFBldGVyIEthc3RpbmcgIDxwa2FzdGluZ0Bnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tp YS5jcHAJKHJldmlzaW9uIDQ4NjgyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDMsNiArNDAzLDkg QEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNsaXBQYXRoKFdpbmRSdWxlIAogICAgICAgICByZXR1 cm47CiAKICAgICBTa1BhdGggcGF0aCA9IHBsYXRmb3JtQ29udGV4dCgpLT5jdXJyZW50UGF0aElu TG9jYWxDb29yZGluYXRlcygpOworICAgIGlmICghaXNQYXRoU2tpYVNhZmUoZ2V0Q1RNKCksIHBh dGgpKQorICAgICAgICByZXR1cm47CisKICAgICBwYXRoLnNldEZpbGxUeXBlKGNsaXBSdWxlID09 IFJVTEVfRVZFTk9ERCA/IFNrUGF0aDo6a0V2ZW5PZGRfRmlsbFR5cGUgOiBTa1BhdGg6OmtXaW5k aW5nX0ZpbGxUeXBlKTsKICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+Y2FudmFzKCktPmNsaXBQYXRo KHBhdGgpOwogfQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3Jt Q29udGV4dFNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAkocmV2aXNpb24gNDg2ODIpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ5MiwxMyArNDkyLDExIEBAIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6YWRk UGF0aChjb25zdCAKIAogU2tQYXRoIFBsYXRmb3JtQ29udGV4dFNraWE6OmN1cnJlbnRQYXRoSW5M b2NhbENvb3JkaW5hdGVzKCkgY29uc3QKIHsKKyAgICBTa1BhdGggbG9jYWxQYXRoID0gbV9wYXRo OwogICAgIGNvbnN0IFNrTWF0cml4JiBtYXRyaXggPSBtX2NhbnZhcy0+Z2V0VG90YWxNYXRyaXgo KTsKICAgICBTa01hdHJpeCBpbnZlcnNlTWF0cml4OwogICAgIGlmICghbWF0cml4LmludmVydCgm aW52ZXJzZU1hdHJpeCkpCiAgICAgICAgIHJldHVybiBTa1BhdGgoKTsKLSAgICBpZiAoIVdlYkNv cmU6OmlzUGF0aFNraWFTYWZlKGludmVyc2VNYXRyaXgsIG1fcGF0aCkpCi0gICAgICAgIHJldHVy biBTa1BhdGgoKTsKLSAgICBTa1BhdGggbG9jYWxQYXRoID0gbV9wYXRoOwogICAgIGxvY2FsUGF0 aC50cmFuc2Zvcm0oaW52ZXJzZU1hdHJpeCk7CiAgICAgcmV0dXJuIGxvY2FsUGF0aDsKIH0K