29694 2009-09-23 14:07:06 -0700 WebCore side of changes to remove gfx::Rect dependency from ImageSkia 2009-09-23 14:19:13 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 pkasting pkasting oldest_to_newest 149498 0 pkasting 2009-09-23 14:07:06 -0700 The Chromium WebCore code should not rely on types in the Chromium repository like gfx::Rect. This bug is for the WebCore side of a change to remove one such dependency; I also need to land a simultaneous Chromium change once this is committed. 149499 1 40016 pkasting 2009-09-23 14:09:24 -0700 Created attachment 40016 patch v1 149501 2 40016 dglazkov 2009-09-23 14:13:49 -0700 Comment on attachment 40016 patch v1 r=me, with nits: > + https://bugs.webkit.org/show_bug.cgi?id=29694 > + Eliminate dependency on gfx::Rect from ImageSkia. pls put [Chromium] in front of the description. > - SkIRect resizedImageRect; // Represents the size of the resized image. > - resizedImageRect.set(0, 0, destRectRounded.width(), destRectRounded.height()); > + SkIRect resizedImageRect = // Represents the size of the resized image. > + { 0, 0, destRectRounded.width(), destRectRounded.height() }; This looks a bit weird, but ok. 149504 3 pkasting 2009-09-23 14:19:13 -0700 Fixed in r48684. 40016 2009-09-23 14:09:24 -0700 2009-09-23 14:13:48 -0700 patch v1 patch text/plain 3182 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ4NjgzKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOS0yMyAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdv b2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5Njk0CisgICAgICAg IEVsaW1pbmF0ZSBkZXBlbmRlbmN5IG9uIGdmeDo6UmVjdCBmcm9tIEltYWdlU2tpYS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmRyYXdSZXNhbXBsZWRCaXRtYXApOgorCiAyMDA5LTA5LTIyICBUaW1vdGh5IEhhdGNo ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBQcmV2ZW50IHNjcm9sbGluZyBtdWx0 aXBsZSBlbGVtZW50cyBkdXJpbmcgbGF0Y2hlZCB3aGVlbCBldmVudHMuCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcA0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCShyZXZpc2lvbiA0ODY4 MykKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00MSw2ICs0MSw3IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0U2tp YS5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSAiU2tpYVV0aWxzLmgi CisjaW5jbHVkZSAiU2tSZWN0LmgiCiAjaW5jbHVkZSAiU2tTaGFkZXIuaCIKICNpbmNsdWRlICJU cmFuc2Zvcm1hdGlvbk1hdHJpeC5oIgogCkBAIC0xNTgsOCArMTU5LDggQEAgc3RhdGljIHZvaWQg ZHJhd1Jlc2FtcGxlZEJpdG1hcChTa0NhbnZhcwogICAgIC8vIFdlIHdpbGwgYWx3YXlzIGRyYXcg aW4gaW50ZWdlciBzaXplcywgc28gcm91bmQgdGhlIGRlc3RpbmF0aW9uIHJlY3QuCiAgICAgU2tJ UmVjdCBkZXN0UmVjdFJvdW5kZWQ7CiAgICAgZGVzdFJlY3Qucm91bmQoJmRlc3RSZWN0Um91bmRl ZCk7Ci0gICAgU2tJUmVjdCByZXNpemVkSW1hZ2VSZWN0OyAgLy8gUmVwcmVzZW50cyB0aGUgc2l6 ZSBvZiB0aGUgcmVzaXplZCBpbWFnZS4KLSAgICByZXNpemVkSW1hZ2VSZWN0LnNldCgwLCAwLCBk ZXN0UmVjdFJvdW5kZWQud2lkdGgoKSwgZGVzdFJlY3RSb3VuZGVkLmhlaWdodCgpKTsKKyAgICBT a0lSZWN0IHJlc2l6ZWRJbWFnZVJlY3QgPSAgLy8gUmVwcmVzZW50cyB0aGUgc2l6ZSBvZiB0aGUg cmVzaXplZCBpbWFnZS4KKyAgICAgICAgeyAwLCAwLCBkZXN0UmVjdFJvdW5kZWQud2lkdGgoKSwg ZGVzdFJlY3RSb3VuZGVkLmhlaWdodCgpIH07CiAKICAgICBpZiAoc3JjSXNGdWxsICYmIGJpdG1h cC5oYXNSZXNpemVkQml0bWFwKGRlc3RSZWN0Um91bmRlZC53aWR0aCgpLCBkZXN0UmVjdFJvdW5k ZWQuaGVpZ2h0KCkpKSB7CiAgICAgICAgIC8vIFlheSwgdGhpcyBiaXRtYXAgZnJhbWUgYWxyZWFk eSBoYXMgYSByZXNpemVkIHZlcnNpb24uCkBAIC0xOTYsMjUgKzE5NywxOSBAQCBzdGF0aWMgdm9p ZCBkcmF3UmVzYW1wbGVkQml0bWFwKFNrQ2FudmFzCiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8g V2Ugc2hvdWxkIG9ubHkgcmVzaXplIHRoZSBleHBvc2VkIHBhcnQgb2YgdGhlIGJpdG1hcCB0byBk byB0aGUKICAgICAgICAgLy8gbWluaW1hbCBwb3NzaWJsZSB3b3JrLgotICAgICAgICBnZng6OlJl Y3QgZGVzdEJpdG1hcFN1YnNldChkZXN0Qml0bWFwU3Vic2V0U2tJLmZMZWZ0LAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkZXN0Qml0bWFwU3Vic2V0U2tJLmZUb3AsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlc3RCaXRtYXBTdWJzZXRTa0kud2lkdGgo KSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVzdEJpdG1hcFN1YnNldFNr SS5oZWlnaHQoKSk7CiAKICAgICAgICAgLy8gUmVzYW1wbGUgdGhlIG5lZWRlZCBwYXJ0IG9mIHRo ZSBpbWFnZS4KICAgICAgICAgU2tCaXRtYXAgcmVzYW1wbGVkID0gc2tpYTo6SW1hZ2VPcGVyYXRp b25zOjpSZXNpemUoc3Vic2V0LAogICAgICAgICAgICAgc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpS RVNJWkVfTEFOQ1pPUzMsCiAgICAgICAgICAgICBkZXN0UmVjdFJvdW5kZWQud2lkdGgoKSwgZGVz dFJlY3RSb3VuZGVkLmhlaWdodCgpLAotICAgICAgICAgICAgZGVzdEJpdG1hcFN1YnNldCk7Cisg ICAgICAgICAgICBkZXN0Qml0bWFwU3Vic2V0U2tJKTsKIAogICAgICAgICAvLyBDb21wdXRlIHdo ZXJlIHRoZSBuZXcgYml0bWFwIHNob3VsZCBiZSBkcmF3bi4gU2luY2Ugb3VyIG5ldyBiaXRtYXAK ICAgICAgICAgLy8gbWF5IGJlIHNtYWxsZXIgdGhhbiB0aGUgb3JpZ2luYWwsIHdlIGhhdmUgdG8g c2hpZnQgaXQgb3ZlciBieSB0aGUKICAgICAgICAgLy8gc2FtZSBhbW91bnQgdGhhdCB3ZSBjdXQg b2ZmIHRoZSB0b3AgYW5kIGxlZnQuCi0gICAgICAgIFNrUmVjdCBvZmZzZXREZXN0UmVjdCA9IHsK LSAgICAgICAgICAgIGRlc3RCaXRtYXBTdWJzZXQueCgpICsgZGVzdFJlY3QuZkxlZnQsCi0gICAg ICAgICAgICBkZXN0Qml0bWFwU3Vic2V0LnkoKSArIGRlc3RSZWN0LmZUb3AsCi0gICAgICAgICAg ICBkZXN0Qml0bWFwU3Vic2V0LnJpZ2h0KCkgKyBkZXN0UmVjdC5mTGVmdCwKLSAgICAgICAgICAg IGRlc3RCaXRtYXBTdWJzZXQuYm90dG9tKCkgKyBkZXN0UmVjdC5mVG9wIH07CisgICAgICAgIGRl c3RCaXRtYXBTdWJzZXRTa0kub2Zmc2V0KGRlc3RSZWN0LmZMZWZ0LCBkZXN0UmVjdC5mVG9wKTsK KyAgICAgICAgU2tSZWN0IG9mZnNldERlc3RSZWN0OworICAgICAgICBvZmZzZXREZXN0UmVjdC5z ZXQoZGVzdEJpdG1hcFN1YnNldFNrSSk7CiAKICAgICAgICAgY2FudmFzLmRyYXdCaXRtYXBSZWN0 KHJlc2FtcGxlZCwgMCwgb2Zmc2V0RGVzdFJlY3QsICZwYWludCk7CiAgICAgfQo=