29693 2009-09-23 13:53:42 -0700 [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly 2009-09-24 07:16:15 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 29348 1 gustavo webkit-unassigned eric evan tony oldest_to_newest 149494 0 gustavo 2009-09-23 13:53:42 -0700 To correctly synthesize events using gtk_main_do_event we need the window to be shown, or GTK+ throws the events away. We want this for our EventSender. See https://bugs.webkit.org/show_bug.cgi?id=29348. 149497 1 40015 gustavo 2009-09-23 14:04:22 -0700 Created attachment 40015 show window instead of realizing only 149592 2 eric 2009-09-23 17:49:47 -0700 Really? This is so sad. I wonder how Chromium test_shell handles this. 149601 3 tony 2009-09-23 18:02:59 -0700 test_shell on all platforms shows the window. On Linux, we run our tests in a virtual X server (Xvfb) so it doesn't really matter. 149604 4 eric 2009-09-23 18:05:50 -0700 Interesting. DumpRenderTree on Mac does not show a window. I don't believe it does on Windows either. 149643 5 gustavo 2009-09-23 20:24:24 -0700 Yeah, that's a limitation in GTK+ - it explicitely checks if the window is visible to decide whether it will propagate the event or not, so to synthesize the events with maximum fidelity, that is, not only emitting signals, but causing GTK+ to do whatever it always does when the event happens, we'll need to show the window. Most people will run the tests inside Xvfb, so it should be a non-issue, as Tony pointed out. 149733 6 40015 jmalonzo 2009-09-24 05:35:40 -0700 Comment on attachment 40015 show window instead of realizing only > + gtk_window_resize(GTK_WINDOW(window), size.width, size.height); > gtk_widget_size_allocate(container, &size); Is this part of the patch? 149734 7 40015 jmalonzo 2009-09-24 05:36:36 -0700 Comment on attachment 40015 show window instead of realizing only r=me. 149749 8 gustavo 2009-09-24 07:16:15 -0700 Landed as r48721, thanks. 40015 2009-09-23 14:04:22 -0700 2009-09-24 05:36:35 -0700 show window instead of realizing only 0001-Show-the-window-to-be-able-to-synthesize-events-corr.patch text/plain 2741 gustavo RnJvbSBhOWJiOTg2Y2E1MGE2YmNhOTBkMDRmNTVjYzgxOWMzOTdkZmUzMzRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFdlZCwgMjMgU2VwIDIwMDkgMTc6NDk6NDMgLTAzMDAK U3ViamVjdDogW1BBVENIXSBTaG93IHRoZSB3aW5kb3csIHRvIGJlIGFibGUgdG8gc3ludGhlc2l6 ZSBldmVudHMgY29ycmVjdGx5CgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAgfCAgICA2ICsrKystLQogMiBmaWxlcyBj aGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAzYjdjZDE0 Li4zMmJkOGE2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0 VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMDktMjMgIEd1c3Rhdm8gTm9y b25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRFJUIG11c3QgZGlz cGxheSB3aW5kb3cgaW5zdGVhZCBvZiBqdXN0IHJlYWxpemluZywgdG8gZW5hYmxlIHN5bnRoZXNp emluZyBldmVudHMgY29ycmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yOTY5MworCisgICAgICAgIFNob3cgdGhlIHdpbmRvdywgdG8gYmUgYWJs ZSB0byBzeW50aGVzaXplIGV2ZW50cyBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocnVuVGVzdCk6CisgICAgICAg IChtYWluKToKKworMjAwOS0wOS0yMyAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5u b3JvbmhhQGNvbGxhYm9yYS5jby51az4KKwogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXou CiAKICAgICAgICAgW0dUS10gbmVlZCB0byBkdW1wIG51bWJlciBvZiBwZW5kaW5nIHVubG9hZCBo YW5kbGVycwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBS ZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVy VHJlZS5jcHAKaW5kZXggZjgxYzk2Yy4uNTMzOWNjZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC03Niw2ICs3Niw3IEBAIEFj Y2Vzc2liaWxpdHlDb250cm9sbGVyKiBheENvbnRyb2xsZXIgPSAwOwogTGF5b3V0VGVzdENvbnRy b2xsZXIqIGdMYXlvdXRUZXN0Q29udHJvbGxlciA9IDA7CiBzdGF0aWMgR0NDb250cm9sbGVyKiBn Y0NvbnRyb2xsZXIgPSAwOwogc3RhdGljIFdlYktpdFdlYlZpZXcqIHdlYlZpZXc7CitzdGF0aWMg R3RrV2lkZ2V0KiB3aW5kb3c7CiBzdGF0aWMgR3RrV2lkZ2V0KiBjb250YWluZXI7CiBXZWJLaXRX ZWJGcmFtZSogbWFpbkZyYW1lID0gMDsKIFdlYktpdFdlYkZyYW1lKiB0b3BMb2FkaW5nRnJhbWUg PSAwOwpAQCAtNDE5LDYgKzQyMCw3IEBAIHN0YXRpYyB2b2lkIHJ1blRlc3QoY29uc3Qgc3RyaW5n JiB0ZXN0UGF0aE9yVVJMKQogICAgIHNpemUueCA9IHNpemUueSA9IDA7CiAgICAgc2l6ZS53aWR0 aCA9IGlzU1ZHVzNDVGVzdCA/IDQ4MCA6IG1heFZpZXdXaWR0aDsKICAgICBzaXplLmhlaWdodCA9 IGlzU1ZHVzNDVGVzdCA/IDM2MCA6IG1heFZpZXdIZWlnaHQ7CisgICAgZ3RrX3dpbmRvd19yZXNp emUoR1RLX1dJTkRPVyh3aW5kb3cpLCBzaXplLndpZHRoLCBzaXplLmhlaWdodCk7CiAgICAgZ3Rr X3dpZGdldF9zaXplX2FsbG9jYXRlKGNvbnRhaW5lciwgJnNpemUpOwogCiAgICAgaWYgKHByZXZU ZXN0QkZJdGVtKQpAQCAtNzIxLDExICs3MjMsMTEgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIq IGFyZ3ZbXSkKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogCi0gICAgR3RrV2lk Z2V0KiB3aW5kb3cgPSBndGtfd2luZG93X25ldyhHVEtfV0lORE9XX1BPUFVQKTsKKyAgICB3aW5k b3cgPSBndGtfd2luZG93X25ldyhHVEtfV0lORE9XX1BPUFVQKTsKICAgICBjb250YWluZXIgPSBH VEtfV0lER0VUKGd0a19zY3JvbGxlZF93aW5kb3dfbmV3KE5VTEwsIE5VTEwpKTsKICAgICBndGtf c2Nyb2xsZWRfd2luZG93X3NldF9wb2xpY3koR1RLX1NDUk9MTEVEX1dJTkRPVyhjb250YWluZXIp LCBHVEtfUE9MSUNZX0FVVE9NQVRJQywgR1RLX1BPTElDWV9BVVRPTUFUSUMpOwogICAgIGd0a19j b250YWluZXJfYWRkKEdUS19DT05UQUlORVIod2luZG93KSwgY29udGFpbmVyKTsKLSAgICBndGtf d2lkZ2V0X3JlYWxpemUod2luZG93KTsKKyAgICBndGtfd2lkZ2V0X3Nob3dfYWxsKHdpbmRvdyk7 CiAKICAgICB3ZWJWaWV3ID0gY3JlYXRlV2ViVmlldygpOwogICAgIGd0a19jb250YWluZXJfYWRk KEdUS19DT05UQUlORVIoY29udGFpbmVyKSwgR1RLX1dJREdFVCh3ZWJWaWV3KSk7Ci0tIAoxLjYu NC4zCgo=