29682 2009-09-23 07:00:35 -0700 [Qt] QWebElement lacks hasFocus and SetFocus apis 2009-09-27 14:33:54 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Enhancement --- 1 joseph.ligman joseph.ligman commit-queue eric kenneth laszlo.gombos tonikitoo vestbo oldest_to_newest 149387 0 joseph.ligman 2009-09-23 07:00:35 -0700 These APIs are needed for clients of QWebElement. 149411 1 40000 joseph.ligman 2009-09-23 09:25:40 -0700 Created attachment 40000 Proposed patch, adds setFocus, hasFocus to QWebElement This patch adds setFocus and hasFocus Api to QWebElement. And a test case. 149413 2 tonikitoo 2009-09-23 09:30:10 -0700 good stuff 149591 3 eric 2009-09-23 17:48:15 -0700 Are these standard Qt apis? Please explain (ideally in the ChangeLog) why you're adding these, and why this particular API makes sense. 149971 4 40000 hausmann 2009-09-25 04:15:12 -0700 Comment on attachment 40000 Proposed patch, adds setFocus, hasFocus to QWebElement In principle this looks good. I think only a few small fixes are necessary. > /*! > + \since 4.6 > + Returns true if this QWebElement has keyboard input focus; otherwise, returns false In the documentation you can simply use "this element" instead of repeating the class name. Just like in the other methods of this class :) > + > + \sa setFocus() > +*/ > +bool QWebElement::hasFocus() const > +{ > + if (m_element->document() && m_element->isFocusable()) > + return m_element == m_element->document()->focusedNode(); > + return false; > +} Please add a null pointer check for m_element. > +/*! > + \since 4.6 > + Gives keyboard input focus to this QWebElement > + > + \sa hasFocus() > +*/ > +void QWebElement::setFocus() > +{ > + if (m_element->document() && m_element->isFocusable()) > + m_element->document()->setFocusedNode(m_element); > +} Same here :) 149997 5 kenneth 2009-09-25 07:02:44 -0700 > > /*! > > + \since 4.6 > > + Returns true if this QWebElement has keyboard input focus; otherwise, returns false > The QWebElement class is new in 4.6 so I believe we should leave out the \since 4.6 150080 6 40127 joseph.ligman 2009-09-25 11:13:41 -0700 Created attachment 40127 Proposed patch, adds API setFocus, hasFocus to QWebElement Fixed the comments and added the null pointer check for m_element 150427 7 40127 hausmann 2009-09-27 14:23:50 -0700 Comment on attachment 40127 Proposed patch, adds API setFocus, hasFocus to QWebElement r=me, thanks! 150430 8 40127 commit-queue 2009-09-27 14:33:50 -0700 Comment on attachment 40127 Proposed patch, adds API setFocus, hasFocus to QWebElement Clearing flags on attachment: 40127 Committed r48805: <http://trac.webkit.org/changeset/48805> 150431 9 commit-queue 2009-09-27 14:33:54 -0700 All reviewed patches have been landed. Closing bug. 40000 2009-09-23 09:25:40 -0700 2009-09-25 11:13:41 -0700 Proposed patch, adds setFocus, hasFocus to QWebElement bug2682.patch text/plain 3350 joseph.ligman SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDg2NzUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMjMgIEpvZSBMaWdtYW4gIDxqb3NlcGgubGln bWFuQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIEFkZGluZyBBUEkgc2V0Rm9jdXMgYW5kIGhhc0ZvY3VzIHRvIFFXZWJFbGVt ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk2 ODIKKworICAgICAgICAqIEFwaS9xd2ViZWxlbWVudC5jcHA6CisgICAgICAgIChRV2ViRWxlbWVu dDo6aGFzRm9jdXMpOgorICAgICAgICAoUVdlYkVsZW1lbnQ6OnNldEZvY3VzKToKKyAgICAgICAg KiBBcGkvcXdlYmVsZW1lbnQuaDoKKyAgICAgICAgKiB0ZXN0cy9xd2ViZWxlbWVudC90c3RfcXdl YmVsZW1lbnQuY3BwOgorICAgICAgICAodHN0X1FXZWJFbGVtZW50OjpoYXNTZXRGb2N1cyk6CisK IDIwMDktMDktMjIgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9x dC9BcGkvcXdlYmVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmVs ZW1lbnQuY3BwCShyZXZpc2lvbiA0ODY3NSkKKysrIFdlYktpdC9xdC9BcGkvcXdlYmVsZW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzMsNiArNDczLDMxIEBAIGJvb2wgUVdlYkVsZW1lbnQ6 Omhhc0F0dHJpYnV0ZXMoKSBjb25zdAogfQogCiAvKiEKKyAgICBcc2luY2UgNC42CisgICAgUmV0 dXJucyB0cnVlIGlmIHRoaXMgUVdlYkVsZW1lbnQgaGFzIGtleWJvYXJkIGlucHV0IGZvY3VzOyBv dGhlcndpc2UsIHJldHVybnMgZmFsc2UKKworICAgIFxzYSBzZXRGb2N1cygpCisqLworYm9vbCBR V2ViRWxlbWVudDo6aGFzRm9jdXMoKSBjb25zdAoreworICAgIGlmIChtX2VsZW1lbnQtPmRvY3Vt ZW50KCkgJiYgbV9lbGVtZW50LT5pc0ZvY3VzYWJsZSgpKQorICAgICAgICByZXR1cm4gbV9lbGVt ZW50ID09IG1fZWxlbWVudC0+ZG9jdW1lbnQoKS0+Zm9jdXNlZE5vZGUoKTsKKyAgICByZXR1cm4g ZmFsc2U7Cit9CisKKy8qIQorICAgIFxzaW5jZSA0LjYKKyAgICBHaXZlcyBrZXlib2FyZCBpbnB1 dCBmb2N1cyB0byB0aGlzIFFXZWJFbGVtZW50CisKKyAgICBcc2EgaGFzRm9jdXMoKQorKi8KK3Zv aWQgUVdlYkVsZW1lbnQ6OnNldEZvY3VzKCkKK3sKKyAgICBpZiAobV9lbGVtZW50LT5kb2N1bWVu dCgpICYmIG1fZWxlbWVudC0+aXNGb2N1c2FibGUoKSkKKyAgICAgICAgbV9lbGVtZW50LT5kb2N1 bWVudCgpLT5zZXRGb2N1c2VkTm9kZShtX2VsZW1lbnQpOworfQorCisvKiEKICAgICBSZXR1cm5z IHRoZSBnZW9tZXRyeSBvZiB0aGlzIGVsZW1lbnQsIHJlbGF0aXZlIHRvIGl0cyBjb250YWluaW5n IGZyYW1lLgogCiAgICAgXHNhIHRhZ05hbWUoKQpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2ViZWxl bWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmVsZW1lbnQuaAkocmV2aXNp b24gNDg2NzUpCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJlbGVtZW50LmgJKHdvcmtpbmcgY29weSkK QEAgLTc0LDYgKzc0LDkgQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlQ2xhc3MoY29uc3QgUVN0 cmluZyYgbmFtZSk7CiAgICAgdm9pZCB0b2dnbGVDbGFzcyhjb25zdCBRU3RyaW5nJiBuYW1lKTsK IAorICAgIGJvb2wgaGFzRm9jdXMoKSBjb25zdDsKKyAgICB2b2lkIHNldEZvY3VzKCk7CisKICAg ICBRUmVjdCBnZW9tZXRyeSgpIGNvbnN0OwogCiAgICAgUVN0cmluZyB0YWdOYW1lKCkgY29uc3Q7 CkluZGV4OiBXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50 LmNwcAkocmV2aXNpb24gNDg2NzUpCisrKyBXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0 X3F3ZWJlbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTAsNiArOTAsNyBAQCBwcml2YXRl IHNsb3RzOgogICAgIHZvaWQgbnVsbFNlbGVjdCgpOwogICAgIHZvaWQgZmlyc3RDaGlsZE5leHRT aWJsaW5nKCk7CiAgICAgdm9pZCBsYXN0Q2hpbGRQcmV2aW91c1NpYmxpbmcoKTsKKyAgICB2b2lk IGhhc1NldEZvY3VzKCk7CiAKIHByaXZhdGU6CiAgICAgUVdlYlZpZXcqIG1fdmlldzsKQEAgLTg3 OCw1ICs4NzksMjQgQEAgdm9pZCB0c3RfUVdlYkVsZW1lbnQ6Omxhc3RDaGlsZFByZXZpb3VzUwog ICAgIFFWRVJJRlkocC5wcmV2aW91c1NpYmxpbmcoKS5pc051bGwoKSk7CiB9CiAKK3ZvaWQgdHN0 X1FXZWJFbGVtZW50OjpoYXNTZXRGb2N1cygpCit7CisgICAgbV9tYWluRnJhbWUtPnNldEh0bWwo IjxodG1sPjxib2R5PiIgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICI8aW5wdXQgdHlw ZT0ndGV4dCcgaWQ9J2lucHV0MScvPiIgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICI8 YnI+IlwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlucHV0IHR5cGU9J3RleHQnIGlk PSdpbnB1dDInLz4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPC9ib2R5PjwvaHRt bD4iKTsKKworICAgIFFMaXN0PFFXZWJFbGVtZW50PiBpbnB1dHMgPSBtX21haW5GcmFtZS0+ZG9j dW1lbnRFbGVtZW50KCkuZmluZEFsbCgiaW5wdXQiKTsKKyAgICBRV2ViRWxlbWVudCBpbnB1dDEg PSBpbnB1dHMuYXQoMCk7CisgICAgaW5wdXQxLnNldEZvY3VzKCk7CisgICAgUVZFUklGWShpbnB1 dDEuaGFzRm9jdXMoKSk7CisKKyAgICBRV2ViRWxlbWVudCBpbnB1dDIgPSBpbnB1dHMuYXQoMSk7 CisgICAgaW5wdXQyLnNldEZvY3VzKCk7CisgICAgUVZFUklGWSghaW5wdXQxLmhhc0ZvY3VzKCkp OworICAgIFFWRVJJRlkoaW5wdXQyLmhhc0ZvY3VzKCkpOworfQorCiBRVEVTVF9NQUlOKHRzdF9R V2ViRWxlbWVudCkKICNpbmNsdWRlICJ0c3RfcXdlYmVsZW1lbnQubW9jIgo= 40127 2009-09-25 11:13:41 -0700 2009-09-27 14:33:50 -0700 Proposed patch, adds API setFocus, hasFocus to QWebElement bug29682.patch text/plain 3458 joseph.ligman SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDg3NjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDktMjUgIEpvZSBMaWdtYW4gIDxqb3NlcGgubGln bWFuQG1pbmRzcHJpbmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gQWRkaW5nIEFQSSBzZXRGb2N1cyBhbmQgaGFzRm9jdXMgdG8gUVdl YkVsZW1lbnQuIFRoaXMgQVBJIGlzIG5lZWRlZCBmb3IKKyAgICAgICAgY2xpZW50cyB0aGF0IHdh bnQgdG8gY2hlY2svc2V0IHRoZSBmb2N1cyBub2RlIG9mIHRoZSBkb2N1bWVudC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NjgyCisKKyAgICAgICAg KiBBcGkvcXdlYmVsZW1lbnQuY3BwOgorICAgICAgICAoUVdlYkVsZW1lbnQ6Omhhc0ZvY3VzKToK KyAgICAgICAgKFFXZWJFbGVtZW50OjpzZXRGb2N1cyk6CisgICAgICAgICogQXBpL3F3ZWJlbGVt ZW50Lmg6CisgICAgICAgICogdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcDoK KyAgICAgICAgKHRzdF9RV2ViRWxlbWVudDo6aGFzU2V0Rm9jdXMpOgorCiAyMDA5LTA5LTI1ICBD c2FiYSBPc3p0cm9nb25hYyAgPG9zemlAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2ViZWxlbWVudC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xd2ViZWxlbWVudC5jcHAJKHJldmlzaW9u IDQ4NzYwKQorKysgV2ViS2l0L3F0L0FwaS9xd2ViZWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ2Myw2ICs0NjMsMzMgQEAgYm9vbCBRV2ViRWxlbWVudDo6aGFzQXR0cmlidXRlcygpIGNv bnN0CiB9CiAKIC8qIQorICAgIFJldHVybnMgdHJ1ZSBpZiB0aGUgZWxlbWVudCBoYXMga2V5Ym9h cmQgaW5wdXQgZm9jdXM7IG90aGVyd2lzZSwgcmV0dXJucyBmYWxzZQorCisgICAgXHNhIHNldEZv Y3VzKCkKKyovCitib29sIFFXZWJFbGVtZW50OjpoYXNGb2N1cygpIGNvbnN0Cit7CisgICAgaWYg KCFtX2VsZW1lbnQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBpZiAobV9lbGVtZW50LT5k b2N1bWVudCgpKQorICAgICAgICByZXR1cm4gbV9lbGVtZW50ID09IG1fZWxlbWVudC0+ZG9jdW1l bnQoKS0+Zm9jdXNlZE5vZGUoKTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKKy8qIQorICAgIEdp dmVzIGtleWJvYXJkIGlucHV0IGZvY3VzIHRvIHRoaXMgZWxlbWVudAorCisgICAgXHNhIGhhc0Zv Y3VzKCkKKyovCit2b2lkIFFXZWJFbGVtZW50OjpzZXRGb2N1cygpCit7CisgICAgaWYgKCFtX2Vs ZW1lbnQpCisgICAgICAgIHJldHVybjsKKyAgICBpZiAobV9lbGVtZW50LT5kb2N1bWVudCgpICYm IG1fZWxlbWVudC0+aXNGb2N1c2FibGUoKSkKKyAgICAgICAgbV9lbGVtZW50LT5kb2N1bWVudCgp LT5zZXRGb2N1c2VkTm9kZShtX2VsZW1lbnQpOworfQorCisvKiEKICAgICBSZXR1cm5zIHRoZSBn ZW9tZXRyeSBvZiB0aGlzIGVsZW1lbnQsIHJlbGF0aXZlIHRvIGl0cyBjb250YWluaW5nIGZyYW1l LgogCiAgICAgXHNhIHRhZ05hbWUoKQpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2ViZWxlbWVudC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmVsZW1lbnQuaAkocmV2aXNpb24gNDg3 NjApCisrKyBXZWJLaXQvcXQvQXBpL3F3ZWJlbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTc0 LDYgKzc0LDkgQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlQ2xhc3MoY29uc3QgUVN0cmluZyYg bmFtZSk7CiAgICAgdm9pZCB0b2dnbGVDbGFzcyhjb25zdCBRU3RyaW5nJiBuYW1lKTsKIAorICAg IGJvb2wgaGFzRm9jdXMoKSBjb25zdDsKKyAgICB2b2lkIHNldEZvY3VzKCk7CisKICAgICBRUmVj dCBnZW9tZXRyeSgpIGNvbnN0OwogCiAgICAgUVN0cmluZyB0YWdOYW1lKCkgY29uc3Q7CkluZGV4 OiBXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcAko cmV2aXNpb24gNDg3NjApCisrKyBXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJl bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODYsNiArODYsNyBAQCBwcml2YXRlIHNsb3Rz OgogICAgIHZvaWQgbnVsbFNlbGVjdCgpOwogICAgIHZvaWQgZmlyc3RDaGlsZE5leHRTaWJsaW5n KCk7CiAgICAgdm9pZCBsYXN0Q2hpbGRQcmV2aW91c1NpYmxpbmcoKTsKKyAgICB2b2lkIGhhc1Nl dEZvY3VzKCk7CiAKIHByaXZhdGU6CiAgICAgUVdlYlZpZXcqIG1fdmlldzsKQEAgLTgwNSw1ICs4 MDYsMjQgQEAgdm9pZCB0c3RfUVdlYkVsZW1lbnQ6Omxhc3RDaGlsZFByZXZpb3VzUwogICAgIFFW RVJJRlkocC5wcmV2aW91c1NpYmxpbmcoKS5pc051bGwoKSk7CiB9CiAKK3ZvaWQgdHN0X1FXZWJF bGVtZW50OjpoYXNTZXRGb2N1cygpCit7CisgICAgbV9tYWluRnJhbWUtPnNldEh0bWwoIjxodG1s Pjxib2R5PiIgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICI8aW5wdXQgdHlwZT0ndGV4 dCcgaWQ9J2lucHV0MScvPiIgXAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICI8YnI+IlwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPGlucHV0IHR5cGU9J3RleHQnIGlkPSdpbnB1 dDInLz4iIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiPC9ib2R5PjwvaHRtbD4iKTsK KworICAgIFFMaXN0PFFXZWJFbGVtZW50PiBpbnB1dHMgPSBtX21haW5GcmFtZS0+ZG9jdW1lbnRF bGVtZW50KCkuZmluZEFsbCgiaW5wdXQiKTsKKyAgICBRV2ViRWxlbWVudCBpbnB1dDEgPSBpbnB1 dHMuYXQoMCk7CisgICAgaW5wdXQxLnNldEZvY3VzKCk7CisgICAgUVZFUklGWShpbnB1dDEuaGFz Rm9jdXMoKSk7CisKKyAgICBRV2ViRWxlbWVudCBpbnB1dDIgPSBpbnB1dHMuYXQoMSk7CisgICAg aW5wdXQyLnNldEZvY3VzKCk7CisgICAgUVZFUklGWSghaW5wdXQxLmhhc0ZvY3VzKCkpOworICAg IFFWRVJJRlkoaW5wdXQyLmhhc0ZvY3VzKCkpOworfQorCiBRVEVTVF9NQUlOKHRzdF9RV2ViRWxl bWVudCkKICNpbmNsdWRlICJ0c3RfcXdlYmVsZW1lbnQubW9jIgo=