29677 2009-09-23 05:19:56 -0700 Guard QX11Info include with Q_WS_X11 2009-09-23 09:23:59 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 27065 0 norbert.leser webkit-unassigned commit-queue hausmann kenneth laszlo.gombos ossy tonikitoo yongjun.zhang oldest_to_newest 149363 0 39990 norbert.leser 2009-09-23 05:19:56 -0700 Created attachment 39990 QX11Info patch Need to guard QX11Info include with Q_WS_X11. That class may not be available (in QT 4.5 for Symbian, for instance). Completes fixes in r48627 and r48604. 149366 1 kenneth 2009-09-23 05:50:30 -0700 Norbert, you don't need reviews for build fixes like this one :-) Feel free to commit! Just write "Unreviewed Qt build fix" in the ChangeLog 149367 2 39990 vestbo 2009-09-23 05:55:51 -0700 Comment on attachment 39990 QX11Info patch Kennth is right, but r=me 149368 3 norbert.leser 2009-09-23 06:00:43 -0700 (In reply to comment #2) > (From update of attachment 39990 [details]) > Kennth is right, but r=me I don't have commit rights - thus, someone else please pick it up. The fix seems trivial, and in this case, I assume it is - still, these sort of changes can easily break the build on certain platforms, under certain conditions. I would caution to treat these as pass-through / non-review fixes. 149372 4 39990 commit-queue 2009-09-23 06:08:55 -0700 Comment on attachment 39990 QX11Info patch Rejecting patch 39990 from commit-queue. kenneth.christiansen@openbossa.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 149376 5 kenneth 2009-09-23 06:15:03 -0700 kenneth@webkit.org is an alias for kenneth.christiansen@openbossa.org Committer("Kenneth Rohde Christiansen", "kenneth@webkit.org"), Should I add both or ? 149379 6 39990 kenneth 2009-09-23 06:21:20 -0700 Comment on attachment 39990 QX11Info patch Let's try again! I changed my bugzilla e-mail. 149408 7 39990 commit-queue 2009-09-23 09:23:54 -0700 Comment on attachment 39990 QX11Info patch Clearing flags on attachment: 39990 Committed r48676: <http://trac.webkit.org/changeset/48676> 149409 8 commit-queue 2009-09-23 09:23:59 -0700 All reviewed patches have been landed. Closing bug. 39990 2009-09-23 05:19:56 -0700 2009-09-23 09:23:54 -0700 QX11Info patch qx11info.patch text/plain 1496 norbert.leser SW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYmdyYXBoaWNzaXRlbS5jcHANCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0t LSBXZWJLaXQvcXQvQXBpL3F3ZWJncmFwaGljc2l0ZW0uY3BwCShyZXZpc2lvbiA0ODY2OSkKKysr IFdlYktpdC9xdC9BcGkvcXdlYmdyYXBoaWNzaXRlbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5 LDcgKzI5LDkgQEAKICNpbmNsdWRlIDxRdEd1aS9xYXBwbGljYXRpb24uaD4KICNpbmNsdWRlIDxR dEd1aS9xZ3JhcGhpY3NzY2VuZWV2ZW50Lmg+CiAjaW5jbHVkZSA8UXRHdWkvcXN0eWxlb3B0aW9u Lmg+CisjaWYgZGVmaW5lZChRX1dTX1gxMSkKICNpbmNsdWRlIDxRWDExSW5mbz4KKyNlbmRpZgog CiBjbGFzcyBRV2ViR3JhcGhpY3NJdGVtUHJpdmF0ZSA6IHB1YmxpYyBRV2ViUGFnZUNsaWVudCB7 CiBwdWJsaWM6CkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmNwcA0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K LS0tIFdlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3BwCShyZXZpc2lvbiA0ODY2OSkKKysrIFdlYktp dC9xdC9BcGkvcXdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSw5IEBACiAj aW5jbHVkZSAicXByaW50ZXIuaCIKICNpbmNsdWRlICJxZGlyLmgiCiAjaW5jbHVkZSAicWZpbGUu aCIKKyNpZiBkZWZpbmVkKFFfV1NfWDExKQogI2luY2x1ZGUgPFFYMTFJbmZvPgorI2VuZGlmCiAK IGNsYXNzIFFXZWJWaWV3UHJpdmF0ZSA6IHB1YmxpYyBRV2ViUGFnZUNsaWVudCB7CiBwdWJsaWM6 CkluZGV4OiBXZWJLaXQvcXQvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L3F0L0No YW5nZUxvZwkocmV2aXNpb24gNDg2NzApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDktMjMgIE5vcmJlcnQgTGVzZXIgIDxub3Ji ZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBOZWVkIHRvIGd1YXJkIFFYMTFJbmZvIGluY2x1ZGUgd2l0aCBRX1dTX1gx MS4KKyAgICAgICAgVGhhdCBjbGFzcyBtYXkgbm90IGJlIGF2YWlsYWJsZSAoaW4gUVQgNC41IGZv ciBTeW1iaWFuLCBmb3IgaW5zdGFuY2UpLgorICAgICAgICBDb21wbGV0ZXMgZml4ZXMgaW4gcjQ4 NjI3IGFuZCByNDg2MDQuCisKKyAgICAgICAgKiBBcGkvcXdlYmdyYXBoaWNzaXRlbS5jcHA6Cisg ICAgICAgICogQXBpL3F3ZWJ2aWV3LmNwcDoKKwogMjAwOS0wOS0yMiAgSm9jZWx5biBUdXJjb3R0 ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNp bW9uIEhhdXNtYW5uLgo=