29676 2009-09-23 04:21:28 -0700 [Qt] QWebPage::setView() changes incorrectly the viewport size of a QWebGraphicsItem 2009-09-23 18:02:14 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 0 jpnurmi webkit-unassigned commit-queue oldest_to_newest 149351 0 jpnurmi 2009-09-23 04:21:28 -0700 Prevent QWebPage::setView() from changing the viewport size on the fly in case the view doesn't actually change. QWebPage::setView() is called upon every QWebGraphicsItem::hoverMoveEvent(), which forces the viewport size to be equal to the size of the whole graphics view. The geometry of a single graphics item rarely matches the geometry of the whole graphics view. 149353 1 39987 jpnurmi 2009-09-23 04:28:28 -0700 Created attachment 39987 QWebPage::setView(): check if the view actually changes 149513 2 39987 hausmann 2009-09-23 14:40:49 -0700 Comment on attachment 39987 QWebPage::setView(): check if the view actually changes r=me. Good catch :) 149598 3 39987 commit-queue 2009-09-23 18:02:11 -0700 Comment on attachment 39987 QWebPage::setView(): check if the view actually changes Clearing flags on attachment: 39987 Committed r48693: <http://trac.webkit.org/changeset/48693> 149599 4 commit-queue 2009-09-23 18:02:14 -0700 All reviewed patches have been landed. Closing bug. 39987 2009-09-23 04:28:28 -0700 2009-09-23 18:02:11 -0700 QWebPage::setView(): check if the view actually changes qwebpage.patch text/plain 1318 jpnurmi SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDg2NjkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMjMgIEotUCBOdXJtaSAgPGpwbnVybWlAZ21h aWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFByZXZlbnQgUVdlYlBhZ2U6OnNldFZpZXcoKSBmcm9tIGNoYW5naW5nIHRoZSB2aWV3cG9ydCBz aXplIG9uIHRoZSBmbHkKKyAgICAgICAgaW4gY2FzZSB0aGUgdmlldyBkb2Vzbid0IGFjdHVhbGx5 IGNoYW5nZS4gUVdlYlBhZ2U6OnNldFZpZXcoKSBpcworICAgICAgICBjYWxsZWQgdXBvbiBldmVy eSBRV2ViR3JhcGhpY3NJdGVtOjpob3Zlck1vdmVFdmVudCgpLCB3aGljaCBmb3JjZWQKKyAgICAg ICAgdGhlIHZpZXdwb3J0IHNpemUgdG8gYmUgZXF1YWwgdG8gdGhlIHNpemUgb2YgdGhlIHdob2xl IGdyYXBoaWNzIHZpZXcuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI5Njc2CisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAo UVdlYlBhZ2U6OnNldFZpZXcpOgorCiAyMDA5LTA5LTIyICBKb2NlbHluIFR1cmNvdHRlICA8am9j ZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1 c21hbm4uCkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAkocmV2aXNpb24gNDg2NjkpCisrKyBXZWJLaXQvcXQv QXBpL3F3ZWJwYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU1NSw4ICsxNTU1LDEwIEBAIFFX ZWJIaXN0b3J5ICpRV2ViUGFnZTo6aGlzdG9yeSgpIGNvbnN0CiAqLwogdm9pZCBRV2ViUGFnZTo6 c2V0VmlldyhRV2lkZ2V0ICp2aWV3KQogewotICAgIGQtPnZpZXcgPSB2aWV3OwotICAgIHNldFZp ZXdwb3J0U2l6ZSh2aWV3ID8gdmlldy0+c2l6ZSgpIDogUVNpemUoMCwgMCkpOworICAgIGlmIChk LT52aWV3ICE9IHZpZXcpIHsKKyAgICAgICAgZC0+dmlldyA9IHZpZXc7CisgICAgICAgIHNldFZp ZXdwb3J0U2l6ZSh2aWV3ID8gdmlldy0+c2l6ZSgpIDogUVNpemUoMCwgMCkpOworICAgIH0KIH0K IAogLyohCg==