<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>296550</bug_id>
          
          <creation_ts>2025-07-27 20:53:58 -0700</creation_ts>
          <short_desc>RenderThemeCocoa.mm error: no matching function for call to &apos;floorToDevicePixel&apos;</short_desc>
          <delta_ts>2025-07-27 23:41:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>296522</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gerald Squelart">g_squelart</reporter>
          <assigned_to name="Gerald Squelart">g_squelart</assigned_to>
          <cc>koivisto</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2132781</commentid>
    <comment_count>0</comment_count>
    <who name="Gerald Squelart">g_squelart</who>
    <bug_when>2025-07-27 20:53:58 -0700</bug_when>
    <thetext>In file included from DerivedSources/WebCore/unified-sources/UnifiedSource54-mm.mm:2:
Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:130:26: error: no matching function for call to &apos;floorToDevicePixel&apos;
  130 |     auto outlineOffset = floorToDevicePixel(box.style().outlineOffset(), deviceScaleFactor);
      |                          ^~~~~~~~~~~~~~~~~~
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource54-mm.mm:1:
In file included from Source/WebCore/rendering/AttachmentLayout.mm:27:
In file included from Source/WebCore/rendering/AttachmentLayout.h:30:
In file included from Source/WebCore/platform/graphics/FloatRect.h:30:
In file included from Source/WebCore/platform/LengthBox.h:24:
In file included from Source/WebCore/platform/BoxExtents.h:28:
Source/WebCore/platform/LayoutUnit.h:652:14: note: candidate function not viable: no known conversion from &apos;Style::Length&lt;&gt;&apos; to &apos;LayoutUnit&apos; for 1st argument
  652 | inline float floorToDevicePixel(LayoutUnit value, float pixelSnappingFactor)
      |              ^                  ~~~~~~~~~~~~~~~~
Source/WebCore/platform/LayoutUnit.h:664:14: note: candidate function not viable: no known conversion from &apos;Style::Length&lt;&gt;&apos; to &apos;float&apos; for 1st argument
  664 | inline float floorToDevicePixel(float value, float pixelSnappingFactor) { return floorToDevicePixel(LayoutUnit(value), pixelSnappingFactor); }
      |              ^                  ~~~~~~~~~~~

Probably due to https://bugs.webkit.org/show_bug.cgi?id=296522

rdar://156874446</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2132782</commentid>
    <comment_count>1</comment_count>
    <who name="Gerald Squelart">g_squelart</who>
    <bug_when>2025-07-27 20:58:12 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/48588</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2132795</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-07-27 23:41:29 -0700</bug_when>
    <thetext>Committed 297912@main (99b502816d9a): &lt;https://commits.webkit.org/297912@main&gt;

Reviewed commits have been landed. Closing PR #48588 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>