29652 2009-09-22 14:17:50 -0700 RenderThemeChromiumWin should use true system colors for CSS system colors 2009-09-22 15:05:40 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 pkasting pkasting oldest_to_newest 149183 0 pkasting 2009-09-22 14:17:50 -0700 Right now we fall back to the default hardcoded values in RenderTheme. This means that e.g. the search buttons on google.com (which have recently changed to using CSS system colors) are illegible in white-on-black system themes. RenderThemeWin.cpp has some appropriate-looking code, so the fix is easy: copy it. 149184 1 39944 pkasting 2009-09-22 14:19:13 -0700 Created attachment 39944 patch v1 149200 2 39944 levin 2009-09-22 14:41:35 -0700 Comment on attachment 39944 patch v1 Two minor nits to fix up on landing. > Index: WebCore/rendering/RenderThemeChromiumWin.cpp > =================================================================== > +// Map a CSSValue* system color to an index understood by GetSysColor Please add a period to the end of the sentence. > +static int cssValueIdToSysColorIndex(int cssValueId) > +{ > + switch (cssValueId) { > + case CSSValueActiveborder: return COLOR_ACTIVEBORDER; A case label should line up with its switch statement (see http://webkit.org/coding/coding-style.html) 149206 3 39944 eric 2009-09-22 14:53:35 -0700 Comment on attachment 39944 patch v1 Looks sane to me too. Dave just beat me! 149214 4 pkasting 2009-09-22 15:05:40 -0700 Both comments addressed and patch landed in r48652. 39944 2009-09-22 14:19:13 -0700 2009-09-22 14:53:35 -0700 patch v1 patch text/plain 4038 pkasting SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ4NjUwKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOS0yMiAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdv b2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NjUyCisgICAgICAg IFN1cHBvcnQgdHJ1ZSBzeXN0ZW0gY29sb3JzIGZvciBDU1Mgc3lzdGVtIGNvbG9ycyBpbiBDaHJv bWl1bS9XaW4uCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NWYWx1ZUlkVG9TeXNDb2xvckluZGV4KToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1XaW46OnN5c3RlbUNvbG9yKToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5oOgorCiAyMDA5LTA5LTIyICBC ZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZl IEh5YXR0LgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5j cHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVt V2luLmNwcAkocmV2aXNpb24gNDg1NDEpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZUNocm9taXVtV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzExLDYgKzMxMSw1MiBAQCB2b2lk IFJlbmRlclRoZW1lQ2hyb21pdW1XaW46OnN5c3RlbUZvbnQoCiAgICAgZm9udERlc2NyaXB0aW9u ID0gKmNhY2hlZERlc2M7CiB9CiAKKy8vIE1hcCBhIENTU1ZhbHVlKiBzeXN0ZW0gY29sb3IgdG8g YW4gaW5kZXggdW5kZXJzdG9vZCBieSBHZXRTeXNDb2xvcg0KK3N0YXRpYyBpbnQgY3NzVmFsdWVJ ZFRvU3lzQ29sb3JJbmRleChpbnQgY3NzVmFsdWVJZCkNCit7DQorICAgIHN3aXRjaCAoY3NzVmFs dWVJZCkgew0KKyAgICAgICAgY2FzZSBDU1NWYWx1ZUFjdGl2ZWJvcmRlcjogcmV0dXJuIENPTE9S X0FDVElWRUJPUkRFUjsNCisgICAgICAgIGNhc2UgQ1NTVmFsdWVBY3RpdmVjYXB0aW9uOiByZXR1 cm4gQ09MT1JfQUNUSVZFQ0FQVElPTjsNCisgICAgICAgIGNhc2UgQ1NTVmFsdWVBcHB3b3Jrc3Bh Y2U6IHJldHVybiBDT0xPUl9BUFBXT1JLU1BBQ0U7DQorICAgICAgICBjYXNlIENTU1ZhbHVlQmFj a2dyb3VuZDogcmV0dXJuIENPTE9SX0JBQ0tHUk9VTkQ7DQorICAgICAgICBjYXNlIENTU1ZhbHVl QnV0dG9uZmFjZTogcmV0dXJuIENPTE9SX0JUTkZBQ0U7DQorICAgICAgICBjYXNlIENTU1ZhbHVl QnV0dG9uaGlnaGxpZ2h0OiByZXR1cm4gQ09MT1JfQlROSElHSExJR0hUOw0KKyAgICAgICAgY2Fz ZSBDU1NWYWx1ZUJ1dHRvbnNoYWRvdzogcmV0dXJuIENPTE9SX0JUTlNIQURPVzsNCisgICAgICAg IGNhc2UgQ1NTVmFsdWVCdXR0b250ZXh0OiByZXR1cm4gQ09MT1JfQlROVEVYVDsNCisgICAgICAg IGNhc2UgQ1NTVmFsdWVDYXB0aW9udGV4dDogcmV0dXJuIENPTE9SX0NBUFRJT05URVhUOw0KKyAg ICAgICAgY2FzZSBDU1NWYWx1ZUdyYXl0ZXh0OiByZXR1cm4gQ09MT1JfR1JBWVRFWFQ7DQorICAg ICAgICBjYXNlIENTU1ZhbHVlSGlnaGxpZ2h0OiByZXR1cm4gQ09MT1JfSElHSExJR0hUOw0KKyAg ICAgICAgY2FzZSBDU1NWYWx1ZUhpZ2hsaWdodHRleHQ6IHJldHVybiBDT0xPUl9ISUdITElHSFRU RVhUOw0KKyAgICAgICAgY2FzZSBDU1NWYWx1ZUluYWN0aXZlYm9yZGVyOiByZXR1cm4gQ09MT1Jf SU5BQ1RJVkVCT1JERVI7DQorICAgICAgICBjYXNlIENTU1ZhbHVlSW5hY3RpdmVjYXB0aW9uOiBy ZXR1cm4gQ09MT1JfSU5BQ1RJVkVDQVBUSU9OOw0KKyAgICAgICAgY2FzZSBDU1NWYWx1ZUluYWN0 aXZlY2FwdGlvbnRleHQ6IHJldHVybiBDT0xPUl9JTkFDVElWRUNBUFRJT05URVhUOw0KKyAgICAg ICAgY2FzZSBDU1NWYWx1ZUluZm9iYWNrZ3JvdW5kOiByZXR1cm4gQ09MT1JfSU5GT0JLOw0KKyAg ICAgICAgY2FzZSBDU1NWYWx1ZUluZm90ZXh0OiByZXR1cm4gQ09MT1JfSU5GT1RFWFQ7DQorICAg ICAgICBjYXNlIENTU1ZhbHVlTWVudTogcmV0dXJuIENPTE9SX01FTlU7DQorICAgICAgICBjYXNl IENTU1ZhbHVlTWVudXRleHQ6IHJldHVybiBDT0xPUl9NRU5VVEVYVDsNCisgICAgICAgIGNhc2Ug Q1NTVmFsdWVTY3JvbGxiYXI6IHJldHVybiBDT0xPUl9TQ1JPTExCQVI7DQorICAgICAgICBjYXNl IENTU1ZhbHVlVGhyZWVkZGFya3NoYWRvdzogcmV0dXJuIENPTE9SXzNEREtTSEFET1c7DQorICAg ICAgICBjYXNlIENTU1ZhbHVlVGhyZWVkZmFjZTogcmV0dXJuIENPTE9SXzNERkFDRTsNCisgICAg ICAgIGNhc2UgQ1NTVmFsdWVUaHJlZWRoaWdobGlnaHQ6IHJldHVybiBDT0xPUl8zREhJR0hMSUdI VDsNCisgICAgICAgIGNhc2UgQ1NTVmFsdWVUaHJlZWRsaWdodHNoYWRvdzogcmV0dXJuIENPTE9S XzNETElHSFQ7DQorICAgICAgICBjYXNlIENTU1ZhbHVlVGhyZWVkc2hhZG93OiByZXR1cm4gQ09M T1JfM0RTSEFET1c7DQorICAgICAgICBjYXNlIENTU1ZhbHVlV2luZG93OiByZXR1cm4gQ09MT1Jf V0lORE9XOw0KKyAgICAgICAgY2FzZSBDU1NWYWx1ZVdpbmRvd2ZyYW1lOiByZXR1cm4gQ09MT1Jf V0lORE9XRlJBTUU7DQorICAgICAgICBjYXNlIENTU1ZhbHVlV2luZG93dGV4dDogcmV0dXJuIENP TE9SX1dJTkRPV1RFWFQ7DQorICAgICAgICBkZWZhdWx0OiByZXR1cm4gLTE7IC8vIFVuc3VwcG9y dGVkIENTU1ZhbHVlDQorICAgIH0NCit9DQorDQorQ29sb3IgUmVuZGVyVGhlbWVDaHJvbWl1bVdp bjo6c3lzdGVtQ29sb3IoaW50IGNzc1ZhbHVlSWQpIGNvbnN0DQorew0KKyAgICBpbnQgc3lzQ29s b3JJbmRleCA9IGNzc1ZhbHVlSWRUb1N5c0NvbG9ySW5kZXgoY3NzVmFsdWVJZCk7DQorICAgIGlm IChDaHJvbWl1bUJyaWRnZTo6bGF5b3V0VGVzdE1vZGUoKSB8fCAoc3lzQ29sb3JJbmRleCA9PSAt MSkpDQorICAgICAgICByZXR1cm4gUmVuZGVyVGhlbWU6OnN5c3RlbUNvbG9yKGNzc1ZhbHVlSWQp Ow0KKw0KKyAgICBDT0xPUlJFRiBjb2xvciA9IEdldFN5c0NvbG9yKHN5c0NvbG9ySW5kZXgpOw0K KyAgICByZXR1cm4gQ29sb3IoR2V0UlZhbHVlKGNvbG9yKSwgR2V0R1ZhbHVlKGNvbG9yKSwgR2V0 QlZhbHVlKGNvbG9yKSk7DQorfQ0KKw0KIHZvaWQgUmVuZGVyVGhlbWVDaHJvbWl1bVdpbjo6YWRq dXN0U2xpZGVyVGh1bWJTaXplKFJlbmRlck9iamVjdCogbykgY29uc3QKIHsKICAgICAvLyBUaGVz ZSBzaXplcyBtYXRjaCB3aGF0IFdpblhQIGRyYXdzIGZvciB2YXJpb3VzIG1lbnVzLgpJbmRleDog V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5oDQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQot LS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVdpbi5oCShyZXZpc2lvbiA0 ODU0MSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1XaW4uaAkod29y a2luZyBjb3B5KQpAQCAtNTksNiArNTksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAg ICAgLy8gU3lzdGVtIGZvbnRzLgogICAgICAgICB2aXJ0dWFsIHZvaWQgc3lzdGVtRm9udChpbnQg cHJvcElkLCBGb250RGVzY3JpcHRpb24mKSBjb25zdDsKKyAgICAgICAgdmlydHVhbCBDb2xvciBz eXN0ZW1Db2xvcihpbnQgY3NzVmFsdWVJZCkgY29uc3Q7DQogCiAgICAgICAgIHZpcnR1YWwgdm9p ZCBhZGp1c3RTbGlkZXJUaHVtYlNpemUoUmVuZGVyT2JqZWN0KikgY29uc3Q7CiAK