29648 2009-09-22 11:39:30 -0700 white-space: nowrap inline element beside a floated element wraps incorrectly without trailing textnode/newline 2012-10-30 12:13:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 retchless robert eric leviw mitz pmuellr robert webkit.review.bot oldest_to_newest 149138 0 retchless 2009-09-22 11:39:30 -0700 I've recently run into an issue with white-space: nowrap which is reproducible with the latest WebKit nightly. Broken: <div style="width: 200px; overflow: hidden"> <div style="float: left; width: 50px; height: 50px; background-color: red"></div> <span style="white-space: nowrap">Some long string that wraps</span></div><!-- </div> not on next line on purpose - triggers bug --> Works: <div style="width: 200px; overflow: hidden"> <div style="float: left; width: 50px; height: 50px; background-color: red"></div> <span style="white-space: nowrap">Some long string that wraps</span><!-- text node (space or newline) here fixes the bug --> </div> Essentially, the white-space: nowrap span (or any inline element) should wrap below the float: left block if it doesn't fit, and should only spill out of its parent if it doesn't fit within the width of its parent after wrapping. Adding a space or newline after the white-space: nowrap span causes it to behave correctly. Note: Overflow hidden on the parent is not necessary, but it makes this scenario clearer. 149148 1 pmuellr 2009-09-22 12:26:01 -0700 This appears to behave the same in Safari 4.0.3 as well. 752732 2 171084 robert 2012-10-27 01:39:05 -0700 Created attachment 171084 Patch 752742 3 171084 leviw 2012-10-27 01:51:38 -0700 Comment on attachment 171084 Patch LGTM. A link to the bug in the ref test would be nice :) 754565 4 171084 webkit.review.bot 2012-10-30 12:13:17 -0700 Comment on attachment 171084 Patch Clearing flags on attachment: 171084 Committed r132935: <http://trac.webkit.org/changeset/132935> 754566 5 webkit.review.bot 2012-10-30 12:13:21 -0700 All reviewed patches have been landed. Closing bug. 171084 2012-10-27 01:39:05 -0700 2012-10-30 12:13:17 -0700 Patch bug-29648-20121027093732.patch text/plain 6106 robert U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmEzM2FmZjFkMWFmYjVi NDRjZmY2N2NmMmExODg1Y2MxMWQ4ZTZiMC4uNDdmYjc1OWMzODc3NDE1MDZhNWFkZGE2OGY5MDg0 NGRiM2Q0OGRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTI1ICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICB3aGl0ZS1zcGFjZTogbm93 cmFwIGlubGluZSBlbGVtZW50IGJlc2lkZSBhIGZsb2F0ZWQgZWxlbWVudCB3cmFwcyBpbmNvcnJl Y3RseSB3aXRob3V0IHRyYWlsaW5nIHRleHRub2RlL25ld2xpbmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBuby13cmFwIGNoaWxkIG9uIGEgbGluZSBp bnNpZGUgYW4gYXV0b3dyYXAgY29udGFpbmVyIHNob3VsZCBtb3ZlIHRvIHRoZSBuZXh0IGxpbmUg aWYgYSBmbG9hdCBkb2Vzbid0IGFsbG93CisgICAgICAgIGl0IHRvIGZpdC4gVGhpcyB3aWxsIGhh cHBlbiBpZiB0aGVyZSBpcyB0cmFpbGluZyBzcGFjZSBhZnRlciB0aGUgbm8td3JhcCBjaGlsZCBi dXQgbm90IGlmIGl0J3MgdGhlIGxhc3QgcmVuZGVyZXIKKyAgICAgICAgb24gdGhlIGxpbmUuIFRo aXMgaXMgYmVjYXVzZSBuZXh0TGluZUJyZWFrKCkgaXMgb25seSBpbnRlcmVzdGVkIGluIHRoZSB3 aGl0ZS1zcGFjZSBzdHlsZSBvZiB0aGUgY3VycmVudCByZW5kZXJlciAKKyAgICAgICAgYW5kIHRo ZSByZW5kZXJlcidzIG5leHQgc2libGluZyAoaWYgdGhlcmUgaXMgb25lKSB3aGVuIGRlY2lkaW5n IHdoZXRoZXIgaXQgbmVlZHMgdG8gZml0IGJlbG93IGFueSBmbG9hdHMgdGhhdAorICAgICAgICBw dXNoIGl0IGJleW9uZCB0aGUgZWRnZSBvZiB0aGUgY29udGFpbmVyLiBUaGVyZSBpc24ndCBhbnkg c2l0dWF0aW9uIGluIHdoaWNoIGEgbm8td3JhcCBjaGlsZCBzaG91bGRuJ3QgbW92ZSAKKyAgICAg ICAgYmVsb3cgYSBmbG9hdCBvbiBhbiBhdXRvLXdyYXAgbGluZSB0aG91Z2gsIHNvIHRoaXMgY2hl Y2sgYWx3YXlzIG5lZWRzIHRvIHJlc3BlY3QgdGhlIGNvbnRhaW5lcidzIHdoaXRlLXNwYWNlIHN0 eWxlIHRvby4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvd2hpdGVzcGFjZS9uby13cmFwLWNo aWxkLWluLWF1dG8td3JhcC1jb250YWluZXIuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6 TGluZUJyZWFrZXI6Om5leHRMaW5lQnJlYWspOgorCiAyMDEyLTEwLTA5ICBSb2JlcnQgSG9nYW4g IDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZWRyYXdpbmcgaXNzdWUgd2l0aCBpbnNl cnRpbmcgbmV3IGlubGluZSBlbGVtZW50IGJldHdlZW4gZXhpc3RpbmcgaW5saW5lIGVsZW1lbnRz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQu Y3BwCmluZGV4IDc1NmEzYzMxZWMzYjM3MzE3YjBmNGI2ZWM0OGI4MDZlMmU4ZmUwZmUuLjEyYzU4 YWY5Mzk1MmI3Mjg0ODZlZjJmNjU0MjFhMDg5ODgzMjJmYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCkBAIC0yODE1LDcgKzI4 MTUsNyBAQCBJbmxpbmVJdGVyYXRvciBSZW5kZXJCbG9jazo6TGluZUJyZWFrZXI6Om5leHRMaW5l QnJlYWsoSW5saW5lQmlkaVJlc29sdmVyJiByZXNvbAogICAgICAgICB9IGVsc2UKICAgICAgICAg ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogCi0gICAgICAgIGJvb2wgY2hlY2tGb3JCcmVhayA9 IGF1dG9XcmFwOworICAgICAgICBib29sIGNoZWNrRm9yQnJlYWsgPSBhdXRvV3JhcCB8fCBibG9j a1N0eWxlLT5hdXRvV3JhcCgpOwogICAgICAgICBpZiAod2lkdGguY29tbWl0dGVkV2lkdGgoKSAm JiAhd2lkdGguZml0c09uTGluZSgpICYmIGxCcmVhay5tX29iaiAmJiBjdXJyV1MgPT0gTk9XUkFQ KQogICAgICAgICAgICAgY2hlY2tGb3JCcmVhayA9IHRydWU7CiAgICAgICAgIGVsc2UgaWYgKG5l eHQgJiYgY3VycmVudC5tX29iai0+aXNUZXh0KCkgJiYgbmV4dC0+aXNUZXh0KCkgJiYgIW5leHQt PmlzQlIoKSAmJiAoYXV0b1dyYXAgfHwgKG5leHQtPnN0eWxlKCktPmF1dG9XcmFwKCkpKSkgewpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDhiZmQ3ZTlkMDAxZmYzOTBjMDVlNmFjYTM0NTQ1ZWVkOTI0NjQ4YWYuLmVmMzYwZmNi ZGNkN2Q2NzY3OWZkZTg1ZGEzYzhiOWU4NmQ5NDU5NWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxMi0xMC0yNSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAg d2hpdGUtc3BhY2U6IG5vd3JhcCBpbmxpbmUgZWxlbWVudCBiZXNpZGUgYSBmbG9hdGVkIGVsZW1l bnQgd3JhcHMgaW5jb3JyZWN0bHkgd2l0aG91dCB0cmFpbGluZyB0ZXh0bm9kZS9uZXdsaW5lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTY0OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC90ZXh0 L3doaXRlc3BhY2Uvbm8td3JhcC1jaGlsZC1pbi1hdXRvLXdyYXAtY29udGFpbmVyLWV4cGVjdGVk Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC93aGl0ZXNwYWNlL25vLXdyYXAtY2hp bGQtaW4tYXV0by13cmFwLWNvbnRhaW5lci5odG1sOiBBZGRlZC4KKwogMjAxMi0xMC0wOSAgUm9i ZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVkcmF3aW5nIGlzc3Vl IHdpdGggaW5zZXJ0aW5nIG5ldyBpbmxpbmUgZWxlbWVudCBiZXR3ZWVuIGV4aXN0aW5nIGlubGlu ZSBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3doaXRlc3BhY2Uv bm8td3JhcC1jaGlsZC1pbi1hdXRvLXdyYXAtY29udGFpbmVyLWV4cGVjdGVkLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L3RleHQvd2hpdGVzcGFjZS9uby13cmFwLWNoaWxkLWluLWF1dG8td3JhcC1j b250YWluZXItZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45ZWE3M2NiNjg4NWE4ZGJjNjY2OGU2 M2YwY2JmMzg3OGQzZTI5ZjRlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90 ZXh0L3doaXRlc3BhY2Uvbm8td3JhcC1jaGlsZC1pbi1hdXRvLXdyYXAtY29udGFpbmVyLWV4cGVj dGVkLmh0bWwKQEAgLTAsMCArMSwzMyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8 aGVhZD4KKyAgICAgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyAgICAgICAgICAgICNjb250 YWluZXIgeworICAgICAgICAgICAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgICAgICNmbG9hdCB7CisgICAgICAgICAgICAgICAgZmxvYXQ6IGxlZnQ7CisgICAgICAg ICAgICAgICAgaGVpZ2h0OjUwcHg7CisgICAgICAgICAgICAgICAgd2lkdGg6IDUwcHg7CisgICAg ICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjpyZWQ7CisgICAgICAgICAgICB9CisgICAgICAg ICAgICAjbm93cmFwIHsKKyAgICAgICAgICAgICAgICB3aGl0ZS1zcGFjZTogbm93cmFwOworICAg ICAgICAgICAgfQorICAgICAgICAgPC9zdHlsZT4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHk+Cisg ICAgICAgIEEgbm8td3JhcCBjaGlsZCB0aGF0IGRvZXMgbm90IGZpdCBvbiBhbiBhdXRvd3JhcCBs aW5lIHNob3VsZCBzaGlmdCBkb3duIGV2ZW4gd2hlbiB0aGVyZQorICAgICAgICBpcyBubyB3aGl0 ZXNwYWNlIGFmdGVyIHRoZSBuby13cmFwIGNoaWxkLgorICAgICAgICA8ZGl2IGlkPSJjb250YWlu ZXIiPgorICAgICAgICAgICAgPGRpdiBpZD0iZmxvYXQiPjwvZGl2PgorICAgICAgICAgICAgPHNw YW4gaWQ9Im5vd3JhcCI+VGhpcyB0ZXh0IHNob3VsZCBiZSB1bmRlciB0aGUgcmVkIHNxdWFyZS48 L3NwYW4+CisgICAgICAgIDwvZGl2PgorICAgICAgICA8YnI+CisgICAgICAgIDxkaXYgaWQ9ImNv bnRhaW5lciBub3dyYXAiPgorICAgICAgICAgICAgPGRpdiBpZD0iZmxvYXQiPjwvZGl2PgorICAg ICAgICAgICAgPHNwYW4gaWQ9Im5vd3JhcCI+VGhpcyB0ZXh0IHNob3VsZCBiZSB0byB0aGUgcmln aHQgb2YgdGhlIHJlZCBzcXVhcmUuPC9zcGFuPgorICAgICAgICA8L2Rpdj4KKyAgICA8L2JvZHk+ Cis8L2h0bWw+CisgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQvd2hpdGVzcGFj ZS9uby13cmFwLWNoaWxkLWluLWF1dG8td3JhcC1jb250YWluZXIuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvdGV4dC93aGl0ZXNwYWNlL25vLXdyYXAtY2hpbGQtaW4tYXV0by13cmFwLWNvbnRhaW5l ci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjU0NWU3ODY2YTQyZDQxMGUxYzQzMDI3Y2FiYWFkN2Q3NGU1NTAx NTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvd2hpdGVzcGFjZS9u by13cmFwLWNoaWxkLWluLWF1dG8td3JhcC1jb250YWluZXIuaHRtbApAQCAtMCwwICsxLDMyIEBA Cis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c3R5bGUgdHlw ZT0idGV4dC9jc3MiPgorICAgICAgICAgICAgI2NvbnRhaW5lciB7CisgICAgICAgICAgICAgICAg d2lkdGg6IDIwMHB4OworICAgICAgICAgICAgfQorICAgICAgICAgICAgI2Zsb2F0IHsKKyAgICAg ICAgICAgICAgICBmbG9hdDogbGVmdDsKKyAgICAgICAgICAgICAgICBoZWlnaHQ6NTBweDsKKyAg ICAgICAgICAgICAgICB3aWR0aDogNTBweDsKKyAgICAgICAgICAgICAgICBiYWNrZ3JvdW5kLWNv bG9yOnJlZDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgICNub3dyYXAgeworICAgICAgICAg ICAgICAgIHdoaXRlLXNwYWNlOiBub3dyYXA7CisgICAgICAgICAgICB9CisgICAgICAgICA8L3N0 eWxlPgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICAgICAgQSBuby13cmFwIGNoaWxkIHRo YXQgZG9lcyBub3QgZml0IG9uIGFuIGF1dG93cmFwIGxpbmUgc2hvdWxkIHNoaWZ0IGRvd24gZXZl biB3aGVuIHRoZXJlCisgICAgICAgIGlzIG5vIHdoaXRlc3BhY2UgYWZ0ZXIgdGhlIG5vLXdyYXAg Y2hpbGQuCisgICAgICAgIDwhLS0gVGhlIGxhY2sgb2Ygd2hpdGVzcGFjZSBiZXR3ZWVuIDwvc3Bh bj4gYW5kIDwvZGl2PiBpbiB0aGlzIGNhc2UgYmVsb3cgd2FzIHByZXZlbnRpbmcgV2ViS2l0IGZy b20gbW92aW5nIHRoZSBsaW5lIGRvd24gYmVuZWF0aCB0aGUgZmxvYXQgLS0+CisgICAgICAgIDxk aXYgaWQ9ImNvbnRhaW5lciI+CisgICAgICAgICAgICA8ZGl2IGlkPSJmbG9hdCI+PC9kaXY+Cisg ICAgICAgICAgICA8c3BhbiBpZD0ibm93cmFwIj5UaGlzIHRleHQgc2hvdWxkIGJlIHVuZGVyIHRo ZSByZWQgc3F1YXJlLjwvc3Bhbj48L2Rpdj4KKyAgICAgICAgPGJyPgorICAgICAgICA8ZGl2IGlk PSJjb250YWluZXIgbm93cmFwIj4KKyAgICAgICAgICAgIDxkaXYgaWQ9ImZsb2F0Ij48L2Rpdj4K KyAgICAgICAgICAgIDxzcGFuIGlkPSJub3dyYXAiPlRoaXMgdGV4dCBzaG91bGQgYmUgdG8gdGhl IHJpZ2h0IG9mIHRoZSByZWQgc3F1YXJlLjwvc3Bhbj48L2Rpdj4KKyAgICA8L2JvZHk+Cis8L2h0 bWw+CisgCg==