29613 2009-09-21 14:15:02 -0700 Web Inspector: Evaluating on call frame always returns "undefined" 2009-09-21 14:37:29 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman yurys timothy yurys oldest_to_newest 148821 0 pfeldman 2009-09-21 14:15:02 -0700 1. Stop on a breakpoint 2. Evaluate "1" Expected: 1 Actual: undefined For some reason evaluation on call frame went different path than evaluating against window. Will use same control flow after the patch. 148824 1 39875 pfeldman 2009-09-21 14:17:26 -0700 Created attachment 39875 patch 148832 2 pfeldman 2009-09-21 14:37:29 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r48603 39875 2009-09-21 14:17:26 -0700 2009-09-21 14:22:12 -0700 patch eval_call_frame text/plain 3601 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTRhOTQxZS4uNTVlZWNmZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBFdmFsdWF0aW5nIG9uIGNh bGwgZnJhbWUgYWx3YXlzIHJldHVybnMgInVuZGVmaW5lZCIuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NjEzCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQu ZXZhbHVhdGUpOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuX2V2YWx1YXRlQW5kV3JhcCk6Cisg ICAgICAgIChJbmplY3RlZFNjcmlwdC5fZXZhbHVhdGVPbik6CisgICAgICAgIChJbmplY3RlZFNj cmlwdC5ldmFsdWF0ZUluQ2FsbEZyYW1lKToKKworMjAwOS0wOS0yMSAgUGF2ZWwgRmVsZG1hbiAg PHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhh dGNoZXIuCisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRXhjZXB0aW9uIGZvcm1hdHRpbmcgaXMg YnJva2VuIGluIGNvbnNvbGUuCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI5NjA4CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0 ZWRTY3JpcHQuanMKaW5kZXggYmEzODM4NS4uNGQ5NmY2OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwpAQCAtNTE1LDI2ICs1MTUsMjAgQEAgSW5q ZWN0ZWRTY3JpcHQuZ2V0Q29tcGxldGlvbnMgPSBmdW5jdGlvbihleHByZXNzaW9uLCBpbmNsdWRl SW5zcGVjdG9yQ29tbWFuZExpbmUKICAgICByZXR1cm4gcHJvcHM7CiB9CiAKLQogSW5qZWN0ZWRT Y3JpcHQuZXZhbHVhdGUgPSBmdW5jdGlvbihleHByZXNzaW9uKQogeworICAgIHJldHVybiBJbmpl Y3RlZFNjcmlwdC5fZXZhbHVhdGVBbmRXcmFwKEluamVjdGVkU2NyaXB0Ll93aW5kb3coKS5ldmFs LCBJbmplY3RlZFNjcmlwdC5fd2luZG93KCksIGV4cHJlc3Npb24pOworfQorCitJbmplY3RlZFNj cmlwdC5fZXZhbHVhdGVBbmRXcmFwID0gZnVuY3Rpb24oZXZhbEZ1bmN0aW9uLCBvYmplY3QsIGV4 cHJlc3Npb24pCit7CiAgICAgdmFyIHJlc3VsdCA9IHt9OwogICAgIHRyeSB7Ci0gICAgICAgIHZh ciB2YWx1ZSA9IEluamVjdGVkU2NyaXB0Ll9ldmFsdWF0ZU9uKEluamVjdGVkU2NyaXB0Ll93aW5k b3coKS5ldmFsLCBJbmplY3RlZFNjcmlwdC5fd2luZG93KCksIGV4cHJlc3Npb24pOwotICAgICAg ICBpZiAodmFsdWUgPT09IG51bGwpCi0gICAgICAgICAgICByZXR1cm4geyB2YWx1ZTogbnVsbCB9 OwotICAgICAgICBpZiAoT2JqZWN0LnR5cGUodmFsdWUpID09PSAiZXJyb3IiKSB7Ci0gICAgICAg ICAgICByZXN1bHQudmFsdWUgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBPYmplY3QodmFsdWUp OworICAgICAgICByZXN1bHQudmFsdWUgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBPYmplY3Qo SW5qZWN0ZWRTY3JpcHQuX2V2YWx1YXRlT24oZXZhbEZ1bmN0aW9uLCBvYmplY3QsIGV4cHJlc3Np b24pKTsKKyAgICAgICAgLy8gSGFuZGxlIGVycm9yIHRoYXQgbWlnaHQgaGF2ZSBoYXBwZW5lZCB3 aGlsZSBkZXNjcmliaW5nIHJlc3VsdC4KKyAgICAgICAgaWYgKHJlc3VsdC52YWx1ZS5lcnJvclRl eHQpIHsKKyAgICAgICAgICAgIHJlc3VsdC52YWx1ZSA9IEluc3BlY3RvckNvbnRyb2xsZXIud3Jh cE9iamVjdChyZXN1bHQudmFsdWUuZXJyb3JUZXh0KTsKICAgICAgICAgICAgIHJlc3VsdC5pc0V4 Y2VwdGlvbiA9IHRydWU7Ci0gICAgICAgICAgICByZXR1cm4gcmVzdWx0OwotICAgICAgICB9Ci0K LSAgICAgICAgdmFyIHdyYXBwZXIgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBPYmplY3QodmFs dWUpOwotICAgICAgICBpZiAod3JhcHBlci5lcnJvclRleHQpIHsKLSAgICAgICAgICAgIHJlc3Vs dC52YWx1ZSA9IEluc3BlY3RvckNvbnRyb2xsZXIud3JhcE9iamVjdCh3cmFwcGVyLmVycm9yVGV4 dCk7Ci0gICAgICAgICAgICByZXN1bHQuaXNFeGNlcHRpb24gPSB0cnVlOwotICAgICAgICB9IGVs c2UgewotICAgICAgICAgICAgcmVzdWx0LnZhbHVlID0gd3JhcHBlcjsKICAgICAgICAgfQogICAg IH0gY2F0Y2ggKGUpIHsKICAgICAgICAgcmVzdWx0LnZhbHVlID0gSW5zcGVjdG9yQ29udHJvbGxl ci53cmFwT2JqZWN0KGUudG9TdHJpbmcoKSk7CkBAIC01NDksNyArNTQzLDEzIEBAIEluamVjdGVk U2NyaXB0Ll9ldmFsdWF0ZU9uID0gZnVuY3Rpb24oZXZhbEZ1bmN0aW9uLCBvYmplY3QsIGV4cHJl c3Npb24pCiAgICAgLy8gU3Vycm91bmQgdGhlIGV4cHJlc3Npb24gaW4gd2l0aCBzdGF0ZW1lbnRz IHRvIGluamVjdCBvdXIgY29tbWFuZCBsaW5lIEFQSSBzbyB0aGF0CiAgICAgLy8gdGhlIHdpbmRv dyBvYmplY3QgcHJvcGVydGllcyBzdGlsbCB0YWtlIG1vcmUgcHJlY2VkZW50IHRoYW4gb3VyIEFQ SSBmdW5jdGlvbnMuCiAgICAgZXhwcmVzc2lvbiA9ICJ3aXRoICh3aW5kb3cuX2luc3BlY3RvckNv bW1hbmRMaW5lQVBJKSB7IHdpdGggKHdpbmRvdykgeyAiICsgZXhwcmVzc2lvbiArICIgfSB9IjsK LSAgICByZXR1cm4gZXZhbEZ1bmN0aW9uLmNhbGwob2JqZWN0LCBleHByZXNzaW9uKTsKKyAgICB2 YXIgdmFsdWUgPSBldmFsRnVuY3Rpb24uY2FsbChvYmplY3QsIGV4cHJlc3Npb24pOworCisgICAg Ly8gV2hlbiBldmFsdWF0aW5nIG9uIGNhbGwgZnJhbWUgZXJyb3IgaXMgbm90IHRocm93biwgYnV0 IHJldHVybmVkIGFzIGEgdmFsdWUuCisgICAgaWYgKE9iamVjdC50eXBlKHZhbHVlKSA9PT0gImVy cm9yIikKKyAgICAgICAgdGhyb3cgdmFsdWUudG9TdHJpbmcoKTsKKworICAgIHJldHVybiB2YWx1 ZTsKIH0KIAogSW5qZWN0ZWRTY3JpcHQuYWRkSW5zcGVjdGVkTm9kZSA9IGZ1bmN0aW9uKG5vZGVJ ZCkKQEAgLTgyNiw3ICs4MjYsNyBAQCBJbmplY3RlZFNjcmlwdC5ldmFsdWF0ZUluQ2FsbEZyYW1l ID0gZnVuY3Rpb24oY2FsbEZyYW1lSWQsIGNvZGUpCiAgICAgdmFyIGNhbGxGcmFtZSA9IEluamVj dGVkU2NyaXB0Ll9jYWxsRnJhbWVGb3JJZChjYWxsRnJhbWVJZCk7CiAgICAgaWYgKCFjYWxsRnJh bWUpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gSW5qZWN0ZWRTY3JpcHQuX2V2 YWx1YXRlT24oY2FsbEZyYW1lLmV2YWx1YXRlLCBjYWxsRnJhbWUsIGNvZGUpOworICAgIHJldHVy biBJbmplY3RlZFNjcmlwdC5fZXZhbHVhdGVBbmRXcmFwKGNhbGxGcmFtZS5ldmFsdWF0ZSwgY2Fs bEZyYW1lLCBjb2RlKTsKIH0KIAogSW5qZWN0ZWRTY3JpcHQuX2NhbGxGcmFtZUZvcklkID0gZnVu Y3Rpb24oaWQpCg==