<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>29609</bug_id>
          
          <creation_ts>2009-09-21 13:39:44 -0700</creation_ts>
          <short_desc>[Qt] Build break on windows with Qt 4.5.0.</short_desc>
          <delta_ts>2009-09-21 13:54:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yael">yael</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>148795</commentid>
    <comment_count>0</comment_count>
    <who name="Yael">yael</who>
    <bug_when>2009-09-21 13:39:44 -0700</bug_when>
    <thetext>Build break on windows with Qt 4.5.0. WV_WINDOWS7 is not defined until Qt 4.5.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>148797</commentid>
    <comment_count>1</comment_count>
      <attachid>39871</attachid>
    <who name="Yael">yael</who>
    <bug_when>2009-09-21 13:43:55 -0700</bug_when>
    <thetext>Created attachment 39871
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>148801</commentid>
    <comment_count>2</comment_count>
      <attachid>39871</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-09-21 13:46:43 -0700</bug_when>
    <thetext>Comment on attachment 39871
Patch

r=me, thanks :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>148803</commentid>
    <comment_count>3</comment_count>
      <attachid>39871</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-09-21 13:54:54 -0700</bug_when>
    <thetext>Comment on attachment 39871
Patch

Clearing flags on attachment: 39871

Committed r48597: &lt;http://trac.webkit.org/changeset/48597&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>148804</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-09-21 13:54:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>39871</attachid>
            <date>2009-09-21 13:43:55 -0700</date>
            <delta_ts>2009-09-21 13:54:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>29609.patch</filename>
            <type>text/plain</type>
            <size>1083</size>
            <attacher name="Yael">yael</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNDg1OTIpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMjEgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy
b25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTYwOQorICAg
ICAgICBCdWlsZCBmaXggZm9yIHdpbmRvd3Mgd2hlbiB1c2luZyBRdCA0LjUuMC4KKworICAgICAg
ICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChRV2ViUGFnZTo6dXNlckFnZW50Rm9yVXJs
KToKKwogMjAwOS0wOS0xOSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9r
aWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2Vi
S2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xd2Vi
cGFnZS5jcHAJKHJldmlzaW9uIDQ4NTkyKQorKysgV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAJ
KHdvcmtpbmcgY29weSkKQEAgLTI5MDksOSArMjkwOSwxMSBAQAogICAgICAgICBjYXNlIFFTeXNJ
bmZvOjpXVl9WSVNUQToKICAgICAgICAgICAgIHZlciA9ICJXaW5kb3dzIE5UIDYuMCI7CiAgICAg
ICAgICAgICBicmVhazsKKyNpZiBRVF9WRVJTSU9OID4gMHgwNDA1MDAKICAgICAgICAgY2FzZSBR
U3lzSW5mbzo6V1ZfV0lORE9XUzc6CiAgICAgICAgICAgICB2ZXIgPSAiV2luZG93cyBOVCA2LjEi
OwogICAgICAgICAgICAgYnJlYWs7CisjZW5kaWYKICAgICAgICAgY2FzZSBRU3lzSW5mbzo6V1Zf
Q0U6CiAgICAgICAgICAgICB2ZXIgPSAiV2luZG93cyBDRSI7CiAgICAgICAgICAgICBicmVhazsK
</data>

          </attachment>
      

    </bug>

</bugzilla>