29608 2009-09-21 13:28:02 -0700 Web Inspector: Exception formatting is broken in console 2009-09-21 14:34:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman timothy yurys oldest_to_newest 148786 0 pfeldman 2009-09-21 13:28:02 -0700 1. Open WebInspector 2. Open console 3. Type "qwerty" Expected: ReferenceError: Can't find variable: qwerty (in red) Actual: nothing This is a regression introduced by the "wrap primitive values" change. Now strings with error messages should also be wrapped. 148788 1 39868 pfeldman 2009-09-21 13:29:55 -0700 Created attachment 39868 patch 148831 2 pfeldman 2009-09-21 14:34:18 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/InjectedScript.js Committed r48602 39868 2009-09-21 13:29:55 -0700 2009-09-21 13:38:58 -0700 patch error_format text/plain 2996 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTA1ZjAwNy4uMTRhOTQxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBFeGNlcHRpb24gZm9ybWF0 dGluZyBpcyBicm9rZW4gaW4gY29uc29sZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk2MDgKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvQ29uc29sZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZUNvbW1hbmRS ZXN1bHQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanM6 CisgICAgICAgIChJbmplY3RlZFNjcmlwdC5ldmFsdWF0ZSk6CisgICAgICAgIChJbmplY3RlZFNj cmlwdC5jcmVhdGVQcm94eU9iamVjdCk6CisKKzIwMDktMDktMjEgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRj aGVyLgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnNvbGUgb2JqZWN0IGZvcm1hdHRpbmcg aXMgYnJva2VuLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yOTYwNwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNv bGVWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCmlu ZGV4IDc3MjU3YjQuLmFiZGE0YjUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9Db25zb2xlVmlldy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29u c29sZVZpZXcuanMKQEAgLTkxMSw3ICs5MTEsNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVRleHRN ZXNzYWdlLnByb3RvdHlwZS5fX3Byb3RvX18gPSBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZwog V2ViSW5zcGVjdG9yLkNvbnNvbGVDb21tYW5kUmVzdWx0ID0gZnVuY3Rpb24ocmVzdWx0LCBleGNl cHRpb24sIG9yaWdpbmF0aW5nQ29tbWFuZCkKIHsKICAgICB2YXIgbGV2ZWwgPSAoZXhjZXB0aW9u ID8gV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VMZXZlbC5FcnJvciA6IFdlYklu c3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdlTGV2ZWwuTG9nKTsKLSAgICB2YXIgbWVzc2Fn ZSA9IChleGNlcHRpb24gPyBTdHJpbmcocmVzdWx0KSA6IHJlc3VsdCk7CisgICAgdmFyIG1lc3Nh Z2UgPSByZXN1bHQ7CiAgICAgdmFyIGxpbmUgPSAoZXhjZXB0aW9uID8gcmVzdWx0LmxpbmUgOiAt MSk7CiAgICAgdmFyIHVybCA9IChleGNlcHRpb24gPyByZXN1bHQuc291cmNlVVJMIDogbnVsbCk7 CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlw dC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwppbmRl eCAyYjZlNDE5Li5iYTM4Mzg1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0lu amVjdGVkU2NyaXB0LmpzCkBAIC01MjQsMjAgKzUyNCwyMCBAQCBJbmplY3RlZFNjcmlwdC5ldmFs dWF0ZSA9IGZ1bmN0aW9uKGV4cHJlc3Npb24pCiAgICAgICAgIGlmICh2YWx1ZSA9PT0gbnVsbCkK ICAgICAgICAgICAgIHJldHVybiB7IHZhbHVlOiBudWxsIH07CiAgICAgICAgIGlmIChPYmplY3Qu dHlwZSh2YWx1ZSkgPT09ICJlcnJvciIpIHsKLSAgICAgICAgICAgIHJlc3VsdC52YWx1ZSA9IE9i amVjdC5kZXNjcmliZSh2YWx1ZSk7CisgICAgICAgICAgICByZXN1bHQudmFsdWUgPSBJbnNwZWN0 b3JDb250cm9sbGVyLndyYXBPYmplY3QodmFsdWUpOwogICAgICAgICAgICAgcmVzdWx0LmlzRXhj ZXB0aW9uID0gdHJ1ZTsKICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgICAgIH0KIAog ICAgICAgICB2YXIgd3JhcHBlciA9IEluc3BlY3RvckNvbnRyb2xsZXIud3JhcE9iamVjdCh2YWx1 ZSk7Ci0gICAgICAgIGlmICh0eXBlb2Ygd3JhcHBlciA9PT0gIm9iamVjdCIgJiYgd3JhcHBlci5l eGNlcHRpb24pIHsKLSAgICAgICAgICAgIHJlc3VsdC52YWx1ZSA9IHdyYXBwZXIuZXhjZXB0aW9u OworICAgICAgICBpZiAod3JhcHBlci5lcnJvclRleHQpIHsKKyAgICAgICAgICAgIHJlc3VsdC52 YWx1ZSA9IEluc3BlY3RvckNvbnRyb2xsZXIud3JhcE9iamVjdCh3cmFwcGVyLmVycm9yVGV4dCk7 CiAgICAgICAgICAgICByZXN1bHQuaXNFeGNlcHRpb24gPSB0cnVlOwogICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgcmVzdWx0LnZhbHVlID0gd3JhcHBlcjsKICAgICAgICAgfQogICAgIH0g Y2F0Y2ggKGUpIHsKLSAgICAgICAgcmVzdWx0LnZhbHVlID0gZS50b1N0cmluZygpOworICAgICAg ICByZXN1bHQudmFsdWUgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBPYmplY3QoZS50b1N0cmlu ZygpKTsKICAgICAgICAgcmVzdWx0LmlzRXhjZXB0aW9uID0gdHJ1ZTsKICAgICB9CiAgICAgcmV0 dXJuIHJlc3VsdDsKQEAgLTk3Niw3ICs5NzYsNyBAQCBJbmplY3RlZFNjcmlwdC5jcmVhdGVQcm94 eU9iamVjdCA9IGZ1bmN0aW9uKG9iamVjdCwgb2JqZWN0SWQsIGFiYnJldmlhdGUpCiAgICAgdHJ5 IHsKICAgICAgICAgcmVzdWx0LmRlc2NyaXB0aW9uID0gT2JqZWN0LmRlc2NyaWJlKG9iamVjdCwg YWJicmV2aWF0ZSk7CiAgICAgfSBjYXRjaCAoZSkgewotICAgICAgICByZXN1bHQuZXhjZXB0aW9u ID0gZS50b1N0cmluZygpOworICAgICAgICByZXN1bHQuZXJyb3JUZXh0ID0gZS50b1N0cmluZygp OwogICAgIH0KICAgICByZXR1cm4gcmVzdWx0OwogfQo=