29605 2009-09-21 12:57:49 -0700 [Chromium] Fix the V8 bindings' handling of window.top 2009-09-21 14:03:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth commit-queue dglazkov levin oldest_to_newest 148763 0 japhet 2009-09-21 12:57:49 -0700 I introduced a regression in the V8 bindings in http://trac.webkit.org/changeset/47130/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm. We were special casing window.top, since we have disallowing shadowing on it, but it's also marked as replaceable. I believe the solution is: 1. Add back in the special case handling to ensure window.top is not v8::ReadOnly, as this causes a TypeError rather than silently failing. 2. Add in a FIXME to see if we can stop disallowing shadowing at some point in the future. 3. Remove V8ReadOnly from window.top, since in any case other than this that uses Replaceable, V8ReadOnly is redundant. 148773 1 39865 japhet 2009-09-21 13:11:02 -0700 Created attachment 39865 patch After rereading CodeGeneratorV8.pm, I found a usage of V8ReadOnly that I hadn't noticed before, so I won't be doing #3 as I had originally thought. 148774 2 dglazkov 2009-09-21 13:12:08 -0700 Adam is your man here. 148800 3 39865 abarth 2009-09-21 13:46:35 -0700 Comment on attachment 39865 patch We can't allow shadowing of window.top without confusing Flash and other plug-ins. The correct solution here is to convince the JSC port not to mark |top| are replaceable, but that's a longer conversation. In the meantime, we should fix the LayoutTest. If this regression is in stable, we should backport this fix. Thanks for the patch. 148812 4 39865 commit-queue 2009-09-21 14:03:15 -0700 Comment on attachment 39865 patch Clearing flags on attachment: 39865 Committed r48598: <http://trac.webkit.org/changeset/48598> 148813 5 commit-queue 2009-09-21 14:03:20 -0700 All reviewed patches have been landed. Closing bug. 39865 2009-09-21 13:11:02 -0700 2009-09-21 14:03:15 -0700 patch patch.txt text/plain 1610 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ4NTkyKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOS0yMSAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBiYWNrIGluIGEgc3BlY2lhbCBjYXNlIGZvciB3aW5kb3cudG9wIGluIHRoZSBWOCBiaW5k aW5ncy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjk2MDUKKworICAgICAgICBGaXhlcyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93 LXByb3BlcnR5LXNoYWRvd2luZy5odG1sIGluIHRoZSBDaHJvbWl1bSBwb3J0LgorCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IEVuc3VyZSB3aW5kb3cudG9w IGlzIG5vdCBtYXJrZWQgYXMgcmVhZCBvbmx5LCBhcyB0aGlzIGJyZWFrcyB0aGUgc2hhZG93aW5n IGRpc2FibGluZy4KKwogMjAwOS0wOS0yMSAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0NCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBX ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCShyZXZpc2lvbiA0ODU5 MikKKysrIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHdvcmtp bmcgY29weSkKQEAgLTEwMDMsNyArMTAwMywxMiBAQCBzdWIgR2VuZXJhdGVCYXRjaGVkQXR0cmli dXRlRGF0YQogICAgICAgICAjIFJlcGxhY2VhYmxlCiAgICAgICAgIGlmICgkYXR0ckV4dC0+eyJS ZXBsYWNlYWJsZSJ9ICYmICEkaGFzQ3VzdG9tU2V0dGVyKSB7CiAgICAgICAgICAgICAkc2V0dGVy ID0gIjAiOwotICAgICAgICAgICAgJHByb3BBdHRyIC49ICJ8djg6OlJlYWRPbmx5IjsKKyAgICAg ICAgICAgICMgSGFuZGxlIHRoZSBzcGVjaWFsIGNhc2Ugb2Ygd2luZG93LnRvcCBiZWluZyBtYXJr ZWQgYXMgUmVwbGFjZWFibGUuCisgICAgICAgICAgICAjIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0 aGVyIHdlIGNvdWxkIHRyZWF0IHdpbmRvdy50b3AgYXMgcmVwbGFjZWFibGUgCisgICAgICAgICAg ICAjIGFuZCBhbGxvdyBzaGFkb3dpbmcgd2l0aG91dCBpdCBiZWluZyBhIHNlY3VyaXR5IGhvbGUu CisgICAgICAgICAgICBpZiAoISgkaW50ZXJmYWNlTmFtZSBlcSAiRE9NV2luZG93IiBhbmQgJGF0 dHJOYW1lIGVxICJ0b3AiKSkgeyAKKyAgICAgICAgICAgICAgICAkcHJvcEF0dHIgLj0gInx2ODo6 UmVhZE9ubHkiOworICAgICAgICAgICAgfQogICAgICAgICB9CiAKICAgICAgICAgIyBSZWFkIG9u bHkgYXR0cmlidXRlcwo=