29582 2009-09-21 08:47:25 -0700 REGRESSION: [Chromium] drop down selects fail to close when a value is selected 2009-09-21 09:07:14 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd andersca oldest_to_newest 148691 0 fishd 2009-09-21 08:47:25 -0700 REGRESSION: [Chromium] drop down selects fail to close when a value is selected This is a regression from http://trac.webkit.org/changeset/48370 The change to RenderMenuList.cpp causes PopupMenu::hide() to no longer be called. It looks like the Chromium implementation was a bit different than the other ports in its dependency on this. 148707 1 39854 fishd 2009-09-21 08:58:49 -0700 Created attachment 39854 v1 patch 148708 2 39854 dglazkov 2009-09-21 09:01:04 -0700 Comment on attachment 39854 v1 patch r=me. > // Hides the popup. Do not call this directly: use client->hidePopup(). This ain't true no more. 148714 3 fishd 2009-09-21 09:07:14 -0700 Landed as http://trac.webkit.org/changeset/48585 39854 2009-09-21 08:58:49 -0700 2009-09-21 09:01:03 -0700 v1 patch popup_1.txt text/plain 3196 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ4NTgzKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwyNSBAQAorMjAwOS0wOS0yMSAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IERyb3AgZG93biBzZWxlY3RzIGZhaWwgdG8gY2xvc2Ugd2hlbiBhIHZhbHVlIGlzIHNlbGVjdGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTU4Mgor CisgICAgICAgIEltcGxlbWVudCBQb3B1cExpc3RCb3g6OmhpZGVQb3B1cCwgd2hpY2ggd2FzIHBy ZXZpb3VzbHkKKyAgICAgICAgZGVjbGFyZWQgYnV0IHVuaW1wbGVtZW50ZWQuICBSZW1vdmVzIHRo ZSBkZWNsYXJhdGlvbiBvZgorICAgICAgICBzaG93UG9wdXAgc2luY2UgdGhhdCBtZXRob2QgaXMg bm90IGltcGxlbWVudGVkLgorCisgICAgICAgIFBvcHVwTGlzdEJveDo6aGlkZVBvcHVwIHRha2Vz IGNhcmUgb2YgaGlkaW5nIHRoZSBwb3B1cCwKKyAgICAgICAgYnkgaW52b2tpbmcgaGlkZVBvcHVw IG9uIGl0cyBwYXJlbnQgUG9wdXBDb250YWluZXIsIGFuZAorICAgICAgICB0aGVuIGluZm9ybXMg dGhlIFBvcHVwTWVudUNsaWVudCB0aGF0IHBvcHVwRGlkSGlkZS4KKyAgICAgICAgVGhpcyBtaW1p Y3MgdGhlIG9sZCBiZWhhdmlvciBwcmlvciB0byByNDgzNzAuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1 cExpc3RCb3g6OmhhbmRsZUtleUV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJv eDo6YWJhbmRvbik6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cExpc3RCb3g6OmFjY2VwdEluZGV4 KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6aGlkZVBvcHVwKToKKwogMjAwOS0w OS0yMSAgQ3NhYmEgT3N6dHJvZ29uYWMgIDxvc3ppQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAg ICBSdWJiZXItc3RhbXBlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDQ4NTgz KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEwNCw5ICsxMDQsNiBAQCBwdWJsaWM6CiAKICAgICAvLyBQb3B1cExp c3RCb3ggbWV0aG9kcwogCi0gICAgLy8gU2hvd3MgdGhlIHBvcHVwCi0gICAgdm9pZCBzaG93UG9w dXAoKTsKLQogICAgIC8vIEhpZGVzIHRoZSBwb3B1cC4gIERvIG5vdCBjYWxsIHRoaXMgZGlyZWN0 bHk6IHVzZSBjbGllbnQtPmhpZGVQb3B1cCgpLgogICAgIHZvaWQgaGlkZVBvcHVwKCk7CiAKQEAg LTYzNSw3ICs2MzIsNyBAQCBib29sIFBvcHVwTGlzdEJveDo6aGFuZGxlS2V5RXZlbnQoY29uc3Qg CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIGNhc2UgVktFWV9SRVRVUk46CiAgICAgICAgIGlm IChtX3NlbGVjdGVkSW5kZXggPT0gLTEpICB7Ci0gICAgICAgICAgICBtX3BvcHVwQ2xpZW50LT5w b3B1cERpZEhpZGUoKTsKKyAgICAgICAgICAgIGhpZGVQb3B1cCgpOwogICAgICAgICAgICAgLy8g RG9uJ3QgZWF0IHRoZSBlbnRlciBpZiBub3RoaW5nIGlzIHNlbGVjdGVkLgogICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgICAgICB9CkBAIC04NzEsNyArODY4LDcgQEAgdm9pZCBQb3B1cExp c3RCb3g6OmFiYW5kb24oKQogCiAgICAgbV9zZWxlY3RlZEluZGV4ID0gbV9vcmlnaW5hbEluZGV4 OwogCi0gICAgbV9wb3B1cENsaWVudC0+cG9wdXBEaWRIaWRlKCk7CisgICAgaGlkZVBvcHVwKCk7 CiAKICAgICBpZiAobV9hY2NlcHRlZEluZGV4T25BYmFuZG9uID49IDApIHsKICAgICAgICAgbV9w b3B1cENsaWVudC0+dmFsdWVDaGFuZ2VkKG1fYWNjZXB0ZWRJbmRleE9uQWJhbmRvbik7CkBAIC05 MDQsNyArOTAxLDcgQEAgdm9pZCBQb3B1cExpc3RCb3g6OmFjY2VwdEluZGV4KGludCBpbmRleAog ICAgIGlmIChpbmRleCA8IDApIHsKICAgICAgICAgaWYgKG1fcG9wdXBDbGllbnQpIHsKICAgICAg ICAgICAgIC8vIEVudGVyIHByZXNzZWQgd2l0aCBubyBzZWxlY3Rpb24sIGp1c3QgY2xvc2UgdGhl IHBvcHVwLgotICAgICAgICAgICAgbV9wb3B1cENsaWVudC0+cG9wdXBEaWRIaWRlKCk7CisgICAg ICAgICAgICBoaWRlUG9wdXAoKTsKICAgICAgICAgfQogICAgICAgICByZXR1cm47CiAgICAgfQpA QCAtOTEzLDcgKzkxMCw3IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjphY2NlcHRJbmRleChpbnQgaW5k ZXgKICAgICAgICAgUmVmUHRyPFBvcHVwTGlzdEJveD4ga2VlcEFsaXZlKHRoaXMpOwogCiAgICAg ICAgIC8vIEhpZGUgb3Vyc2VsdmVzIGZpcnN0IHNpbmNlIHZhbHVlQ2hhbmdlZCBtYXkgaGF2ZSBu dW1lcm91cyBzaWRlLWVmZmVjdHMuCi0gICAgICAgIG1fcG9wdXBDbGllbnQtPnBvcHVwRGlkSGlk ZSgpOworICAgICAgICBoaWRlUG9wdXAoKTsKIAogICAgICAgICAvLyBUZWxsIHRoZSA8c2VsZWN0 PiBQb3B1cE1lbnVDbGllbnQgd2hhdCBpbmRleCB3YXMgc2VsZWN0ZWQuCiAgICAgICAgIG1fcG9w dXBDbGllbnQtPnZhbHVlQ2hhbmdlZChpbmRleCk7CkBAIC0xMDU5LDYgKzEwNTYsMTMgQEAgdm9p ZCBQb3B1cExpc3RCb3g6OmFkanVzdFNlbGVjdGVkSW5kZXgoaQogICAgIHNjcm9sbFRvUmV2ZWFs U2VsZWN0aW9uKCk7CiB9CiAKK3ZvaWQgUG9wdXBMaXN0Qm94OjpoaWRlUG9wdXAoKQoreworICAg IGlmIChwYXJlbnQoKSkKKyAgICAgICAgc3RhdGljX2Nhc3Q8UG9wdXBDb250YWluZXIqPihwYXJl bnQoKSktPmhpZGVQb3B1cCgpOworICAgIG1fcG9wdXBDbGllbnQtPnBvcHVwRGlkSGlkZSgpOwor fQorCiB2b2lkIFBvcHVwTGlzdEJveDo6dXBkYXRlRnJvbUVsZW1lbnQoKQogewogICAgIGNsZWFy KCk7Cg==