29544 2009-09-21 07:11:57 -0700 Make sunspider script work on Windows platform 2009-09-30 01:13:14 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 ossy webkit-unassigned commit-queue mjs zoltan oldest_to_newest 148637 0 ossy 2009-09-21 07:11:57 -0700 On Windows there isn't /dev/null device. Instead of this, we should use NUL device. Windows hasn't grep.exe by default. To make sunspider script work, you should install grep.exe eg from UnxUtils. I don't find any reason why grep is necessary in sunspider script. If it is really unnecessary, we should remove it, and the script will work on Windows too without installing grep.exe . 148638 1 ossy 2009-09-21 07:16:09 -0700 "grep -v break" added by Maciej, accordingly I added you to cc. Could you tell me why it is necessary? I don't find any "break" in jsc output. http://trac.webkit.org/changeset/26915 148639 2 39849 ossy 2009-09-21 07:17:05 -0700 Created attachment 39849 proposed patch 148640 3 39850 ossy 2009-09-21 07:21:52 -0700 Created attachment 39850 proposed patch sorry, I forgot adding bug to the ChangeLog 148675 4 39852 ossy 2009-09-21 08:33:36 -0700 Created attachment 39852 proposed patch Here is the new proposed patch, because grep should be necessary for sunspider-compare-result script. I'll try to find the function of this grep, and if I am convinced it is really unnecessary, I'll submit new patch to remove it. 148680 5 39852 mjs 2009-09-21 08:37:40 -0700 Comment on attachment 39852 proposed patch r=me 148703 6 zoltan 2009-09-21 08:57:20 -0700 attachment 39852 landed in: http://trac.webkit.org/changeset/48584 148818 7 39852 eric 2009-09-21 14:08:01 -0700 Comment on attachment 39852 proposed patch Csaba isn't a committer, so I assume he (she?) wanted this automatted commit. You can opt in/out of auto-commit in the future using "commit-queue?" or "commit-queue-" 148819 8 39852 commit-queue 2009-09-21 14:08:38 -0700 Comment on attachment 39852 proposed patch Rejecting patch 39852 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=39852 from bug 29544 failed to download and apply. 148823 9 ossy 2009-09-21 14:15:57 -0700 (In reply to comment #7) > (From update of attachment 39852 [details]) > Csaba isn't a committer, so I assume he (she?) wanted this automatted commit. > You can opt in/out of auto-commit in the future using "commit-queue?" or > "commit-queue-" I asked Zoltan to commit this patch, he is our committer, and he done it. Should we have removed r+ flag after landing? I would like to leave open this bug, because it might need one more patch. 150482 10 40224 ossy 2009-09-28 03:49:06 -0700 Created attachment 40224 proposed patch I've found a nicer and platorm independent solution for null device problem. 151182 11 40224 zoltan 2009-09-30 00:55:56 -0700 Comment on attachment 40224 proposed patch > diff --git a/SunSpider/ChangeLog b/SunSpider/ChangeLog > index e121eeb..8aa63bf 100644 > --- a/SunSpider/ChangeLog > +++ b/SunSpider/ChangeLog > @@ -1,3 +1,12 @@ > +2009-09-28 Csaba Osztrogonac <oszi@inf.u-szeged.hu> > + > + Reviewed by NOBODY (OOPS!). > + > + Platform specific null device replaced with a platform independent. > + https://bugs.webkit.org/show_bug.cgi?id=29544 > + > + * sunspider: Using File::Spec->devnull() instead of /dev/null and NUL. > + > 2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu> > > Reviewed by Maciej Stachowiak. > diff --git a/SunSpider/sunspider b/SunSpider/sunspider > index 7825a63..20614b1 100755 > --- a/SunSpider/sunspider > +++ b/SunSpider/sunspider > @@ -160,8 +160,7 @@ sub writePrefixFile() > sub runTestsOnce($) > { > my ($useShark) = @_; > - my $nullDevice = ($^O eq "MSWin32") ? "NUL" : "/dev/null"; > - my $shellArgs = $jsShellArgs . " -f $prefixFile -f resources/sunspider-standalone-driver.js 2> " . $nullDevice; > + my $shellArgs = $jsShellArgs . " -f $prefixFile -f resources/sunspider-standalone-driver.js 2> " . File::Spec->devnull(); > my $output; > if ($useShark) { > my $intervalArg = $useShark == 20 ? "-I 20u" : ""; 151184 12 40224 commit-queue 2009-09-30 01:13:10 -0700 Comment on attachment 40224 proposed patch Clearing flags on attachment: 40224 Committed r48923: <http://trac.webkit.org/changeset/48923> 151185 13 commit-queue 2009-09-30 01:13:14 -0700 All reviewed patches have been landed. Closing bug. 39849 2009-09-21 07:17:05 -0700 2009-09-21 07:21:52 -0700 proposed patch sunspider_proposed.patch text/plain 1472 ossy ZGlmZiAtLWdpdCBhL1N1blNwaWRlci9DaGFuZ2VMb2cgYi9TdW5TcGlkZXIvQ2hhbmdlTG9nCmlu ZGV4IDRhNTMxN2MuLjYyYmY3NDUgMTAwNjQ0Ci0tLSBhL1N1blNwaWRlci9DaGFuZ2VMb2cKKysr IGIvU3VuU3BpZGVyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA5LTIxICBDc2Fi YSBPc3p0cm9nb25hYyAgPG9zemlAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWFrZSBzdW5zcGlkZXIgc2NyaXB0 IHdvcmsgb24gV2luZG93cyBwbGF0Zm9ybS4KKworICAgICAgICAqIHN1bnNwaWRlcjoKKyAgICAg ICAgVXNpbmcgcGxhdGZvcm0gc3BlY2lmaWMgbnVsbCBkZXZpY2UgaW5zdGVhZCBvZiAvZGV2L251 bGwuCisgICAgICAgIFVubmVjZXNzYXJ5IGdyZXAgcmVtb3ZlZC4KKwogMjAwOS0wNi0xOSAgQWRh bSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvU3VuU3BpZGVyL3N1bnNwaWRlciBiL1N1blNw aWRlci9zdW5zcGlkZXIKaW5kZXggNjM1ZDA5My4uYzg0NTNhMyAxMDA3NTUKLS0tIGEvU3VuU3Bp ZGVyL3N1bnNwaWRlcgorKysgYi9TdW5TcGlkZXIvc3Vuc3BpZGVyCkBAIC0xNjAsMTQgKzE2MCwx NSBAQCBzdWIgd3JpdGVQcmVmaXhGaWxlKCkKIHN1YiBydW5UZXN0c09uY2UoJCkKIHsKICAgICBt eSAoJHVzZVNoYXJrKSA9IEBfOwotICAgIG15ICRzaGVsbEFyZ3MgPSAkanNTaGVsbEFyZ3MgLiAi IC1mICRwcmVmaXhGaWxlIC1mIHJlc291cmNlcy9zdW5zcGlkZXItc3RhbmRhbG9uZS1kcml2ZXIu anMgMj4gL2Rldi9udWxsIjsKKyAgICBteSAkbnVsbERldmljZSA9ICgkXk8gZXEgIk1TV2luMzIi KSA/ICJOVUwiIDogIi9kZXYvbnVsbCI7CisgICAgbXkgJHNoZWxsQXJncyA9ICRqc1NoZWxsQXJn cyAuICIgLWYgJHByZWZpeEZpbGUgLWYgcmVzb3VyY2VzL3N1bnNwaWRlci1zdGFuZGFsb25lLWRy aXZlci5qcyAyPiAiIC4gJG51bGxEZXZpY2U7CiAgICAgbXkgJG91dHB1dDsKICAgICBpZiAoJHVz ZVNoYXJrKSB7CiAgICAgICAgIG15ICRpbnRlcnZhbEFyZyA9ICR1c2VTaGFyayA9PSAyMCA/ICIt SSAyMHUiIDogIiI7CiAgICAgICAgIG15ICRjYWNoZUFyZyA9ICRydW5TaGFya0NhY2hlID8gIi1j ICRzaGFya0NhY2hlUHJvZmlsZUluZGV4IiA6ICIiOwogICAgICAgICAkb3V0cHV0ID0gYHNoYXJr ICRpbnRlcnZhbEFyZyAkY2FjaGVBcmcgLWkgLTEtcSAiJGpzU2hlbGxQYXRoIiAkc2hlbGxBcmdz YDsKICAgICB9IGVsc2UgewotICAgICAgICAkb3V0cHV0ID0gYCIkanNTaGVsbFBhdGgiICRzaGVs bEFyZ3MgfCBncmVwIC12IGJyZWFrYDsKKyAgICAgICAgJG91dHB1dCA9IGAiJGpzU2hlbGxQYXRo IiAkc2hlbGxBcmdzIGA7CiAgICAgfQogICAgIHJldHVybiAkb3V0cHV0OwogfQo= 39850 2009-09-21 07:21:52 -0700 2009-09-21 08:33:36 -0700 proposed patch sunspider_proposed.patch text/plain 1527 ossy ZGlmZiAtLWdpdCBhL1N1blNwaWRlci9DaGFuZ2VMb2cgYi9TdW5TcGlkZXIvQ2hhbmdlTG9nCmlu ZGV4IDRhNTMxN2MuLmIyNjRiNWQgMTAwNjQ0Ci0tLSBhL1N1blNwaWRlci9DaGFuZ2VMb2cKKysr IGIvU3VuU3BpZGVyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTA5LTIxICBDc2Fi YSBPc3p0cm9nb25hYyAgPG9zemlAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWFrZSBzdW5zcGlkZXIgc2NyaXB0 IHdvcmsgb24gV2luZG93cyBwbGF0Zm9ybS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI5NTQ0CisKKyAgICAgICAgKiBzdW5zcGlkZXI6CisgICAgICAg IFVzaW5nIHBsYXRmb3JtIHNwZWNpZmljIG51bGwgZGV2aWNlIGluc3RlYWQgb2YgL2Rldi9udWxs LgorICAgICAgICBVbm5lY2Vzc2FyeSBncmVwIHJlbW92ZWQuCisKIDIwMDktMDYtMTkgIEFkYW0g VHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1N1blNwaWRlci9zdW5zcGlkZXIgYi9TdW5TcGlk ZXIvc3Vuc3BpZGVyCmluZGV4IDYzNWQwOTMuLmM4NDUzYTMgMTAwNzU1Ci0tLSBhL1N1blNwaWRl ci9zdW5zcGlkZXIKKysrIGIvU3VuU3BpZGVyL3N1bnNwaWRlcgpAQCAtMTYwLDE0ICsxNjAsMTUg QEAgc3ViIHdyaXRlUHJlZml4RmlsZSgpCiBzdWIgcnVuVGVzdHNPbmNlKCQpCiB7CiAgICAgbXkg KCR1c2VTaGFyaykgPSBAXzsKLSAgICBteSAkc2hlbGxBcmdzID0gJGpzU2hlbGxBcmdzIC4gIiAt ZiAkcHJlZml4RmlsZSAtZiByZXNvdXJjZXMvc3Vuc3BpZGVyLXN0YW5kYWxvbmUtZHJpdmVyLmpz IDI+IC9kZXYvbnVsbCI7CisgICAgbXkgJG51bGxEZXZpY2UgPSAoJF5PIGVxICJNU1dpbjMyIikg PyAiTlVMIiA6ICIvZGV2L251bGwiOworICAgIG15ICRzaGVsbEFyZ3MgPSAkanNTaGVsbEFyZ3Mg LiAiIC1mICRwcmVmaXhGaWxlIC1mIHJlc291cmNlcy9zdW5zcGlkZXItc3RhbmRhbG9uZS1kcml2 ZXIuanMgMj4gIiAuICRudWxsRGV2aWNlOwogICAgIG15ICRvdXRwdXQ7CiAgICAgaWYgKCR1c2VT aGFyaykgewogICAgICAgICBteSAkaW50ZXJ2YWxBcmcgPSAkdXNlU2hhcmsgPT0gMjAgPyAiLUkg MjB1IiA6ICIiOwogICAgICAgICBteSAkY2FjaGVBcmcgPSAkcnVuU2hhcmtDYWNoZSA/ICItYyAk c2hhcmtDYWNoZVByb2ZpbGVJbmRleCIgOiAiIjsKICAgICAgICAgJG91dHB1dCA9IGBzaGFyayAk aW50ZXJ2YWxBcmcgJGNhY2hlQXJnIC1pIC0xLXEgIiRqc1NoZWxsUGF0aCIgJHNoZWxsQXJnc2A7 CiAgICAgfSBlbHNlIHsKLSAgICAgICAgJG91dHB1dCA9IGAiJGpzU2hlbGxQYXRoIiAkc2hlbGxB cmdzIHwgZ3JlcCAtdiBicmVha2A7CisgICAgICAgICRvdXRwdXQgPSBgIiRqc1NoZWxsUGF0aCIg JHNoZWxsQXJncyBgOwogICAgIH0KICAgICByZXR1cm4gJG91dHB1dDsKIH0K 39852 2009-09-21 08:33:36 -0700 2009-09-28 03:49:06 -0700 proposed patch sunspider_proposed.patch text/plain 1171 ossy ZGlmZiAtLWdpdCBhL1N1blNwaWRlci9DaGFuZ2VMb2cgYi9TdW5TcGlkZXIvQ2hhbmdlTG9nCmlu ZGV4IDRhNTMxN2MuLjZkOTExOWYgMTAwNjQ0Ci0tLSBhL1N1blNwaWRlci9DaGFuZ2VMb2cKKysr IGIvU3VuU3BpZGVyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA5LTIxICBDc2Fi YSBPc3p0cm9nb25hYyAgPG9zemlAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWFrZSBzdW5zcGlkZXIgc2NyaXB0 IHdvcmsgb24gV2luZG93cyBwbGF0Zm9ybS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI5NTQ0CisKKyAgICAgICAgKiBzdW5zcGlkZXI6CisgICAgICAg IFVzaW5nIHBsYXRmb3JtIHNwZWNpZmljIG51bGwgZGV2aWNlIGluc3RlYWQgb2YgL2Rldi9udWxs LgorCiAyMDA5LTA2LTE5ICBBZGFtIFRyZWF0ICA8YWRhbS50cmVhdEB0b3JjaG1vYmlsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCmRpZmYgLS1naXQgYS9TdW5TcGlk ZXIvc3Vuc3BpZGVyIGIvU3VuU3BpZGVyL3N1bnNwaWRlcgppbmRleCA2MzVkMDkzLi43ODI1YTYz IDEwMDc1NQotLS0gYS9TdW5TcGlkZXIvc3Vuc3BpZGVyCisrKyBiL1N1blNwaWRlci9zdW5zcGlk ZXIKQEAgLTE2MCw3ICsxNjAsOCBAQCBzdWIgd3JpdGVQcmVmaXhGaWxlKCkKIHN1YiBydW5UZXN0 c09uY2UoJCkKIHsKICAgICBteSAoJHVzZVNoYXJrKSA9IEBfOwotICAgIG15ICRzaGVsbEFyZ3Mg PSAkanNTaGVsbEFyZ3MgLiAiIC1mICRwcmVmaXhGaWxlIC1mIHJlc291cmNlcy9zdW5zcGlkZXIt c3RhbmRhbG9uZS1kcml2ZXIuanMgMj4gL2Rldi9udWxsIjsKKyAgICBteSAkbnVsbERldmljZSA9 ICgkXk8gZXEgIk1TV2luMzIiKSA/ICJOVUwiIDogIi9kZXYvbnVsbCI7CisgICAgbXkgJHNoZWxs QXJncyA9ICRqc1NoZWxsQXJncyAuICIgLWYgJHByZWZpeEZpbGUgLWYgcmVzb3VyY2VzL3N1bnNw aWRlci1zdGFuZGFsb25lLWRyaXZlci5qcyAyPiAiIC4gJG51bGxEZXZpY2U7CiAgICAgbXkgJG91 dHB1dDsKICAgICBpZiAoJHVzZVNoYXJrKSB7CiAgICAgICAgIG15ICRpbnRlcnZhbEFyZyA9ICR1 c2VTaGFyayA9PSAyMCA/ICItSSAyMHUiIDogIiI7Cg== 40224 2009-09-28 03:49:06 -0700 2009-09-30 01:13:10 -0700 proposed patch devnull.patch text/plain 1199 ossy ZGlmZiAtLWdpdCBhL1N1blNwaWRlci9DaGFuZ2VMb2cgYi9TdW5TcGlkZXIvQ2hhbmdlTG9nCmlu ZGV4IGUxMjFlZWIuLjhhYTYzYmYgMTAwNjQ0Ci0tLSBhL1N1blNwaWRlci9DaGFuZ2VMb2cKKysr IGIvU3VuU3BpZGVyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTA5LTI4ICBDc2Fi YSBPc3p0cm9nb25hYyAgPG9zemlAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBsYXRmb3JtIHNwZWNpZmljIG51bGwgZGV2 aWNlIHJlcGxhY2VkIHdpdGggYSBwbGF0Zm9ybSBpbmRlcGVuZGVudC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NTQ0CisKKyAgICAgICAgKiBzdW5z cGlkZXI6IFVzaW5nIEZpbGU6OlNwZWMtPmRldm51bGwoKSBpbnN0ZWFkIG9mIC9kZXYvbnVsbCBh bmQgTlVMLgorCiAyMDA5LTA5LTIxICBDc2FiYSBPc3p0cm9nb25hYyAgPG9zemlAaW5mLnUtc3pl Z2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZmIC0t Z2l0IGEvU3VuU3BpZGVyL3N1bnNwaWRlciBiL1N1blNwaWRlci9zdW5zcGlkZXIKaW5kZXggNzgy NWE2My4uMjA2MTRiMSAxMDA3NTUKLS0tIGEvU3VuU3BpZGVyL3N1bnNwaWRlcgorKysgYi9TdW5T cGlkZXIvc3Vuc3BpZGVyCkBAIC0xNjAsOCArMTYwLDcgQEAgc3ViIHdyaXRlUHJlZml4RmlsZSgp CiBzdWIgcnVuVGVzdHNPbmNlKCQpCiB7CiAgICAgbXkgKCR1c2VTaGFyaykgPSBAXzsKLSAgICBt eSAkbnVsbERldmljZSA9ICgkXk8gZXEgIk1TV2luMzIiKSA/ICJOVUwiIDogIi9kZXYvbnVsbCI7 Ci0gICAgbXkgJHNoZWxsQXJncyA9ICRqc1NoZWxsQXJncyAuICIgLWYgJHByZWZpeEZpbGUgLWYg cmVzb3VyY2VzL3N1bnNwaWRlci1zdGFuZGFsb25lLWRyaXZlci5qcyAyPiAiIC4gJG51bGxEZXZp Y2U7CisgICAgbXkgJHNoZWxsQXJncyA9ICRqc1NoZWxsQXJncyAuICIgLWYgJHByZWZpeEZpbGUg LWYgcmVzb3VyY2VzL3N1bnNwaWRlci1zdGFuZGFsb25lLWRyaXZlci5qcyAyPiAiIC4gRmlsZTo6 U3BlYy0+ZGV2bnVsbCgpOwogICAgIG15ICRvdXRwdXQ7CiAgICAgaWYgKCR1c2VTaGFyaykgewog ICAgICAgICBteSAkaW50ZXJ2YWxBcmcgPSAkdXNlU2hhcmsgPT0gMjAgPyAiLUkgMjB1IiA6ICIi Owo=