29532 2009-09-20 14:54:31 -0700 [GTK] media tests failing after their rework 2009-09-23 06:05:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned pnormand xan.lopez oldest_to_newest 148575 0 gustavo 2009-09-20 14:54:31 -0700 A Chromium developer reworked the tests to allow testing using formats/codecs that are supported. GStreamer supports the formats that are used in the tests, but doesn't correctly advertise them, so we started failing. 148576 1 39836 gustavo 2009-09-20 15:01:07 -0700 Created attachment 39836 proposed fix 148614 2 pnormand 2009-09-21 01:09:21 -0700 GStreamer doesn't report the mime-types like the ones listed in /etc/mime.types. The typefind functions (src ! typefind) report things like content-type/container: audio/mpeg or video/x-msvideo for an avi file. More data is probably available in the caps property of the typefind element. So I'm not sure it's a good idea to have that mapping between Gstreamer formats and WebKit. Would need to think more about it. 148616 3 xan.lopez 2009-09-21 02:20:43 -0700 (In reply to comment #2) > GStreamer doesn't report the mime-types like the ones listed in > /etc/mime.types. The typefind functions (src ! typefind) report things like > content-type/container: > > audio/mpeg > > or video/x-msvideo for an avi file. > > More data is probably available in the caps property of the typefind element. Right, so gustavo's comment about gst failing to report things is not accurate. > > So I'm not sure it's a good idea to have that mapping between Gstreamer formats > and WebKit. Would need to think more about it. Keep in mind that it's the HTML5 standard that says we should work with mime types, so this is not really up to debate (unless you convince the HTML5 guys we shouldn't use mime types). See: http://www.whatwg.org/specs/web-apps/current-work/multipage/video.html 148636 4 gustavo 2009-09-21 07:09:35 -0700 (In reply to comment #2) > GStreamer doesn't report the mime-types like the ones listed in > /etc/mime.types. The typefind functions (src ! typefind) report things like > content-type/container: > > audio/mpeg Right. But we are given the mime type as defined in HTML5 to find out if we do support it or not, so we need some kind of mapping here. > or video/x-msvideo for an avi file. > > More data is probably available in the caps property of the typefind element. We are using data from caps to get what we do now. Any suggestions on how we could improve this to correctly say we support video/mp4, audio/mp3, and the others? 148652 5 gustavo 2009-09-21 07:43:45 -0700 Some discussoin down at #gstreamer: <slomo> kov: you need a MIME type <-> caps conversion and then you could check the registry <slomo> or what everybody else said before ;) <bilboed-pi> even then, it's not guaranteed <__tim> we should add an FAQ entry for this somewhere ;) <kov> __tim, I did look for that in the FAQ ;D <bilboed-pi> i.e. MIME-TYPE : video/x-asf => neat, I have an asfdemux, all good => but you fail because you don't have the decoders <ensonic> yes, if you don't find elements, then it won't play, but the opposite doe not have to be tru automatically <kov> bilboed-pi, right, but I may also have the codec names does that help somehow? such as: type: video/ogg, codec: speex sorry, audio/ogg, speex <bilboed-pi> you'd have to do a mapping table between your application's type system and gstreamer caps <kov> bilboed-pi, sounds like a plan <bilboed-pi> there are corner cases where it will fail though... because that codec description isn't verbose enough <kov> I have made a quick try to see if I could get the tests working: https://bugs.webkit.org/attachment.cgi?id=39836&action=review I guess I'll have to play with that quite a bit more =) <bilboed-pi> mp3 => audio/mpeg, mpegversion=1, layer=3 wav is tricky it's a container format which, agreed, is mostly used for raw pcm... but can contain mp3 or other codecs <kov> I guess we can handle corner cases as we find them if we get 80% coverage I'll be happy 149006 6 pnormand 2009-09-22 04:54:30 -0700 About last part of the patch, mapping audio/mpeg to audio/mp3 mime-type, what about mp1 and mp2 ? 149357 7 gustavo 2009-09-23 04:47:30 -0700 (In reply to comment #6) > About last part of the patch, mapping audio/mpeg to audio/mp3 mime-type, what > about mp1 and mp2 ? I'll fix that =). We will need a quite big mapping. I am inclined to write it on demand like I did with those, and in the near future refactor it into a separate file, so that we can easily use the same code in other projects. 149358 8 39836 xan.lopez 2009-09-23 04:55:43 -0700 Comment on attachment 39836 proposed fix Let's get this for now and improve it gradually :) r=me 149369 9 gustavo 2009-09-23 06:05:08 -0700 Landed as r48671, thanks! 39836 2009-09-20 15:01:07 -0700 2009-09-23 04:55:42 -0700 proposed fix 0001-Advertise-support-for-web-video-audio-formats.patch text/plain 3960 gustavo RnJvbSA1ZTMyODI4MjlkMGM2OWY4MzE3YzJjMGY1NTdmOWI0MTBhYTk5ZWE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFN1biwgMjAgU2VwIDIwMDkgMTk6MDA6MzUgLTAzMDAK U3ViamVjdDogW1BBVENIXSBBZHZlcnRpc2Ugc3VwcG9ydCBmb3Igd2ViIHZpZGVvL2F1ZGlvIGZv cm1hdHMKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDQyICsrKysrKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8ICAgMTcgKysrKysrKysKIDIgZmlsZXMgY2hh bmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGY3NTZiMDguLmM3NWUwY2Ug MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsNDUgQEAKKzIwMDktMDktMjAgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bn bm9tZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gbWVkaWEgdGVzdHMgZmFpbGluZyBhZnRlciB0aGVpciByZXdvcmsKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NTMyCisKKyAgICAgICAg Q29ycmVjdGx5IGFkdmVydGlzZSB0aGUgbWltZSB0eXBlcyB1c2VkIGJ5IHRoZSBjb21tb24gZm9y bWF0cyB1c2VkCisgICAgICAgIGluIHRoZSB0ZXN0cy4KKworICAgICAgICBUZXN0cyB0aGF0IHJl Z3Jlc3NlZCwgYW5kIHdpbGwgcGFzcyBhZ2FpbjoKKworICAgICAgICAgICBtZWRpYS92aWRlby1j YW52YXMtc291cmNlLmh0bWwKKyAgICAgICAgICAgbWVkaWEvdmlkZW8tY29udHJvbHMuaHRtbAor ICAgICAgICAgICBtZWRpYS92aWRlby1jdXJyZW50VGltZS1zZXQyLmh0bWwKKyAgICAgICAgICAg bWVkaWEvdmlkZW8tZG9tLWF1dG9wbGF5Lmh0bWwKKyAgICAgICAgICAgbWVkaWEvdmlkZW8tZG9t LXNyYy5odG1sCisgICAgICAgICAgIG1lZGlhL3ZpZGVvLWVycm9yLWFib3J0Lmh0bWwKKyAgICAg ICAgICAgbWVkaWEvdmlkZW8tbG9hZC1uZXR3b3JrU3RhdGUuaHRtbAorICAgICAgICAgICBtZWRp YS92aWRlby1sb2FkLXJlYWR5U3RhdGUuaHRtbAorICAgICAgICAgICBtZWRpYS92aWRlby1tdXRl ZC5odG1sCisgICAgICAgICAgIG1lZGlhL3ZpZGVvLW5vLWF1dG9wbGF5Lmh0bWwKKyAgICAgICAg ICAgbWVkaWEvdmlkZW8tcGF1c2UtZW1wdHktZXZlbnRzLmh0bWwKKyAgICAgICAgICAgbWVkaWEv dmlkZW8tcGxheS1lbXB0eS1ldmVudHMuaHRtbAorICAgICAgICAgICBtZWRpYS92aWRlby1zZWVr YWJsZS5odG1sCisgICAgICAgICAgIG1lZGlhL3ZpZGVvLXNlZWtpbmcuaHRtbAorICAgICAgICAg ICBtZWRpYS92aWRlby1zaXplLmh0bWwKKyAgICAgICAgICAgbWVkaWEvdmlkZW8tc291cmNlLXR5 cGUtcGFyYW1zLmh0bWwKKyAgICAgICAgICAgbWVkaWEvdmlkZW8tc291cmNlLXR5cGUuaHRtbAor ICAgICAgICAgICBtZWRpYS92aWRlby1zb3VyY2UuaHRtbAorICAgICAgICAgICBtZWRpYS92aWRl by1zcmMtY2hhbmdlLmh0bWwKKyAgICAgICAgICAgbWVkaWEvdmlkZW8tc3JjLWludmFsaWQtcmVt b3ZlLmh0bWwKKyAgICAgICAgICAgbWVkaWEvdmlkZW8tc3JjLXJlbW92ZS5odG1sCisgICAgICAg ICAgIG1lZGlhL3ZpZGVvLXNyYy1zZXQuaHRtbAorICAgICAgICAgICBtZWRpYS92aWRlby1zcmMt c291cmNlLmh0bWwKKyAgICAgICAgICAgbWVkaWEvdmlkZW8tc3JjLmh0bWwKKyAgICAgICAgICAg bWVkaWEvdmlkZW8tdGltZXVwZGF0ZS1kdXJpbmctcGxheWJhY2suaHRtbAorICAgICAgICAgICBt ZWRpYS92aWRlby12b2x1bWUuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjptaW1l VHlwZUNhY2hlKToKKwogMjAwOS0wOS0xOCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2 by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0 ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDYwYmE1OTYuLmVkOGFkNzgg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMiw2ICsyLDcgQEAKICAqIENvcHlyaWdo dCAoQykgMjAwNywgMjAwOSBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogQ29w eXJpZ2h0IChDKSAyMDA3IENvbGxhYm9yYSBMdGQuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogICog Q29weXJpZ2h0IChDKSAyMDA3IEFscCBUb2tlciA8YWxwQGF0b2tlci5jb20+CisgKiBDb3B5cmln aHQgKEMpIDIwMDkgR3VzdGF2byBOb3JvbmhhIFNpbHZhIDxnbnNAZ25vbWUub3JnPgogICoKICAq IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IKICAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdl bmVyYWwgUHVibGljCkBAIC02NzIsNiArNjczLDIyIEBAIHN0YXRpYyBIYXNoU2V0PFN0cmluZz4g bWltZVR5cGVDYWNoZSgpCiAgICAgICAgICAgICAgICAgICAgIChnX3N0cl9lcXVhbChtaW1ldHlw ZVswXSwgImFwcGxpY2F0aW9uIikgJiYKICAgICAgICAgICAgICAgICAgICAgICAgICFpZ25vcmVk QXBwbGljYXRpb25TdWJ0eXBlcy5jb250YWlucyhTdHJpbmcobWltZXR5cGVbMV0pKSkpIHsKICAg ICAgICAgICAgICAgICBjYWNoZS5hZGQoU3RyaW5nKGNhcGFiaWxpdHlbMF0pKTsKKworICAgICAg ICAgICAgICAgIC8vIFRoZXNlIGZvcm1hdHMgYXJlIHN1cHBvcnRlZCBieSBHU3RyZWFtZXIsIGJ1 dCBub3QgY29ycmVjdGx5IGFkdmVydGlzZWQKKyAgICAgICAgICAgICAgICBpZiAoZ19zdHJfZXF1 YWwoY2FwYWJpbGl0eVswXSwgInZpZGVvL3gtaDI2NCIpIHx8CisgICAgICAgICAgICAgICAgICAg IGdfc3RyX2VxdWFsKGNhcGFiaWxpdHlbMF0sICJhdWRpby94LW00YSIpKSB7CisgICAgICAgICAg ICAgICAgICAgIGNhY2hlLmFkZChTdHJpbmcoInZpZGVvL21wNCIpKTsKKyAgICAgICAgICAgICAg ICAgICAgY2FjaGUuYWRkKFN0cmluZygiYXVkaW8vYWFjIikpOworICAgICAgICAgICAgICAgIH0K KworICAgICAgICAgICAgICAgIGlmIChnX3N0cl9lcXVhbChjYXBhYmlsaXR5WzBdLCAidmlkZW8v eC10aGVvcmEiKSkKKyAgICAgICAgICAgICAgICAgICAgY2FjaGUuYWRkKFN0cmluZygidmlkZW8v b2dnIikpOworCisgICAgICAgICAgICAgICAgaWYgKGdfc3RyX2VxdWFsKGNhcGFiaWxpdHlbMF0s ICJhdWRpby94LXdhdiIpKQorICAgICAgICAgICAgICAgICAgICBjYWNoZS5hZGQoU3RyaW5nKCJh dWRpby93YXYiKSk7CisKKyAgICAgICAgICAgICAgICBpZiAoZ19zdHJfZXF1YWwoY2FwYWJpbGl0 eVswXSwgImF1ZGlvL21wZWciKSkKKyAgICAgICAgICAgICAgICAgICAgY2FjaGUuYWRkKFN0cmlu ZygiYXVkaW8vbXAzIikpOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBnX3N0cmZyZWV2 KGNhcGFiaWxpdHkpOwotLSAKMS42LjMuMwoK