29527 2009-09-20 01:36:35 -0700 [GTK] WebKitHitTestResult is completely broken in gmail 2009-09-22 05:13:19 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned jmalonzo oldest_to_newest 148555 0 xan.lopez 2009-09-20 01:36:35 -0700 It fails to figure out whether you are over a link, over an editable area, etc. 148981 1 39907 xan.lopez 2009-09-22 00:47:14 -0700 Created attachment 39907 hittestfix.diff 148997 2 jmalonzo 2009-09-22 03:42:11 -0700 No test? 149000 3 xan.lopez 2009-09-22 03:53:27 -0700 (In reply to comment #2) > No test? See https://bugs.webkit.org/show_bug.cgi?id=27546#c9 I'm trying to see how to figure out things from the JSC APIs. 149004 4 39907 jmalonzo 2009-09-22 04:21:03 -0700 Comment on attachment 39907 hittestfix.diff (In reply to comment #3) > (In reply to comment #2) > > No test? > > See https://bugs.webkit.org/show_bug.cgi?id=27546#c9 I'm trying to see how to > figure out things from the JSC APIs. Ok. r=me. 149011 5 xan.lopez 2009-09-22 05:13:19 -0700 Thanks! Committed in r48626 39907 2009-09-22 00:47:14 -0700 2009-09-22 04:21:03 -0700 hittestfix.diff hittestfix.diff text/plain 2223 xan.lopez RnJvbSAzNTc4ZTQzZDY5YmIyYzI3NDBhNTBjMWJjYzA3NTY5YjY0NzYyYzhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU dWUsIDIyIFNlcCAyMDA5IDEwOjQ0OjQ2ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wOS0y MiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBXZWJLaXRIaXRUZXN0UmVzdWx0IGlzIGNvbXBs ZXRlbHkgYnJva2VuIGluIGdtYWlsCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI5NTI3CgogICAgICAgIFdlIG5lZWQgdG8gdXNlIHRoZSBtYWluIG9yIGZv Y3VzZWQgZnJhbWUgd2hlbiBkb2luZyB0aGUgY29vcmRpbmF0ZQogICAgICAgIHRyYW5zZm9ybWF0 aW9uIGluc3RlYWQgb2YgYWx3YXlzIHVzaW5nIHRoZSBtYWluIGZyYW1lLgoKICAgICAgICAqIHdl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKICAgICAgICAod2Via2l0X3dlYl92aWV3X2dldF9oaXRf dGVzdF9yZXN1bHQpOgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwg ICAxMSArKysrKysrKysrKwogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgfCAg ICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxv ZwppbmRleCAwNmY0YmU1Li5jNGQwYjlkIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTA5LTIy ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBXZWJLaXRI aXRUZXN0UmVzdWx0IGlzIGNvbXBsZXRlbHkgYnJva2VuIGluIGdtYWlsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTUyNworCisgICAgICAgIFdlIG5l ZWQgdG8gdXNlIHRoZSBtYWluIG9yIGZvY3VzZWQgZnJhbWUgd2hlbiBkb2luZyB0aGUgY29vcmRp bmF0ZQorICAgICAgICB0cmFuc2Zvcm1hdGlvbiBpbnN0ZWFkIG9mIGFsd2F5cyB1c2luZyB0aGUg bWFpbiBmcmFtZS4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAg ICAgKHdlYmtpdF93ZWJfdmlld19nZXRfaGl0X3Rlc3RfcmVzdWx0KToKKwogMjAwOS0wOS0yMSAg R3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4K IAogICAgICAgICBVcGRhdGUgZG9jdW1lbnRhdGlvbiBjb250cm9sIGZpbGVzIHRvIDEuMS4xNS4K ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggYTQxMGY3Ny4uMDQyOGRkYiAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTM5NDgsNyArMzk0OCw3IEBAIFdlYktp dEhpdFRlc3RSZXN1bHQqIHdlYmtpdF93ZWJfdmlld19nZXRfaGl0X3Rlc3RfcmVzdWx0KFdlYktp dFdlYlZpZXcqIHdlYlZpZXcsCiAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoZXZlbnQsIE5VTEwp OwogCiAgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IG1vdXNlRXZlbnQgPSBQbGF0Zm9ybU1vdXNlRXZl bnQoZXZlbnQpOwotICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUod2ViVmlldyktPm1haW5GcmFtZSgp OworICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUod2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpLT5m b2N1c2VkT3JNYWluRnJhbWUoKTsKICAgICBIaXRUZXN0UmVxdWVzdCByZXF1ZXN0KEhpdFRlc3RS ZXF1ZXN0OjpBY3RpdmUpOwogICAgIEludFBvaW50IGRvY3VtZW50UG9pbnQgPSBkb2N1bWVudFBv aW50Rm9yV2luZG93UG9pbnQoZnJhbWUsIG1vdXNlRXZlbnQucG9zKCkpOwogICAgIE1vdXNlRXZl bnRXaXRoSGl0VGVzdFJlc3VsdHMgbWV2ID0gZnJhbWUtPmRvY3VtZW50KCktPnByZXBhcmVNb3Vz ZUV2ZW50KHJlcXVlc3QsIGRvY3VtZW50UG9pbnQsIG1vdXNlRXZlbnQpOwotLSAKMS42LjQuMgoK