29510 2009-09-18 15:18:22 -0700 Active DOM objects should be suspended while a modal dialog is displayed 2009-09-18 15:26:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 148418 0 ap 2009-09-18 15:18:22 -0700 PageGroupLoadDeferrer calls suspendActiveDOMObjects() on all platforms but Mac, which results in e.g. DOM timers working in a page beneath a modal dialog. This doesn't match Safari for Windows or Firefox, and generally doesn't make much sense. Other active DOM objects also need to be suspended to avoid reentrant JavaScript execution. 148425 1 39799 ap 2009-09-18 15:23:09 -0700 Created attachment 39799 proposed patch 148426 2 ap 2009-09-18 15:26:43 -0700 Committed revision 48540. Note that Firefox doesn't fully pass the test - even though timers are disabled while the modal alert and dialog are displayed, they still run while he latter is being created. 39799 2009-09-18 15:23:09 -0700 2009-09-18 15:23:31 -0700 proposed patch SuspendTimers.txt text/plain 3311 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODUzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDktMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NTEwCisgICAgICAgIEFj dGl2ZSBET00gb2JqZWN0cyBzaG91bGQgYmUgc3VzcGVuZGVkIHdoaWxlIGEgbW9kYWwgZGlhbG9n IGlzIGRpc3BsYXllZAorCisgICAgICAgICogbWFudWFsLXRlc3RzL2pzLXRpbWVycy1iZW5lYXRo LW1vZGFsLWRpYWxvZy5odG1sOiBBZGRlZCBhIHRlc3QgZm9yIEpTIHRpbWVycy4KKworICAgICAg ICAqIHBhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBh Z2VHcm91cExvYWREZWZlcnJlcjo6UGFnZUdyb3VwTG9hZERlZmVycmVyKToKKyAgICAgICAgKFdl YkNvcmU6OlBhZ2VHcm91cExvYWREZWZlcnJlcjo6flBhZ2VHcm91cExvYWREZWZlcnJlcik6Cisg ICAgICAgIE1hdGNoIG90aGVyIHBsYXRmb3JtcywgYW5kIG1ha2UgTWFjIGFsc28gc3VzcGVuZCBh Y3RpdmUgRE9NIG9iamVjdHMuIFNpbmNlIGEgcGFnZSB0aGF0CisgICAgICAgIGN1cnJlbnRseSBk aXNwbGF5cyBhIG1vZGFsIGRpYWxvZyBjYW5ub3QgZ28gaW50byBwYWdlIGNhY2hlLCB0aGVyZSBp cyBubyBkYW5nZXIgb2Ygc3VzcGVuZGluZworICAgICAgICBhbiBvYmplY3QgdHdpY2UuICAgICAg ICAKKwogMjAwOS0wOS0xOCAgQ3NhYmEgT3N6dHJvZ29uYWMgIDxvc3ppQGluZi51LXN6ZWdlZC5o dT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvbWFu dWFsLXRlc3RzL2pzLXRpbWVycy1iZW5lYXRoLW1vZGFsLWRpYWxvZy5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL2pzLXRpbWVycy1iZW5lYXRoLW1vZGFsLWRpYWxvZy5o dG1sCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9tYW51YWwtdGVzdHMvanMtdGltZXJzLWJlbmVh dGgtbW9kYWwtZGlhbG9nLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTkgQEAKKzxwPkpT IHRpbWVycyBzaG91bGQgYmUgcGF1c2VkIHdoaWxlIGEgbW9kYWwgZGlhbG9nIChvciBhbGVydCkg aXMgZGlzcGxheWVkLjwvcD4KKzxwPlBsZWFzZSBkaXNhYmxlIHBvcHVwIGJsb2NrZXIgZm9yIHRo aXMgdGVzdC48L3A+Cis8ZGl2PjA8L2Rpdj4KKzxzY3JpcHQ+CitmdW5jdGlvbiBmKCkKK3sKKyAg ICB2YXIgZCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJkaXYiKVswXTsKKyAgICBk LmlubmVySFRNTCA9IHBhcnNlSW50KGQuaW5uZXJIVE1MKSArIDE7Cit9CisKK3ZhciB0aW1lcklk ID0gc2V0SW50ZXJ2YWwoZiwgMTAwKTsKKworYWxlcnQoIk51bWJlcnMgaW4gbWFpbiB3aW5kb3cg c2hvdWxkIG5vdCBpbmNyZWFzZSB3aGlsZSB0aGlzIGFsZXJ0IGlzIGRpc3BsYXllZCIpOworc2hv d01vZGFsRGlhbG9nKCJkYXRhOnRleHQvaHRtbCw8cD5OdW1iZXJzIGluIG1haW4gd2luZG93IHNo b3VsZCBub3QgaW5jcmVhc2Ugd2hpbGUgdGhpcyBtb2RhbCBkaWFsb2cgaXMgZGlzcGxheWVkPC9w PiIpOworZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImRpdiIpWzBdLmlubmVySFRNTCA9 ICJET05FIjsKKworY2xlYXJJbnRlcnZhbCh0aW1lcklkKTsKKworPC9zY3JpcHQ+CgpQcm9wZXJ0 eSBjaGFuZ2VzIG9uOiBXZWJDb3JlL21hbnVhbC10ZXN0cy9qcy10aW1lcnMtYmVuZWF0aC1tb2Rh bC1kaWFsb2cuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L2h0 bWwKCkluZGV4OiBXZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAkocmV2aXNpb24g NDg1MTApCisrKyBXZWJDb3JlL3BhZ2UvUGFnZUdyb3VwTG9hZERlZmVycmVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDEsMTAgKzQxLDEwIEBAIFBhZ2VHcm91cExvYWREZWZlcnJlcjo6UGFnZUdy b3VwTG9hZERlZmUKICAgICAgICAgICAgIGlmICghb3RoZXJQYWdlLT5kZWZlcnNMb2FkaW5nKCkp CiAgICAgICAgICAgICAgICAgbV9kZWZlcnJlZEZyYW1lcy5hcHBlbmQob3RoZXJQYWdlLT5tYWlu RnJhbWUoKSk7CiAKLSNpZiAhUExBVEZPUk0oTUFDKQorICAgICAgICAgICAgLy8gVGhpcyBjb2Rl IGlzIG5vdCBsb2dpY2FsbHkgcGFydCBvZiBsb2FkIGRlZmVycmluZywgYnV0IHdlIGRvIG5vdCB3 YW50IEpTIGNvZGUgZXhlY3V0ZWQgYmVuZWF0aCBtb2RhbAorICAgICAgICAgICAgLy8gd2luZG93 cyBvciBzaGVldHMsIHdoaWNoIGlzIGV4YWN0bHkgd2hlbiBQYWdlR3JvdXBMb2FkRGVmZXJyZXIg aXMgdXNlZC4KICAgICAgICAgICAgIGZvciAoRnJhbWUqIGZyYW1lID0gb3RoZXJQYWdlLT5tYWlu RnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KCkpCiAg ICAgICAgICAgICAgICAgZnJhbWUtPmRvY3VtZW50KCktPnN1c3BlbmRBY3RpdmVET01PYmplY3Rz KCk7Ci0jZW5kaWYKICAgICAgICAgfQogICAgIH0KIApAQCAtNjAsMTAgKzYwLDggQEAgUGFnZUdy b3VwTG9hZERlZmVycmVyOjp+UGFnZUdyb3VwTG9hZERlZgogICAgICAgICBpZiAoUGFnZSogcGFn ZSA9IG1fZGVmZXJyZWRGcmFtZXNbaV0tPnBhZ2UoKSkgewogICAgICAgICAgICAgcGFnZS0+c2V0 RGVmZXJzTG9hZGluZyhmYWxzZSk7CiAKLSNpZiAhUExBVEZPUk0oTUFDKQogICAgICAgICAgICAg Zm9yIChGcmFtZSogZnJhbWUgPSBwYWdlLT5tYWluRnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJh bWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KCkpCiAgICAgICAgICAgICAgICAgZnJhbWUtPmRvY3Vt ZW50KCktPnJlc3VtZUFjdGl2ZURPTU9iamVjdHMoKTsKLSNlbmRpZgogICAgICAgICB9CiAgICAg fQogfQo=