29506 2009-09-18 14:38:24 -0700 PrettyPatch should show images even when they have the wrong mime type 2009-10-26 11:45:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned aroben oldest_to_newest 148390 0 eric 2009-09-18 14:38:24 -0700 PrettyPatch should show images even when they have the wrong mime type It seems very common for windows svn users to upload png files with the wrong mime type: https://bugs.webkit.org/attachment.cgi?id=39787&action=prettypatch PrettyPatch's image display code ignores them because the're application/octetstream instead of image/png. We should make PrettyPatch smarter. It should see that the file name ends in .png and pretend it's an image anyway. 157358 1 41760 eric 2009-10-23 16:10:16 -0700 Created attachment 41760 Patch v1 157585 2 41760 aroben 2009-10-25 08:32:29 -0700 Comment on attachment 41760 Patch v1 It seems a little strange for has_image_suffix to be an instance method of the FileDiff class. It would probably be better as a method of String or just in the private section of the PrettyPatch module. r=me 157835 3 eric 2009-10-26 11:36:16 -0700 Landed as r50077. 157841 4 eric 2009-10-26 11:45:24 -0700 I moved it to the private section of PrettyPatch per your suggestion. 41760 2009-10-23 16:10:16 -0700 2009-10-25 08:32:29 -0700 Patch v1 bug-29506-20091023161014.patch text/plain 2232 eric ZGlmZiAtLWdpdCBhL0J1Z3NTaXRlL0NoYW5nZUxvZyBiL0J1Z3NTaXRlL0NoYW5nZUxvZwppbmRl eCA4ZDc5YTNmLi5hZTU5YjI4IDEwMDY0NAotLS0gYS9CdWdzU2l0ZS9DaGFuZ2VMb2cKKysrIGIv QnVnc1NpdGUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAtMjMgIEVyaWMgU2Vp ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFByZXR0eVBhdGNoIHNob3VsZCBzaG93IGltYWdlcyBldmVuIHdoZW4g dGhleSBoYXZlIHRoZSB3cm9uZyBtaW1lIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI5NTA2CisKKyAgICAgICAgKiBQcmV0dHlQYXRjaC9QcmV0 dHlQYXRjaC5yYjoKKwogMjAwOS0xMC0xNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9C dWdzU2l0ZS9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYiBiL0J1Z3NTaXRlL1ByZXR0eVBhdGNo L1ByZXR0eVBhdGNoLnJiCmluZGV4IDczODVmNjUuLjg1YmQ3ZmYgMTAwNjQ0Ci0tLSBhL0J1Z3NT aXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCisrKyBiL0J1Z3NTaXRlL1ByZXR0eVBhdGNo L1ByZXR0eVBhdGNoLnJiCkBAIC00Miw2ICs0Miw4IEBAIHByaXZhdGUKIAogICAgIElNQUdFX0ZJ TEVfTUFSS0VSX0ZPUk1BVCA9IC9ec3ZuOm1pbWUtdHlwZSA9IGltYWdlXC9wbmckLwogCisgICAg U1RBUlRfT0ZfQklOQVJZX0RBVEFfRk9STUFUID0gL15bMC05YS16QS1aXCtcLz1dezIwLH0vICMg QXNzdW1lIDIwIGNoYXJzIHdpdGhvdXQgYSBzcGFjZSBpcyBiYXNlNjQgYmluYXJ5IGRhdGEuCisK ICAgICBTVEFSVF9PRl9TRUNUSU9OX0ZPUk1BVCA9IC9eQEAgLShcZCspKD86LFxkKyk/IFwrKFxk KykoPzosXGQrKT8gQEBccyooLiopLwogCiAgICAgU1RBUlRfT0ZfRVhURU5UX1NUUklORyA9ICIl YyIgJSAwCkBAIC0xOTcsOSArMTk5LDE2IEBAIEVPRgogICAgICAgICAgICAgICAgICAgICBicmVh awogICAgICAgICAgICAgICAgIHdoZW4gQklOQVJZX0ZJTEVfTUFSS0VSX0ZPUk1BVAogICAgICAg ICAgICAgICAgICAgICBAYmluYXJ5ID0gdHJ1ZQotICAgICAgICAgICAgICAgICAgICBpZiAoSU1B R0VfRklMRV9NQVJLRVJfRk9STUFULm1hdGNoKGxpbmVzW2kgKyAxXSkpIHRoZW4KKyAgICAgICAg ICAgICAgICAgICAgaWYgKElNQUdFX0ZJTEVfTUFSS0VSX0ZPUk1BVC5tYXRjaChsaW5lc1tpICsg MV0pIG9yIGhhc19pbWFnZV9zdWZmaXgoQGZpbGVuYW1lKSkgdGhlbgogICAgICAgICAgICAgICAg ICAgICAgICAgQGltYWdlID0gdHJ1ZQogICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnRPZlNl Y3Rpb25zID0gaSArIDIKKyAgICAgICAgICAgICAgICAgICAgICAgIGZvciB4IGluIHN0YXJ0T2ZT ZWN0aW9ucy4uLmxpbmVzLmxlbmd0aAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICMgQmlu YXJ5IGRpZmZzIG9mdGVuIGhhdmUgcHJvcGVydHkgY2hhbmdlcyBsaXN0ZWQgYmVmb3JlIHRoZSBh Y3R1YWwgYmluYXJ5IGRhdGEuICBTa2lwIHRoZW0uCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaWYgU1RBUlRfT0ZfQklOQVJZX0RBVEFfRk9STUFULm1hdGNoKGxpbmVzW3hdKSB0aGVuCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXJ0T2ZTZWN0aW9ucyA9IHgKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBlbmQKKyAgICAgICAgICAgICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAgICAgICAg ICBlbmQKICAgICAgICAgICAgICAgICAgICAgYnJlYWsKICAgICAgICAgICAgICAgICBlbmQKQEAg LTIxMCw2ICsyMTksMTAgQEAgRU9GCiAgICAgICAgICAgICBuaWwKICAgICAgICAgZW5kCiAKKyAg ICAgICAgZGVmIGhhc19pbWFnZV9zdWZmaXgoZmlsZW5hbWUpCisgICAgICAgICAgICBmaWxlbmFt ZSA9fiAvXC4ocG5nfGpwZ3xnaWYpJC8KKyAgICAgICAgZW5kCisKICAgICAgICAgZGVmIHRvX2h0 bWwKICAgICAgICAgICAgIHN0ciA9ICI8ZGl2IGNsYXNzPSdGaWxlRGlmZic+XG4iCiAgICAgICAg ICAgICBzdHIgKz0gIjxoMT4je1ByZXR0eVBhdGNoLmxpbmtpZnlGaWxlbmFtZShAZmlsZW5hbWUp fTwvaDE+XG4i