29499 2009-09-18 11:38:39 -0700 Coding style guidelines should standardize on "using namespace" positioning 2009-09-21 19:17:42 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 beidson webkit-unassigned darin eric oldest_to_newest 148257 0 beidson 2009-09-18 11:38:39 -0700 "using namespace" statements are positions in a very inconsistent manner throughout WebCore - sometimes before a defined namespace, and sometimes within that defined namespace. The coding style guidelines should specify a standard place to put these. 148259 1 39771 beidson 2009-09-18 11:39:56 -0700 Created attachment 39771 Proposed guidelines 148270 2 darin 2009-09-18 11:49:48 -0700 I like this guideline, but I think we should have a brief webkit-dev discussion before landing the change. 148292 3 beidson 2009-09-18 12:07:40 -0700 Agreed, I will send an email out 148909 4 beidson 2009-09-21 17:14:31 -0700 This proposal hasn't received any objections, so I'd like to land it. 148926 5 darin 2009-09-21 18:28:38 -0700 I noticed a double period ".." somewhere in this patch. You should fix that when landing. 148933 6 eric 2009-09-21 18:43:04 -0700 Agreed, I think this is a great thing to put in the style guide. :) 148940 7 beidson 2009-09-21 19:16:56 -0700 Committed rr48616: <http://trac.webkit.org/changeset/r48616> 148941 8 beidson 2009-09-21 19:17:42 -0700 `bugzilla-tool mark-fixed` beats me again... Committed r48616: <http://trac.webkit.org/changeset/48616> 39771 2009-09-18 11:39:56 -0700 2009-09-21 18:28:16 -0700 Proposed guidelines patch.txt text/plain 1873 beidson SW5kZXg6IFdlYktpdFNpdGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hh bmdlTG9nCShyZXZpc2lvbiA0ODUxNykKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDktMTggIEJyYWR5IEVpZHNvbiAgPGJlaWRz b25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBjb2Rpbmcgc3R5bGUgZ3VpZGVsaW5lcyBmb3IgJ3VzaW5nIG5hbWVzcGFjZS4n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTQ5OQor CisgICAgICAgICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOgorCiAyMDA5LTA5LTE3ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KSW5kZXg6IFdlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHlsZS5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHlsZS5odG1sCShyZXZpc2lvbiA0ODQ1 MykKKysrIFdlYktpdFNpdGUvY29kaW5nL2NvZGluZy1zdHlsZS5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC03MDQsNyArNzA0LDYwIEBAIERvbid0IGJvdGhlciB0byBvcmdhbml6ZSB0aGVtIGluIGEg bG9naWMKICNpbmNsdWRlICJRdWFsaWZpZWROYW1lLmgiCiAjaW5jbHVkZSAiQXR0cmlidXRlLmgi CiA8L3ByZT4KKzwvb2w+CisKKzxoMz4idXNpbmcgbmFtZXNwYWNlIiBTdGF0ZW1lbnRzPC9oMz4K KworPG9sPgorCis8bGk+QW55ICJ1c2luZyBuYW1lc3BhY2UiIHN0YXRlbWVudHMgZm9yIGEgbmVz dGVkIG5hbWVzcGFjZSB3aG9zZSBwYXJlbnQgbmFtZXNwYWNlIAoraXMgYWxzbyBkZWZpbmVkIGlu IGEgZmlsZSBtdXN0IGJlIGRlY2xhcmVkIHdpdGhpbiB0aGF0IG5hbWVzcGFjZSBkZWZpbml0aW9u Li4KKworPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9oND4KKzxwcmUgY2xhc3M9ImNvZGUiPgor Ly8gSFRNTEJhc2VFbGVtZW50LmNwcAorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK3VzaW5nIG5h bWVzcGFjZSBIVE1MTmFtZXM7CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKzwvcHJlPgorCis8 aDQgY2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+CisvLyBIVE1M QmFzZUVsZW1lbnQuY3BwCisKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOjpIVE1MTmFtZXM7CisK K25hbWVzcGFjZSBXZWJDb3JlIHsKIAorfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorPC9wcmU+CisK KzxsaT5Bbnkgb3RoZXIgInVzaW5nIG5hbWVzcGFjZSIgc3RhdGVtZW50cyBtdXN0IGJlIGRlY2xh cmVkIGJlZm9yZSB0aGUgZmlyc3QgbmFtZXNwYWNlIAorZGVmaW5pdGlvbiBpbiB0aGUgZmlsZS4K KzxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+Cis8cHJlIGNsYXNzPSJjb2RlIj4KKy8vIEhU TUxTZWxlY3RFbGVtZW50LmNwcAorCit1c2luZyBuYW1lc3BhY2Ugc3RkOworCituYW1lc3BhY2Ug V2ViQ29yZSB7CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKzwvcHJlPgorCis8aDQgY2xhc3M9 Indyb25nIj5Xcm9uZzo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+CisvLyBIVE1MU2VsZWN0RWxl bWVudC5jcHAKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCit1c2luZyBuYW1lc3BhY2Ugc3RkOwor Cit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCis8L3ByZT4KIDwvb2w+CiAKIDw/cGhwCg==