29496 2009-09-18 10:53:33 -0700 [GTK] Sometimes crashes when a page is destroyed/loads another URL while playing video 2009-10-09 13:19:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://limi.net/articles/firefox-3.7-4.0-design-directions/ Gtk P2 Normal --- 1 gustavo webkit-unassigned jmalonzo zan oldest_to_newest 148240 0 gustavo 2009-09-18 10:53:33 -0700 I am using http://limi.net/articles/firefox-3.7-4.0-design-directions/ to test. I click the very bottom/left corner to start the video playback, then click reload. Rinse and repeat 'till I get a crash. (gdb) bt full #0 webkit_video_sink_idle_func (data=0x12abc80) at ../WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp:108 sink = 0x12abc80 priv = 0xaaaaaaaaaaaaaaaa buffer = <value optimized out> src = <value optimized out> cr = <value optimized out> #1 0x00007ffff2ebc21a in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 No symbol table info available. #2 0x00007ffff2ebfa78 in ?? () from /usr/lib/libglib-2.0.so.0 No symbol table info available. #3 0x00007ffff2ebff4d in g_main_loop_run () from /usr/lib/libglib-2.0.so.0 No symbol table info available. #4 0x00007ffff4e04be7 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #5 0x000000000043293e in main (argc=1, argv=0x7fffffffdc58) at /tmp/buildd/epiphany-webkit-2.27.92/src/ephy-main.c:784 option_context = <value optimized out> option_group = <value optimized out> proxy = <value optimized out> error = 0x0 user_time = 285348661 148244 1 gustavo 2009-09-18 10:56:39 -0700 Zan told me on IRC this is probably the same thing that is causing media/video-seekable.html to crash. 148395 2 39789 gustavo 2009-09-18 14:49:30 -0700 Created attachment 39789 proposed fix This is a bit hacky, but a real fix requires a bigger rework of the code that I am unable to do right now. Since it's a crash, I'd rather plug it quickly, and refactor the media player later. 148572 3 39789 xan.lopez 2009-09-20 13:50:28 -0700 Comment on attachment 39789 proposed fix OK, r=me 148591 4 gustavo 2009-09-20 18:23:41 -0700 Thanks, landed as r48571. 148779 5 39789 eric 2009-09-21 13:16:41 -0700 Comment on attachment 39789 proposed fix Clearing review flag, since according to the above comment this was reviewed and landed already. :( 148782 6 jmalonzo 2009-09-21 13:20:39 -0700 Reopening to remind us that this needs a "real fix". 153746 7 gustavo 2009-10-09 13:19:51 -0700 Real fix landed as r49401. 39789 2009-09-18 14:49:30 -0700 2009-09-21 13:16:40 -0700 proposed fix 0001-Protect-the-sink-object-from-premature-destruction.patch text/plain 3548 gustavo RnJvbSBkNzE0M2FlZGU3Y2E5ZjgxNzBiMTI0MTQxMzAwOTVlMDVjOWViN2FiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IEZyaSwgMTggU2VwIDIwMDkgMTg6NDc6NTEgLTAzMDAK U3ViamVjdDogW1BBVENIXSBQcm90ZWN0IHRoZSBzaW5rIG9iamVjdCBmcm9tIHByZW1hdHVyZSBk ZXN0cnVjdGlvbgoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAgIHwgICAyMyArKysrKysrKysrKysrKysrKysrKwog MiBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVjYjll MS4uM2ZkNTQ4OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wOS0xOCAgR3VzdGF2byBOb3JvbmhhIFNp bHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBTb21ldGltZXMgY3Jhc2hlcyB3 aGVuIGEgcGFnZSBpcyBkZXN0cm95ZWQvbG9hZHMgYW5vdGhlciBVUkwgd2hpbGUgcGxheWluZyB2 aWRlbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk0 OTYKKworICAgICAgICBQcm90ZWN0IHRoZSB2aWRlbyBzaW5rIG9iamVjdCwgYW5kIGRlc3Ryb3kg aXQgaW4gYW4gaWRsZSBjYWxsYmFjaworICAgICAgICB0byBob3BlZnVsbHkgYXZvaWQgYSByYWNl IGNvbmRpdGlvbiB0aGF0IGxlYWRzIHRvIGEgY3Jhc2guCisKKyAgICAgICAgVGhpcyBpcyBhbHJl YWR5IHRlc3RlZCBieSBtZWRpYS92aWRlby1zZWVrYWJsZS5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmlkbGVVbnJlZik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGU6On5NZWRpYVBsYXllclByaXZhdGUpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlOjpjcmVhdGVHU1RQbGF5QmluKToKKwogMjAwOS0wOS0xNyAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxk IGZpeC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDYwYmE1OTYuLmU5MWQ0NGIgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTQ5LDYgKzE0OSwxMiBAQCBNZWRpYVBsYXll clByaXZhdGU6Ok1lZGlhUGxheWVyUHJpdmF0ZShNZWRpYVBsYXllciogcGxheWVyKQogICAgIG1f c3VyZmFjZSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlKENBSVJPX0ZPUk1BVF9BUkdCMzIs IDY0MCwgNDgwKTsKIH0KIAorc3RhdGljIGdib29sZWFuIGlkbGVVbnJlZihncG9pbnRlciBkYXRh KQoreworICAgIGdfb2JqZWN0X3VucmVmKHJlaW50ZXJwcmV0X2Nhc3Q8R09iamVjdCo+KGRhdGEp KTsKKyAgICByZXR1cm4gRkFMU0U7Cit9CisKIE1lZGlhUGxheWVyUHJpdmF0ZTo6fk1lZGlhUGxh eWVyUHJpdmF0ZSgpCiB7CiAgICAgaWYgKG1fc3VyZmFjZSkKQEAgLTE1OCw2ICsxNjQsMTggQEAg TWVkaWFQbGF5ZXJQcml2YXRlOjp+TWVkaWFQbGF5ZXJQcml2YXRlKCkKICAgICAgICAgZ3N0X2Vs ZW1lbnRfc2V0X3N0YXRlKG1fcGxheUJpbiwgR1NUX1NUQVRFX05VTEwpOwogICAgICAgICBnc3Rf b2JqZWN0X3VucmVmKEdTVF9PQkpFQ1QobV9wbGF5QmluKSk7CiAgICAgfQorCisgICAgLy8gRklY TUU6IFdlIHNob3VsZCBmaW5kIGEgYmV0dGVyIHdheSB0byBoYW5kbGUgdGhlIGxpZmV0aW1lIG9m IHRoaXMgb2JqZWN0OyB0aGlzIGlzCisgICAgLy8gbmVlZGVkIGJlY2F1c2UgdGhlIG9iamVjdCBp cyBzb21ldGltZXMgYmVpbmcgZGVzdHJveWVkIGluYmV0d2VlbiBhIGNhbGwgdG8KKyAgICAvLyB3 ZWJraXRfdmlkZW9fc2lua19yZW5kZXIsIGFuZCB0aGUgaWRsZSBpdCBzY2hlZHVsZXMuIEFkZGlu ZyBhIHJlZiBpbgorICAgIC8vIHdlYmtpdF92aWRlb19zaW5rX3JlbmRlciB0aGF0IHdvdWxkIGJl IGJhbGFuY2VkIGJ5IHRoZSBpZGxlIGlzIG5vdCBhbiBvcHRpb24sCisgICAgLy8gYmVjYXVzZSBp biBzb21lIGNhc2VzIHRoZSBkZXN0cnVjdGlvbiBvZiB0aGUgc2luayBtYXkgaGFwcGVuIGluIHRp bWUgZm9yIHRoZSBpZGxlCisgICAgLy8gdG8gYmUgcmVtb3ZlZCBmcm9tIHRoZSBxdWV1ZSwgc28g aXQgbWF5IG5vdCBydW4uIEl0IHdvdWxkIGFsc28gY2F1c2UgbG90cyBvZiByZWYKKyAgICAvLyBj b3VudGluZyBjaHVybiAocmVuZGVyL2lkbGUgYXJlIGNhbGxlZCBtYW55IHRpbWVzKS4gVGhpcyBp cyBhbiB1Z2x5IHJhY2UuCisgICAgaWYgKG1fdmlkZW9TaW5rKSB7CisgICAgICAgIGdfaWRsZV9h ZGQoaWRsZVVucmVmLCBtX3ZpZGVvU2luayk7CisgICAgICAgIG1fdmlkZW9TaW5rID0gMDsKKyAg ICB9CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpsb2FkKGNvbnN0IFN0cmluZyYgdXJs KQpAQCAtNzI2LDYgKzc0NCwxMSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6Y3JlYXRlR1NU UGxheUJpbihTdHJpbmcgdXJsKQogICAgIGdfb2JqZWN0X3NldChHX09CSkVDVChtX3BsYXlCaW4p LCAidXJpIiwgdXJsLnV0ZjgoKS5kYXRhKCksIE5VTEwpOwogCiAgICAgbV92aWRlb1NpbmsgPSB3 ZWJraXRfdmlkZW9fc2lua19uZXcobV9zdXJmYWNlKTsKKworICAgIC8vIFRoaXMgcmVmIGlzIHRv IHByb3RlY3QgdGhlIHNpbmsgZnJvbSBiZWluZyBkZXN0cm95ZWQgYmVmb3JlIHdlIHN0b3AgdGhl IGlkbGUgaXQKKyAgICAvLyBjcmVhdGVzIGludGVybmFsbHkuIFNlZSB0aGUgY29tbWVudCBpbiB+ TWVkaWFQbGF5ZXJQcml2YXRlLgorICAgIGdfb2JqZWN0X3JlZihtX3ZpZGVvU2luayk7CisKICAg ICBnX29iamVjdF9zZXQobV9wbGF5QmluLCAidmlkZW8tc2luayIsIG1fdmlkZW9TaW5rLCBOVUxM KTsKIAogICAgIGdfc2lnbmFsX2Nvbm5lY3QobV92aWRlb1NpbmssICJyZXBhaW50LXJlcXVlc3Rl ZCIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlUmVwYWludENhbGxiYWNrKSwgdGhpcyk7 Ci0tIAoxLjYuMy4zCgo=