29494 2009-09-18 10:15:01 -0700 HTMLMediaElement m_playedTimeRanges can be NULL 2009-09-18 11:48:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson oldest_to_newest 148225 0 eric.carlson 2009-09-18 10:15:01 -0700 m_playedTimeRanges is initialized in HTMLMediaElement::loadInternal and assumed to be non-NULL everywhere it is used. This does not work when PLUGIN_PROXY_FOR_VIDEO is defined, because loadInternal is never called. 148228 1 39767 eric.carlson 2009-09-18 10:28:08 -0700 Created attachment 39767 proposed patch 148234 2 39767 darin 2009-09-18 10:36:58 -0700 Comment on attachment 39767 proposed patch Can we have a regression test for this? 148265 3 eric.carlson 2009-09-18 11:47:52 -0700 A regression test isn't possible on the desktop because none of the ports build with PLUGIN_PROXY_FOR_VIDEO defined. 148268 4 eric.carlson 2009-09-18 11:48:09 -0700 http://trac.webkit.org/changeset/48519 39767 2009-09-18 10:28:08 -0700 2009-09-18 10:36:58 -0700 proposed patch patch_1.txt text/plain 3794 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODUxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDktMTggIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTlVMTCBjaGVjayBIVE1MTWVkaWFFbGVtZW50OjptX3BsYXllZFRpbWVSYW5nZXMuCisKKyAg ICAgICAgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk0 OTQKKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpIVE1MTWVkaWFFbGVtZW50OjphZGRQbGF5ZWRSYW5nZSk6IE5ldy4gQ3JlYXRlIG1fcGxh eWVkVGltZVJhbmdlcyBpZgorICAgICAgICBuZWNlc3NhcnksIGFkZCByYW5nZSBzcGVjaWZpZWQu CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZWVrKTogVXNlIGFkZFBsYXll ZFJhbmdlLiAKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnBsYXllZCk6IFVz ZSBhZGRQbGF5ZWRSYW5nZS4gQ2hhbmdlIHRpbWUgY29tcGFyaXNvbiAKKyAgICAgICAgdG8gYmUg bW9yZSByZWFkYWJsZS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0 ZVBsYXlTdGF0ZSk6IERpdHRvLgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgor CiAyMDA5LTA5LTE4ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiA0ODQzMykKKysrIFdlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODk2LDYgKzg5NiwxMyBAQCB2b2lk IEhUTUxNZWRpYUVsZW1lbnQ6OnJldHVyblRvUmVhbHRpbWUoCiAgICAgc2V0Q3VycmVudFRpbWUo bWF4VGltZVNlZWthYmxlKCksIGUpOwogfSAgCiAKK3ZvaWQgSFRNTE1lZGlhRWxlbWVudDo6YWRk UGxheWVkUmFuZ2UoZmxvYXQgc3RhcnQsIGZsb2F0IGVuZCkKK3sKKyAgICBpZiAoIW1fcGxheWVk VGltZVJhbmdlcykKKyAgICAgICAgbV9wbGF5ZWRUaW1lUmFuZ2VzID0gVGltZVJhbmdlczo6Y3Jl YXRlKCk7CisgICAgbV9wbGF5ZWRUaW1lUmFuZ2VzLT5hZGQoc3RhcnQsIGVuZCk7Cit9ICAKKwog Ym9vbCBIVE1MTWVkaWFFbGVtZW50OjpzdXBwb3J0c1NhdmUoKSBjb25zdAogewogICAgIHJldHVy biBtX3BsYXllciA/IG1fcGxheWVyLT5zdXBwb3J0c1NhdmUoKSA6IGZhbHNlOwpAQCAtOTMxLDcg KzkzOCw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2VlayhmbG9hdCB0aW1lLCAKICAgICAv LyA1CiAgICAgaWYgKG1fcGxheWluZykgewogICAgICAgICBpZiAobV9sYXN0U2Vla1RpbWUgPCBu b3cpCi0gICAgICAgICAgICBtX3BsYXllZFRpbWVSYW5nZXMtPmFkZChtX2xhc3RTZWVrVGltZSwg bm93KTsKKyAgICAgICAgICAgIGFkZFBsYXllZFJhbmdlKG1fbGFzdFNlZWtUaW1lLCBub3cpOwog ICAgIH0KICAgICBtX2xhc3RTZWVrVGltZSA9IHRpbWU7CiAKQEAgLTE0ODMsMTcgKzE0OTAsMTcg QEAgUGFzc1JlZlB0cjxUaW1lUmFuZ2VzPiBIVE1MTWVkaWFFbGVtZW50OgogICAgIHJldHVybiBt X3BsYXllci0+YnVmZmVyZWQoKTsKIH0KIAotUGFzc1JlZlB0cjxUaW1lUmFuZ2VzPiBIVE1MTWVk aWFFbGVtZW50OjpwbGF5ZWQoKSBjb25zdAorUGFzc1JlZlB0cjxUaW1lUmFuZ2VzPiBIVE1MTWVk aWFFbGVtZW50OjpwbGF5ZWQoKQogewotICAgIGlmICghbV9wbGF5ZWRUaW1lUmFuZ2VzKSB7Ci0g ICAgICAgIC8vIFdlIGFyZSBub3QgeWV0IGxvYWRlZAotICAgICAgICByZXR1cm4gVGltZVJhbmdl czo6Y3JlYXRlKCk7Ci0gICAgfQogICAgIGlmIChtX3BsYXlpbmcpIHsKICAgICAgICAgZmxvYXQg dGltZSA9IGN1cnJlbnRUaW1lKCk7Ci0gICAgICAgIGlmIChtX2xhc3RTZWVrVGltZSA8IHRpbWUp Ci0gICAgICAgICAgICBtX3BsYXllZFRpbWVSYW5nZXMtPmFkZChtX2xhc3RTZWVrVGltZSwgdGlt ZSk7CisgICAgICAgIGlmICh0aW1lID4gbV9sYXN0U2Vla1RpbWUpCisgICAgICAgICAgICBhZGRQ bGF5ZWRSYW5nZShtX2xhc3RTZWVrVGltZSwgdGltZSk7CiAgICAgfQorCisgICAgaWYgKCFtX3Bs YXllZFRpbWVSYW5nZXMpCisgICAgICAgIG1fcGxheWVkVGltZVJhbmdlcyA9IFRpbWVSYW5nZXM6 OmNyZWF0ZSgpOworCiAgICAgcmV0dXJuIG1fcGxheWVkVGltZVJhbmdlcy0+Y29weSgpOwogfQog CkBAIC0xNTg5LDggKzE1OTYsOCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBsYXlT dGF0ZSgpCiAgICAgICAgIG1fcGxheWJhY2tQcm9ncmVzc1RpbWVyLnN0b3AoKTsKICAgICAgICAg bV9wbGF5aW5nID0gZmFsc2U7CiAgICAgICAgIGZsb2F0IHRpbWUgPSBjdXJyZW50VGltZSgpOwot ICAgICAgICBpZiAobV9sYXN0U2Vla1RpbWUgPCB0aW1lKQotICAgICAgICAgICAgbV9wbGF5ZWRU aW1lUmFuZ2VzLT5hZGQobV9sYXN0U2Vla1RpbWUsIHRpbWUpOworICAgICAgICBpZiAodGltZSA+ IG1fbGFzdFNlZWtUaW1lKQorICAgICAgICAgICAgYWRkUGxheWVkUmFuZ2UobV9sYXN0U2Vla1Rp bWUsIHRpbWUpOwogICAgIH0KICAgICAKICAgICBpZiAocmVuZGVyZXIoKSkKSW5kZXg6IFdlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuaAkocmV2aXNpb24gNDg0MzMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjAsNyArMTIwLDcgQEAgcHVibGljOgog ICAgIHZvaWQgc2V0UGxheWJhY2tSYXRlKGZsb2F0KTsKICAgICBib29sIHdlYmtpdFByZXNlcnZl c1BpdGNoKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRXZWJraXRQcmVzZXJ2ZXNQaXRjaChib29sKTsK LSAgICBQYXNzUmVmUHRyPFRpbWVSYW5nZXM+IHBsYXllZCgpIGNvbnN0OworICAgIFBhc3NSZWZQ dHI8VGltZVJhbmdlcz4gcGxheWVkKCk7CiAgICAgUGFzc1JlZlB0cjxUaW1lUmFuZ2VzPiBzZWVr YWJsZSgpIGNvbnN0OwogICAgIGJvb2wgZW5kZWQoKSBjb25zdDsKICAgICBib29sIGF1dG9wbGF5 KCkgY29uc3Q7ICAgIApAQCAtMTkzLDYgKzE5Myw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBzZWVr KGZsb2F0IHRpbWUsIEV4Y2VwdGlvbkNvZGUmKTsKICAgICB2b2lkIGZpbmlzaFNlZWsoKTsKICAg ICB2b2lkIGNoZWNrSWZTZWVrTmVlZGVkKCk7CisgICAgdm9pZCBhZGRQbGF5ZWRSYW5nZShmbG9h dCBzdGFydCwgZmxvYXQgZW5kKTsKICAgICAKICAgICB2b2lkIHNjaGVkdWxlVGltZXVwZGF0ZUV2 ZW50KGJvb2wgcGVyaW9kaWNFdmVudCk7CiAgICAgdm9pZCBzY2hlZHVsZVByb2dyZXNzRXZlbnQo Y29uc3QgQXRvbWljU3RyaW5nJiBldmVudE5hbWUpOwo=