294615 2025-06-17 09:11:03 -0700 [WTF] Add overloads of WTF::arePointingToEqualData for non-nullable pointer-like types 2025-06-17 20:45:22 -0700 1 1 1 Unclassified WebKit Web Template Framework Safari 18 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam webkit-bug-importer oldest_to_newest 2124216 0 sam 2025-06-17 09:11:03 -0700 To replace the relatively common idiom of: ``` foo.ptr() == bar.ptr() || foo.get() == bar.get(); ``` used for Ref and UniqueRef that want value semantics, we can add overloads of WTF::arePointingToEqualData that do the right thing. At some point later, we should consider replacing these uses with types that do the same thing. For instance, for the UniqueRef case, the upcoming std::indirect would be a good fit - https://en.cppreference.com/w/cpp/memory/indirect.html. For Ref, we would need to make our own "boxed ref" type. 2124227 1 sam 2025-06-17 09:55:16 -0700 Pull request: https://github.com/WebKit/WebKit/pull/46857 2124377 2 ews-feeder 2025-06-17 20:43:05 -0700 Committed 296358@main (f7123211c62d): <https://commits.webkit.org/296358@main> Reviewed commits have been landed. Closing PR #46857 and removing active labels. 2124378 3 webkit-bug-importer 2025-06-17 20:45:22 -0700 <rdar://problem/153701651>