294317 2025-06-11 04:28:45 -0700 [WPEPlatform] Introduce support for Android's AHardwareBuffer 2025-08-13 01:22:51 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 294318 294322 297316 1 aperez aperez bugs-noreply cgarcia oldest_to_newest 2122974 0 aperez 2025-06-11 04:28:45 -0700 The same way we have a WPEBufferDMABuf, we would want to have a WPEBuffer subclass to wrap Android's AHardwareBuffer. One question is what to do when building for non-Android systems. One option is to have the implementation contain stubs that error out, the other to avoid building the Android-specific code at all. 2122975 1 cgarcia 2025-06-11 04:43:14 -0700 What we do for the builtin platforms, that are optional and have public API, is that and ifdef is needed to use them, see WPEConfig.h.in where we define (or not) WPE_PLATFORM_WAYLAND, WPE_PLATFORM_DRM and WPE_PLATFORM_HEADLESS. So, to use for example wpe_screen_drm_get_crtc_index() in DisplayVBlankMonitorDRM.cpp we need to add #ifdef WPE_PLATFORM_DRM. This could be something similar. 2122976 2 aperez 2025-06-11 04:48:11 -0700 Pull request: https://github.com/WebKit/WebKit/pull/46598 2122977 3 aperez 2025-06-11 04:49:29 -0700 (In reply to Carlos Garcia Campos from comment #1) > What we do for the builtin platforms, that are optional and have public API, > is that and ifdef is needed to use them, see WPEConfig.h.in where we define > (or not) WPE_PLATFORM_WAYLAND, WPE_PLATFORM_DRM and WPE_PLATFORM_HEADLESS. > So, to use for example wpe_screen_drm_get_crtc_index() in > DisplayVBlankMonitorDRM.cpp we need to add #ifdef WPE_PLATFORM_DRM. This > could be something similar. Thanks for the pointer, I'll take a look. For now I have posted the PR as a draft and will update it when I have the needed changes applied. 2136149 4 ews-feeder 2025-08-13 01:22:47 -0700 Committed 298619@main (fd72faeef06a): <https://commits.webkit.org/298619@main> Reviewed commits have been landed. Closing PR #46598 and removing active labels.