29424 2009-09-18 07:42:52 -0700 [Qt] QWebFrame: When a relative url is loaded then it will make it absolute internally, however this strips out any query/fragments 2011-02-16 02:47:39 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 vestbo webkit-unassigned aparna.nand commit-queue kent.hansen kling oldest_to_newest 148130 0 vestbo 2009-09-18 07:42:52 -0700 This bug report originated from issue QTBUG-3889 <http://bugreports.qt.nokia.com/browse/QTBUG-3889> --- Description --- QWebFrame: When a relative url is loaded then it will make it absolute internally, however this strips out any query/fragments 199678 1 50712 kent.hansen 2010-03-15 08:56:10 -0700 Created attachment 50712 Testcase 199679 2 kent.hansen 2010-03-15 08:56:41 -0700 Reproduced with r55986. 225812 3 jesus 2010-05-14 07:43:36 -0700 Reproduced on Snow Leopard with Qt 4.7 trunk (HEAD 03f8f1df0d88f5ffe0b3120cffce614cbeefdb70) and WebKit trunk (r59155). 351492 4 82506 aparna.nand 2011-02-15 12:37:54 -0800 Created attachment 82506 Patch for review In function ensureAbsoluteUrl, call is made to QUrl::toLocalFile() which strips the query, fragment part out. Patch corrects this to resolve it before returning absolute url. 351494 5 82506 kling 2011-02-15 12:40:05 -0800 Comment on attachment 82506 Patch for review Needs a test. :) 351922 6 aparna.nand 2011-02-16 00:34:04 -0800 (In reply to comment #5) > (From update of attachment 82506 [details]) > Needs a test. :) Kling as discussed yesterday, I am able to write an automation test. The patch can get tested only when a relative url is passed to QWebView. But the way automation test framework is designed, the test html files are stored in resources directory and an absolute path like qrc:///resources/local.html needs to be passed. When this is passed, the code that needs to be tested is not hit. Tested the below code by passing relative url and it works fine. void tst_QWebView::loadRelativeUrl() { QWebView view; QSignalSpy spy(view.page(), SIGNAL(loadFinished(bool))); // This is the line that should be in the final test. But its absolute path // QUrl url("qrc:///resources/local.html"); // This url actually tests the patch QUrl url("local.html"); url.setFragment("Overview"); view.load(url); ::waitForSignal(&view, SIGNAL(loadFinished(bool))); QCOMPARE(spy.count(), 1); QUrl loadedUrl = view.page()->mainFrame()->url(); QVERIFY(loadedUrl.hasFragment()); } Any suggestions to get around this problem. 351947 7 82506 commit-queue 2011-02-16 02:47:34 -0800 Comment on attachment 82506 Patch for review Clearing flags on attachment: 82506 Committed r78688: <http://trac.webkit.org/changeset/78688> 351948 8 commit-queue 2011-02-16 02:47:39 -0800 All reviewed patches have been landed. Closing bug. 50712 2010-03-15 08:56:10 -0700 2010-03-15 08:56:10 -0700 Testcase main.cpp text/x-c++src 807 kent.hansen I2luY2x1ZGUgPFF0R3VpPgojaW5jbHVkZSA8UXRXZWJLaXQ+CgpjbGFzcyBPYmplY3QgOiBwdWJs aWMgUU9iamVjdAp7CiAgICBRX09CSkVDVApwdWJsaWM6CiAgICBPYmplY3QoUU9iamVjdCAqcGFy ZW50ID0gMCkKICAgIHsKICAgICAgICB2aWV3ID0gbmV3IFFXZWJWaWV3OwogICAgICAgIFFPYmpl Y3Q6OmNvbm5lY3QodmlldywgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSksIHRoaXMsIFNMT1Qo b25Mb2FkRmluaXNoZWQoKSkpOwogICAgICAgIFFVcmwgdXJsKCJpbmRleC5odG1sIik7CiAgICAg ICAgdXJsLnNldEZyYWdtZW50KCJxdWVzdGlvbjEzIik7CiAgICAgICAgcURlYnVnKCkgPDwgIk9y aWdpbmFsIChyZWxhdGl2ZSkgVVJMIHBhc3NlZCB0byBRV2ViVmlldzo6bG9hZCgpOiIgPDwgdXJs LnRvU3RyaW5nKCk7CiAgICAgICAgdmlldy0+bG9hZCh1cmwpOwogICAgICAgIHZpZXctPnNob3co KTsKICAgIH0KICAgIH5PYmplY3QoKSB7IGRlbGV0ZSB2aWV3OyB9Cgpwcml2YXRlIFFfU0xPVFM6 CiAgICB2b2lkIG9uTG9hZEZpbmlzaGVkKCkgewogICAgICAgIHFEZWJ1ZygpIDw8ICJGcmFtZSdz IFVSTCBhZnRlciBsb2FkaW5nOiIgPDwgdmlldy0+cGFnZSgpLT5tYWluRnJhbWUoKS0+dXJsKCku dG9TdHJpbmcoKTsKICAgIH0KCnByaXZhdGU6CiAgICBRV2ViVmlldyAqdmlldzsKfTsKCmludCBt YWluKGludCBhcmdjLCBjaGFyICoqYXJndikKewogICAgUUFwcGxpY2F0aW9uIGFwcChhcmdjLCBh cmd2KTsKICAgIE9iamVjdCBvOwogICAgcmV0dXJuIGFwcC5leGVjKCk7Cn0KCiNpbmNsdWRlICJt YWluLm1vYyIK 82506 2011-02-15 12:37:54 -0800 2011-02-16 02:47:34 -0800 Patch for review patch29424 text/plain 1594 aparna.nand ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCmluZGV4IDA4NTNkYjMuLmFiMzg1NGQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcApAQCAtNzMyLDcgKzczMiwxNSBAQCBzdGF0aWMgaW5s aW5lIFFVcmwgZW5zdXJlQWJzb2x1dGVVcmwoY29uc3QgUVVybCAmdXJsKQogICAgIGlmICghdXJs LmlzUmVsYXRpdmUoKSkKICAgICAgICAgcmV0dXJuIHVybDsKIAotICAgIHJldHVybiBRVXJsOjpm cm9tTG9jYWxGaWxlKFFGaWxlSW5mbyh1cmwudG9Mb2NhbEZpbGUoKSkuYWJzb2x1dGVGaWxlUGF0 aCgpKTsKKyAgICAvLyBUaGlzIGNvbnRhaW5zIHRoZSBVUkwgd2l0aCBhYnNvbHV0ZSBwYXRoIGJ1 dCB3aXRob3V0IAorICAgIC8vIHRoZSBxdWVyeSBhbmQgdGhlIGZyYWdtZW50IHBhcnQuCisgICAg UVVybCBiYXNlVXJsID0gUVVybDo6ZnJvbUxvY2FsRmlsZShRRmlsZUluZm8odXJsLnRvTG9jYWxG aWxlKCkpLmFic29sdXRlRmlsZVBhdGgoKSk7IAorCisgICAgLy8gVGhlIHBhdGggaXMgcmVtb3Zl ZCBzbyB0aGUgcXVlcnkgYW5kIHRoZSBmcmFnbWVudCBwYXJ0cyBhcmUgdGhlcmUuCisgICAgUVN0 cmluZyBwYXRoUmVtb3ZlZCA9IHVybC50b1N0cmluZyhRVXJsOjpSZW1vdmVQYXRoKTsKKyAgICBR VXJsIHRvUmVzb2x2ZShwYXRoUmVtb3ZlZCk7CisgICAgCisgICAgcmV0dXJuIGJhc2VVcmwucmVz b2x2ZWQodG9SZXNvbHZlKTsKIH0KIAogLyohCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGU0YzhjZWYuLmNm NGM1NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMTUgIEFwYXJu YSBOYW5keWFsICA8YXBhcm5hLm5hbmRAd2lwcm8uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUVdlYkZyYW1lOiBXaGVuIGEgcmVsYXRp dmUgdXJsIGlzIGxvYWRlZCB0aGVuIGl0IHdpbGwgbWFrZSBpdCBhYnNvbHV0ZSBpbnRlcm5hbGx5 LCBob3dldmVyIHRoaXMgc3RyaXBzIG91dCBhbnkgcXVlcnkvZnJhZ21lbnRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTQyNAorCisgICAgICAgIGVu c3VyZUFic29sdXRlVXJsIGZ1bmN0aW9uIHdhcyBzdHJpcHBpbmcgdGhlIHF1ZXJ5IGFuZCB0aGUK KyAgICAgICAgZnJhZ21lbnQgcGFydCBvZiB0aGUgdXJsLiBDb3JyZWN0ZWQgdGhpcy4KKworICAg ICAgICAqIEFwaS9xd2ViZnJhbWUuY3BwOgorICAgICAgICAoZW5zdXJlQWJzb2x1dGVVcmwpOgor CiAyMDExLTAyLTExICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNs YXZAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCg==