29367 2009-09-18 04:12:38 -0700 memory leak in JavaScriptCore RegisterFile on Windows CE 2009-09-22 08:11:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Other Other RESOLVED FIXED P1 Major --- 0 joerg.bornemann webkit-unassigned hausmann staikos oldest_to_newest 148041 0 39756 joerg.bornemann 2009-09-18 04:12:38 -0700 Created attachment 39756 mem leak fix On Widows CE we must decommit all committed pages before we release them. See VirtualFree documentation. Desktop Windows behaves much smoother in this situation. 148042 1 joerg.bornemann 2009-09-18 04:14:11 -0700 Without this patch we leak 2 MB every time after destroying a JSC instance on Windows CE. 148048 2 39756 hausmann 2009-09-18 05:54:12 -0700 Comment on attachment 39756 mem leak fix Changed requested eviewer to George, to be sure this won't conflict with the other Windows CE port. 148049 3 hausmann 2009-09-18 05:54:44 -0700 George, do you know if that would help or conflict with your CE port? 148510 4 39822 hausmann 2009-09-19 10:45:25 -0700 Created attachment 39822 Updated patch with ChangeLog New patch with fixed paths and ChangeLog 148996 5 39822 hausmann 2009-09-22 03:30:04 -0700 Comment on attachment 39822 Updated patch with ChangeLog Joerg explained the change in all detail to me and it seems like the right thing to do. George, please holler if you notice any issues with it. 148998 6 hausmann 2009-09-22 03:47:53 -0700 Landed in r48623 149040 7 staikos 2009-09-22 07:03:47 -0700 Yes it's fine. SHould have been Yong reviewing this :) Oh, and it's only really an issue if you load/unload the dll. 149054 8 joerg.bornemann 2009-09-22 08:11:27 -0700 (In reply to comment #7) > Yes it's fine. SHould have been Yong reviewing this :) Oh, and it's only > really an issue if you load/unload the dll. Or if you create / destroy QScriptEngine objects. ;-) 39756 2009-09-18 04:12:38 -0700 2009-09-19 10:45:25 -0700 mem leak fix patch.txt text/plain 1109 joerg.bornemann Y29tbWl0IDg5OTgyYTJjMTY3OGYyYzQyYzlhYmYxMDIxYjM1ZWQ0NTAwNDI3OGMKQXV0aG9yOiBK b2VyZyBCb3JuZW1hbm4gPGpvZXJnLmJvcm5lbWFubkBub2tpYS5jb20+CkRhdGU6ICAgVHVlIFNl cCA4IDEzOjQ4OjEzIDIwMDkgKzAyMDAKCiAgICBmaXggbWFqb3IgbWVtb3J5IGxlYWsgaW4gSmF2 YVNjcmlwdENvcmUgUmVnaXN0ZXJGaWxlIG9uIFdpbmRvd3MgQ0UKICAgIAogICAgT24gV2lkb3dz IENFIHdlIG11c3QgZGVjb21taXQgYWxsIGNvbW1pdHRlZCBwYWdlcyBiZWZvcmUgd2UgcmVsZWFz ZQogICAgdGhlbS4gU2VlIFZpcnR1YWxGcmVlIGRvY3VtZW50YXRpb24uCiAgICBEZXNrdG9wIFdp bmRvd3MgYmVoYXZlcyBtdWNoIHNtb290aGVyIGluIHRoaXMgc2l0dWF0aW9uLgogICAgCiAgICBS ZXZpZXdlZC1ieTogYXJpeWEKCmRpZmYgLS1naXQgYS9zcmMvM3JkcGFydHkvd2Via2l0L0phdmFT Y3JpcHRDb3JlL2ludGVycHJldGVyL1JlZ2lzdGVyRmlsZS5jcHAgYi9zcmMvM3JkcGFydHkvd2Vi a2l0L0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL1JlZ2lzdGVyRmlsZS5jcHAKaW5kZXggMjlh MTNjYS4uZGU1MTc1ZSAxMDA2NDQKLS0tIGEvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9SZWdpc3RlckZpbGUuY3BwCisrKyBiL3NyYy8zcmRwYXJ0eS93ZWJr aXQvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcApAQCAtMzYsNiAr MzYsOSBAQCBSZWdpc3RlckZpbGU6On5SZWdpc3RlckZpbGUoKQogI2lmIEhBVkUoTU1BUCkKICAg ICBtdW5tYXAocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4obV9idWZmZXIpLCAoKG1fbWF4IC0gbV9z dGFydCkgKyBtX21heEdsb2JhbHMpICogc2l6ZW9mKFJlZ2lzdGVyKSk7CiAjZWxpZiBIQVZFKFZJ UlRVQUxBTExPQykKKyNpZiBQTEFURk9STShXSU5DRSkKKyAgICBWaXJ0dWFsRnJlZShtX2J1ZmZl ciwgRFdPUkQobV9jb21taXRFbmQpIC0gRFdPUkQobV9idWZmZXIpLCBNRU1fREVDT01NSVQpOwor I2VuZGlmCiAgICAgVmlydHVhbEZyZWUobV9idWZmZXIsIDAsIE1FTV9SRUxFQVNFKTsKICNlbHNl CiAgICAgZmFzdEZyZWUobV9idWZmZXIpOwo= 39822 2009-09-19 10:45:25 -0700 2009-09-22 03:30:03 -0700 Updated patch with ChangeLog patch.txt text/plain 1356 hausmann ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA3OGNiM2U4Li5hMWU1MTliIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMDktMDktMTkgIEpvZXJnIEJvcm5lbWFubiAgPGpvZXJnLmJvcm5lbWFubkBub2tpYS5j b20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IG1ham9yIG1lbW9yeSBsZWFrIGluIEphdmFTY3JpcHRDb3JlIFJlZ2lzdGVyRmlsZSBvbiBXaW5k b3dzIENFCisKKyAgICAgICAgT24gV2lkb3dzIENFIHdlIG11c3QgZGVjb21taXQgYWxsIGNvbW1p dHRlZCBwYWdlcyBiZWZvcmUgd2UgcmVsZWFzZQorICAgICAgICB0aGVtLiBTZWUgVmlydHVhbEZy ZWUgZG9jdW1lbnRhdGlvbi4KKyAgICAgICAgRGVza3RvcCBXaW5kb3dzIGJlaGF2ZXMgbXVjaCBz bW9vdGhlciBpbiB0aGlzIHNpdHVhdGlvbi4KKworICAgICAgICAqIGludGVycHJldGVyL1JlZ2lz dGVyRmlsZS5jcHA6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyRmlsZTo6flJlZ2lzdGVyRmlsZSk6 CisKKzIwMDktMDktMTkgIEpvZXJnIEJvcm5lbWFubiAgPGpvZXJnLmJvcm5lbWFubkBub2tpYS5j b20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvcmdlIFN0YWlrb3MuCiAKICAgICAgICAgUXRX ZWJLaXQgV2luZG93cyBDRSBjb21waWxlIGZpeApkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUv aW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcCBiL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L1JlZ2lzdGVyRmlsZS5jcHAKaW5kZXggMDZkZGVmYy4uNTQyNDE5OSAxMDA2NDQKLS0tIGEvSmF2 YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXJGaWxlLmNwcAorKysgYi9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9SZWdpc3RlckZpbGUuY3BwCkBAIC0zNiw2ICszNiw5IEBAIFJlZ2lz dGVyRmlsZTo6flJlZ2lzdGVyRmlsZSgpCiAjaWYgSEFWRShNTUFQKQogICAgIG11bm1hcChtX2J1 ZmZlciwgKChtX21heCAtIG1fc3RhcnQpICsgbV9tYXhHbG9iYWxzKSAqIHNpemVvZihSZWdpc3Rl cikpOwogI2VsaWYgSEFWRShWSVJUVUFMQUxMT0MpCisjaWYgUExBVEZPUk0oV0lOQ0UpCisgICAg VmlydHVhbEZyZWUobV9idWZmZXIsIERXT1JEKG1fY29tbWl0RW5kKSAtIERXT1JEKG1fYnVmZmVy KSwgTUVNX0RFQ09NTUlUKTsKKyNlbmRpZgogICAgIFZpcnR1YWxGcmVlKG1fYnVmZmVyLCAwLCBN RU1fUkVMRUFTRSk7CiAjZWxzZQogICAgIGZhc3RGcmVlKG1fYnVmZmVyKTsK