29364 2009-09-18 02:24:19 -0700 SourceCode() does not initialize m_provider 2009-09-21 13:37:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 jedrzej.nowacki webkit-unassigned commit-queue eric oldest_to_newest 148032 0 jedrzej.nowacki 2009-09-18 02:24:19 -0700 Default constructor of SourceCode class doesn't initialize m_provider member. It could be source of problems in future. Right now nobody use it... 148033 1 39753 jedrzej.nowacki 2009-09-18 02:28:44 -0700 Created attachment 39753 patch resolving problem 148258 2 ap 2009-09-18 11:39:15 -0700 Please mark the patch for review by clicking "Details" link to the right of it, and changing review flag to "?". 148603 3 jedrzej.nowacki 2009-09-21 00:03:04 -0700 (In reply to comment #2) > Please mark the patch for review by clicking "Details" link to the right of it, > and changing review flag to "?". Done 148780 4 39753 eric 2009-09-21 13:18:47 -0700 Comment on attachment 39753 patch resolving problem That seems like a rather needlessly verbose ChangeLog entry. I think all I would have said was: Fix SourceCode() to initialize m_provider. https://bugs.webkit.org/show_bug.cgi?id=29364 This is OK though. Since you're not a committer I'll assume you wanted cq=? and set cq+ for you. 148789 5 39753 commit-queue 2009-09-21 13:37:23 -0700 Comment on attachment 39753 patch resolving problem Clearing flags on attachment: 39753 Committed r48593: <http://trac.webkit.org/changeset/48593> 148791 6 commit-queue 2009-09-21 13:37:28 -0700 All reviewed patches have been landed. Closing bug. 39753 2009-09-18 02:28:44 -0700 2009-09-21 13:37:23 -0700 patch resolving problem sourcecode.diff text/plain 1134 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA4YWE4YzFkLi45ZmVmMTNmIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMDktMDktMTggIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Zp eF0gU291cmNlQ29kZSdzIHVuaW5pdGlhbGl6ZWQgbWVtYmVyCisgICAgICAgIAorICAgICAgICBQ b3RlbnRpYWwgc291cmNlIG9mIGNyYXNoZXMgYW5kIGJ1Z3Mgd2FzIGZpeGVkLiBEZWZhdWx0IGNv bnN0cnVjdG9yCisgICAgICAgIGRpZG4ndCBpbml0aWFsaXplZCBtX3Byb3ZpZGVyIG1lbWJlci4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkzNjQK KworICAgICAgICAqIHBhcnNlci9Tb3VyY2VDb2RlLmg6CisgICAgICAgIChKU0M6OlNvdXJjZUNv ZGU6OlNvdXJjZUNvZGUpOgorCiAyMDA5LTA5LTE3ICBKYW5uZSBLb3NraW5lbiAgPGphbm5lLnAu a29za2luZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5u LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJjZUNvZGUuaCBiL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9Tb3VyY2VDb2RlLmgKaW5kZXggODQzNjBiOC4uOWJhNGRhMyAxMDA2 NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJjZUNvZGUuaAorKysgYi9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvU291cmNlQ29kZS5oCkBAIC0zNyw3ICszNyw4IEBAIG5hbWVzcGFjZSBK U0MgewogICAgIGNsYXNzIFNvdXJjZUNvZGUgewogICAgIHB1YmxpYzoKICAgICAgICAgU291cmNl Q29kZSgpCi0gICAgICAgICAgICA6IG1fc3RhcnRDaGFyKDApCisgICAgICAgICAgICA6IG1fcHJv dmlkZXIoMCkKKyAgICAgICAgICAgICwgbV9zdGFydENoYXIoMCkKICAgICAgICAgICAgICwgbV9l bmRDaGFyKDApCiAgICAgICAgICAgICAsIG1fZmlyc3RMaW5lKDApCiAgICAgICAgIHsK