29356 2009-09-17 20:09:28 -0700 LayoutTests/platform/win/accessibility/scroll-to-anchor.html doesn't render as text if there's no accessibilityController 2009-09-18 12:13:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 1 dpranke dpranke fishd oldest_to_newest 148007 0 dpranke 2009-09-17 20:09:28 -0700 Chromium does not yet implement accessibilityController() in test_shell (chromium's version of dumpRenderTree). The test script bails out without calling dumpAsText(), which causes Chromium's test driver (run_webkit_tests) to expect there to be an image baseline, and there isn't one. 148009 1 39746 dpranke 2009-09-17 20:21:46 -0700 Created attachment 39746 patch to handle accessibilityController not being present more gracefully 148017 2 39746 eric 2009-09-17 22:31:08 -0700 Comment on attachment 39746 patch to handle accessibilityController not being present more gracefully Indent is wrong. This makes no sense? Why not just skip this test? What purpose does it serve if accessibilityController is not there? 148020 3 39749 dpranke 2009-09-17 23:33:30 -0700 Created attachment 39749 patch w/ revised indent 148021 4 dpranke 2009-09-17 23:34:53 -0700 (In reply to comment #2) > (From update of attachment 39746 [details]) > Indent is wrong. Fixed! Thanks. > This makes no sense? Why not just skip this test? What purpose does it serve > if accessibilityController is not there? If we skip the test, then we're not running it at all. If we don't skip the test, we are at least insuring that we don't crash on this test. Another way of saying this is that I don't like skipping tests :) 148226 5 39749 fishd 2009-09-18 10:19:32 -0700 Comment on attachment 39749 patch w/ revised indent I don't think this is the right change to make. We should leave the test as is. Back in chromium land, we should just implement a no-op accessibilityController if we want to avoid skipping the test. 148298 6 dpranke 2009-09-18 12:13:33 -0700 okey doke. 39746 2009-09-17 20:21:46 -0700 2009-09-17 23:33:30 -0700 patch to handle accessibilityController not being present more gracefully bug29356.patch text/plain 1623 dpranke SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ4NDk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDktMTcgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTW9kaWZ5IHRlc3QgZmlsZSB0byBmYWlsIG1vcmUgZ3JhY2VmdWxseSBvbiB0 aGUgQ2hyb21pdW0gcG9ydAorICAgICAgICAod2hpY2ggZG9lc24ndCBpbXBsZW1lbnQgdGhlIGFj Y2Vzc2liaWxpdHlDb250cm9sbGVyIHlldCkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI5MzU2CisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vYWNj ZXNzaWJpbGl0eS9zY3JvbGwtdG8tYW5jaG9yLmh0bWw6CisKIDIwMDktMDktMTcgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVk IGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vYWNj ZXNzaWJpbGl0eS9zY3JvbGwtdG8tYW5jaG9yLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vd2luL2FjY2Vzc2liaWxpdHkvc2Nyb2xsLXRvLWFuY2hvci5odG1sCShyZXZp c2lvbiA0ODQ5OSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3Nj cm9sbC10by1hbmNob3IuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMywxMiArMywxMyBAQAogICAg ICAgICA8c2NyaXB0PgogICAgICAgICAgICAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICB7 Ci0gICAgICAgICAgICAgICAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIgfHwgIXdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICBpZiAoIXdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogCiAg ICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm5vdERSVCIpLnN0eWxlLnZp c2liaWxpdHkgPSAiaGlkZGVuIjsKIAotICAgICAgICAgICAgICAgIGFjY2Vzc2liaWxpdHlDb250 cm9sbGVyLmxvZ1Njcm9sbGluZ1N0YXJ0RXZlbnRzKCk7CisgICAgICAgICAgICAgICAgaWYgKHdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICAgIGFjY2Vzc2li aWxpdHlDb250cm9sbGVyLmxvZ1Njcm9sbGluZ1N0YXJ0RXZlbnRzKCk7CiAgICAgICAgICAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwogICAgICAgICAgICAgICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgICAgICAgICBzZXRU aW1lb3V0KHNjcm9sbFRvQW5jaG9yLCAwKTsK 39749 2009-09-17 23:33:30 -0700 2009-09-18 10:19:32 -0700 patch w/ revised indent bug29356.patch text/plain 1625 dpranke SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ4NDk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDktMTcgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTW9kaWZ5IHRlc3QgZmlsZSB0byBmYWlsIG1vcmUgZ3JhY2VmdWxseSBvbiB0 aGUgQ2hyb21pdW0gcG9ydAorICAgICAgICAod2hpY2ggZG9lc24ndCBpbXBsZW1lbnQgdGhlIGFj Y2Vzc2liaWxpdHlDb250cm9sbGVyIHlldCkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI5MzU2CisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vYWNj ZXNzaWJpbGl0eS9zY3JvbGwtdG8tYW5jaG9yLmh0bWw6CisKIDIwMDktMDktMTcgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVk IGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vYWNj ZXNzaWJpbGl0eS9zY3JvbGwtdG8tYW5jaG9yLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vd2luL2FjY2Vzc2liaWxpdHkvc2Nyb2xsLXRvLWFuY2hvci5odG1sCShyZXZp c2lvbiA0ODQ5OSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9hY2Nlc3NpYmlsaXR5L3Nj cm9sbC10by1hbmNob3IuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMywxMiArMywxMyBAQAogICAg ICAgICA8c2NyaXB0PgogICAgICAgICAgICAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICB7 Ci0gICAgICAgICAgICAgICAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIgfHwgIXdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICBpZiAoIXdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogCiAg ICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm5vdERSVCIpLnN0eWxlLnZp c2liaWxpdHkgPSAiaGlkZGVuIjsKIAotICAgICAgICAgICAgICAgIGFjY2Vzc2liaWxpdHlDb250 cm9sbGVyLmxvZ1Njcm9sbGluZ1N0YXJ0RXZlbnRzKCk7CisgICAgICAgICAgICAgICAgaWYgKHdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICAgICAgYWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIubG9nU2Nyb2xsaW5nU3RhcnRFdmVudHMoKTsKICAgICAgICAgICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiAgICAgICAgICAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgICAgICAgICAgICAgIHNl dFRpbWVvdXQoc2Nyb2xsVG9BbmNob3IsIDApOwo=